Venetia Furtado license statement
All of my past and future contributions to LibreOffice may be licensed under MPLv2/LGPLv3+ dual license. Venetia Furtado
[Libreoffice-bugs] [Bug 155862] New: Klinik Apollo Jakarta Pusat
https://bugs.documentfoundation.org/show_bug.cgi?id=155862 Bug ID: 155862 Summary: Klinik Apollo Jakarta Pusat Product: LibreOffice Version: 3.3.2 release Hardware: Other OS: other Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: klinikapoll...@gmail.com Description: Klinik spesialis penyakit kelamin di Jakarta yang telah berdiri sejak tahun 2012 dengan penanganan dokter dan tenaga medis profesional. Blog: https://klinikapollojakartapusat.blogspot.com/ Actual Results: Klinik Spesialis Kelamin Jakarta Expected Results: https://klinikapollojakartapusat.blogspot.com/ Reproducible: Always User Profile Reset: No Additional Info: Website: https://klinikapollojakartapusat.blogspot.com/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155635] A ODS sheet with links to another ODS file, copied in another calc file loose links
https://bugs.documentfoundation.org/show_bug.cgi?id=155635 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155625] GTK3 a11y: some roles not properly updated
https://bugs.documentfoundation.org/show_bug.cgi?id=155625 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155619] screen size incorrectly detected
https://bugs.documentfoundation.org/show_bug.cgi?id=155619 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155634] Announcement by Orca screen reader 'Contains formula' disappeared in calc 7.5.3 on a cell including a formula.
https://bugs.documentfoundation.org/show_bug.cgi?id=155634 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155624] A11y crash on cppunittester exit
https://bugs.documentfoundation.org/show_bug.cgi?id=155624 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102985] [META] Font bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102985 Bug 102985 depends on bug 152062, which changed state. Bug 152062 Summary: Noto Serif Ahom font does not implement correctly in Libre Office https://bugs.documentfoundation.org/show_bug.cgi?id=152062 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152062] Noto Serif Ahom font does not implement correctly in Libre Office
https://bugs.documentfoundation.org/show_bug.cgi?id=152062 --- Comment #7 from QA Administrators --- Dear Stephen Morey, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152062] Noto Serif Ahom font does not implement correctly in Libre Office
https://bugs.documentfoundation.org/show_bug.cgi?id=152062 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151824] Mysterious font colours in track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=151824 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151824] Mysterious font colours in track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=151824 --- Comment #4 from QA Administrators --- Dear philevedoug, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 85651] Writer crashes when a MailMerge instance is created in C#
https://bugs.documentfoundation.org/show_bug.cgi?id=85651 --- Comment #10 from QA Administrators --- Dear APS, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 59326] FORMATTING: Foreground and Background Problems of Frames and Basic Shapes in “Wrap Through“ Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=59326 --- Comment #13 from QA Administrators --- Dear Harald Koester, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142864] [WMF] should ignore META_ESCAPE_ENHANCED_METAFILE
https://bugs.documentfoundation.org/show_bug.cgi?id=142864 --- Comment #5 from QA Administrators --- Dear Valek Filippov, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106722] Crash in: ne_addr_resolve - using system credentials on a webdav share (Kerberos protocol)
https://bugs.documentfoundation.org/show_bug.cgi?id=106722 --- Comment #6 from QA Administrators --- Dear michel.guillot, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101522] [META] Media playback bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101522 --- Comment #3 from alishaynoor0 --- Meta for issue related to the playback of media in the document area, media player dialog, or during presentation slide show. https://myreminiapk.com/why-photo-editing-is-important/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155620] Docx content cant't be rendered completely on high resolution android device
https://bugs.documentfoundation.org/show_bug.cgi?id=155620 disco changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #4 from disco --- for some reason i can't attach the sample file,but i can provide some information about the sample file. It's normal text on the first few pages but the rest is a lot of images -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151976] missing Standard Toolbar buttons when editing chart
https://bugs.documentfoundation.org/show_bug.cgi?id=151976 V Stuart Foote changed: What|Removed |Added Ever confirmed|1 |0 Status|NEW |UNCONFIRMED --- Comment #9 from V Stuart Foote --- Things are not being hidden, rather the 'Standard' toolbar is no longer active. That is when the integrated chart2 editing context view mode is activated it has its own implementation of the Standard toolbar and the Formatting toolbar. They replace the toolbars of the 'normal' view. As the UI for the chart2 was being reworked, buttons on that toolbar were set to not shown mode--and the 'standard' and 'formatting' toolbars activated by chart2 in edit mode were merged onto one line. To streamline the UI, unnecessary buttons (for majority of use cases) were suppressed, not removed. Yes it is trivial to restore by commit removing the toggle in the UI XML but it is also trivial for users to do that directly and has been so since 5.0.0. And changing from default (expanding the chart2 'Standard toolbar) and setting any visible is persistent and recorded into user profile. So no need to back track on a dev choice decision done back at the 5.0.0 release. Doing so is a bad precedence to second guess implemented features, which chart2 is. Rather, it is a a RTM opportunity for users to explore the UI functions--which ever UI or MUFFIN flavor. IMHO => NAB and WF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 151976] missing Standard Toolbar buttons when editing chart
https://bugs.documentfoundation.org/show_bug.cgi?id=151976 V Stuart Foote changed: What|Removed |Added Ever confirmed|1 |0 Status|NEW |UNCONFIRMED --- Comment #9 from V Stuart Foote --- Things are not being hidden, rather the 'Standard' toolbar is no longer active. That is when the integrated chart2 editing context view mode is activated it has its own implementation of the Standard toolbar and the Formatting toolbar. They replace the toolbars of the 'normal' view. As the UI for the chart2 was being reworked, buttons on that toolbar were set to not shown mode--and the 'standard' and 'formatting' toolbars activated by chart2 in edit mode were merged onto one line. To streamline the UI, unnecessary buttons (for majority of use cases) were suppressed, not removed. Yes it is trivial to restore by commit removing the toggle in the UI XML but it is also trivial for users to do that directly and has been so since 5.0.0. And changing from default (expanding the chart2 'Standard toolbar) and setting any visible is persistent and recorded into user profile. So no need to back track on a dev choice decision done back at the 5.0.0 release. Doing so is a bad precedence to second guess implemented features, which chart2 is. Rather, it is a a RTM opportunity for users to explore the UI functions--which ever UI or MUFFIN flavor. IMHO => NAB and WF -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: editeng/source include/editeng sw/inc sw/source
editeng/source/outliner/outlvw.cxx| 12 +
include/editeng/outliner.hxx |2
sw/inc/AnnotationWin.hxx |5 --
sw/inc/fmtfld.hxx |3 -
sw/source/core/fields/textapi.cxx |4 +
sw/source/core/text/txtfld.cxx|5 --
sw/source/uibase/docvw/AnnotationWin.cxx | 18 ---
sw/source/uibase/docvw/AnnotationWin2.cxx | 72 --
sw/source/uibase/docvw/PostItMgr.cxx | 29
9 files changed, 20 insertions(+), 130 deletions(-)
New commits:
commit 6cb6f76095d2df07102ffd3da7accf7d075df90b
Author: Maxim Monastirsky
AuthorDate: Thu Jun 15 11:39:25 2023 +0300
Commit: Maxim Monastirsky
CommitDate: Fri Jun 16 00:49:09 2023 +0200
tdf#103064 sw: use the comment style by default instead of DF
As part of that, language changes in the document's body are
no longer applied to comments, as that would be a DF. Instead,
the default language of comments is controlled via the style
(see tdf#153805 for the use case).
Change-Id: Icfa9a7334b52fe74292e82fa8daa01a15197e384
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153158
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky
diff --git a/editeng/source/outliner/outlvw.cxx
b/editeng/source/outliner/outlvw.cxx
index 705b5e10b06b..382d1d63f7da 100644
--- a/editeng/source/outliner/outlvw.cxx
+++ b/editeng/source/outliner/outlvw.cxx
@@ -715,6 +715,18 @@ void OutlinerView::CreateSelectionList
(std::vector )
}
}
+void OutlinerView::SetStyleSheet(const OUString& rStyleName)
+{
+ParaRange aParas = ImpGetSelectedParagraphs(false);
+
+auto pStyle = pOwner->GetStyleSheetPool()->Find(rStyleName,
SfxStyleFamily::Para);
+if (!pStyle)
+return;
+
+for (sal_Int32 nPara = aParas.nStartPara; nPara <= aParas.nEndPara;
nPara++)
+pOwner->SetStyleSheet(nPara, static_cast(pStyle));
+}
+
const SfxStyleSheet* OutlinerView::GetStyleSheet() const
{
return pEditView->GetStyleSheet();
diff --git a/include/editeng/outliner.hxx b/include/editeng/outliner.hxx
index 7622138271ee..0b9b06395dba 100644
--- a/include/editeng/outliner.hxx
+++ b/include/editeng/outliner.hxx
@@ -267,6 +267,8 @@ public:
voidPaste( bool bUseSpecial = false );
voidPasteSpecial();
+void SetStyleSheet(const OUString& rStyleName);
+
const SfxStyleSheet* GetStyleSheet() const;
SfxStyleSheet* GetStyleSheet();
diff --git a/sw/inc/AnnotationWin.hxx b/sw/inc/AnnotationWin.hxx
index c3d556085a03..f7ac7b301d46 100644
--- a/sw/inc/AnnotationWin.hxx
+++ b/sw/inc/AnnotationWin.hxx
@@ -171,8 +171,6 @@ class SAL_DLLPUBLIC_RTTI SwAnnotationWin final : public
InterimItemWindow
bool IsMouseOverSidebarWin() const { return mbMouseOver; }
-void SetLanguage(const SvxLanguageItem& rNewItem);
-
void ChangeSidebarItem( SwSidebarItem const & rSidebarItem );
virtual css::uno::Reference< css::accessibility::XAccessible >
CreateAccessible() override;
@@ -216,7 +214,6 @@ class SAL_DLLPUBLIC_RTTI SwAnnotationWin final : public
InterimItemWindow
virtual voidDataChanged( const DataChangedEvent& rDCEvt ) override;
voidSetSizePixel( const Size& rNewSize ) override;
-SfxItemSet DefaultItem();
DECL_DLLPRIVATE_LINK(ModifyHdl, LinkParamNone*, void);
DECL_DLLPRIVATE_LINK(ScrollHdl, weld::ScrolledWindow&, void);
@@ -228,8 +225,6 @@ class SAL_DLLPUBLIC_RTTI SwAnnotationWin final : public
InterimItemWindow
sal_uInt32 CountFollowing();
-SvxLanguageItem GetLanguage() const;
-
void SetMenuButtonColors();
SwPostItMgr&mrMgr;
diff --git a/sw/inc/fmtfld.hxx b/sw/inc/fmtfld.hxx
index 6f5811539b17..4c4c1ea91293 100644
--- a/sw/inc/fmtfld.hxx
+++ b/sw/inc/fmtfld.hxx
@@ -178,8 +178,7 @@ enum class SwFormatFieldHintWhich
REMOVED= 2,
FOCUS = 3,
CHANGED= 4,
-LANGUAGE = 5,
-RESOLVED = 6
+RESOLVED = 5
};
class SW_DLLPUBLIC SwFormatFieldHint final : public SfxHint
diff --git a/sw/source/core/fields/textapi.cxx
b/sw/source/core/fields/textapi.cxx
index 88520065c7e3..6dcdc99d3b47 100644
--- a/sw/source/core/fields/textapi.cxx
+++ b/sw/source/core/fields/textapi.cxx
@@ -22,6 +22,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -189,6 +190,9 @@ void SwTextAPIEditSource::SetString( const OUString& rText )
m_pImpl->mpOutliner->Clear();
EnsureOutliner();
+
+if (auto pStyle =
m_pImpl->mpOutliner->GetStyleSheetPool()->Find(SwResId(STR_POOLCOLL_COMMENT),
SfxStyleFamily::Para))
+m_pImpl->mpOutliner->SetStyleSheet(0,
static_cast(pStyle));
m_pImpl->mpOutliner->Insert( rText );
}
diff --git a/sw/source/core/text/txtfld.cxx b/sw/source/core/text/txtfld.cxx
index 004a2bc17c09..aa8fef7331c5 100644
--- a/sw/source/core/text/txtfld.cxx
+++
[Libreoffice-commits] core.git: 2 commits - editeng/source include/editeng include/svl svl/source svx/source sw/inc sw/qa sw/source
editeng/source/editeng/impedit.hxx |4
editeng/source/editeng/impedit2.cxx|2
editeng/source/editeng/impedit5.cxx|2
editeng/source/uno/unoedprx.cxx| 14 +
editeng/source/uno/unofored.cxx| 14 +
editeng/source/uno/unoforou.cxx| 14 +
editeng/source/uno/unotext.cxx | 54
include/editeng/unoedprx.hxx |3
include/editeng/unoedsrc.hxx |3
include/editeng/unofored.hxx |3
include/editeng/unoforou.hxx |5
include/editeng/unotext.hxx|4
include/svl/style.hxx |2
svl/source/items/style.cxx |2
svx/source/accessibility/AccessibleEmptyEditSource.cxx |3
svx/source/dialog/weldeditview.cxx | 20 +
sw/inc/docstyle.hxx|4
sw/inc/docufld.hxx |1
sw/qa/extras/odfexport/odfexport2.cxx | 29 ++
sw/source/core/fields/docufld.cxx |6
sw/source/core/fields/textapi.cxx | 61 +++--
sw/source/core/inc/textapi.hxx |1
sw/source/uibase/app/docstyle.cxx | 191 -
sw/source/uibase/docvw/AnnotationWin2.cxx |5
sw/source/uibase/docvw/PostItMgr.cxx | 14 +
25 files changed, 428 insertions(+), 33 deletions(-)
New commits:
commit 6c4edf7f86912084371e15be7321e9c4764a9ca6
Author: Maxim Monastirsky
AuthorDate: Thu Jun 15 11:36:43 2023 +0300
Commit: Maxim Monastirsky
CommitDate: Fri Jun 16 00:48:56 2023 +0200
tdf#103064 sw,editeng: enable UNO API and ODF import/export
Change-Id: Icf30e1f30fe6bf6a7d96d14b975954613cd68b70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153157
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky
diff --git a/editeng/source/uno/unoedprx.cxx b/editeng/source/uno/unoedprx.cxx
index 5bddd24fca7a..20d5df281bce 100644
--- a/editeng/source/uno/unoedprx.cxx
+++ b/editeng/source/uno/unoedprx.cxx
@@ -530,6 +530,20 @@ void SvxAccessibleTextAdapter::GetPortions( sal_Int32
nPara, std::vectorGetPortions( nPara, rList );
}
+OUString SvxAccessibleTextAdapter::GetStyleSheet(sal_Int32 nPara) const
+{
+assert(mpTextForwarder && "SvxAccessibleTextAdapter: no forwarder");
+
+return mpTextForwarder->GetStyleSheet(nPara);
+}
+
+void SvxAccessibleTextAdapter::SetStyleSheet(sal_Int32 nPara, const OUString&
rStyleName)
+{
+assert(mpTextForwarder && "SvxAccessibleTextAdapter: no forwarder");
+
+mpTextForwarder->SetStyleSheet(nPara, rStyleName);
+}
+
SfxItemState SvxAccessibleTextAdapter::GetItemState( const ESelection& rSel,
sal_uInt16 nWhich ) const
{
assert(mpTextForwarder && "SvxAccessibleTextAdapter: no forwarder");
diff --git a/editeng/source/uno/unofored.cxx b/editeng/source/uno/unofored.cxx
index 5e1824ff5dca..66f4fde2bf78 100644
--- a/editeng/source/uno/unofored.cxx
+++ b/editeng/source/uno/unofored.cxx
@@ -124,6 +124,20 @@ void SvxEditEngineForwarder::GetPortions( sal_Int32 nPara,
std::vectorGetName();
+return OUString();
+}
+
+void SvxEditEngineForwarder::SetStyleSheet(sal_Int32 nPara, const OUString&
rStyleName)
+{
+auto pStyleSheetPool = rEditEngine.GetStyleSheetPool();
+if (auto pStyle = pStyleSheetPool ? pStyleSheetPool->Find(rStyleName,
SfxStyleFamily::Para) : nullptr)
+rEditEngine.SetStyleSheet(nPara, static_cast(pStyle));
+}
+
void SvxEditEngineForwarder::QuickInsertText( const OUString& rText, const
ESelection& rSel )
{
rEditEngine.QuickInsertText( rText, rSel );
diff --git a/editeng/source/uno/unoforou.cxx b/editeng/source/uno/unoforou.cxx
index f6d0fbb8eaea..8772ff9a77fa 100644
--- a/editeng/source/uno/unoforou.cxx
+++ b/editeng/source/uno/unoforou.cxx
@@ -186,6 +186,20 @@ void SvxOutlinerForwarder::GetPortions( sal_Int32 nPara,
std::vector&
const_cast(rOutliner.GetEditEngine()).GetPortions( nPara,
rList );
}
+OUString SvxOutlinerForwarder::GetStyleSheet(sal_Int32 nPara) const
+{
+if (auto pStyle = rOutliner.GetStyleSheet(nPara))
+return pStyle->GetName();
+return OUString();
+}
+
+void SvxOutlinerForwarder::SetStyleSheet(sal_Int32 nPara, const OUString&
rStyleName)
+{
+auto pStyleSheetPool = rOutliner.GetStyleSheetPool();
+if (auto pStyle = pStyleSheetPool ? pStyleSheetPool->Find(rStyleName,
SfxStyleFamily::Para) : nullptr)
+rOutliner.SetStyleSheet(nPara, static_cast(pStyle));
+}
+
void SvxOutlinerForwarder::QuickInsertText( const OUString& rText, const
ESelection& rSel )
{
flushCache();
diff --git a/editeng/source/uno/unotext.cxx b/editeng/source/uno/unotext.cxx
index
[Libreoffice-commits] core.git: sc/source
sc/source/filter/inc/condformatbuffer.hxx |2 +-
sc/source/filter/oox/condformatbuffer.cxx |1 -
sc/source/filter/oox/condformatcontext.cxx |6 ++
3 files changed, 7 insertions(+), 2 deletions(-)
New commits:
commit cc483a88a03f9ee847f3cb5fac83fb5dd49d0ba1
Author: Henry Castro
AuthorDate: Tue Mar 28 17:48:19 2023 -0400
Commit: Henry Castro
CommitDate: Fri Jun 16 00:43:42 2023 +0200
sc: filter: oox: do not insert rule too early
The tag is a good place to do a post check
the conditional format sanity.
Signed-off-by: Henry Castro
Change-Id: Id6e99c81011040ec47034e993490fae5c71d7e04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149719
Reviewed-by: Andras Timar
Tested-by: Andras Timar
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151977
Tested-by: Jenkins CollaboraOffice
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153159
Tested-by: Jenkins
diff --git a/sc/source/filter/inc/condformatbuffer.hxx
b/sc/source/filter/inc/condformatbuffer.hxx
index d5d5ebac2ab5..a1cc7bb81381 100644
--- a/sc/source/filter/inc/condformatbuffer.hxx
+++ b/sc/source/filter/inc/condformatbuffer.hxx
@@ -219,9 +219,9 @@ public:
const ScRangeList& getRanges() const { return maModel.maRanges; }
voidsetReadyForFinalize() { mbReadyForFinalize = true; }
+voidinsertRule( CondFormatRuleRef const & xRule );
private:
CondFormatRuleRef createRule();
-voidinsertRule( CondFormatRuleRef const & xRule );
private:
typedef RefMap< sal_Int32, CondFormatRule > CondFormatRuleMap;
diff --git a/sc/source/filter/oox/condformatbuffer.cxx
b/sc/source/filter/oox/condformatbuffer.cxx
index 4c55792779af..80891c2e9abf 100644
--- a/sc/source/filter/oox/condformatbuffer.cxx
+++ b/sc/source/filter/oox/condformatbuffer.cxx
@@ -1107,7 +1107,6 @@ CondFormatRuleRef CondFormat::importCfRule( const
AttributeList& rAttribs )
{
CondFormatRuleRef xRule = createRule();
xRule->importCfRule( rAttribs );
-insertRule( xRule );
return xRule;
}
diff --git a/sc/source/filter/oox/condformatcontext.cxx
b/sc/source/filter/oox/condformatcontext.cxx
index 2f3ae391ab71..845d105b7605 100644
--- a/sc/source/filter/oox/condformatcontext.cxx
+++ b/sc/source/filter/oox/condformatcontext.cxx
@@ -202,6 +202,12 @@ void CondFormatContext::onEndElement()
if(mxCondFmt)
mxCondFmt->setReadyForFinalize();
break;
+case XLS_TOKEN( cfRule ):
+if (mxCondFmt && mxRule)
+{
+mxCondFmt->insertRule(mxRule);
+}
+break;
}
}
[Libreoffice-bugs] [Bug 130087] Fileopen DOC: Text in table different width in Writer (multiple lines) and Word (single line)
https://bugs.documentfoundation.org/show_bug.cgi?id=130087 --- Comment #8 from Justin L --- The DOCX fix was about rounding issues. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 33201] UI: Highlight (not select) current row and column in spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=33201 m.a.riosv changed: What|Removed |Added CC||gptmailingli...@gmail.com --- Comment #65 from m.a.riosv --- *** Bug 155857 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155857] Add optional horizontal and vertical guidelines to selected cell(s)
https://bugs.documentfoundation.org/show_bug.cgi?id=155857 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |DUPLICATE --- Comment #3 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 33201 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155486] LibreOffice supports Open Type embedded font?
https://bugs.documentfoundation.org/show_bug.cgi?id=155486 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com, ||luigi.iu...@collabora.com --- Comment #18 from Aron Budea --- Gerrit patch: https://gerrit.libreoffice.org/c/core/+/153007 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf155736_PageNumbers_footer.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport18.cxx | 14 ++
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 21
+++---
writerfilter/source/dmapper/DomainMapper_Impl.hxx |2
4 files changed, 30 insertions(+), 7 deletions(-)
New commits:
commit d7dd39e124f8a1fa199dd8322b642e8be04ed360
Author: Satya
AuthorDate: Wed Jun 14 18:15:35 2023 +0530
Commit: Justin Luth
CommitDate: Thu Jun 15 23:39:33 2023 +0200
tdf#155736 Modified IsInTOC() to handle IsInHeaderFooter() case.
This fixes a problem of page numbers missing in the footer.
The importer might start processing the footer before the
TOC has finished - m_bStartTOC might be true.
In this case we are not actually IsInTOC,and m_bStartTOC
should be ignored and make use of IsInHeaderFooter() and
m_bStartTOCHeaderFooter to confirm if the footer/header itself
has TOC.
Change-Id: Ieede9f8e2120556630ba57b9c748935788f3cc9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153052
Reviewed-by: Justin Luth
Tested-by: Justin Luth
diff --git a/sw/qa/extras/ooxmlexport/data/tdf155736_PageNumbers_footer.docx
b/sw/qa/extras/ooxmlexport/data/tdf155736_PageNumbers_footer.docx
new file mode 100644
index ..58e36988002a
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/tdf155736_PageNumbers_footer.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
index fbb87915369e..9183863c8af7 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
@@ -850,6 +850,20 @@ DECLARE_OOXMLEXPORT_TEST(testTdf135786, "tdf135786.docx")
CPPUNIT_ASSERT_EQUAL(2, getParagraphs());
}
+DECLARE_OOXMLEXPORT_TEST(testTdf155736, "tdf155736_PageNumbers_footer.docx")
+{
+CPPUNIT_ASSERT_EQUAL(2, getPages());
+
+xmlDocUniquePtr pXmlDoc = parseLayoutDump();
+assertXPath(pXmlDoc, "/root/page[1]/footer");
+assertXPath(pXmlDoc, "/root/page[2]/footer");
+//Without the fix in place, it would have failed with
+//- Expected: Page * of *
+//- Actual : Page of
+CPPUNIT_ASSERT_EQUAL(OUString("Page * of *"),
parseDump("/root/page[1]/footer/txt/text()"));
+CPPUNIT_ASSERT_EQUAL(OUString("Page * of *"),
parseDump("/root/page[2]/footer/txt/text()"));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index f75fbf529c96..8b5cf8b6e049 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -2959,7 +2959,7 @@ void DomainMapper_Impl::appendTextPortion( const
OUString& rString, const Proper
// If we are in comments, then disable CharGrabBag, comment text
doesn't support that.
uno::Sequence< beans::PropertyValue > aValues =
pPropertyMap->GetPropertyValues(/*bCharGrabBag=*/!m_bIsInComments);
-if (m_bStartTOC || m_bStartIndex || m_bStartBibliography)
+if (IsInTOC() || m_bStartIndex || m_bStartBibliography)
for( auto& rValue : asNonConstRange(aValues) )
{
if (rValue.Name == "CharHidden")
@@ -3372,6 +3372,14 @@ void
DomainMapper_Impl::fillEmptyFrameProperties(std::vector(0)));
}
+bool DomainMapper_Impl::IsInTOC() const
+{
+if (IsInHeaderFooter())
+return m_bStartTOCHeaderFooter;
+else
+return m_bStartTOC;
+}
+
void DomainMapper_Impl::ConvertHeaderFooterToTextFrame(bool bDynamicHeightTop,
bool bDynamicHeightBottom)
{
while (!m_aHeaderFooterTextAppendStack.empty())
@@ -7063,7 +7071,7 @@ void DomainMapper_Impl::CloseFieldCommand()
break;
}
}
-if (m_bStartTOC && (aIt->second.eFieldId == FIELD_PAGEREF) )
+if (IsInTOC() && (aIt->second.eFieldId == FIELD_PAGEREF))
{
bCreateField = false;
}
@@ -7451,7 +7459,7 @@ void DomainMapper_Impl::CloseFieldCommand()
break;
case FIELD_PAGEREF:
case FIELD_REF:
-if (xFieldProperties.is() && !m_bStartTOC)
+if (xFieldProperties.is() && !IsInTOC())
{
bool bPageRef = aIt->second.eFieldId == FIELD_PAGEREF;
@@ -8133,9 +8141,9 @@ void DomainMapper_Impl::PopFieldContext()
else
{
xToInsert.set(pContext->GetTC(), uno::UNO_QUERY);
-if( !xToInsert.is() && !m_bStartTOC && !m_bStartIndex &&
!m_bStartBibliography )
+if (!xToInsert.is() && !IsInTOC() && !m_bStartIndex &&
!m_bStartBibliography)
xToInsert = pContext->GetTextField();
-if(
[Libreoffice-bugs] [Bug 155838] PDF Convertion Removing Dropdown and Checkbox Input
https://bugs.documentfoundation.org/show_bug.cgi?id=155838 --- Comment #5 from m.a.riosv --- I think you don't need to open LibreOffice, only export once opening LibreOffice, the option is saved and used after with the command line. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155776] Slow scrolling, utilizing a CPU core to max
https://bugs.documentfoundation.org/show_bug.cgi?id=155776 --- Comment #3 from m.a.riosv --- I can't appreciate such slow. Version: 7.6.0.0.beta1 (X86_64) / LibreOffice Community Build ID: be55b15d98c5f059483845a183fcb5ea8023d27c CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/xlsx/condformat_databar.xlsx |binary
sc/qa/unit/subsequent_filters_test.cxx | 21 +
2 files changed, 21 insertions(+)
New commits:
commit 02ba31714a5f72495df203833ec9772b380b1b77
Author: Henry Castro
AuthorDate: Fri Mar 17 15:49:45 2023 -0400
Commit: Henry Castro
CommitDate: Thu Jun 15 22:43:30 2023 +0200
sc: qa: add databar unit test
0
1
Change-Id: Ib57dac07027e2c3c01ee556a3df791f49637be54
Signed-off-by: Henry Castro
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149070
Tested-by: Jenkins CollaboraOffice
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153120
Tested-by: Jenkins
diff --git a/sc/qa/unit/data/xlsx/condformat_databar.xlsx
b/sc/qa/unit/data/xlsx/condformat_databar.xlsx
new file mode 100644
index ..2d2d727322b7
Binary files /dev/null and b/sc/qa/unit/data/xlsx/condformat_databar.xlsx differ
diff --git a/sc/qa/unit/subsequent_filters_test.cxx
b/sc/qa/unit/subsequent_filters_test.cxx
index d206ce2cbf69..f633073c85f9 100644
--- a/sc/qa/unit/subsequent_filters_test.cxx
+++ b/sc/qa/unit/subsequent_filters_test.cxx
@@ -1639,6 +1639,27 @@ CPPUNIT_TEST_FIXTURE(ScFiltersTest,
testRowIndex1BasedXLSX)
CPPUNIT_ASSERT_EQUAL(OUString("Third line."), aStr);
}
+CPPUNIT_TEST_FIXTURE(ScFiltersTest, testCondFormatCfvoScaleValueXLSX)
+{
+createScDoc("xlsx/condformat_databar.xlsx");
+
+ScDocument* pDoc = getScDoc();
+ScConditionalFormat* pFormat = pDoc->GetCondFormat(0, 0, 0);
+const ScFormatEntry* pEntry = pFormat->GetEntry(0);
+CPPUNIT_ASSERT(pEntry);
+CPPUNIT_ASSERT_EQUAL(ScFormatEntry::Type::Databar, pEntry->GetType());
+const ScDataBarFormat* pDataBar = static_cast(pEntry);
+const ScDataBarFormatData* pDataBarFormatData = pDataBar->GetDataBarData();
+const ScColorScaleEntry* pLower = pDataBarFormatData->mpLowerLimit.get();
+const ScColorScaleEntry* pUpper = pDataBarFormatData->mpUpperLimit.get();
+
+CPPUNIT_ASSERT_EQUAL(COLORSCALE_VALUE, pLower->GetType());
+CPPUNIT_ASSERT_EQUAL(COLORSCALE_VALUE, pUpper->GetType());
+
+CPPUNIT_ASSERT_EQUAL(0.0, pLower->GetValue());
+CPPUNIT_ASSERT_EQUAL(1.0, pUpper->GetValue());
+}
+
ScFiltersTest::ScFiltersTest()
: ScModelTestBase("sc/qa/unit/data")
{
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sc/source
sc/source/filter/oox/condformatbuffer.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 631f99be735735fd3422516441f18bff7782972c
Author: Caolán McNamara
AuthorDate: Wed Jun 14 15:37:08 2023 +0100
Commit: Henry Castro
CommitDate: Thu Jun 15 22:42:51 2023 +0200
cid#1532384 Out-of-bounds read
sizeof returns num of bytes, not num of elements
Change-Id: I9dea109e5f322d93ee10680f120b15554efa92e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153070
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Henry Castro
diff --git a/sc/source/filter/oox/condformatbuffer.cxx
b/sc/source/filter/oox/condformatbuffer.cxx
index 568a4197b070..7dfc73a4ca7c 100644
--- a/sc/source/filter/oox/condformatbuffer.cxx
+++ b/sc/source/filter/oox/condformatbuffer.cxx
@@ -265,7 +265,7 @@ static ::Color IndexedColors[] = {
else if (rAttribs.hasAttribute(XML_indexed))
{
sal_uInt32 nIndexed = rAttribs.getUnsigned(XML_indexed, 0);
-if (nIndexed < sizeof(IndexedColors))
+if (nIndexed < std::size(IndexedColors))
nColor = IndexedColors[nIndexed];
}
[Libreoffice-commits] core.git: sfx2/source sw/inc sw/source
sfx2/source/dialog/StyleList.cxx |3 +--
sw/inc/docstyle.hxx|2 +-
sw/source/core/model/ThemeColorChanger.cxx |3 +++
sw/source/core/undo/unattr.cxx |9 +
sw/source/uibase/app/docst.cxx |6 +++---
sw/source/uibase/app/docstyle.cxx |6 +-
sw/source/uibase/shells/basesh.cxx |4
7 files changed, 22 insertions(+), 11 deletions(-)
New commits:
commit e229e13f9d5f1322986775399276f5503ebb83f7
Author: Maxim Monastirsky
AuthorDate: Thu Jun 15 11:21:01 2023 +0300
Commit: Maxim Monastirsky
CommitDate: Thu Jun 15 22:37:41 2023 +0200
tdf#103064 sw: improved notifications on style modification
- More useful notification on undo
- Added notifications for theme change and UNO API.
Change-Id: I554dceff92f4f8a6dd5c39c6965b7de706ab6678
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153110
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky
diff --git a/sfx2/source/dialog/StyleList.cxx b/sfx2/source/dialog/StyleList.cxx
index 0247e01e7340..bf9bf80d9db8 100644
--- a/sfx2/source/dialog/StyleList.cxx
+++ b/sfx2/source/dialog/StyleList.cxx
@@ -1565,8 +1565,7 @@ void StyleList::Notify(SfxBroadcaster& /*rBC*/, const
SfxHint& rHint)
if (!m_bDontUpdate && nId != SfxHintId::Dying
&& (dynamic_cast()
|| dynamic_cast()
-|| dynamic_cast()
-|| nId == SfxHintId::StyleSheetModified))
+|| dynamic_cast()))
{
if (!pIdle)
{
diff --git a/sw/inc/docstyle.hxx b/sw/inc/docstyle.hxx
index d727245c059e..e71fb73c9828 100644
--- a/sw/inc/docstyle.hxx
+++ b/sw/inc/docstyle.hxx
@@ -99,7 +99,7 @@ public:
which indicates that the indent attributes at a paragraph style should
be reset in case that a list style is applied to the paragraph style and
no indent attributes are applied. */
-voidSetItemSet( const SfxItemSet& rSet,
+voidSetItemSet( const SfxItemSet& rSet, const bool
bBroadcast = true,
const bool
bResetIndentAttrsAtParagraphStyle = false );
virtual SfxItemSet& GetItemSet() override;
diff --git a/sw/source/core/model/ThemeColorChanger.cxx
b/sw/source/core/model/ThemeColorChanger.cxx
index caf4de1787ce..03fe47641bf3 100644
--- a/sw/source/core/model/ThemeColorChanger.cxx
+++ b/sw/source/core/model/ThemeColorChanger.cxx
@@ -430,7 +430,10 @@ void
ThemeColorChanger::apply(std::shared_ptr const& pColorSet)
bChanged = changeBackground(rAttrSet, *pNewSet, *pColorSet) ||
bChanged;
if (bChanged)
+{
pDocument->ChgFormat(*pTextFormatCollection, *pNewSet);
+
pPool->Broadcast(SfxStyleSheetHint(SfxHintId::StyleSheetModified, *pStyle));
+}
}
pStyle = static_cast(pPool->Next());
}
diff --git a/sw/source/core/undo/unattr.cxx b/sw/source/core/undo/unattr.cxx
index 9b6a12a43707..acc1503ee35c 100644
--- a/sw/source/core/undo/unattr.cxx
+++ b/sw/source/core/undo/unattr.cxx
@@ -226,6 +226,15 @@ void SwUndoFormatAttr::UndoImpl(::sw::UndoRedoContext &
rContext)
if ( RES_FLYFRMFMT == m_nFormatWhich || RES_DRAWFRMFMT == m_nFormatWhich )
{
rContext.SetSelections(static_cast(pFormat), nullptr);
}
+
+SfxStyleFamily nFamily = SfxStyleFamily::None;
+if (RES_TXTFMTCOLL == m_nFormatWhich || RES_CONDTXTFMTCOLL ==
m_nFormatWhich)
+nFamily = SfxStyleFamily::Para;
+else if (RES_CHRFMT == m_nFormatWhich)
+nFamily = SfxStyleFamily::Char;
+
+if (pFormat && nFamily != SfxStyleFamily::None)
+rContext.GetDoc().BroadcastStyleOperation(pFormat->GetName(), nFamily,
SfxHintId::StyleSheetModified);
}
// Check if it is still in Doc
diff --git a/sw/source/uibase/app/docst.cxx b/sw/source/uibase/app/docst.cxx
index d4a05bf2a173..2016d712e9a7 100644
--- a/sw/source/uibase/app/docst.cxx
+++ b/sw/source/uibase/app/docst.cxx
@@ -594,7 +594,7 @@ IMPL_LINK_NOARG(ApplyStyle, ApplyHdl, LinkParamNone*, void)
::SfxToSwPageDescAttr( *pWrtShell, aSet );
// reset indent attributes at paragraph style, if a list style
// will be applied and no indent attributes will be applied.
-m_xTmp->SetItemSet( aSet, true );
+m_xTmp->SetItemSet( aSet, false, true );
}
else
{
@@ -614,7 +614,7 @@ IMPL_LINK_NOARG(ApplyStyle, ApplyHdl, LinkParamNone*, void)
::ConvertAttrGenToChar(aTmpSet, m_xTmp->GetItemSet());
}
-m_xTmp->SetItemSet( aTmpSet );
+m_xTmp->SetItemSet( aTmpSet, false );
if( SfxStyleFamily::Page == m_nFamily &&
SvtCTLOptions::IsCTLFontEnabled() )
{
@@ -667,7 +667,7 @@ IMPL_LINK_NOARG(ApplyStyle, ApplyHdl, LinkParamNone*, void)
SfxItemSet aTmpSet(*m_pDlg->GetOutputItemSet());
aTmpSet.ClearItem(XATTR_FILLSTYLE);
-
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/editattr.cxx |2 +-
editeng/source/editeng/editdoc.cxx |7 +--
2 files changed, 6 insertions(+), 3 deletions(-)
New commits:
commit 9474ff4cc0abbd16f91ea582050c2332bdad88a3
Author: Maxim Monastirsky
AuthorDate: Wed May 31 21:59:06 2023 +0300
Commit: Maxim Monastirsky
CommitDate: Thu Jun 15 22:37:16 2023 +0200
tdf#103064 editeng: fix handling of char highlighting
Transparency should be set to false if a color is present, but not
with COL_TRANSPARENT. Compare with what is done for shape text in
VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D.
Change-Id: I5e4c8e53b53a363813ced50358c5ee795cdb61dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153107
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky
diff --git a/editeng/source/editeng/editattr.cxx
b/editeng/source/editeng/editattr.cxx
index 3277ed0916ba..42e5f20206ba 100644
--- a/editeng/source/editeng/editattr.cxx
+++ b/editeng/source/editeng/editattr.cxx
@@ -230,7 +230,7 @@
EditCharAttribBackgroundColor::EditCharAttribBackgroundColor(
void EditCharAttribBackgroundColor::SetFont( SvxFont& rFont, OutputDevice* )
{
Color aColor = static_cast(GetItem())->GetValue();
-rFont.SetTransparent(false);
+rFont.SetTransparent(aColor == COL_TRANSPARENT);
rFont.SetFillColor(aColor);
}
diff --git a/editeng/source/editeng/editdoc.cxx
b/editeng/source/editeng/editdoc.cxx
index 9fff222d9368..08750a94fcd2 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -1976,7 +1976,6 @@ void CreateFont( SvxFont& rFont, const SfxItemSet& rSet,
bool bSearchInParent, S
{
vcl::Font aPrevFont( rFont );
rFont.SetAlignment( ALIGN_BASELINE );
-rFont.SetTransparent( true );
sal_uInt16 nWhich_FontInfo = GetScriptItemId( EE_CHAR_FONTINFO,
nScriptType );
sal_uInt16 nWhich_Language = GetScriptItemId( EE_CHAR_LANGUAGE,
nScriptType );
@@ -1997,7 +1996,11 @@ void CreateFont( SvxFont& rFont, const SfxItemSet& rSet,
bool bSearchInParent, S
if ( bSearchInParent || ( rSet.GetItemState( EE_CHAR_COLOR ) ==
SfxItemState::SET ) )
rFont.SetColor( rSet.Get( EE_CHAR_COLOR ).GetValue() );
if ( bSearchInParent || ( rSet.GetItemState( EE_CHAR_BKGCOLOR ) ==
SfxItemState::SET ) )
-rFont.SetFillColor( rSet.Get( EE_CHAR_BKGCOLOR ).GetValue() );
+{
+auto& aColor = rSet.Get( EE_CHAR_BKGCOLOR ).GetValue();
+rFont.SetTransparent(aColor == COL_TRANSPARENT);
+rFont.SetFillColor(aColor);
+}
if ( bSearchInParent || ( rSet.GetItemState( nWhich_FontHeight ) ==
SfxItemState::SET ) )
rFont.SetFontSize( Size( rFont.GetFontSize().Width(),
static_cast(rSet.Get( nWhich_FontHeight )
).GetHeight() ) );
if ( bSearchInParent || ( rSet.GetItemState( nWhich_Weight ) ==
SfxItemState::SET ) )
[Libreoffice-bugs] [Bug 133507] contextual spacing wrong between normal text and section
https://bugs.documentfoundation.org/show_bug.cgi?id=133507 --- Comment #7 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/12f256cd1ae3e625c7b7f48987b7e843046924fa tdf#133507 sw: hunt for documents with ULSpacing at section end It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/odfexport/data/tdf133507_contextualSpacingSection.odt |binary
sw/qa/extras/odfexport/odfexport2.cxx |6 ++
sw/source/core/inc/frmtool.hxx |2
sw/source/core/layout/flowfrm.cxx | 26
++
sw/source/core/layout/frmtool.cxx |4 +
5 files changed, 26 insertions(+), 12 deletions(-)
New commits:
commit 12f256cd1ae3e625c7b7f48987b7e843046924fa
Author: Justin Luth
AuthorDate: Tue Jun 13 20:54:14 2023 -0400
Commit: Justin Luth
CommitDate: Thu Jun 15 22:30:20 2023 +0200
tdf#133507 sw: hunt for documents with ULSpacing at section end
When a paragraph style has "contextualspacing" with Spacing Above paragraph,
and option "Don't add space between paragraphs of the same style,
the spacing should apply after a section end.
Contextual spacing was officially added to 1.3 spec in 7.0-ish timeframe:
"The space between the paragraphs is zero,
if all of the following conditions hold:
...
The paragraphs belong to the same content area.
...
Contextual spacing was actually added in LO 3.6,
and it applies as expected when transitioning
from one section to another.
The missing case was when transitioning from a section
back to the main body text.
This was an implementation error. So the question is
whether we add yet another compatibility flag
to handle the old way of doing things,
or just fix it.
I'm leaning towards no compat flag because
-it is a recent official addition to ODF
-it is an implementation error
-it currently is inconsistent - works on section start, but not end
-rarely used: it is primarily an interoperability feature
-rarely encountered: sections aren't really needed in LO.
-no existing unit tests matched the condition.
-interoperability isn't affected - section end == document end.
This patch is hunting to prove some of the above points.
-shouldn't hit any DOC/DOCX/RTF files.
-only expect to find ODT files related to this bug report.
So, I don't think a compat flag is warranted in this case.
It is easy enough for a human to "fix" the document
by removing the undesired "spacing before/after" settings.
make CppunitTest_sw_odfexport2 \
CPPUNIT_TEST_NAME=tdf133507_contextualSpacingSection
Change-Id: Ia041741bbada8c2f4cd97aa6b7cd98d4d7ffb275
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153033
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/qa/extras/odfexport/data/tdf133507_contextualSpacingSection.odt
b/sw/qa/extras/odfexport/data/tdf133507_contextualSpacingSection.odt
new file mode 100644
index ..a2a9ebd47198
Binary files /dev/null and
b/sw/qa/extras/odfexport/data/tdf133507_contextualSpacingSection.odt differ
diff --git a/sw/qa/extras/odfexport/odfexport2.cxx
b/sw/qa/extras/odfexport/odfexport2.cxx
index 103892a7723a..46e192eaf3eb 100644
--- a/sw/qa/extras/odfexport/odfexport2.cxx
+++ b/sw/qa/extras/odfexport/odfexport2.cxx
@@ -242,6 +242,12 @@ DECLARE_ODFEXPORT_TEST(testSpellOutNumberingTypes,
"spellout-numberingtypes.odt"
}
}
+// DECLARE_ODFEXPORT_TEST(tdf133507_contextualSpacingSection,
"tdf133507_contextualSpacingSection.odt")
+// {
+// // Previously this was one page (no UL spacing) or three pages (every
para had spacing)
+// CPPUNIT_ASSERT_EQUAL(2, getPages());
+// }
+
// MAILMERGE Add conditional to expand / collapse bookmarks
DECLARE_ODFEXPORT_TEST(tdf101856_overlapped, "tdf101856_overlapped.odt")
{
diff --git a/sw/source/core/inc/frmtool.hxx b/sw/source/core/inc/frmtool.hxx
index ffc218b5504e..a497ea09e590 100644
--- a/sw/source/core/inc/frmtool.hxx
+++ b/sw/source/core/inc/frmtool.hxx
@@ -583,7 +583,7 @@ void GetSpacingValuesOfFrame( const SwFrame& rFrame,
SwTwips& onLowerSpacing,
SwTwips& onLineSpacing,
bool& obIsLineSpacingProportional,
-bool bIdenticalStyles );
+bool bIdenticalStyles, bool bIdenticalSections =
true );
/** method to get the content of the table cell
diff --git a/sw/source/core/layout/flowfrm.cxx
b/sw/source/core/layout/flowfrm.cxx
index 41b6b8fff953..a2b9da301678 100644
--- a/sw/source/core/layout/flowfrm.cxx
+++ b/sw/source/core/layout/flowfrm.cxx
@@ -1464,9 +1464,20 @@ const SwFrame*
SwFlowFrame::GetPrevFrameForUpperSpaceCalc_( const SwFrame* _pPro
return pPrevFrame;
}
+// This should be renamed to something like lcl_ApplyULSpacing
/// Compare styles attached to these text frames.
static bool lcl_IdenticalStyles(const SwFrame* pPrevFrame, const SwFrame*
pFrame)
{
+if (!pFrame || !pFrame->IsTextFrame())
+return false;
+
+// Identical styles only applies if "the
[Libreoffice-bugs] [Bug 133507] contextual spacing wrong between normal text and section
https://bugs.documentfoundation.org/show_bug.cgi?id=133507 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131173] CRASH: DOC: undoing merge cells
https://bugs.documentfoundation.org/show_bug.cgi?id=131173 Julien Nabet changed: What|Removed |Added CC||michael.st...@allotropia.de --- Comment #11 from Julien Nabet --- Michael: thought you might be interested in this one (noticing your work on tdf#155685) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155861] New: Quick parts or autotext are not being filled.
https://bugs.documentfoundation.org/show_bug.cgi?id=155861 Bug ID: 155861 Summary: Quick parts or autotext are not being filled. Product: LibreOffice Version: 7.5.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: giancarlo.nascime...@neomind.com.br Description: Configured quick parts are not being filled after version 7.5.2.2. The generated document contains codes instead of replacing them with the corresponding texts. Steps to Reproduce: 1. Configure a document with quick parts or autotext. 2. Generate a document with the quick parts. 3. The generated document does not have the quick parts filled in. Actual Results: The generated document contains codes instead of replacing them with the corresponding texts. Expected Results: The gerenated document replacing the quick parts with the corresponding texts. Reproducible: Always User Profile Reset: Yes Additional Info: No other information. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155860] Languagetool for german does not work in Libreoffice 7.5.4 anymore, in Libreoffice 7.5.3 it does work. I use Java "Microsoft OpenJDK".
https://bugs.documentfoundation.org/show_bug.cgi?id=155860 Pachnes changed: What|Removed |Added Version|3.3.1 release |7.5.4.2 release -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155860] New: Languagetool for german does not work in Libreoffice 7.5.4 anymore, in Libreoffice 7.5.3 it does work. I use Java "Microsoft OpenJDK".
https://bugs.documentfoundation.org/show_bug.cgi?id=155860 Bug ID: 155860 Summary: Languagetool for german does not work in Libreoffice 7.5.4 anymore, in Libreoffice 7.5.3 it does work. I use Java "Microsoft OpenJDK". Product: LibreOffice Version: 3.3.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pach...@web.de Description: Languagetool for german does not work in Libreoffice 7.5.4 anymore, in Libreoffice 7.5.3 it does work. I use Java "Microsoft OpenJDK". Actual Results: Install Microsoft Java OpenJDK Version 11.x.x or Version 17.x.x, Install Libreoffice 7.5.4, Open Libreoffice writer, write some german words with typos. In Libreoffice Version 7.5.4 the typos are not detected, in Libreoffice Version 7.5.3 the typos are detected. Expected Results: the typos in are not detected in Libreoffice writer 7.5.4 Reproducible: Always User Profile Reset: Yes Additional Info: the typos should have been detected in Libreoffice 7.5.4 too, not only in Libreoffice 7.5.3. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/localedata/LocaleNode.cxx | 16
i18npool/source/localedata/localedata.cxx | 15 +++
2 files changed, 15 insertions(+), 16 deletions(-)
New commits:
commit 183e1f9eef4840689e81bbf4d7734df2c7e63c5d
Author: Noel Grandin
AuthorDate: Thu Jun 15 10:31:59 2023 +0200
Commit: Noel Grandin
CommitDate: Thu Jun 15 21:02:59 2023 +0200
speed up startup time
by avoid conversion of static locale data from sal_Unicode to OUString
data - we can declare the data as OUStringConstExpr arrays and then
no conversion is necessary.
Change-Id: Ief35b1e3e08ed44c1b9161485a69ef504e1a1c89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153123
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/i18npool/source/localedata/LocaleNode.cxx
b/i18npool/source/localedata/LocaleNode.cxx
index d797c45c53b6..d89a7515c8da 100644
--- a/i18npool/source/localedata/LocaleNode.cxx
+++ b/i18npool/source/localedata/LocaleNode.cxx
@@ -296,8 +296,8 @@ void LCInfoNode::generateCode (const OFileWriter ) const
aLanguage = languageNode->getChildAt(0)->getValue();
if (aLanguage.getLength() != 2 && aLanguage.getLength() != 3)
incErrorStr( "Error: langID '%s' not 2-3 characters\n", aLanguage);
-of.writeParameter("langID", aLanguage);
-of.writeParameter("langDefaultName",
languageNode->getChildAt(1)->getValue());
+of.writeOUStringLiteralParameter("langID", aLanguage);
+of.writeOUStringLiteralParameter("langDefaultName",
languageNode->getChildAt(1)->getValue());
}
else
incError( "No Language node.");
@@ -306,8 +306,8 @@ void LCInfoNode::generateCode (const OFileWriter ) const
OUString aCountry( countryNode->getChildAt(0)->getValue());
if (!(aCountry.isEmpty() || aCountry.getLength() == 2))
incErrorStr( "Error: countryID '%s' not empty or more than 2
characters\n", aCountry);
-of.writeParameter("countryID", aCountry);
-of.writeParameter("countryDefaultName",
countryNode->getChildAt(1)->getValue());
+of.writeOUStringLiteralParameter("countryID", aCountry);
+of.writeOUStringLiteralParameter("countryDefaultName",
countryNode->getChildAt(1)->getValue());
}
else
incError( "No Country node.");
@@ -319,18 +319,18 @@ void LCInfoNode::generateCode (const OFileWriter )
const
incErrorStr( "Error: invalid Variant '%s'\n", aVariant);
if (!(aVariant.isEmpty() || aLanguage == "qlt"))
incErrorStrStr( "Error: Variant '%s' given but Language '%s' is
not 'qlt'\n", aVariant, aLanguage);
-of.writeParameter("Variant", aVariant);
+of.writeOUStringLiteralParameter("Variant", aVariant);
}
else
-of.writeParameter("Variant", std::u16string_view());
-of.writeAsciiString("\nstatic const sal_Unicode* LCInfoArray[] = {\n");
+of.writeOUStringLiteralParameter("Variant", std::u16string_view());
+of.writeAsciiString("\nstatic constexpr rtl::OUStringConstExpr
LCInfoArray[] = {\n");
of.writeAsciiString("\tlangID,\n");
of.writeAsciiString("\tlangDefaultName,\n");
of.writeAsciiString("\tcountryID,\n");
of.writeAsciiString("\tcountryDefaultName,\n");
of.writeAsciiString("\tVariant\n");
of.writeAsciiString("};\n\n");
-of.writeFunction("getLCInfo_", "SAL_N_ELEMENTS(LCInfoArray)",
"LCInfoArray");
+of.writeOUStringFunction("getLCInfo_", "SAL_N_ELEMENTS(LCInfoArray)",
"LCInfoArray");
}
diff --git a/i18npool/source/localedata/localedata.cxx
b/i18npool/source/localedata/localedata.cxx
index 7316b66fce7f..89ee3d5a281d 100644
--- a/i18npool/source/localedata/localedata.cxx
+++ b/i18npool/source/localedata/localedata.cxx
@@ -42,7 +42,6 @@ using namespace com::sun::star::uno;
using namespace com::sun::star::lang;
using namespace com::sun::star;
-typedef sal_Unicode** (* MyFunc_Type)( sal_Int16&);
typedef OUString const * (* MyFuncOUString_Type)( sal_Int16&);
typedef sal_Unicode const *** (* MyFunc_Type2)( sal_Int16&, sal_Int16& );
typedef sal_Unicode const (* MyFunc_Type3)( sal_Int16&, sal_Int16&,
sal_Int16& );
@@ -1123,16 +1122,16 @@ LocaleDataImpl::getTransliterations( const Locale&
rLocale )
LanguageCountryInfo SAL_CALL
LocaleDataImpl::getLanguageCountryInfo( const Locale& rLocale )
{
-MyFunc_Type func = reinterpret_cast(getFunctionSymbol(
rLocale, "getLCInfo" ));
+MyFuncOUString_Type func =
reinterpret_cast(getFunctionSymbol( rLocale, "getLCInfo"
));
if ( func ) {
sal_Int16 LCInfoCount = 0;
-sal_Unicode **LCInfoArray = func(LCInfoCount);
-LanguageCountryInfo info{OUString(LCInfoArray[0]),
-OUString(LCInfoArray[1]),
-OUString(LCInfoArray[2]),
-OUString(LCInfoArray[3]),
-OUString(LCInfoArray[4])};
+OUString const *LCInfoArray = func(LCInfoCount);
+
[Libreoffice-bugs] [Bug 155843] LOOKUP function not working properly
https://bugs.documentfoundation.org/show_bug.cgi?id=155843 --- Comment #3 from Werner Tietz --- (In reply to Liam M from comment #2) … > > Oh no! It does indeed say that. That's unfortunate. This really needs to be > changed. Libreoffice Calc should definitely have a function that does this. the Formula exists: =VLOOKUP(D$1;$A$3:$B$28;2;0) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - vcl/source
vcl/source/gdi/pdfwriter_impl.cxx | 35 ---
1 file changed, 20 insertions(+), 15 deletions(-)
New commits:
commit 6eab55912fc0e6bcb4b2ca15fd626d54b9346d43
Author: Khaled Hosny
AuthorDate: Thu Jun 15 06:27:38 2023 +0300
Commit: Xisco Fauli
CommitDate: Thu Jun 15 20:53:56 2023 +0200
Don’t add empty Fonts dictionary to Type 3 font resources
If the Type 3 font does not use any other fonts, skip writing Fonts to
its Resources dictionary.
Change-Id: I1d0489debeb9f0e24022316551eb234b279381c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153100
Tested-by: Jenkins
Reviewed-by: خالد حسني
(cherry picked from commit 845fbfcce9091e541bab657163b026aad8648261)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153085
Reviewed-by: Xisco Fauli
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 718433aafc02..7ad67f9f1772 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -2755,22 +2755,26 @@ bool PDFWriterImpl::emitType3Font(const
vcl::font::PhysicalFontFace* pFace,
}
// write font dict
-auto nFontDict = createObject();
-aLine.setLength(0);
-aLine.append(OString::number(nFontDict) + " 0 obj\n<<");
-for (auto nFontID : aUsedFonts)
+auto nFontDict = -1;
+if (!aUsedFonts.empty())
{
-aLine.append("/F"
-+ OString::number(nFontID)
-+ " "
-+ OString::number(rFontIDToObject[nFontID])
-+ " 0 R");
+nFontDict = createObject();
+aLine.setLength(0);
+aLine.append(OString::number(nFontDict) + " 0 obj\n<<");
+for (auto nFontID : aUsedFonts)
+{
+aLine.append("/F"
++ OString::number(nFontID)
++ " "
++ OString::number(rFontIDToObject[nFontID])
++ " 0 R");
+}
+aLine.append(">>\nendobj\n\n");
+if (!updateObject(nFontDict))
+return false;
+if (!writeBuffer(aLine))
+return false;
}
-aLine.append(">>\nendobj\n\n");
-if (!updateObject(nFontDict))
-return false;
-if (!writeBuffer(aLine))
-return false;
// write ExtGState objects
if (!aUsedAlpha.empty())
@@ -2806,7 +2810,8 @@ bool PDFWriterImpl::emitType3Font(const
vcl::font::PhysicalFontFace* pFace,
// write resources dict
aLine.setLength(0);
aLine.append(OString::number(nResources) + " 0 obj\n");
-aResourceDict.append(aLine, nFontDict);
+if (!aUsedFonts.empty())
+aResourceDict.append(aLine, nFontDict);
aLine.append("endobj\n\n");
if (!updateObject(nResources))
return false;
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - download.lst
download.lst |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit ead11155b611a355d0f4bfa91454b345a0cd15e0 Author: Taichi Haradaguchi <20001...@ymail.ne.jp> AuthorDate: Thu Jun 15 07:09:06 2023 +0900 Commit: Xisco Fauli CommitDate: Thu Jun 15 20:53:37 2023 +0200 nss: upgrade to release 3.90 Change-Id: Ic446f33abd5355886b8c8c181a088c07ea4605c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153096 Tested-by: Jenkins Reviewed-by: Michael Stahl (cherry picked from commit 3f6bb9565d4edce563dbd938c655ae853926d362) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153083 Reviewed-by: Xisco Fauli diff --git a/download.lst b/download.lst index a9c9eaf5f0fc..e8ce2bfc67aa 100644 --- a/download.lst +++ b/download.lst @@ -392,8 +392,8 @@ MYTHES_TARBALL := mythes-1.2.5.tar.xz # three static lines # so that git cherry-pick # will not run into conflicts -NSS_SHA256SUM := fcfa26d2738ec5b0cf72ab4be784eac832a75132cda2e295799c04d62a93607a -NSS_TARBALL := nss-3.88.1-with-nspr-4.35.tar.gz +NSS_SHA256SUM := f78ab1d911cae8bbc94758fb3bd0f731df4087423a4ff5db271ba65381f6b739 +NSS_TARBALL := nss-3.90-with-nspr-4.35.tar.gz # three static lines # so that git cherry-pick # will not run into conflicts
[Libreoffice-commits] core.git: officecfg/registry
officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu | 14 ++ 1 file changed, 14 insertions(+) New commits: commit 11ac3528f46443cb1f790d0e9ac710cea27fc3a0 Author: Julien Nabet AuthorDate: Thu Jun 15 18:26:36 2023 +0200 Commit: Julien Nabet CommitDate: Thu Jun 15 20:52:55 2023 +0200 Related tdf#148263: on Writer, no need to repeat "Delete" for columns To reproduce the regression, just do this: - launch Writer - create a by default 2x2 table - select a cell - right click and take a look at sub-entries of Delete entry Change-Id: I05bf4824e0786f1b4ea73b24389d38858e01818e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153122 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu index a93b1c50960b..726643e1c7e6 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu @@ -1828,6 +1828,20 @@ 1 + + + Delete Columns + + + ~Columns + + + Delete selected columns + + + 1 + + Delete Table
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - svgio/qa svgio/source
svgio/qa/cppunit/SvgImportTest.cxx | 13 ++
svgio/qa/cppunit/data/tdf155833.svg | 31
svgio/source/svgreader/svgimagenode.cxx | 60 +---
3 files changed, 70 insertions(+), 34 deletions(-)
New commits:
commit 0718628ee0173abb703b9d1999e89eabc26476c9
Author: Xisco Fauli
AuthorDate: Thu Jun 15 10:10:38 2023 +0200
Commit: Xisco Fauli
CommitDate: Thu Jun 15 20:53:09 2023 +0200
tdf#155833: apply transform to image even if target is equal to viewbox
Change-Id: Ie820528384d096c6a332e2abd0095f68c7f64a0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153103
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
(cherry picked from commit 6dce36484bfcac711251710697dca961fd77ca20)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153082
diff --git a/svgio/qa/cppunit/SvgImportTest.cxx
b/svgio/qa/cppunit/SvgImportTest.cxx
index bdfbfcccb911..7184c5fa500b 100644
--- a/svgio/qa/cppunit/SvgImportTest.cxx
+++ b/svgio/qa/cppunit/SvgImportTest.cxx
@@ -423,6 +423,19 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf45771)
assertXPath(pDocument, "/primitive2D/transform/textsimpleportion[1]",
"familyname", "Times New Roman");
}
+CPPUNIT_TEST_FIXTURE(Test, testTdf155833)
+{
+Primitive2DSequence aSequence =
parseSvg(u"/svgio/qa/cppunit/data/tdf155833.svg");
+CPPUNIT_ASSERT_EQUAL(1, static_cast(aSequence.getLength()));
+
+drawinglayer::Primitive2dXmlDump dumper;
+xmlDocUniquePtr pDocument = dumper.dumpAndParse(aSequence);
+
+CPPUNIT_ASSERT (pDocument);
+
+assertXPath(pDocument,
"/primitive2D/transform/mask/transform/transform/transform/transform/transform/bitmap",
1);
+}
+
CPPUNIT_TEST_FIXTURE(Test, testTdf97941)
{
//Check tspan fontsize when using relative units
diff --git a/svgio/qa/cppunit/data/tdf155833.svg
b/svgio/qa/cppunit/data/tdf155833.svg
new file mode 100644
index ..8cc908424af0
--- /dev/null
+++ b/svgio/qa/cppunit/data/tdf155833.svg
@@ -0,0 +1,31 @@
+
+
+
+http://www.w3.org/1999/xlink;
+ xmlns="http://www.w3.org/2000/svg;
+ xmlns:svg="http://www.w3.org/2000/svg;>
+
+
+
+
+
+
+
+
diff --git a/svgio/source/svgreader/svgimagenode.cxx
b/svgio/source/svgreader/svgimagenode.cxx
index ed7b81cef61a..19c8c9404541 100644
--- a/svgio/source/svgreader/svgimagenode.cxx
+++ b/svgio/source/svgreader/svgimagenode.cxx
@@ -310,45 +310,37 @@ namespace svgio::svgreader
if(aNewTarget.empty())
return;
-if(aTarget.equal(aViewBox))
-{
-// just add to rTarget
-rTarget.append(aNewTarget);
-}
-else
-{
-// create mapping
-const SvgAspectRatio& rRatio = maSvgAspectRatio;
+// create mapping
+const SvgAspectRatio& rRatio = maSvgAspectRatio;
-// even when ratio is not set, use the defaults
-// let mapping be created from SvgAspectRatio
-const basegfx::B2DHomMatrix
aEmbeddingTransform(rRatio.createMapping(aTarget, aViewBox));
+// even when ratio is not set, use the defaults
+// let mapping be created from SvgAspectRatio
+const basegfx::B2DHomMatrix
aEmbeddingTransform(rRatio.createMapping(aTarget, aViewBox));
-if(!aEmbeddingTransform.isIdentity())
-{
-const drawinglayer::primitive2d::Primitive2DReference xRef(
-new drawinglayer::primitive2d::TransformPrimitive2D(
-aEmbeddingTransform,
-std::move(aNewTarget)));
-
-aNewTarget =
drawinglayer::primitive2d::Primitive2DContainer { xRef };
-}
+if(!aEmbeddingTransform.isIdentity())
+{
+const drawinglayer::primitive2d::Primitive2DReference xRef(
+new drawinglayer::primitive2d::TransformPrimitive2D(
+aEmbeddingTransform,
+std::move(aNewTarget)));
-if(!rRatio.isMeetOrSlice())
-{
-// need to embed in MaskPrimitive2D to ensure clipping
-const drawinglayer::primitive2d::Primitive2DReference
xMask(
-new drawinglayer::primitive2d::MaskPrimitive2D(
-basegfx::B2DPolyPolygon(
-
basegfx::utils::createPolygonFromRect(aTarget)),
-std::move(aNewTarget)));
-
-aNewTarget =
drawinglayer::primitive2d::Primitive2DContainer { xMask };
-}
+aNewTarget = drawinglayer::primitive2d::Primitive2DContainer {
xRef };
+}
-// embed and add to rTarget, take local extra-transform into
account
-pStyle->add_postProcess(rTarget,
[Libreoffice-bugs] [Bug 155772] Japanese, vertical CTL text: some pasted text displayed incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=155772 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Summary|Japanese, vertical RTL |Japanese, vertical CTL |text: some pasted text |text: some pasted text |displayed incorrectly |displayed incorrectly -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155848] CSV import improperly import floats as text prefixed by a hidden apostrophe
https://bugs.documentfoundation.org/show_bug.cgi?id=155848 --- Comment #3 from Werner Tietz --- The purpose of a csv-import-DIALOG is NOT to press the "ok" button as soon as possible, but to choose the IMPORT options carefully!! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - 2 commits - sw/qa sw/source
sw/qa/extras/uiwriter/data/table-at-end-of-cell.fodt | 219 +++
sw/qa/extras/uiwriter/uiwriter.cxx | 18 +
sw/source/core/docnode/ndtbl.cxx | 46 +++
sw/source/core/edit/eddel.cxx| 10
4 files changed, 283 insertions(+), 10 deletions(-)
New commits:
commit 916caa67508530c38eea50061390e8e4ec7e8cc9
Author: Michael Stahl
AuthorDate: Thu Jun 15 13:13:05 2023 +0200
Commit: Michael Stahl
CommitDate: Thu Jun 15 20:08:45 2023 +0200
tdf#155685 sw: ExtendedSelectAll with tables, group the Undo objects
Change-Id: I2fba70968c97cd9704212cd799b333d2d158a042
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153115
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 5ab4fb27f4232fe0f36cfc079acb065d1712a355)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153089
diff --git a/sw/source/core/edit/eddel.cxx b/sw/source/core/edit/eddel.cxx
index 6082dabb9ef0..10d086bbac63 100644
--- a/sw/source/core/edit/eddel.cxx
+++ b/sw/source/core/edit/eddel.cxx
@@ -99,6 +99,12 @@ void SwEditShell::DeleteSel(SwPaM& rPam, bool const
isArtificialSelection, bool
SwPaM * pPam =
if (oSelectAll)
{
+if (!oSelectAll->second.empty())
+{
+SwRewriter aRewriter;
+aRewriter.AddRule(UndoArg1, SwResId(STR_MULTISEL));
+GetDoc()->GetIDocumentUndoRedo().StartUndo(SwUndoId::DELETE,
);
+}
// tdf#155685 tables at the end must be deleted separately
for (SwTableNode *const pTable : oSelectAll->second)
{
@@ -115,6 +121,10 @@ void SwEditShell::DeleteSel(SwPaM& rPam, bool const
isArtificialSelection, bool
GetDoc()->getIDocumentContentOperations().DeleteAndJoin(*pPam,
isArtificialSelection ? SwDeleteFlags::ArtificialSelection :
SwDeleteFlags::Default);
SaveTableBoxContent( pPam->GetPoint() );
+if (oSelectAll && !oSelectAll->second.empty())
+{
+GetDoc()->GetIDocumentUndoRedo().EndUndo(SwUndoId::END, nullptr);
+}
}
// Selection is not needed anymore
commit a398e3eb78783dfe533b55b6f174d76265ea422b
Author: Michael Stahl
AuthorDate: Thu Jun 15 12:22:11 2023 +0200
Commit: Michael Stahl
CommitDate: Thu Jun 15 20:08:34 2023 +0200
tdf#155685 sw: fix another ExtendedSelectAll Redo crash w table at end
This can be reproduced with a table containing in the last cell a
paragraph followed by a table, then ExtendedSelectAll in the cell and
delete.
On Redo of the SwUndoDelete:
warn:legacy.osl:326138:326138:sw/source/core/frmedt/tblsel.cxx:1775:
MakeSelUnions with pStart or pEnd not in CellFrame
In function:
const_reference std::vector::operator[](size_type) const
[_Tp = SwTableBox *, _Allocator = std::allocator]
Error: attempt to subscript container with out-of-bounds index 0, but
container only holds 0 elements.
The problem is that DelTable() calls PaMCorrAbs() with a target that is
outside of the outer table, so the SwEditShell::DeleteSel() rPam has one
end in the last table cell and other end outside the table.
Change-Id: Ia2764a4c99ba12102957153e005284a44be04fd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153114
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 4ef548a672658ab164e45e45ebd1b9f0b9282019)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153088
diff --git a/sw/qa/extras/uiwriter/data/table-at-end-of-cell.fodt
b/sw/qa/extras/uiwriter/data/table-at-end-of-cell.fodt
new file mode 100644
index ..4e18f7dc2ce4
--- /dev/null
+++ b/sw/qa/extras/uiwriter/data/table-at-end-of-cell.fodt
@@ -0,0 +1,219 @@
+
+http://www.w3.org/TR/css3-text/;
xmlns:grddl="http://www.w3.org/2003/g/data-view#;
xmlns:xhtml="http://www.w3.org/1999/xhtml;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xmlns:xsd="http://www.w3.org/2001/XMLSchema;
xmlns:xforms="http://www.w3.org/2002/xforms;
xmlns:dom="http://www.w3.org/2001/xml-events;
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0"
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0"
xmlns:math="http://www.w3.org/1998/Math/MathML;
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0"
xmlns:ooo="http://openoffice.org/2004/office;
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0"
xmlns:ooow="http://openoffice.org/2004/writer;
xmlns:xlink="http://www.w3.org/1999/xlink;
xmlns:drawooo="http://openoffice.org/2010/draw;
xmlns:oooc="http://openoffice.org/2004/calc;
xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c
alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
[Libreoffice-bugs] [Bug 139273] FILEOPEN: DOC/DOCX/RTF. Endnote page style page-size different from Default Page Size
https://bugs.documentfoundation.org/show_bug.cgi?id=139273 --- Comment #15 from Justin L --- Although this patch https://gerrit.libreoffice.org/c/core/+/153151 is probably not correct I'll post it here anyway to document my attempt. This is not an easyhack. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #21 from Julien Nabet --- (In reply to zuebgirl from comment #19) > ... > There's also another such benchmark: > > https://survey.stackoverflow.co/2023/#technology-most-popular-technologies > > Here JS leads by about 30%. Whatever, it doesn't justify the fact to remove VB or Python knowing they're still quite used + already existing files (as Mike indicated). If you think something's lacking about Javascript binding, don't hesitate to contribute after reading https://wiki.documentfoundation.org/Development/GetInvolved. You can also try to submit a patch to remove Python or VB binding, but I'm pretty sure it'll be refused (and I would understand). So please, no need to insist here to remove VB or Python binding. They're far to be deprecated. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155852] MCGR FILESAVE PPTX export of stepped gradient has wrong colors
https://bugs.documentfoundation.org/show_bug.cgi?id=155852 Regina Henschel changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #19 from zuebg...@sharklasers.com --- (In reply to Mike Kaganski from comment #12) > (In reply to zuebgirl from comment #11) > > There is no benefit of JS over any other language, except when someone knows > one better than another. Python is the *world's #1* programming language - > see today's TIOBE index [1]; the idea that the project has a goal to force > people to learn some other programming language *just because zuebgirl has > an idea it has an abstract benefit* is another daydreaming. > > [1] https://www.tiobe.com/tiobe-index/ There's also another such benchmark: https://survey.stackoverflow.co/2023/#technology-most-popular-technologies Here JS leads by about 30%. --- Comment #20 from Julien Nabet --- (In reply to Julien Nabet from comment #18) > (In reply to zuebgirl from comment #16) > > ... > > Further, I've thought that the DOM model makes much more sense for LO > > applications than Python's generic abstractions. > ??? LO is written in C++ at 95% at min, the rest is in C, Java, some assembly, Objective C (for macOs part), Perl and I must forget some. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #19 from zuebg...@sharklasers.com --- (In reply to Mike Kaganski from comment #12) > (In reply to zuebgirl from comment #11) > > There is no benefit of JS over any other language, except when someone knows > one better than another. Python is the *world's #1* programming language - > see today's TIOBE index [1]; the idea that the project has a goal to force > people to learn some other programming language *just because zuebgirl has > an idea it has an abstract benefit* is another daydreaming. > > [1] https://www.tiobe.com/tiobe-index/ There's also another such benchmark: https://survey.stackoverflow.co/2023/#technology-most-popular-technologies Here JS leads by about 30%. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #18 from Julien Nabet --- (In reply to zuebgirl from comment #16) > ... > Further, I've thought that the DOM model makes much more sense for LO > applications than Python's generic abstractions. ??? LO is written in C++ at 95% at min, the rest is in C, Javsome assembly, Java, Objective C (for macOs part), Perl and I must forget some. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103064] Introduce a comment style
https://bugs.documentfoundation.org/show_bug.cgi?id=103064 Maxim Monastirsky changed: What|Removed |Added Status|NEW |ASSIGNED Keywords|needsDevAdvice, topicUI | Assignee|libreoffice-b...@lists.free |momonas...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #17 from Julien Nabet --- (In reply to zuebgirl from comment #15) > ... > Yes, so how will LO Calc implement a BI workflow with a front-end in the > browser? Flask? LibreOffice is an Office Suite, not a BI software. Now you can (or pay someone) to create an extension. Now there are scripting possibilitiess which allow to automatize some actions (eg: file conversion from line command) but won't go further here since I'm not an expert. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103064] Introduce a comment style
https://bugs.documentfoundation.org/show_bug.cgi?id=103064 --- Comment #42 from Commit Notification --- Maxim Monastirsky committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6e2c8f3f56ab52dfaa9bdce37423bac44cc64061 tdf#103064 sw: add a comment style It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/qa sw/source
sw/inc/poolfmt.hxx |2 ++
sw/inc/strings.hrc |1 +
sw/qa/python/check_styles.py|2 +-
sw/source/core/doc/DocumentStylePoolManager.cxx | 10 +-
sw/source/core/doc/SwStyleNameMapper.cxx|3 ++-
sw/source/core/doc/poolfmt.cxx |1 +
6 files changed, 16 insertions(+), 3 deletions(-)
New commits:
commit 6e2c8f3f56ab52dfaa9bdce37423bac44cc64061
Author: Maxim Monastirsky
AuthorDate: Thu Jun 15 11:23:02 2023 +0300
Commit: Maxim Monastirsky
CommitDate: Thu Jun 15 19:34:13 2023 +0200
tdf#103064 sw: add a comment style
Change-Id: I96acdf3200836efe1d66e19dd85000fca9e7a6fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153109
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky
diff --git a/sw/inc/poolfmt.hxx b/sw/inc/poolfmt.hxx
index 358747e37808..4f017de21d3a 100644
--- a/sw/inc/poolfmt.hxx
+++ b/sw/inc/poolfmt.hxx
@@ -356,6 +356,8 @@ RES_POOLCOLL_SEND_ADDRESS,
///< Sender.
RES_POOLCOLL_ENDNOTE, ///< Endnotes.
RES_POOLCOLL_LABEL_DRAWING, ///< Label drawing
objects.
+RES_POOLCOLL_COMMENT, ///< Comment
+
RES_POOLCOLL_EXTRA_END,
/// Group indices.
diff --git a/sw/inc/strings.hrc b/sw/inc/strings.hrc
index 38ae2f61bff9..97d216e7ba83 100644
--- a/sw/inc/strings.hrc
+++ b/sw/inc/strings.hrc
@@ -152,6 +152,7 @@
#define STR_POOLCOLL_LABEL_FRAME
NC_("STR_POOLCOLL_LABEL_FRAME", "Text")
#define STR_POOLCOLL_LABEL_DRAWING
NC_("STR_POOLCOLL_LABEL_DRAWING", "Drawing")
#define STR_POOLCOLL_LABEL_FIGURE
NC_("STR_POOLCOLL_LABEL_FIGURE", "Figure")
+#define STR_POOLCOLL_COMMENTNC_("STR_POOLCOLL_COMMENT",
"Comment")
#define STR_POOLCOLL_ENVELOPE_ADDRESS
NC_("STR_POOLCOLL_ENVELOPE_ADDRESS", "Addressee")
#define STR_POOLCOLL_SEND_ADDRESS
NC_("STR_POOLCOLL_SEND_ADDRESS", "Sender")
#define STR_POOLCOLL_TOX_IDXH NC_("STR_POOLCOLL_TOX_IDXH",
"Index Heading")
diff --git a/sw/qa/python/check_styles.py b/sw/qa/python/check_styles.py
index 113fd801593c..aca3d8f0486e 100644
--- a/sw/qa/python/check_styles.py
+++ b/sw/qa/python/check_styles.py
@@ -131,7 +131,7 @@ class CheckStyle(unittest.TestCase):
def test_ParagraphFamily(self):
xDoc = CheckStyle._uno.openEmptyWriterDoc()
xParaStyles = xDoc.StyleFamilies["ParagraphStyles"]
-vEmptyDocStyles = ['Standard', 'Heading', 'Text body', 'List',
'Caption', 'Index', 'First line indent', 'Hanging indent', 'Text body indent',
'Salutation', 'Signature', 'List Indent', 'Marginalia', 'Heading 1', 'Heading
2', 'Heading 3', 'Heading 4', 'Heading 5', 'Heading 6', 'Heading 7', 'Heading
8', 'Heading 9', 'Heading 10', 'Title', 'Subtitle', 'Appendix', 'Numbering 1
Start', 'Numbering 1', 'Numbering 1 End', 'Numbering 1 Cont.', 'Numbering 2
Start', 'Numbering 2', 'Numbering 2 End', 'Numbering 2 Cont.', 'Numbering 3
Start', 'Numbering 3', 'Numbering 3 End', 'Numbering 3 Cont.', 'Numbering 4
Start', 'Numbering 4', 'Numbering 4 End', 'Numbering 4 Cont.', 'Numbering 5
Start', 'Numbering 5', 'Numbering 5 End', 'Numbering 5 Cont.', 'List 1 Start',
'List 1', 'List 1 End', 'List 1 Cont.', 'List 2 Start', 'List 2', 'List 2 End',
'List 2 Cont.', 'List 3 Start', 'List 3', 'List 3 End', 'List 3 Cont.', 'List 4
Start', 'List 4', 'List 4 End', 'List 4 Cont.', 'List 5 Start', 'List 5
', 'List 5 End', 'List 5 Cont.', 'Index Heading', 'Index 1', 'Index 2', 'Index
3', 'Index Separator', 'Contents Heading', 'Contents 1', 'Contents 2',
'Contents 3', 'Contents 4', 'Contents 5', 'User Index Heading', 'User Index 1',
'User Index 2', 'User Index 3', 'User Index 4', 'User Index 5', 'Contents 6',
'Contents 7', 'Contents 8', 'Contents 9', 'Contents 10', 'Figure Index
Heading', 'Figure Index 1', 'Object index heading', 'Object index 1', 'Table
index heading', 'Table index 1', 'Bibliography Heading', 'Bibliography 1',
'User Index 6', 'User Index 7', 'User Index 8', 'User Index 9', 'User Index
10', 'Header and Footer','Header', 'Header left', 'Header right', 'Footer',
'Footer left', 'Footer right', 'Table Contents', 'Table Heading',
'Illustration', 'Table', 'Text','Figure', 'Frame contents', 'Footnote',
'Addressee', 'Sender', 'Endnote', 'Drawing', 'Quotations', 'Preformatted Text',
'Horizontal Line', 'List Contents', 'List Heading']
+vEmptyDocStyles = ['Standard', 'Heading', 'Text body', 'List',
'Caption', 'Comment', 'Index', 'First line indent', 'Hanging indent', 'Text
body indent', 'Salutation', 'Signature', 'List Indent', 'Marginalia', 'Heading
1', 'Heading 2', 'Heading 3', 'Heading 4', 'Heading 5', 'Heading 6', 'Heading
7', 'Heading 8', 'Heading 9', 'Heading 10', 'Title', 'Subtitle', 'Appendix',
'Numbering 1 Start', 'Numbering 1', 'Numbering 1 End',
[Libreoffice-bugs] [Bug 103064] Introduce a comment style
https://bugs.documentfoundation.org/show_bug.cgi?id=103064 --- Comment #41 from Commit Notification --- Maxim Monastirsky committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c89d6d690ba4b48c235752a6193aa77d9ecb7384 tdf#103064 editeng: invalidate spelling results on style change It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103064] Introduce a comment style
https://bugs.documentfoundation.org/show_bug.cgi?id=103064 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/impedit5.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit c89d6d690ba4b48c235752a6193aa77d9ecb7384 Author: Maxim Monastirsky AuthorDate: Thu Jun 15 11:16:29 2023 +0300 Commit: Maxim Monastirsky CommitDate: Thu Jun 15 19:33:48 2023 +0200 tdf#103064 editeng: invalidate spelling results on style change Because a style might define a different langauge. This is similar to what we do for DF in SetAttribs/SetParaAttribs. See also alternative approach in SwLangHelper::SetLanguageStatus or SwAnnotationWin::SetLanguage. Change-Id: I38caa716ec95958580f4ce0ede70eff5d1024e13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153108 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky diff --git a/editeng/source/editeng/impedit5.cxx b/editeng/source/editeng/impedit5.cxx index 3a87c4b5bfb7..8438f0be7632 100644 --- a/editeng/source/editeng/impedit5.cxx +++ b/editeng/source/editeng/impedit5.cxx @@ -87,6 +87,9 @@ void ImpEditEngine::SetStyleSheet( sal_Int32 nPara, SfxStyleSheet* pStyle ) pNode->SetStyleSheet( pStyle, aStatus.UseCharAttribs() ); if ( pStyle ) StartListening(*pStyle, DuplicateHandling::Prevent); + +if (pNode->GetWrongList()) +pNode->GetWrongList()->ResetInvalidRange(0, pNode->Len()); ParaAttribsChanged( pNode ); } if (IsUpdateLayout()) @@ -110,6 +113,8 @@ void ImpEditEngine::UpdateParagraphsWithStyleSheet( SfxStyleSheet* pStyle ) else pNode->SetStyleSheet( pStyle, false ); +if (pNode->GetWrongList()) +pNode->GetWrongList()->ResetInvalidRange(0, pNode->Len()); ParaAttribsChanged( pNode ); } }
[Libreoffice-bugs] [Bug 155859] New: Insert hyperlinks to positions in current document is more tedious that it needs to be
https://bugs.documentfoundation.org/show_bug.cgi?id=155859 Bug ID: 155859 Summary: Insert hyperlinks to positions in current document is more tedious that it needs to be Product: LibreOffice Version: 7.5.3.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gregpsm...@live.co.uk Description: When writing technical documentation I regularly add cross-reference links with the Hyperlink command. However, this command (in Windows, at least), does not remember my last use, so each time I must: 1. Ctrl+K to open Hyperlink dialog 2. Click on Document 3. Click on Target in Document 4. Expand Target in document window 5. Expand to find my item, select etc Could the Hyperlink window remember the last selection (Internet, Mail, Document...)? Could the Target in Document Window remember its last position and size. Could we have Ctrl+K,D (or other combination) take us straight to the Target in Document window? Could we leave the Target in Document window window open so that selecting text in the document then selecting in the Target in Document window and clicking Apply inserts a Hyperlink? Steps to Reproduce: 1.See above 2. 3. Actual Results: Repetitive Strain Injury Expected Results: A great user experience Reproducible: Always User Profile Reset: No Additional Info: Assume that my most likely action is similar to the previous one. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #16 from zuebg...@sharklasers.com --- (In reply to zuebgirl from comment #15) > (In reply to Mike Kaganski from comment #14) > > (In reply to zuebgirl from comment #13) > > > But also, just because something is popular does not mean it's right or > > > the > > > best. > > > > Again: the LO project has *no* goal of *deciding* which programming language > > is "right" or "best"; the popularity tells the only one metric that matters > > for this project: the number of people who potentially can benefit from the > > support; it shows that dropping this support would make much harm (and there > > are other metrics telling about harm from dropping such support); and trying > > to force your idea on the project is trying to shift the project's goals, > > that are fixed and defined in the TDF legal statutes. > > > > I'm off of this useless discussion. > > Yes, so how will LO Calc implement a BI workflow with a front-end in the > browser? Flask? Further, I've thought that the DOM model makes much more sense for LO applications than Python's generic abstractions. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #15 from zuebg...@sharklasers.com --- (In reply to Mike Kaganski from comment #14) > (In reply to zuebgirl from comment #13) > > But also, just because something is popular does not mean it's right or the > > best. > > Again: the LO project has *no* goal of *deciding* which programming language > is "right" or "best"; the popularity tells the only one metric that matters > for this project: the number of people who potentially can benefit from the > support; it shows that dropping this support would make much harm (and there > are other metrics telling about harm from dropping such support); and trying > to force your idea on the project is trying to shift the project's goals, > that are fixed and defined in the TDF legal statutes. > > I'm off of this useless discussion. Yes, so how will LO Calc implement a BI workflow with a front-end in the browser? Flask? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155857] Add optional horizontal and vertical guidelines to selected cell(s)
https://bugs.documentfoundation.org/show_bug.cgi?id=155857 --- Comment #2 from temp_user --- Actually it makes easier to track and read other cells which are on the same row or column in a _sparse_ table. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155857] Add optional horizontal and vertical guidelines to selected cell(s)
https://bugs.documentfoundation.org/show_bug.cgi?id=155857 --- Comment #1 from temp_user --- Actually it makes easier to track and read other cells which are on the same row or column in a table. PS: Please simplify the procedure to request feature request! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155858] New: PRINTING on Super B landscape has wide L/R margins
https://bugs.documentfoundation.org/show_bug.cgi?id=155858 Bug ID: 155858 Summary: PRINTING on Super B landscape has wide L/R margins Product: LibreOffice Version: 7.5.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dpie...@cartchunk.org Created attachment 187928 --> https://bugs.documentfoundation.org/attachment.cgi?id=187928=edit STandard ruler pattern shows wide margins when printed as described When trying to print drawings scaled to Super B (13" x 19") paper on Epson Pro9000, printing is restricted to about 17" along the long side. The printed area on the final paper seems to have 1" to 1.25" left and right margins that cannot be changed. Vertical margins seem to be no more than about 0.2". All other applications (Autocad, Photoshop (various), Gimp) don't seem to have similar limitations. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155857] New: Add optional horizontal and vertical guidelines to selected cell(s)
https://bugs.documentfoundation.org/show_bug.cgi?id=155857 Bug ID: 155857 Summary: Add optional horizontal and vertical guidelines to selected cell(s) Product: LibreOffice Version: 3.3.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gptmailingli...@gmail.com Description: An horizontal (maybe colored) guideline extended to the row number makes reading the row number easily. Actual Results: N/A Expected Results: N/A Reproducible: Always User Profile Reset: No Additional Info: N/A -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144207] SUGGESTION : default file names when printing workbook in PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=144207 Buovjaga changed: What|Removed |Added Keywords||needsUXEval CC||ilmari.lauhakangas@libreoff ||ice.org, ||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #3 from Buovjaga --- (In reply to Robert Lacroix from comment #2) > Expected Results: > - automatically suggest a PDF file name > - automatically create several PDF files according to the choice indicated UX team: this report has two ideas, but maybe you can evaluate them both and then decide whether to accept and split the report? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 144207] SUGGESTION : default file names when printing workbook in PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=144207 Buovjaga changed: What|Removed |Added Keywords||needsUXEval CC||ilmari.lauhakangas@libreoff ||ice.org, ||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #3 from Buovjaga --- (In reply to Robert Lacroix from comment #2) > Expected Results: > - automatically suggest a PDF file name > - automatically create several PDF files according to the choice indicated UX team: this report has two ideas, but maybe you can evaluate them both and then decide whether to accept and split the report? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 147542] Draw should let the user define an Anchor, to snap the object
https://bugs.documentfoundation.org/show_bug.cgi?id=147542 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #3 from Buovjaga --- (In reply to TorrAB from comment #0) > Description: > Draw should let the user define an Anchor (master point) for any shape s.he > wants to move —the centre of a circle, one corner or the centre of a > rectangle or a triangle, etc. Then, when the object is selected and dragged > around, the Anchor would snap to a point or line. In particular, snapping to > a line would help User to move the shape along that line. I can understand the last sentence, like the geometry of a line acting as a guide. But do you have in mind some other software that would implement this? Also, about snapping to a point, I'm not sure I understand it. An illustration might help. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155809] Insert comment keyboard shortcut (Ctrl+Alt+C) has no effect with BenQ Display Pilot
https://bugs.documentfoundation.org/show_bug.cgi?id=155809 --- Comment #4 from Filipus Klutiero --- (In reply to Stéphane Guillou (stragu) from comment #3) > (In reply to Filipus Klutiero from comment #2) > > The only other shortcut using Ctrl+Alt which I can see is the one for the > > extension manager, Ctrl+Alt+E, which also does not work. However, that is > > because CAN/CSA has the Euro symbol € on level 3 for E. > > Right, which would be the issue many users hit, tracked in bug 119676 Ah, indeed. Thanks again Stéphane > > That being said, I figured out that Ctrl+Alt+C did have an effect, ie > > removing focus from the window. That is because a utility was globally > > catching that combination. It is BenQ's Display Pilot which uses that > > shortcut to switch color mode: > > https://defkey.com/benq-display-pilot-shortcuts > > Not sure much can be done here, as we can't cater for all the other software > catching shortcuts before LO does. > Will ask in the dev channel. Thanks. It's more about managing conflicts than "catering" for other software. Visually, shortcut hints could be displayed in gray when a conflict is detected. However, to detect them, the OS needs to allow polling for handlers. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: connectivity/source include/connectivity
connectivity/source/parse/sqlbison.y |2 +-
connectivity/source/parse/sqlnode.cxx | 15 +++
include/connectivity/sqlparse.hxx |3 ++-
3 files changed, 10 insertions(+), 10 deletions(-)
New commits:
commit e469a171833c2d88c4e129f339415c15a3a14b1e
Author: Noel Grandin
AuthorDate: Thu Jun 15 15:34:40 2023 +0200
Commit: Noel Grandin
CommitDate: Thu Jun 15 18:39:31 2023 +0200
wrap OSQLParser::s_xLocaleData in vcl::DeleteOnDeinit
since my adaption of i18npool to use OUStringLiteral, this
data structure might get torn down after the i18npool data is
has pointers to.
Change-Id: If83d232d5bfb003ed4dbfb70d47f707a73d2bcc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153121
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/connectivity/source/parse/sqlbison.y
b/connectivity/source/parse/sqlbison.y
index cbad86149fc2..0c5d359d083e 100644
--- a/connectivity/source/parse/sqlbison.y
+++ b/connectivity/source/parse/sqlbison.y
@@ -4493,7 +4493,7 @@ sal_Int32 OSQLParser::s_nRefCount = 0;
// ::osl::MutexOSQLParser::s_aMutex;
OSQLScanner* OSQLParser::s_pScanner = nullptr;
OSQLParseNodesGarbageCollector*OSQLParser::s_pGarbageCollector
= nullptr;
-css::uno::Reference< css::i18n::XLocaleData4> OSQLParser::s_xLocaleData =
nullptr;
+vcl::DeleteOnDeinit>
OSQLParser::s_xLocaleData(vcl::DeleteOnDeinitFlag::Empty);
void setParser(OSQLParser* _pParser)
{
diff --git a/connectivity/source/parse/sqlnode.cxx
b/connectivity/source/parse/sqlnode.cxx
index 4f213bf4f902..1153a216cffd 100644
--- a/connectivity/source/parse/sqlnode.cxx
+++ b/connectivity/source/parse/sqlnode.cxx
@@ -803,7 +803,7 @@ void OSQLParser::killThousandSeparator(OSQLParseNode*
pLiteral)
{
if ( pLiteral )
{
-if ( s_xLocaleData->getLocaleItem( m_pData->aLocale
).decimalSeparator.toChar() == ',' )
+if ( s_xLocaleData.get()->get()->getLocaleItem( m_pData->aLocale
).decimalSeparator.toChar() == ',' )
{
pLiteral->m_aNodeValue = pLiteral->m_aNodeValue.replace('.',
sal_Unicode());
// and replace decimal
@@ -1118,7 +1118,7 @@ OUString OSQLParser::stringToDouble(const OUString&
_rValue,sal_Int16 _nScale)
OUString aValue;
if(!m_xCharClass.is())
m_xCharClass = CharacterClassification::create( m_xContext );
-if( s_xLocaleData.is() )
+if( s_xLocaleData.get() )
{
try
{
@@ -1129,7 +1129,8 @@ OUString OSQLParser::stringToDouble(const OUString&
_rValue,sal_Int16 _nScale)
sal_Int32 nPos = aValue.lastIndexOf('.');
if((nPos+_nScale) < aValue.getLength())
aValue =
aValue.replaceAt(nPos+_nScale,aValue.getLength()-nPos-_nScale, u"");
-aValue =
aValue.replaceAt(aValue.lastIndexOf('.'),1,s_xLocaleData->getLocaleItem(m_pData->aLocale).decimalSeparator);
+OUString sDecimalSeparator =
s_xLocaleData.get()->get()->getLocaleItem(m_pData->aLocale).decimalSeparator;
+aValue = aValue.replaceAt(aValue.lastIndexOf('.'), 1,
sDecimalSeparator);
return aValue;
}
}
@@ -1247,7 +1248,7 @@ std::unique_ptr
OSQLParser::predicateTree(OUString& rErrorMessage
s_pScanner->SetRule(OSQLScanner::GetSTRINGRule());
break;
default:
-if ( s_xLocaleData->getLocaleItem( m_pData->aLocale
).decimalSeparator.toChar() == ',' )
+if ( s_xLocaleData.get()->get()->getLocaleItem(
m_pData->aLocale ).decimalSeparator.toChar() == ',' )
s_pScanner->SetRule(OSQLScanner::GetGERRule());
else
s_pScanner->SetRule(OSQLScanner::GetENGRule());
@@ -1330,8 +1331,8 @@ OSQLParser::OSQLParser(css::uno::Reference<
css::uno::XComponentContext > xConte
s_pScanner->setScanner();
s_pGarbageCollector = new OSQLParseNodesGarbageCollector();
-if(!s_xLocaleData.is())
-s_xLocaleData = LocaleData::create(m_xContext);
+if(!s_xLocaleData.get())
+s_xLocaleData.set(LocaleData::create(m_xContext));
// reset to UNKNOWN_RULE
static_assert(OSQLParseNode::UNKNOWN_RULE==0, "UNKNOWN_RULE must be 0
for memset to 0 to work");
@@ -1482,8 +1483,6 @@ OSQLParser::~OSQLParser()
delete s_pGarbageCollector;
s_pGarbageCollector = nullptr;
-// Is only set the first time, so we should delete it only when there
are no more instances
-s_xLocaleData = nullptr;
RuleIDMap().swap(s_aReverseRuleIDLookup);
}
diff --git a/include/connectivity/sqlparse.hxx
b/include/connectivity/sqlparse.hxx
index c3314c470c6b..15400c112240 100644
--- a/include/connectivity/sqlparse.hxx
+++ b/include/connectivity/sqlparse.hxx
@@ -25,6 +25,7 @@
#include
#include
#include
+#include
#include
#include
@@
[Libreoffice-bugs] [Bug 38891] Ctrl+Alt+? shortcuts don't work on some keyboard layouts
https://bugs.documentfoundation.org/show_bug.cgi?id=38891 --- Comment #18 from Filipus Klutiero --- Ctrl+Alt+E is still used for the extension manager, as reported in ticket #119676. As for Ctrl+Alt+C, I reported that it conflicts with BenQ's Display Pilot (which is unrelated to keyboard layout) in ticket #155809. -- You are receiving this mail because: You are the assignee for the bug.
Week 1 & 2 Report : GSoC 2023 - Convert Writer's Java UNO API Tests to C++
Hey everyone, I want to submit the project report for Week #1 and #2. The converted tests ready for commiting are as mentioned below 1. SwXCell.java The tests still under work are 1. SwXAutoTextContainer.java 2. SwXAutoTextEntry.java 3. SwXAutoTextGroup.java The converted tests will be committed by Monday. Thanks and regards Dipam Turkar
[Libreoffice-commits] help.git: Branch 'libreoffice-7-6' - source/text
source/text/shared/00/0208.xhp | 13 ++--- source/text/shared/guide/csv_params.xhp | 15 +-- 2 files changed, 23 insertions(+), 5 deletions(-) New commits: commit ef0e2a4bf333ba01d2e3fd81ad9e4b14fb205e4d Author: Laurent Balland AuthorDate: Tue May 30 21:46:27 2023 +0200 Commit: Laurent Balland CommitDate: Thu Jun 15 18:30:25 2023 +0200 tdf#154131 Detect numbers in scientfic notation Add a new option to CSV params Add help to dialog Change-Id: If812698a5083cc19431d6de6c2439d2879baa1f7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152407 Tested-by: Jenkins Reviewed-by: Olivier Hallot (cherry picked from commit a8a5edeadd66edfc0fb0747ba7f1251da1b2597c) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152983 diff --git a/source/text/shared/00/0208.xhp b/source/text/shared/00/0208.xhp index 0e6ce5b98e..38cdfd518b 100644 --- a/source/text/shared/00/0208.xhp +++ b/source/text/shared/00/0208.xhp @@ -108,11 +108,18 @@ Detect special numbers -When this option is enabled, Calc will automatically detect all number formats, including special number formats such as dates, time, and scientific notation. +When this option is enabled, Calc will automatically detect all number formats, including special number formats such as dates and time. Scientific notation will also be detected as Detect scientific notation option must be enabled at the same time. The selected language influences how such special numbers are detected, since different languages and regions many have different conventions for such special numbers. -When this option is disabled, Calc will detect and convert only numbers in decimal or scientific notation. The rest will be imported as text. A decimal number string can have digits 0-9, thousands separators, and a decimal separator. Thousands separators and decimal separators may vary with the selected language and region. - +When this option is disabled, Calc will detect and convert only numbers in decimal notation. Detection of numbers in scientific notation will depend on Detect scientific notation option. The rest will be imported as text. A decimal number string can have digits 0-9, thousands separators, and a decimal separator. Thousands separators and decimal separators may vary with the selected language and region. + + +Detect scientific notation +When this option is enabled, Calc will automatically detect numbers with scientific notation, like 5E2 for 500. +The selected language influences how scientific notation is detected, since different languages and regions many have different decimal separator. +This option can be be disabled only if Detect special numbers option is previously disabled. +When this option is disabled, Calc will detect and convert only numbers in decimal notation. The rest will be imported as text. A decimal number string can have digits 0-9, thousands separators, and a decimal separator. Thousands separators and decimal separators may vary with the selected language and region. + Skip empty cells Available when using Paste Special: when this option is enabled, Calc preserves previous content of cells when pasting empty ones. Otherwise, Calc deletes content of previous cells. In Text to Columns conversion, if cell content begins with a separator and this option is disabled, then first column will be emptied. diff --git a/source/text/shared/guide/csv_params.xhp b/source/text/shared/guide/csv_params.xhp index a6bcf26e46..4a695e793d 100644 --- a/source/text/shared/guide/csv_params.xhp +++ b/source/text/shared/guide/csv_params.xhp @@ -25,7 +25,7 @@ CSV Filter Options -The CSV filter accepts an option string containing five to thirteen tokens, separated by commas. Tokens 6 to 13 are optional. +The CSV filter accepts an option string containing five to fifteen tokens, separated by commas. Tokens 6 to 15 are optional. Import from UTF-8, Language German, Comma separated, Text delimiter ", Quoted field as text. CSV file has columns formatted as date, number, number, number: @@ -134,7 +134,7 @@ Import: String, either false or true. Default value: false. This token is the equivalent of the check box "Detect special numbers". -Export: String, either false or true. Default value: true. This token has no UI equivalent. If true, the number cells are stored as numbers. If false, the numbers are stored as text, with text delimiters. +Export: String, either false or true. Default value: true. This token has no UI equivalent. If true, the number cells are stored as numbers. If false, the numbers are stored as text, with text delimiters. @@ -219,6 +219,17 @@ String, either false or true. Default value: false. If true include a
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7ef2a697b7daa3338febd98057241b57cf7722b3 Author: Laurent Balland AuthorDate: Thu Jun 15 18:30:26 2023 +0200 Commit: Gerrit Code Review CommitDate: Thu Jun 15 18:30:26 2023 +0200 Update git submodules * Update helpcontent2 from branch 'libreoffice-7-6' to ef0e2a4bf333ba01d2e3fd81ad9e4b14fb205e4d - tdf#154131 Detect numbers in scientfic notation Add a new option to CSV params Add help to dialog Change-Id: If812698a5083cc19431d6de6c2439d2879baa1f7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152407 Tested-by: Jenkins Reviewed-by: Olivier Hallot (cherry picked from commit a8a5edeadd66edfc0fb0747ba7f1251da1b2597c) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152983 diff --git a/helpcontent2 b/helpcontent2 index 7eaf785f0e90..ef0e2a4bf333 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 7eaf785f0e905577cce77c82fa58f1dcefcd879e +Subproject commit ef0e2a4bf333ba01d2e3fd81ad9e4b14fb205e4d
[Libreoffice-commits] core.git: drawinglayer/source editeng/source i18npool/source include/editeng svx/CppunitTest_svx_styles.mk sw/CppunitTest_sw_uibase_uiview.mk
drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx | 20 ++--
drawinglayer/source/processor2d/vclmetafileprocessor2d.hxx |3
editeng/source/editeng/eerdll.cxx | 10 +-
i18npool/source/localedata/LocaleNode.cxx | 60 ++---
i18npool/source/localedata/localedata.cxx | 51 +++
include/editeng/eerdll.hxx |1
svx/CppunitTest_svx_styles.mk |1
sw/CppunitTest_sw_uibase_uiview.mk |1
8 files changed, 71 insertions(+), 76 deletions(-)
New commits:
commit 1a253362f6d1e1909913dce298630c92d431e41e
Author: Noel Grandin
AuthorDate: Wed Jun 14 13:32:01 2023 +0200
Commit: Noel Grandin
CommitDate: Thu Jun 15 18:15:18 2023 +0200
speed up startup time
by avoid conversion of static locale data from sal_Unicode to OUString
data - we can declare the data as OUStringConstExpr arrays and then
no conversion is necessary.
Here we trigger a problem - EditDLL has static data that tends
to get torn down __after__ the i18npool shared library has been
removed from memory, which means it tries to access OUStringLiteral
objects that no longer exists.
So use vcl::DeleteOnExit to explicitly clear that on application
shutdown.
Change-Id: Ie4bfcef7eb4656316ea825474ac42f85844d1dcc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153060
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
index 1b411d16f443..794f8085f9c8 100644
--- a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
@@ -520,7 +520,8 @@ void VclMetafileProcessor2D::popList()
}
// init static break iterator
-uno::Reference
VclMetafileProcessor2D::mxBreakIterator;
+vcl::DeleteOnDeinit>
+VclMetafileProcessor2D::mxBreakIterator;
VclMetafileProcessor2D::VclMetafileProcessor2D(const
geometry::ViewInformation2D& rViewInformation,
OutputDevice& rOutDev)
@@ -1470,12 +1471,13 @@ void
VclMetafileProcessor2D::processTextSimplePortionPrimitive2D(
// #i101169# if(pTextDecoratedCandidate)
{
// support for TEXT_ MetaFile actions only for decorated texts
-if (!mxBreakIterator.is())
+if (!mxBreakIterator.get() || !mxBreakIterator.get()->get())
{
uno::Reference xContext(
::comphelper::getProcessComponentContext());
-mxBreakIterator = i18n::BreakIterator::create(xContext);
+mxBreakIterator.set(i18n::BreakIterator::create(xContext));
}
+auto& rBreakIterator = *mxBreakIterator.get()->get();
const OUString& rTxt = rTextCandidate.getText();
const sal_Int32 nTextLength(rTextCandidate.getTextLength()); //
rTxt.getLength());
@@ -1486,13 +1488,13 @@ void
VclMetafileProcessor2D::processTextSimplePortionPrimitive2D(
const sal_Int32 nTextPosition(rTextCandidate.getTextPosition());
sal_Int32 nDone;
-sal_Int32 nNextCellBreak(mxBreakIterator->nextCharacters(
+sal_Int32 nNextCellBreak(rBreakIterator.nextCharacters(
rTxt, nTextPosition, rLocale,
css::i18n::CharacterIteratorMode::SKIPCELL, 0,
nDone));
-css::i18n::Boundary
nNextWordBoundary(mxBreakIterator->getWordBoundary(
+css::i18n::Boundary
nNextWordBoundary(rBreakIterator.getWordBoundary(
rTxt, nTextPosition, rLocale, css::i18n::WordType::ANY_WORD,
true));
sal_Int32 nNextSentenceBreak(
-mxBreakIterator->endOfSentence(rTxt, nTextPosition, rLocale));
+rBreakIterator.endOfSentence(rTxt, nTextPosition, rLocale));
const OString aCommentStringA("XTEXT_EOC");
const OString aCommentStringB("XTEXT_EOW");
const OString aCommentStringC("XTEXT_EOS");
@@ -1504,21 +1506,21 @@ void
VclMetafileProcessor2D::processTextSimplePortionPrimitive2D(
{
mpMetaFile->AddAction(
new MetaCommentAction(aCommentStringA, i -
nTextPosition));
-nNextCellBreak = mxBreakIterator->nextCharacters(
+nNextCellBreak = rBreakIterator.nextCharacters(
rTxt, i, rLocale,
css::i18n::CharacterIteratorMode::SKIPCELL, 1, nDone);
}
if (i == nNextWordBoundary.endPos)
{
mpMetaFile->AddAction(
new MetaCommentAction(aCommentStringB, i -
nTextPosition));
-nNextWordBoundary = mxBreakIterator->getWordBoundary(
+nNextWordBoundary = rBreakIterator.getWordBoundary(
[Libreoffice-commits] core.git: cppcanvas/source
cppcanvas/source/mtfrenderer/implrenderer.cxx|5 +---
cppcanvas/source/mtfrenderer/transparencygroupaction.cxx | 16 +++
cppcanvas/source/mtfrenderer/transparencygroupaction.hxx |7 +-
3 files changed, 12 insertions(+), 16 deletions(-)
New commits:
commit c7dfec21b44b23c4e52b938721f356f75046f37b
Author: Noel Grandin
AuthorDate: Thu Jun 15 14:51:52 2023 +0200
Commit: Noel Grandin
CommitDate: Thu Jun 15 18:14:39 2023 +0200
remove some misleading typedefs
Change-Id: I8016c42c3ff8d1cf03c276ebbb68ae7872cd43fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153119
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/cppcanvas/source/mtfrenderer/implrenderer.cxx
b/cppcanvas/source/mtfrenderer/implrenderer.cxx
index 226e62d7eec4..10ccaf1ccdbb 100644
--- a/cppcanvas/source/mtfrenderer/implrenderer.cxx
+++ b/cppcanvas/source/mtfrenderer/implrenderer.cxx
@@ -2404,12 +2404,11 @@ namespace cppcanvas::internal
{
MetaFloatTransparentAction* pAct =
static_cast(pCurrAct);
-internal::MtfAutoPtr pMtf(
+std::unique_ptr< GDIMetaFile > pMtf(
new ::GDIMetaFile( pAct->GetGDIMetaFile() ) );
// TODO(P2): Use native canvas gradients here (saves a
lot of UNO calls)
-internal::GradientAutoPtr pGradient(
-pAct->GetGradient() );
+std::optional< Gradient > pGradient(
pAct->GetGradient() );
DBG_TESTSOLARMUTEX();
diff --git a/cppcanvas/source/mtfrenderer/transparencygroupaction.cxx
b/cppcanvas/source/mtfrenderer/transparencygroupaction.cxx
index b1dff7cb404f..35a2b45fd7bd 100644
--- a/cppcanvas/source/mtfrenderer/transparencygroupaction.cxx
+++ b/cppcanvas/source/mtfrenderer/transparencygroupaction.cxx
@@ -83,8 +83,8 @@ namespace cppcanvas::internal
Size of the transparency group object, in current
state coordinate system.
*/
-TransparencyGroupAction( MtfAutoPtr&&
rGroupMtf,
- GradientAutoPtr&&
rAlphaGradient,
+TransparencyGroupAction( std::unique_ptr< GDIMetaFile >&&
rGroupMtf,
+ std::optional< Gradient >&&
rAlphaGradient,
const ::basegfx::B2DPoint&
rDstPoint,
const ::basegfx::B2DVector&
rDstSize,
const CanvasSharedPtr&
rCanvas,
@@ -104,8 +104,8 @@ namespace cppcanvas::internal
virtual sal_Int32 getActionCount() const override;
private:
-MtfAutoPtr mpGroupMtf;
-GradientAutoPtr
mpAlphaGradient;
+std::unique_ptr< GDIMetaFile > mpGroupMtf;
+std::optional< Gradient >
mpAlphaGradient;
const ::basegfx::B2DSizemaDstSize;
@@ -135,8 +135,8 @@ namespace cppcanvas::internal
aLocalTransformation );
}
-TransparencyGroupAction::TransparencyGroupAction( MtfAutoPtr&&
rGroupMtf,
-
GradientAutoPtr&& rAlphaGradient,
+TransparencyGroupAction::TransparencyGroupAction( std::unique_ptr<
GDIMetaFile >&& rGroupMtf,
+ std::optional<
Gradient >&& rAlphaGradient,
const
::basegfx::B2DPoint&rDstPoint,
const
::basegfx::B2DVector& rDstSize,
const
CanvasSharedPtr&rCanvas,
@@ -453,8 +453,8 @@ namespace cppcanvas::internal
}
-std::shared_ptr
TransparencyGroupActionFactory::createTransparencyGroupAction( MtfAutoPtr&&
rGroupMtf,
-
GradientAutoPtr&&rAlphaGradient,
+std::shared_ptr
TransparencyGroupActionFactory::createTransparencyGroupAction( std::unique_ptr<
GDIMetaFile >&& rGroupMtf,
+
std::optional< Gradient >&& rAlphaGradient,
const ::basegfx::B2DPoint& rDstPoint,
Minutes from the UX/design meeting 2023-Jun-15
Present: Happy, Hossein, Heiko Comments: Mike, Dieter, Eyal Tickets/Topics * E-Mail by using mail-merge needs handling of: "messages per connection" + https://bugs.documentfoundation.org/show_bug.cgi?id=155299 + reasonable request (Mike) + add to Tools > Options > Writer > Mail Merge a frame "Options" with "Break every [ 100] messages for [ 5] s" (the values could need a review) => do this * Allow edit of F1 keystroke + https://bugs.documentfoundation.org/show_bug.cgi?id=155671 + makes sense to allow customization of all keys (Happy) + F1 has a dedicated command so it's just the limitation to customize => allow it * Include extension chart digitizer in LO 7 chart with Calc table + https://bugs.documentfoundation.org/show_bug.cgi?id=139933 + LibreOffice is not an OCR tool, well suited for an extension (Heiko) => do not add to the core functionality * More centralized endnote/footnote settings + https://bugs.documentfoundation.org/show_bug.cgi?id=125876 + rename Tools > "F & E" to "Footnotes/Endnotes settings" (Dieter) + +1 (Happy, Heiko) + add F Settings to context menu of footnote anchor + should be the fact right now + rename "Insert > Footnote or Endnote" to "Edit Footnote/Endnote" (Dieter) + rather hide this command as adding a random character is odd (Heiko) + it's the only way to insert characters not available as numbering lists like Arabic alef (Hossein) + keep and rename to "Insert Special Footnote/Endnote" (Happy) + make footnote numbering page-style-specific, rename the Insert > F dialog "Out-of-order Note" or "Special Note", provide access to Page Style from F (Eyal) + off topic here, depends on bug 155712; if footnotes were bound to page style it would be confusing for left/right varying styles => follow Dieter's suggestion except Special F/E * HYPERLINK DIALOG: Simplification of Hyperlink Process + https://bugs.documentfoundation.org/show_bug.cgi?id=130646 + search for bookmarks or optionally sort alphabetically in the Navigator + Navigator shows the URL on hover + use case is "referencing of terminology" which would be Insert > Cross-reference (Eyal) + or rather Alphabetical Index created per Concordance File (Heiko) => sufficient methods, NEEDINFO OpenPGP_signature Description: OpenPGP digital signature
[Libreoffice-qa] Minutes from the UX/design meeting 2023-Jun-15
Present: Happy, Hossein, Heiko Comments: Mike, Dieter, Eyal Tickets/Topics * E-Mail by using mail-merge needs handling of: "messages per connection" + https://bugs.documentfoundation.org/show_bug.cgi?id=155299 + reasonable request (Mike) + add to Tools > Options > Writer > Mail Merge a frame "Options" with "Break every [ 100] messages for [ 5] s" (the values could need a review) => do this * Allow edit of F1 keystroke + https://bugs.documentfoundation.org/show_bug.cgi?id=155671 + makes sense to allow customization of all keys (Happy) + F1 has a dedicated command so it's just the limitation to customize => allow it * Include extension chart digitizer in LO 7 chart with Calc table + https://bugs.documentfoundation.org/show_bug.cgi?id=139933 + LibreOffice is not an OCR tool, well suited for an extension (Heiko) => do not add to the core functionality * More centralized endnote/footnote settings + https://bugs.documentfoundation.org/show_bug.cgi?id=125876 + rename Tools > "F & E" to "Footnotes/Endnotes settings" (Dieter) + +1 (Happy, Heiko) + add F Settings to context menu of footnote anchor + should be the fact right now + rename "Insert > Footnote or Endnote" to "Edit Footnote/Endnote" (Dieter) + rather hide this command as adding a random character is odd (Heiko) + it's the only way to insert characters not available as numbering lists like Arabic alef (Hossein) + keep and rename to "Insert Special Footnote/Endnote" (Happy) + make footnote numbering page-style-specific, rename the Insert > F dialog "Out-of-order Note" or "Special Note", provide access to Page Style from F (Eyal) + off topic here, depends on bug 155712; if footnotes were bound to page style it would be confusing for left/right varying styles => follow Dieter's suggestion except Special F/E * HYPERLINK DIALOG: Simplification of Hyperlink Process + https://bugs.documentfoundation.org/show_bug.cgi?id=130646 + search for bookmarks or optionally sort alphabetically in the Navigator + Navigator shows the URL on hover + use case is "referencing of terminology" which would be Insert > Cross-reference (Eyal) + or rather Alphabetical Index created per Concordance File (Heiko) => sufficient methods, NEEDINFO OpenPGP_signature Description: OpenPGP digital signature
[Libreoffice-bugs] [Bug 120522] FILEOPEN XLSX Wrapped text looks different in Excel and Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=120522 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||2561 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112561] XLS/XLSX/ODS - Excel uses a 1.12 line spacing for multiline text
https://bugs.documentfoundation.org/show_bug.cgi?id=112561 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||0522 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - sw/qa sw/source
sw/qa/extras/uiwriter/data/table-at-end-of-cell.fodt | 219 +++
sw/qa/extras/uiwriter/uiwriter.cxx | 18 +
sw/source/core/docnode/ndtbl.cxx | 46 +++
sw/source/core/edit/eddel.cxx| 10
4 files changed, 283 insertions(+), 10 deletions(-)
New commits:
commit 5ab4fb27f4232fe0f36cfc079acb065d1712a355
Author: Michael Stahl
AuthorDate: Thu Jun 15 13:13:05 2023 +0200
Commit: Michael Stahl
CommitDate: Thu Jun 15 17:18:48 2023 +0200
tdf#155685 sw: ExtendedSelectAll with tables, group the Undo objects
Change-Id: I2fba70968c97cd9704212cd799b333d2d158a042
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153115
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/source/core/edit/eddel.cxx b/sw/source/core/edit/eddel.cxx
index 6082dabb9ef0..10d086bbac63 100644
--- a/sw/source/core/edit/eddel.cxx
+++ b/sw/source/core/edit/eddel.cxx
@@ -99,6 +99,12 @@ void SwEditShell::DeleteSel(SwPaM& rPam, bool const
isArtificialSelection, bool
SwPaM * pPam =
if (oSelectAll)
{
+if (!oSelectAll->second.empty())
+{
+SwRewriter aRewriter;
+aRewriter.AddRule(UndoArg1, SwResId(STR_MULTISEL));
+GetDoc()->GetIDocumentUndoRedo().StartUndo(SwUndoId::DELETE,
);
+}
// tdf#155685 tables at the end must be deleted separately
for (SwTableNode *const pTable : oSelectAll->second)
{
@@ -115,6 +121,10 @@ void SwEditShell::DeleteSel(SwPaM& rPam, bool const
isArtificialSelection, bool
GetDoc()->getIDocumentContentOperations().DeleteAndJoin(*pPam,
isArtificialSelection ? SwDeleteFlags::ArtificialSelection :
SwDeleteFlags::Default);
SaveTableBoxContent( pPam->GetPoint() );
+if (oSelectAll && !oSelectAll->second.empty())
+{
+GetDoc()->GetIDocumentUndoRedo().EndUndo(SwUndoId::END, nullptr);
+}
}
// Selection is not needed anymore
commit 4ef548a672658ab164e45e45ebd1b9f0b9282019
Author: Michael Stahl
AuthorDate: Thu Jun 15 12:22:11 2023 +0200
Commit: Michael Stahl
CommitDate: Thu Jun 15 17:18:44 2023 +0200
tdf#155685 sw: fix another ExtendedSelectAll Redo crash w table at end
This can be reproduced with a table containing in the last cell a
paragraph followed by a table, then ExtendedSelectAll in the cell and
delete.
On Redo of the SwUndoDelete:
warn:legacy.osl:326138:326138:sw/source/core/frmedt/tblsel.cxx:1775:
MakeSelUnions with pStart or pEnd not in CellFrame
In function:
const_reference std::vector::operator[](size_type) const
[_Tp = SwTableBox *, _Allocator = std::allocator]
Error: attempt to subscript container with out-of-bounds index 0, but
container only holds 0 elements.
The problem is that DelTable() calls PaMCorrAbs() with a target that is
outside of the outer table, so the SwEditShell::DeleteSel() rPam has one
end in the last table cell and other end outside the table.
Change-Id: Ia2764a4c99ba12102957153e005284a44be04fd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153114
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/qa/extras/uiwriter/data/table-at-end-of-cell.fodt
b/sw/qa/extras/uiwriter/data/table-at-end-of-cell.fodt
new file mode 100644
index ..4e18f7dc2ce4
--- /dev/null
+++ b/sw/qa/extras/uiwriter/data/table-at-end-of-cell.fodt
@@ -0,0 +1,219 @@
+
+http://www.w3.org/TR/css3-text/;
xmlns:grddl="http://www.w3.org/2003/g/data-view#;
xmlns:xhtml="http://www.w3.org/1999/xhtml;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xmlns:xsd="http://www.w3.org/2001/XMLSchema;
xmlns:xforms="http://www.w3.org/2002/xforms;
xmlns:dom="http://www.w3.org/2001/xml-events;
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0"
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0"
xmlns:math="http://www.w3.org/1998/Math/MathML;
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0"
xmlns:ooo="http://openoffice.org/2004/office;
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0"
xmlns:ooow="http://openoffice.org/2004/writer;
xmlns:xlink="http://www.w3.org/1999/xlink;
xmlns:drawooo="http://openoffice.org/2010/draw;
xmlns:oooc="http://openoffice.org/2004/calc;
xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c
alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0"
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0"
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2"
xmlns:tableooo="http://openoffice.org/2009/table;
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0"
[Libreoffice-bugs] [Bug 155809] Insert comment keyboard shortcut (Ctrl+Alt+C) has no effect with BenQ Display Pilot
https://bugs.documentfoundation.org/show_bug.cgi?id=155809 Stéphane Guillou (stragu) changed: What|Removed |Added Version|unspecified |7.5.4.2 release --- Comment #3 from Stéphane Guillou (stragu) --- (In reply to Filipus Klutiero from comment #2) > The only other shortcut using Ctrl+Alt which I can see is the one for the > extension manager, Ctrl+Alt+E, which also does not work. However, that is > because CAN/CSA has the Euro symbol € on level 3 for E. Right, which would be the issue many users hit, tracked in bug 119676 > That being said, I figured out that Ctrl+Alt+C did have an effect, ie > removing focus from the window. That is because a utility was globally > catching that combination. It is BenQ's Display Pilot which uses that > shortcut to switch color mode: > https://defkey.com/benq-display-pilot-shortcuts Not sure much can be done here, as we can't cater for all the other software catching shortcuts before LO does. Will ask in the dev channel. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: solenv/gdb
solenv/gdb/libreoffice/sw.py |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ea858ca92488309789e8381a358af1d9f6f6
Author: Julien Nabet
AuthorDate: Thu Jun 15 12:22:57 2023 +0200
Commit: Julien Nabet
CommitDate: Thu Jun 15 17:12:50 2023 +0200
gdb: BigPtrArrayPrinter, add the suffix, so 0->0ul
On pc Debian testing with GNU gdb (Debian 13.2-1) 13.2, I got this trying
to debug tdf#131173
Thread 1 "soffice.bin" hit Breakpoint 1, SwUndoTableMerge::UndoImpl
(this=0x5599a0d302b0, rContext=...) at sw/source/core/undo/untbl.cxx:1878
1878SwStartNode* pSttNd = rDoc.GetNodes().MakeTextSection(
aIdx.GetNode(),
(gdb) p rDoc.GetNodes()
$1 = (SwNodes &) @0x5599a0477000: { = BigPtrArray of length
18Python Exception : No type named std::_Head_base<0,
BlockInfo**, false>.
, m_vIndices = 0x5599a04a4478, m_rMyDoc = @0x5599a0479590, m_pEndOfPostIts
= 0x5599a04739b0, m_pEndOfInserts = 0x5599a042da70,
m_pEndOfAutotext = 0x5599a04764b0, m_pEndOfRedlines = 0x5599a04765e0,
m_pEndOfContent = std::unique_ptr = {get() = 0x5599a0478d20},
m_aOutlineNodes = {> = {m_vector = std::__debug::vector of length 0,
capacity 0}, static npos = 18446744073709551615},
m_bInNodesDel = false, m_bInDelUpdOutline = false}
with the patch, I got:
(gdb) p rDoc.GetNodes()
$1 = (SwNodes &) @0x55c379492b10: { = BigPtrArray of length 18
= {
[ 0] 0x55c37948c9a0StartNode ,
[ 1] 0x55c3794859a0 EndNode ,
[ 2] 0x55c379492bb0StartNode ,
[ 3] 0x55c37948a6c0 EndNode ,
[ 4] 0x55c3794925a0StartNode ,
[ 5] 0x55c37948ff10 EndNode ,
[ 6] 0x55c379492630StartNode ,
[ 7] 0x55c379490040 EndNode ,
[ 8] 0x55c3794926c0StartNode ,
[ 9] 0x55c3795bd170 TableNode ,
[ 10] 0x55c379606280 StartNode ,
[ 11]0x55c379616ee8 TextNode "",
[ 12] 0x55c37960cd70EndNode ,
[ 13] 0x55c379612780 EndNode ,
[ 14] 0x55c3794b6628TextNode "",
[ 15] 0x55c37962d848TextNode "",
[ 16] 0x55c379616778TextNode "",
[ 17] 0x55c37948fd20 EndNode }, m_vIndices = 0x55c3794bda68,
m_rMyDoc = @0x55c379492f80, m_pEndOfPostIts = 0x55c3794859a0, m_pEndOfInserts =
0x55c37948a6c0, m_pEndOfAutotext = 0x55c37948ff10,
m_pEndOfRedlines = 0x55c379490040, m_pEndOfContent =
std::unique_ptr = {get() = 0x55c37948fd20}, m_aOutlineNodes =
{>
= {
m_vector = std::__debug::vector of length 0, capacity 0}, static npos
= 18446744073709551615}, m_bInNodesDel = false, m_bInDelUpdOutline = false}
Change-Id: I492b49dd1a554dc95abb0ed97fa99541c8dbd7f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153111
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/solenv/gdb/libreoffice/sw.py b/solenv/gdb/libreoffice/sw.py
index 206eda25fa18..2b5cc7c7278b 100644
--- a/solenv/gdb/libreoffice/sw.py
+++ b/solenv/gdb/libreoffice/sw.py
@@ -194,7 +194,7 @@ class BigPtrArrayPrinter(object):
# libstdc++ unique_ptr is a std::tuple which contains multiple
# _M_head_impl members and gdb may pick the wrong one by default
# so have to manually cast it to the one that contains the array
-self.blocks =
array['m_ppInf']['_M_t']['_M_t'].cast(gdb.lookup_type("std::_Head_base<0,
BlockInfo**, false>"))['_M_head_impl']
+self.blocks =
array['m_ppInf']['_M_t']['_M_t'].cast(gdb.lookup_type("std::_Head_base<0ul,
BlockInfo**, false>"))['_M_head_impl']
self.count = array['m_nSize']
self.pos = 0
self.block_count = array['m_nBlock']
[Libreoffice-bugs] [Bug 101257] Outdated content is pasted, when copy source is Microsoft Edge browser
https://bugs.documentfoundation.org/show_bug.cgi?id=101257 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8647 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148647] LO pastes previously copied content instead of what was last copied from other app (Windows 10; see comment 11)
https://bugs.documentfoundation.org/show_bug.cgi?id=148647 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||1257 --- Comment #16 from Stéphane Guillou (stragu) --- Likely the same issue as in earlier bug 101257. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151976] missing Standard Toolbar buttons when editing chart
https://bugs.documentfoundation.org/show_bug.cgi?id=151976 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords|bibisectNotNeeded | --- Comment #8 from Stéphane Guillou (stragu) --- (In reply to V Stuart Foote from comment #7) > The standard menu in chart2 was configured for bug 90492 Thanks for finding it, Stuart! In that report, UX eval was asked after the commit was merged for some reason. Wondering if we could get it discussed at the next design meeting? After reading the comments there, I still think the standard toolbar should have the usual defaults. There was opposition to removing Copy and Paste from the toolbar in bug 90492 comment 2. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 151976] missing Standard Toolbar buttons when editing chart
https://bugs.documentfoundation.org/show_bug.cgi?id=151976 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords|bibisectNotNeeded | --- Comment #8 from Stéphane Guillou (stragu) --- (In reply to V Stuart Foote from comment #7) > The standard menu in chart2 was configured for bug 90492 Thanks for finding it, Stuart! In that report, UX eval was asked after the commit was merged for some reason. Wondering if we could get it discussed at the next design meeting? After reading the comments there, I still think the standard toolbar should have the usual defaults. There was opposition to removing Copy and Paste from the toolbar in bug 90492 comment 2. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 155170] LibreOffice stops responding when opening the attached PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=155170 Buovjaga changed: What|Removed |Added Version|7.4.6.2 release |4.2.0.4 release -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152396] Font width (expanded, condensed, etc.) is not supported
https://bugs.documentfoundation.org/show_bug.cgi?id=152396 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||5853 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155853] Embedded variable fonts show only the default instance
https://bugs.documentfoundation.org/show_bug.cgi?id=155853 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2396 Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||stephane.guillou@libreoffic ||e.org Version|unspecified |6.3.6.2 release --- Comment #1 from Stéphane Guillou (stragu) --- On Ubuntu 20.04 without Cantarell installed, I only get the default font styles in the Character dialog: Regular, Italic, Bold, Bold Italic. Version: 7.6.0.0.beta1 (X86_64) / LibreOffice Community Build ID: be55b15d98c5f059483845a183fcb5ea8023d27c CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Also in 6.3: Version: 6.3.6.2 Build ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
ESC meeting minutes: 2023-06-15
* Present: + Regina, Stephane, Caolan, Cloph, Khaled, Heiko, Xisco, Hossein, Ilmari, Stephan, Miklos, Olivier, Michael S, Gabriel, Thorsten, Tomaz, Raphael, Eike * Completed Action Items: + update Caolan's affiliation on the TDF / ESC page (Ilmari) + give the commit bit to Taichi (Cloph) + send the welcome mail to Taichi (Miklos) * Pending Action Items: + ESC tendering: prepare the sheet with the ideas + estimates (Ilmari, Xisco) + Xisco shared the sheet for ESC consumption, hope to have it ready soon * Release Engineering update (Cloph/Xisco) + master is bumped to 24.2, complain if that breaks scripts + 7.6 status: rc 1 will be in 3 weeks / string / UI freeze + 7.5 status: 7.5.5 rc1 in 2 weeks * Documentation (Olivier) + Helpcontents2 + Updates for accessing uno commands (ohallot) + Fixes (L. Balland) + Guides + Published Math Guide 7.5 (V. Ferreira) + Published Impress Guide 7.5 (Schofield) + Bugzilla Documentation statistics 260(260) bugs open + Updates: BZ changes 1 week 1 month 3 months 12 months created 2(-1)17(-14)82(-8) 303(0) commented 7(-2)46(-21) 247(-24) 1034(4) resolved 1(0) 9(-4) 39(-4) 176(1) + top 10 contributors: Seth Chaiklin made 12 changes in 1 month, and 329 changes in 1 year Olivier Hallot made 11 changes in 1 month, and 500 changes in 1 year Stéphane Guillou made 7 changes in 1 month, and 219 changes in 1 year Heiko Tietze made 6 changes in 1 month, and 108 changes in 1 year Robert Großkopf made 5 changes in 1 month, and 14 changes in 1 year Roman Kuznetsov made 4 changes in 1 month, and 72 changes in 1 year Ilmari Lauhakangas made 4 changes in 1 month, and 107 changes in 1 year Vernon, Stuart Foote made 4 changes in 1 month, and 44 changes in 1 year Kaganski, Mike made 3 changes in 1 month, and 101 changes in 1 year Cip made 2 changes in 1 month, and 2 changes in 1 year * UX Update (Heiko) + Bugzilla (topicUI) statistics 275(275) (topicUI) bugs open, 62(62) (needsUXEval) needs to be evaluated by the UXteam + Updates: BZ changes 1 week1 month3 months 12 months added 8(4) 14(4) 32(1) 55(5) commented 33(-33) 203(-58) 834(-44) 2366(-1) removed 1(0) 4(-1) 14(0) 30(1) resolved 2(-6) 30(-15) 103(-6) 312(-8) + top 10 contributors: Heiko Tietze made 144 changes in 1 month, and 1462 changes in 1 year Stéphane Guillou made 42 changes in 1 month, and 332 changes in 1 year Dieter made 37 changes in 1 month, and 251 changes in 1 year Eyal Rozenberg made 23 changes in 1 month, and 270 changes in 1 year Vernon, Stuart Foote made 19 changes in 1 month, and 368 changes in 1 year Bogdan B made 16 changes in 1 month, and 83 changes in 1 year Telesto made 15 changes in 1 month, and 74 changes in 1 year Ilmari Lauhakangas made 14 changes in 1 month, and 207 changes in 1 year Seth Chaiklin made 13 changes in 1 month, and 76 changes in 1 year Attila Szűcs made 12 changes in 1 month, and 12 changes in 1 year + [Bug 155839] When propmpted about missing hyphenation data - I should be offered a download link + [Bug 151976] missing Standard Toolbar buttons when editing chart + [Bug 155737] EDITING a cell: can't undo back to overwritten contents + [Bug 80188] Undo after Cut/Paste does not restore original cell contents + [Bug 155834] Unnumbered entries do not move together with their main entry, when list's "move item up / down" commands are used -> + [Bug 154756] Vertical text direction results in rotation, not vertical text direction + current behavior looks OK (Khaled) + opt-in / new way would be possible + [Bug 155729] Set paragraph style drop down is able to create new styles, which is unconventional (and not fitting the label) * ESC tender project proposal process (Thorsten & Florian) + propose a separate call, for those who want to rank (Thorsten) + suggest to re-use the ESC call timeslot for this if it works for everyone (Miklos) + no objections, let's decide next week (Thorsten) + today Xisco updated the ESC-aimed sheet, on nextcloud (Ilmari) + categories: drop, on-hold, do it, split it + worked on the budget 2023 page, dropping already done items + proposal: Ilmari will update the final voting result sheet (from Feb) + keep the votes there that people added + drop "done" items + in the call next week: + discuss what to drop, what to postpone, see if there are any objections + would speed things up if people are
[Libreoffice-qa] ESC meeting minutes: 2023-06-15
* Present: + Regina, Stephane, Caolan, Cloph, Khaled, Heiko, Xisco, Hossein, Ilmari, Stephan, Miklos, Olivier, Michael S, Gabriel, Thorsten, Tomaz, Raphael, Eike * Completed Action Items: + update Caolan's affiliation on the TDF / ESC page (Ilmari) + give the commit bit to Taichi (Cloph) + send the welcome mail to Taichi (Miklos) * Pending Action Items: + ESC tendering: prepare the sheet with the ideas + estimates (Ilmari, Xisco) + Xisco shared the sheet for ESC consumption, hope to have it ready soon * Release Engineering update (Cloph/Xisco) + master is bumped to 24.2, complain if that breaks scripts + 7.6 status: rc 1 will be in 3 weeks / string / UI freeze + 7.5 status: 7.5.5 rc1 in 2 weeks * Documentation (Olivier) + Helpcontents2 + Updates for accessing uno commands (ohallot) + Fixes (L. Balland) + Guides + Published Math Guide 7.5 (V. Ferreira) + Published Impress Guide 7.5 (Schofield) + Bugzilla Documentation statistics 260(260) bugs open + Updates: BZ changes 1 week 1 month 3 months 12 months created 2(-1)17(-14)82(-8) 303(0) commented 7(-2)46(-21) 247(-24) 1034(4) resolved 1(0) 9(-4) 39(-4) 176(1) + top 10 contributors: Seth Chaiklin made 12 changes in 1 month, and 329 changes in 1 year Olivier Hallot made 11 changes in 1 month, and 500 changes in 1 year Stéphane Guillou made 7 changes in 1 month, and 219 changes in 1 year Heiko Tietze made 6 changes in 1 month, and 108 changes in 1 year Robert Großkopf made 5 changes in 1 month, and 14 changes in 1 year Roman Kuznetsov made 4 changes in 1 month, and 72 changes in 1 year Ilmari Lauhakangas made 4 changes in 1 month, and 107 changes in 1 year Vernon, Stuart Foote made 4 changes in 1 month, and 44 changes in 1 year Kaganski, Mike made 3 changes in 1 month, and 101 changes in 1 year Cip made 2 changes in 1 month, and 2 changes in 1 year * UX Update (Heiko) + Bugzilla (topicUI) statistics 275(275) (topicUI) bugs open, 62(62) (needsUXEval) needs to be evaluated by the UXteam + Updates: BZ changes 1 week1 month3 months 12 months added 8(4) 14(4) 32(1) 55(5) commented 33(-33) 203(-58) 834(-44) 2366(-1) removed 1(0) 4(-1) 14(0) 30(1) resolved 2(-6) 30(-15) 103(-6) 312(-8) + top 10 contributors: Heiko Tietze made 144 changes in 1 month, and 1462 changes in 1 year Stéphane Guillou made 42 changes in 1 month, and 332 changes in 1 year Dieter made 37 changes in 1 month, and 251 changes in 1 year Eyal Rozenberg made 23 changes in 1 month, and 270 changes in 1 year Vernon, Stuart Foote made 19 changes in 1 month, and 368 changes in 1 year Bogdan B made 16 changes in 1 month, and 83 changes in 1 year Telesto made 15 changes in 1 month, and 74 changes in 1 year Ilmari Lauhakangas made 14 changes in 1 month, and 207 changes in 1 year Seth Chaiklin made 13 changes in 1 month, and 76 changes in 1 year Attila Szűcs made 12 changes in 1 month, and 12 changes in 1 year + [Bug 155839] When propmpted about missing hyphenation data - I should be offered a download link + [Bug 151976] missing Standard Toolbar buttons when editing chart + [Bug 155737] EDITING a cell: can't undo back to overwritten contents + [Bug 80188] Undo after Cut/Paste does not restore original cell contents + [Bug 155834] Unnumbered entries do not move together with their main entry, when list's "move item up / down" commands are used -> + [Bug 154756] Vertical text direction results in rotation, not vertical text direction + current behavior looks OK (Khaled) + opt-in / new way would be possible + [Bug 155729] Set paragraph style drop down is able to create new styles, which is unconventional (and not fitting the label) * ESC tender project proposal process (Thorsten & Florian) + propose a separate call, for those who want to rank (Thorsten) + suggest to re-use the ESC call timeslot for this if it works for everyone (Miklos) + no objections, let's decide next week (Thorsten) + today Xisco updated the ESC-aimed sheet, on nextcloud (Ilmari) + categories: drop, on-hold, do it, split it + worked on the budget 2023 page, dropping already done items + proposal: Ilmari will update the final voting result sheet (from Feb) + keep the votes there that people added + drop "done" items + in the call next week: + discuss what to drop, what to postpone, see if there are any objections + would speed things up if people are
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 47e5264233adbf4c06076dae7474d7e175e684fa
Author: Khaled Hosny
AuthorDate: Thu Jun 15 14:50:00 2023 +0300
Commit: خالد حسني
CommitDate: Thu Jun 15 16:42:28 2023 +0200
Use sal_Int32 instead of overzealous use of auto
Change-Id: Ia307f398260343fe388965673da42d9404195224
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153117
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 0c5fc8401a43..e9e7e32620cc 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -2756,7 +2756,7 @@ bool PDFWriterImpl::emitType3Font(const
vcl::font::PhysicalFontFace* pFace,
}
// write font dict
-auto nFontDict = -1;
+sal_Int32 nFontDict = -1;
if (!aUsedFonts.empty())
{
nFontDict = createObject();
[Libreoffice-bugs] [Bug 155835] Incorrect display of Cyrillic characters in the text in LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=155835 --- Comment #8 from randylo...@gmail.com --- https://ibb.co/YfDsmyF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155835] Incorrect display of Cyrillic characters in the text in LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=155835 --- Comment #7 from randylo...@gmail.com --- (In reply to Mike Kaganski from comment #6) > Created attachment 187927 [details] > Minimized sample > > (In reply to randylow77 from comment #3) > > Created attachment 187916 [details] > > new file > > Repro. This is a minimized sample. > $ libreoffice --safe-mode https://ibb.co/mHpj4jC -- You are receiving this mail because: You are the assignee for the bug.
