[libvirt] [PATCH] Fix build of portallocator on mingw

2014-02-20 Thread Ján Tomko 
IN6ADDR_ANY_INIT does not seem to be working as expected on MinGW:
error: missing braces around initializer [-Werror=missing-braces]
 .sin6_addr = IN6ADDR_ANY_INIT,

Use the in6addr_any variable instead.

Reported by Daniel P. Berrange.
---
Pushed as a build breaker.

 src/util/virportallocator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virportallocator.c b/src/util/virportallocator.c
index 06174b0..22cdc37 100644
--- a/src/util/virportallocator.c
+++ b/src/util/virportallocator.c
@@ -106,7 +106,7 @@ static int virPortAllocatorBindToPort(bool *used,
 struct sockaddr_in6 addr6 = {
 .sin6_family = AF_INET6,
 .sin6_port = htons(port),
-.sin6_addr = IN6ADDR_ANY_INIT,
+.sin6_addr = in6addr_any
 };
 struct sockaddr_in addr4 = {
 .sin_family = AF_INET,
-- 
1.8.3.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Fix build of portallocator on mingw

2014-02-20 Thread Eric Blake 
On 02/20/2014 05:38 AM, Eric Blake wrote:
 [adding gnulib]
 
 On 02/20/2014 02:39 AM, Ján Tomko wrote:
 IN6ADDR_ANY_INIT does not seem to be working as expected on MinGW:
 error: missing braces around initializer [-Werror=missing-braces]
  .sin6_addr = IN6ADDR_ANY_INIT,

 Use the in6addr_any variable instead.

 Reported by Daniel P. Berrange.
 ---
 Pushed as a build breaker.
 
 For libvirt, I'm half tempted to just kill -Wmissing-braces on platforms
 whose headers don't have enough {}.  Have we filed a bug report against
 mingw's headers yet?

Done:
https://bugzilla.redhat.com/show_bug.cgi?id=1067426

 
 Also, perhaps gnulib could be taught to work around the problem.

Particularly since gnulib is already providing a netinet/in.h for
mingw since mingw currently lacks it natively.

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list