Re: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check
On Mon, 2011-01-24 at 14:13 -0800, David Brown wrote: > On Mon, Jan 24 2011, Daniel Walker wrote: > > >> What do you want me to call it? > >> > >> #define cpu_is_97d0c886-3768-4998-8925-16f36209d0d1() > > > > I want you to call it msm8x60 .. > > msm8960 is not a subset of msm8x60. It's just a misleading name. It's > a very different device, and needs it's own identifier. Can you site reason why it's different .. My impression is that it's not as different as you think it is. Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check
On Mon, Jan 24 2011, Daniel Walker wrote: >> What do you want me to call it? >> >> #define cpu_is_97d0c886-3768-4998-8925-16f36209d0d1() > > I want you to call it msm8x60 .. msm8960 is not a subset of msm8x60. It's just a misleading name. It's a very different device, and needs it's own identifier. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check
On Mon, 2011-01-24 at 13:30 -0800, David Brown wrote: > On Mon, Jan 24 2011, Daniel Walker wrote: > > > On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: > >> diff --git a/arch/arm/mach-msm/include/mach/cpu.h > >> b/arch/arm/mach-msm/include/mach/cpu.h > >> index e1ba9db..a9481b0 100644 > >> --- a/arch/arm/mach-msm/include/mach/cpu.h > >> +++ b/arch/arm/mach-msm/include/mach/cpu.h > >> @@ -24,6 +24,7 @@ > >> #define cpu_is_msm7x30() 0 > >> #define cpu_is_qsd8x50() 0 > >> #define cpu_is_msm8x60() 0 > >> +#define cpu_is_msm8960() 0 > > > > The naming is just perverted even more here.. > > What do you want me to call it? > > #define cpu_is_97d0c886-3768-4998-8925-16f36209d0d1() I want you to call it msm8x60 .. > It's the name of the chip. We've already been through this. The names > are unfortunate, but it is what the devices are called. I think you can re-org things to mask all this.. I've been suggesting is that we look into that .. Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check
On Mon, Jan 24 2011, Daniel Walker wrote: > On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: >> diff --git a/arch/arm/mach-msm/include/mach/cpu.h >> b/arch/arm/mach-msm/include/mach/cpu.h >> index e1ba9db..a9481b0 100644 >> --- a/arch/arm/mach-msm/include/mach/cpu.h >> +++ b/arch/arm/mach-msm/include/mach/cpu.h >> @@ -24,6 +24,7 @@ >> #define cpu_is_msm7x30() 0 >> #define cpu_is_qsd8x50() 0 >> #define cpu_is_msm8x60() 0 >> +#define cpu_is_msm8960() 0 > > The naming is just perverted even more here.. What do you want me to call it? #define cpu_is_97d0c886-3768-4998-8925-16f36209d0d1() It's the name of the chip. We've already been through this. The names are unfortunate, but it is what the devices are called. At some point, I may change the msm8x60 to something more specific, such as msm8260, or msm8660, one of the devices that it represents. But this isn't correct, either. There really isn't a good answer. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check
On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: > diff --git a/arch/arm/mach-msm/include/mach/cpu.h > b/arch/arm/mach-msm/include/mach/cpu.h > index e1ba9db..a9481b0 100644 > --- a/arch/arm/mach-msm/include/mach/cpu.h > +++ b/arch/arm/mach-msm/include/mach/cpu.h > @@ -24,6 +24,7 @@ > #define cpu_is_msm7x30() 0 > #define cpu_is_qsd8x50() 0 > #define cpu_is_msm8x60() 0 > +#define cpu_is_msm8960() 0 The naming is just perverted even more here.. Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
