Re: [PATCH] btrfs: change resize ioctl to take device path instead of id

2012-01-09 Thread Phillip Susi

Bump.

On 12/11/2011 10:12 PM, Phillip Susi wrote:

The resize ioctl took an optional argument that was a string
representation of the devid which you wish to resize.  For
the sake of consistency with the other ioctls that take a
device argument, I converted this to take a device path instead
of a devid number, and look up the number from the path.

--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] btrfs: change resize ioctl to take device path instead of id

2011-12-11 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 12/11/2011 10:31 PM, Li Zefan wrote:
 Phillip Susi wrote:
 The resize ioctl took an optional argument that was a string
 representation of the devid which you wish to resize.  For
 the sake of consistency with the other ioctls that take a
 device argument, I converted this to take a device path instead
 of a devid number, and look up the number from the path.

 
 but.. isn't this an ABI change?

Technically no, since the ABI is just a string that may (undocumented) have a 
colon in it followed by digits.

 so instead of changing it, I think it's ok to extend it.

I considered that at first, but the existing code appears to not handle errors 
( what happens when the string can't be converted to an integer? ) and the 
interface has not been documented until now, so I figured may as well just get 
rid of it.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7leawACgkQJ4UciIs+XuIJ3ACeKuQidLKrb/nVqaS13Z1yzzoh
MDAAoIIPhBEnAbmTWdc6M4NBQUdX1+Pv
=7JV1
-END PGP SIGNATURE-
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html