Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables
Jeff Garzik wrote:
Tejun Heo wrote:
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 07dcaf6..08301ca 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -351,6 +351,8 @@ static const struct ata_port_operations
ahci_vt8251_ops = {
.port_suspend= ahci_port_suspend,
.port_resume= ahci_port_resume,
#endif
+.enable_pm= ahci_enable_alpm,
+.disable_pm= ahci_disable_alpm,
.port_start= ahci_port_start,
.port_stop= ahci_port_stop,
@@ -385,6 +387,8 @@ static const struct ata_port_operations
ahci_p5wdh_ops = {
.port_suspend= ahci_port_suspend,
.port_resume= ahci_port_resume,
#endif
+.enable_pm= ahci_enable_alpm,
+.disable_pm= ahci_disable_alpm,
.port_start= ahci_port_start,
.port_stop= ahci_port_stop,
The last one is probably OK, but I didn't think vt8521 could do this?
I don't know. Those should be determined by CAP bits and if vt8251 lies
about it, it should be blacklisted by clearing CAP bit as other features.
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables
Alan Cox wrote:
* Every driver for SFF controllers now uses ata_pci_default_filter()
unless the driver has custom implementation.
That is only needed for DMA capable devices. I guess it does no harm to
be consistent and call it anyway but you then say ..
Yeah, it's kind of fuzzy to distinguish SFF and BMDMA functions and we
mix the names. I'll clean up the names afterwards. Things like that
are much easier after this patchset.
* No reason to set ata_pci_default_filter() for PIO-only drivers.
and your patches add the calls for the CS5520 ?
diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c
index 972ed9f..5614e76 100644
--- a/drivers/ata/pata_cs5520.c
+++ b/drivers/ata/pata_cs5520.c
@@ -160,6 +160,7 @@ static struct scsi_host_template cs5520_sht = {
static struct ata_port_operations cs5520_port_ops = {
.set_piomode= cs5520_set_piomode,
.set_dmamode= cs5520_set_dmamode,
+.mode_filter= ata_pci_default_filter,
This case is wrong. CS5520 doesn't do DMA (just VDMA which we don't
support) and in addition doesn't use BAR4 so its not a generic PCI
controller and this is asking for trouble later.
Ah.. okay. Thanks for pointing out.
diff --git a/drivers/ata/pata_opti.c b/drivers/ata/pata_opti.c
index 8f79447..ebb9dc1 100644
--- a/drivers/ata/pata_opti.c
+++ b/drivers/ata/pata_opti.c
@@ -184,6 +184,7 @@ static struct scsi_host_template opti_sht = {
static struct ata_port_operations opti_port_ops = {
.set_piomode= opti_set_piomode,
+.mode_filter= ata_pci_default_filter,
PIO only
--- a/drivers/ata/pata_rz1000.c
+++ b/drivers/ata/pata_rz1000.c
@@ -72,6 +72,7 @@ static struct scsi_host_template rz1000_sht = {
static struct ata_port_operations rz1000_port_ops = {
.set_mode = rz1000_set_mode,
+.mode_filter= ata_pci_default_filter,
PIO only
Will update accordingly. Thanks.
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables
Tejun Heo wrote:
* No reason to set ata_pci_default_filter() for PIO-only drivers.
and your patches add the calls for the CS5520 ?
diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c
index 972ed9f..5614e76 100644
--- a/drivers/ata/pata_cs5520.c
+++ b/drivers/ata/pata_cs5520.c
@@ -160,6 +160,7 @@ static struct scsi_host_template cs5520_sht = {
static struct ata_port_operations cs5520_port_ops = {
.set_piomode= cs5520_set_piomode,
.set_dmamode= cs5520_set_dmamode,
+ .mode_filter= ata_pci_default_filter,
This case is wrong. CS5520 doesn't do DMA (just VDMA which we don't
support) and in addition doesn't use BAR4 so its not a generic PCI
controller and this is asking for trouble later.
Hmm... cs5520's vdma looks like BMDMA and behaves like one. BMDMA
methods are used and, although it doesn't use BAR4, ioaddr-bmdma_addr
is initialized, so as long as libata SFF layer is concerned, it can be
considered a BMDMA controller.
Thanks.
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables
* Every driver for SFF controllers now uses ata_pci_default_filter()
unless the driver has custom implementation.
That is only needed for DMA capable devices. I guess it does no harm to
be consistent and call it anyway but you then say ..
* No reason to set ata_pci_default_filter() for PIO-only drivers.
and your patches add the calls for the CS5520 ?
diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c
index 972ed9f..5614e76 100644
--- a/drivers/ata/pata_cs5520.c
+++ b/drivers/ata/pata_cs5520.c
@@ -160,6 +160,7 @@ static struct scsi_host_template cs5520_sht = {
static struct ata_port_operations cs5520_port_ops = {
.set_piomode= cs5520_set_piomode,
.set_dmamode= cs5520_set_dmamode,
+ .mode_filter= ata_pci_default_filter,
This case is wrong. CS5520 doesn't do DMA (just VDMA which we don't
support) and in addition doesn't use BAR4 so its not a generic PCI
controller and this is asking for trouble later.
diff --git a/drivers/ata/pata_opti.c b/drivers/ata/pata_opti.c
index 8f79447..ebb9dc1 100644
--- a/drivers/ata/pata_opti.c
+++ b/drivers/ata/pata_opti.c
@@ -184,6 +184,7 @@ static struct scsi_host_template opti_sht = {
static struct ata_port_operations opti_port_ops = {
.set_piomode= opti_set_piomode,
+ .mode_filter= ata_pci_default_filter,
PIO only
--- a/drivers/ata/pata_rz1000.c
+++ b/drivers/ata/pata_rz1000.c
@@ -72,6 +72,7 @@ static struct scsi_host_template rz1000_sht = {
static struct ata_port_operations rz1000_port_ops = {
.set_mode = rz1000_set_mode,
+ .mode_filter= ata_pci_default_filter,
PIO only
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables
Tejun Heo wrote:
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 07dcaf6..08301ca 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -351,6 +351,8 @@ static const struct ata_port_operations ahci_vt8251_ops = {
.port_suspend = ahci_port_suspend,
.port_resume= ahci_port_resume,
#endif
+ .enable_pm = ahci_enable_alpm,
+ .disable_pm = ahci_disable_alpm,
.port_start = ahci_port_start,
.port_stop = ahci_port_stop,
@@ -385,6 +387,8 @@ static const struct ata_port_operations ahci_p5wdh_ops = {
.port_suspend = ahci_port_suspend,
.port_resume= ahci_port_resume,
#endif
+ .enable_pm = ahci_enable_alpm,
+ .disable_pm = ahci_disable_alpm,
.port_start = ahci_port_start,
.port_stop = ahci_port_stop,
The last one is probably OK, but I didn't think vt8521 could do this?
ACK everything else
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
