Re: [PATCH 1/2] MAINTAINERS: Move Kukjin Kim to credits
> 10/16/20 PM 3:19, Krzysztof Kozlowski wrote: Hi Krzysztof, Thanks for your maintaining :) I’m fine on this change. > Kukjin Kim has been maintaining the Samsung ARM architectures since 2010 > up to 2016. He contributed many patches for the S3C, S5P and Exynos > support. However since 2016 there is little activity from him on the > LKML [1] so move his name to the CREDITS. > > Dear Kukjin, thank you for all the effort you put in to the upstream > Samsung support. > > [1] https://lore.kernel.org/lkml/?q=f%3A%22Kukjin+Kim%22 > > Cc: Kukjin Kim Acked-by: Kukjin Kim > Cc: Arnd Bergmann > Cc: Olof Johansson > Signed-off-by: Krzysztof Kozlowski > --- > CREDITS | 4 > MAINTAINERS | 2 -- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/CREDITS b/CREDITS > index cb02b9923a52..5df027e12ff7 100644 > --- a/CREDITS > +++ b/CREDITS > @@ -1910,6 +1910,10 @@ S: 660 Harvard Ave. #7 > S: Santa Clara, CA 95051 > S: USA > > +N: Kukjin Kim > +E: kg...@kernel.org > +D: Samsung S3C, S5P and Exynos ARM architectures > + > N: Russell King > E: r...@arm.linux.org.uk > D: Linux/arm integrator, maintainer & hacker > diff --git a/MAINTAINERS b/MAINTAINERS > index 4538378de6f5..c3976803057c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2375,7 +2375,6 @@ F:sound/soc/rockchip/ > N:rockchip > > ARM/SAMSUNG EXYNOS ARM ARCHITECTURES > -M:Kukjin Kim > M:Krzysztof Kozlowski > L:linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) > L:linux-samsung-...@vger.kernel.org > @@ -15497,7 +15496,6 @@ F:include/linux/clk/samsung.h > F:include/linux/platform_data/clk-s3c2410.h > > SAMSUNG SPI DRIVERS > -M:Kukjin Kim > M:Krzysztof Kozlowski > M:Andi Shyti > L:linux-...@vger.kernel.org > -- > 2.25.1 >
Re: [PATCH 0/4] Drop drivers for Exynos4415
Hi Krzk, 2017. 1. 14. PM 8:36 Krzysztof Kozlowski wrote: > Hi, > > Support for Exynos4415 is being removed because: > 1. There are no upstream users, > 2. There are no known downstream users, > 3. Except compile testing, you cannot build working kernel > for Exynos4415 anymore. > > Patches are rebased on current next and are independent. > Please pick up as you wish. > > Best regards, > Krzysztof Agreed, Acked-by: Kukjin Kim k-gene > > Krzysztof Kozlowski (4): > ARM: EXYNOS: Remove Exynos4415 driver (SoC not supported anymore) > clk: samsung: Remove Exynos4415 driver (SoC not supported anymore) > pinctrl: samsung: Remove support for Exynos4415 (SoC not supported >anymore) > drm: exynos: Remove support for Exynos4415 (SoC not supported anymore) > > .../devicetree/bindings/clock/exynos4415-clock.txt | 38 - > .../bindings/display/exynos/exynos_dsim.txt|1 - > .../bindings/display/exynos/samsung-fimd.txt |1 - > arch/arm/mach-exynos/Kconfig |5 - > arch/arm/mach-exynos/exynos.c |1 - > arch/arm/mach-exynos/suspend.c |1 - > drivers/clk/samsung/Makefile |1 - > drivers/clk/samsung/clk-exynos4415.c | 1022 > drivers/gpu/drm/exynos/exynos_drm_dsi.c| 15 +- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 18 +- > drivers/pinctrl/samsung/pinctrl-exynos.c | 75 -- > drivers/pinctrl/samsung/pinctrl-samsung.c |2 - > drivers/pinctrl/samsung/pinctrl-samsung.h |1 - > include/dt-bindings/clock/exynos4415.h | 360 --- > 14 files changed, 3 insertions(+), 1538 deletions(-) > delete mode 100644 > Documentation/devicetree/bindings/clock/exynos4415-clock.txt > delete mode 100644 drivers/clk/samsung/clk-exynos4415.c > delete mode 100644 include/dt-bindings/clock/exynos4415.h > > -- > 2.9.3 >
Re: [PATCH] MAINTAINERS: Add Patchwork URL to Samsung Exynos entry
2016. 12. 8. 02:18 Krzysztof Kozlowski wrote: > I use Patchwork for handling incoming patches. Put its address here so > submitters could know what is in the queue. > Signed-off-by: Krzysztof Kozlowski > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 191887bdc49b..ec5137c39572 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1689,6 +1689,7 @@ M:Krzysztof Kozlowski > R:Javier Martinez Canillas > L:linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) > L:linux-samsung-...@vger.kernel.org (moderated for non-subscribers) > +Q:https://patchwork.kernel.org/project/linux-samsung-soc/list/ to use http would be better instead of https? then, Acked-by: Kukjin Kim > S:Maintained > F:arch/arm/boot/dts/s3c* > F:arch/arm/boot/dts/s5p* > -- > 2.7.4 >
Re: [PATCH v2] ARM: Drop fixed 200 Hz timer requirement from Samsung platforms
2016. 11. 18. 16:16 Krzysztof Kozlowski wrote:
> All Samsung platforms, including the Exynos, are selecting HZ_FIXED with
> 200 Hz. Unfortunately in case of multiplatform image this affects also
> other platforms when Exynos is enabled.
>
> This looks like an very old legacy code, dating back to initial
> upstreaming of S3C24xx. Probably it was required for s3c24xx timer
> driver, which was removed in commit ad38bdd15d5b ("ARM: SAMSUNG: Remove
> unused plat-samsung/time.c").
>
> Since then, this fixed 200 Hz spread everywhere, including out-of-tree
> Samsung kernels (SoC vendor's and Tizen's). I believe this choice
> was rather an effect of coincidence instead of conscious choice.
>
> Exynos uses its own MCT or arch timer and can work with all HZ values.
> Older platforms use newer Samsung PWM timer driver which should handle
> down to 100 Hz.
>
> Few perf mem and sched tests on Odroid XU3 board (Exynos5422, 4x Cortex
> A7, 4x Cortex A15) show no regressions when switching from 200 Hz to
> other values.
>
> Reported-by: Lee Jones
> [Dropping 200_HZ from S3C/S5P suggested by Arnd]
> Reported-by: Arnd Bergmann
> Signed-off-by: Krzysztof Kozlowski
> Cc: Kukjin Kim
Acked-by: Kukjin Kim
> Tested-by: Javier Martinez Canillas
>
> ---
>
> Tested on Exynos5422 and Exynos5800 (by Javier). It would be
> appreciated if anyone could test it on S3C24xx or S5PV210.
>
> Changes since v1:
> 1. Add Javier's tested-by.
> 2. Drop HZ_FIXED also from ARCH_S5PV210 and ARCH_S3C24XX after Arnd
> suggestions and analysis.
> ---
> arch/arm/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index b5d529fdffab..ced2e08a9d08 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1496,8 +1496,7 @@ source kernel/Kconfig.preempt
>
> config HZ_FIXED
>int
> -default 200 if ARCH_EBSA110 || ARCH_S3C24XX || \
> -ARCH_S5PV210 || ARCH_EXYNOS4
> +default 200 if ARCH_EBSA110
>default 128 if SOC_AT91RM9200
>default 0
>
> --
> 2.7.4
>
RE: [GIT PULL 1/3] ARM: soc: exynos: Drivers for v4.9
Kukjin Kim wrote:
- Krzysztof's samsung email because he is not using now
>
> 2016. 10. 3. 21:19 Kukjin Kim wrote:
>
> + my samsung email
>
> > 2016. 10. 3. 15:48 Krzysztof Kozlowski wrote:
> >
> >>>> On Sun, Oct 02, 2016 at 05:25:07PM -0700, Olof Johansson wrote:
> >>>>> On Mon, Sep 19, 2016 at 8:53 AM, Krzysztof Kozlowski
> >>>>> wrote:
> >>>>>> On Mon, Sep 19, 2016 at 05:02:40PM +0200, Arnd Bergmann wrote:
> >>>>>> On Sunday, September 18, 2016 6:39:46 PM CEST Krzysztof Kozlowski
> >>>>>> wrote:
> >>>>>> Samsung drivers/soc update for v4.9:
> >>>>>> 1. Allow compile testing of exynos-mct clocksource driver on ARM64.
> >>>>>> 2. Document Exynos5433 PMU compatible (already used by clkout
> >>>>>> driver and more will be coming soon).
> >>>>>
> >>>>> Pulled into next/drivers, thanks
> >>>>>
> >>>>> Just for my understanding: why do we need the exynos-mct driver on
> >>>>> ARM64 but not the delay-timer portion of it?
> >>>>
> >>>> I think we want all of it but Doug's optimization 3252a646aa2c
> >>>> ("clocksource: exynos_mct: Only use 32-bits where possible") is not
> >>>> ARM64 friendly. One way of dealing with it would be to prepare two
> >>>> versions of exynos4_read_current_timer(). One reading only lower
> >>>> 32-bit value for ARMv7 and second (slow) reading lower and upper for
> >>>> ARMv8.
> >>>>
> >>>>>
> >>>>> Is there an advantage in using MCT over the architected timer on
> >>>>> these chips? If so, should we also have a way to use it as the delay
> >>>>> timer?
> >>>>
> >>>> No, there is no real advantage... except that the SoC has some
> >>>> interesting "characteristics"... The timers are tightly coupled.
> >>>> Very tightly. I spent a lot of time and failed to boot my ARMv8
> >>>> board without some MCT magic.
> >>>
> >>> What kind of magic is that?
> >>
> >> Most notably: the arch timer starts when MCT forward running counter
> >> starts. Without kicking MCT, the arch timer seems to be frozen.
> >>
> >>> I can understand that needing the MCT for some system-level timer
> >>> functionality might be true (wakeups, etc),
Yes correct, the MCT is designed for the power consumption related
functionalities such as cluster power down
> >>> but for system
> >>> timesource avoiding the MMIO timer and using the arch ones is a
> >>> substantial performance improvement for gettimeofday() and friends.
> >>>
At this moment, we can use the ARM arch timers as clocksource so I think
no performance degradation (some latency?) with using the CP15 access for
the gettimeofday() and friends
> >>> There was extensive discussion last year over using arch timers on
> >>> 5420/5422, and it fizzled out with vague comments about something
> >>> not working right between A15/A7 on b.L. hardware.
Current Exynos SoCs including ARMv8 architecture based have no hardware
something which means 'not working right'
> >>> I'm presuming
> >>> whatever implementation details of that SoC has since been fixed on
> >>> later chips (including v8). Any chance you can confirm? It'd be very
> >>> nice to leave MCT behind on v8 as a system time source.
It is depending on system level design architecture. If we don't need to
support some power mode such as cluster power down, we can use arch timers
without the MCT but actual product needed to support it for power consumption.
Let me add some comments.
According to the ARM architecture design, the ARM arch timers require toggle
from outside of the core as timer source and we're using the MCT for it. And
we can use the ARM arch timers as clocksource not the MCT on current Exynos.
> >> Unfortunately, I cannot confirm this, at least on Exynos5433 (ARMv8).
> >> I played with arch and MCT timers on it and failed to get the
> >> arch-timer-only setup working. I did not have access to newer Exynos
> >> designs (Exynos 7) so I do not know how it works there.
> >
> > Hi guys,
> >
> > I know what Olof want to know and actually several days ago someone asked
> > me about that. As you guys
> talked, a couple of years ago there were some discussions...BTW I need to
> contact to hardware designer
> before let you guys know because something needs to be confirmed by them even
> I know roughly.
> >
> > Note I'm in vacation with my family. Will be back on this in several days
> > with exact information.
> >
> > BRs,
> > Kukjin
k-gene
Re: [GIT PULL 1/3] ARM: soc: exynos: Drivers for v4.9
2016. 10. 3. 21:19 Kukjin Kim wrote:
+ my samsung email
> 2016. 10. 3. 15:48 Krzysztof Kozlowski wrote:
>
>>>> On Sun, Oct 02, 2016 at 05:25:07PM -0700, Olof Johansson wrote:
>>>>> On Mon, Sep 19, 2016 at 8:53 AM, Krzysztof Kozlowski
>>>>> wrote:
>>>>>> On Mon, Sep 19, 2016 at 05:02:40PM +0200, Arnd Bergmann wrote:
>>>>>> On Sunday, September 18, 2016 6:39:46 PM CEST Krzysztof Kozlowski wrote:
>>>>>> Samsung drivers/soc update for v4.9:
>>>>>> 1. Allow compile testing of exynos-mct clocksource driver on ARM64.
>>>>>> 2. Document Exynos5433 PMU compatible (already used by clkout driver and
>>>>>> more
>>>>>> will be coming soon).
>>>>>
>>>>> Pulled into next/drivers, thanks
>>>>>
>>>>> Just for my understanding: why do we need the exynos-mct driver on ARM64
>>>>> but not the delay-timer portion of it?
>>>>
>>>> I think we want all of it but Doug's optimization 3252a646aa2c
>>>> ("clocksource: exynos_mct: Only use 32-bits where possible") is not
>>>> ARM64 friendly. One way of dealing with it would be to prepare two
>>>> versions of exynos4_read_current_timer(). One reading only lower 32-bit
>>>> value for ARMv7 and second (slow) reading lower and upper for ARMv8.
>>>>
>>>>>
>>>>> Is there an advantage in using MCT over the architected timer on these
>>>>> chips? If so, should we also have a way to use it as the delay timer?
>>>>
>>>> No, there is no real advantage... except that the SoC has some
>>>> interesting "characteristics"... The timers are tightly coupled. Very
>>>> tightly. I spent a lot of time and failed to boot my ARMv8 board without
>>>> some MCT magic.
>>>
>>> What kind of magic is that?
>>
>> Most notably: the arch timer starts when MCT forward running counter
>> starts. Without kicking MCT, the arch timer seems to be frozen.
>>
>>> I can understand that needing the MCT for
>>> some system-level timer functionality might be true (wakeups, etc),
>>> but for system timesource avoiding the MMIO timer and using the arch
>>> ones is a substantial performance improvement for gettimeofday() and
>>> friends.
>>>
>>> There was extensive discussion last year over using arch timers on
>>> 5420/5422, and it fizzled out with vague comments about something not
>>> working right between A15/A7 on b.L. hardware. I'm presuming whatever
>>> implementation details of that SoC has since been fixed on later chips
>>> (including v8). Any chance you can confirm? It'd be very nice to leave
>>> MCT behind on v8 as a system time source.
>>
>> Unfortunately, I cannot confirm this, at least on Exynos5433 (ARMv8). I
>> played with arch and MCT timers on it and failed to get the
>> arch-timer-only setup working. I did not have access to newer Exynos
>> designs (Exynos 7) so I do not know how it works there.
>
> Hi guys,
>
> I know what Olof want to know and actually several days ago someone asked me
> about that. As you guys talked, a couple of years ago there were some
> discussions...BTW I need to contact to hardware designer before let you guys
> know because something needs to be confirmed by them even I know roughly.
>
> Note I'm in vacation with my family. Will be back on this in several days
> with exact information.
>
> BRs,
> Kukjin
Re: [GIT PULL 1/3] ARM: soc: exynos: Drivers for v4.9
2016. 10. 3. 15:48 Krzysztof Kozlowski wrote:
>> On Sun, Oct 02, 2016 at 05:25:07PM -0700, Olof Johansson wrote:
>>> On Mon, Sep 19, 2016 at 8:53 AM, Krzysztof Kozlowski
>>> wrote:
On Mon, Sep 19, 2016 at 05:02:40PM +0200, Arnd Bergmann wrote:
> On Sunday, September 18, 2016 6:39:46 PM CEST Krzysztof Kozlowski wrote:
> Samsung drivers/soc update for v4.9:
> 1. Allow compile testing of exynos-mct clocksource driver on ARM64.
> 2. Document Exynos5433 PMU compatible (already used by clkout driver and
> more
> will be coming soon).
Pulled into next/drivers, thanks
Just for my understanding: why do we need the exynos-mct driver on ARM64
but not the delay-timer portion of it?
>>>
>>> I think we want all of it but Doug's optimization 3252a646aa2c
>>> ("clocksource: exynos_mct: Only use 32-bits where possible") is not
>>> ARM64 friendly. One way of dealing with it would be to prepare two
>>> versions of exynos4_read_current_timer(). One reading only lower 32-bit
>>> value for ARMv7 and second (slow) reading lower and upper for ARMv8.
>>>
Is there an advantage in using MCT over the architected timer on these
chips? If so, should we also have a way to use it as the delay timer?
>>>
>>> No, there is no real advantage... except that the SoC has some
>>> interesting "characteristics"... The timers are tightly coupled. Very
>>> tightly. I spent a lot of time and failed to boot my ARMv8 board without
>>> some MCT magic.
>>
>> What kind of magic is that?
>
> Most notably: the arch timer starts when MCT forward running counter
> starts. Without kicking MCT, the arch timer seems to be frozen.
>
>> I can understand that needing the MCT for
>> some system-level timer functionality might be true (wakeups, etc),
>> but for system timesource avoiding the MMIO timer and using the arch
>> ones is a substantial performance improvement for gettimeofday() and
>> friends.
>>
>> There was extensive discussion last year over using arch timers on
>> 5420/5422, and it fizzled out with vague comments about something not
>> working right between A15/A7 on b.L. hardware. I'm presuming whatever
>> implementation details of that SoC has since been fixed on later chips
>> (including v8). Any chance you can confirm? It'd be very nice to leave
>> MCT behind on v8 as a system time source.
>
> Unfortunately, I cannot confirm this, at least on Exynos5433 (ARMv8). I
> played with arch and MCT timers on it and failed to get the
> arch-timer-only setup working. I did not have access to newer Exynos
> designs (Exynos 7) so I do not know how it works there.
Hi guys,
I know what Olof want to know and actually several days ago someone asked me
about that. As you guys talked, a couple of years ago there were some
discussions...BTW I need to contact to hardware designer before let you guys
know because something needs to be confirmed by them even I know roughly.
Note I'm in vacation with my family. Will be back on this in several days with
exact information.
BRs,
Kukjin
Re: [PATCH] MAINTAINERS: Add myself as reviewer for Samsung Exynos support
Javier Martinez Canillas wrote: > I've been helping reviewing and testing Exynos SoC support patches > for the last couple of years. But it would be easier for me if I'm > cc'ed for patches, so I'm adding myself as reviewer for this entry. Hi Javier, Thanks for your review and support :) Acked-by: Kukjin Kim BRs, k-gene > Signed-off-by: Javier Martinez Canillas > > --- > > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d8e81b1dde30..27ffdb2a98e0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1635,6 +1635,7 @@ N: rockchip > ARM/SAMSUNG EXYNOS ARM ARCHITECTURES > M:Kukjin Kim > M:Krzysztof Kozlowski > +R:Javier Martinez Canillas > L:linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) > L:linux-samsung-...@vger.kernel.org (moderated for non-subscribers) > S:Maintained > -- > 2.5.5
Re: [PATCH v3] MAINTAINERS: Switch to kernel.org account for Krzysztof Kozlowski
Krzysztof Kozlowski wrote: > Change my email address to kernel.org account instead of Samsung one. > > Add Bartlomiej Zolnierkiewicz as a co-maintainer of Maxim and Samsung > PMIC drivers. These are used on many of our boards along with Exynos > SoCs and Samsung R&D Institute Poland can still take care of them. > > Signed-off-by: Krzysztof Kozlowski > Cc: Kukjin Kim Acked-by: Kukjin Kim > Cc: linux-samsung-...@vger.kernel.org > Cc: Bartlomiej Zolnierkiewicz > > --- > > Third revision for simple maintainers update. Nice! :) > > Changes since v2: > 1. Add Bartlomiej, leave MUIC charger drivers as "Supported". > > Changes since v1: > 1. Update also mailmap after Joe Perches suggestion. > > Affected drivers/subsystems: > 1. arch/arm, > 2. mfd, > 3. power, > 4. regulator, > 5. clk, > 6. rtc, > 7. extcon, > 8. pinctrl, > 9. sound/soc, > > However if there are no objections, I can push it through my tree (to > arm-soc folks). > --- > .mailmap| 1 + > MAINTAINERS | 15 +-- > 2 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/.mailmap b/.mailmap > index 2a91c14c80bf..b18912c5121e 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -88,6 +88,7 @@ Kay Sievers > Kenneth W Chen > Konstantin Khlebnikov > Koushik > +Krzysztof Kozlowski > Krzysztof Kozlowski > Kuninori Morimoto > Leonid I Ananiev > diff --git a/MAINTAINERS b/MAINTAINERS > index 45c98485c3f0..f77df673d097 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1623,7 +1623,7 @@ N:rockchip > > ARM/SAMSUNG EXYNOS ARM ARCHITECTURES > M:Kukjin Kim > -M:Krzysztof Kozlowski > +M:Krzysztof Kozlowski > L:linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) > L:linux-samsung-...@vger.kernel.org (moderated for non-subscribers) > S:Maintained > @@ -7465,7 +7465,8 @@ F: > Documentation/devicetree/bindings/sound/max9860.txt > F:sound/soc/codecs/max9860.* > > MAXIM MUIC CHARGER DRIVERS FOR EXYNOS BASED BOARDS > -M:Krzysztof Kozlowski > +M:Krzysztof Kozlowski > +M:Bartlomiej Zolnierkiewicz > L:linux...@vger.kernel.org > S:Supported > F:drivers/power/supply/max14577_charger.c > @@ -7481,7 +7482,8 @@ F:include/dt-bindings/*/*max77802.h > > MAXIM PMIC AND MUIC DRIVERS FOR EXYNOS BASED BOARDS > M:Chanwoo Choi > -M:Krzysztof Kozlowski > +M:Krzysztof Kozlowski > +M:Bartlomiej Zolnierkiewicz > L:linux-kernel@vger.kernel.org > S:Supported > F:drivers/*/max14577*.c > @@ -9258,7 +9260,7 @@ F:drivers/pinctrl/sh-pfc/ > > PIN CONTROLLER - SAMSUNG > M:Tomasz Figa > -M:Krzysztof Kozlowski > +M:Krzysztof Kozlowski > M:Sylwester Nawrocki > L:linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) > L:linux-samsung-...@vger.kernel.org (moderated for non-subscribers) > @@ -10189,7 +10191,7 @@ S:Maintained > F:drivers/platform/x86/samsung-laptop.c > > SAMSUNG AUDIO (ASoC) DRIVERS > -M:Krzysztof Kozlowski > +M:Krzysztof Kozlowski > M:Sangbeom Kim > M:Sylwester Nawrocki > L:alsa-de...@alsa-project.org (moderated for non-subscribers) > @@ -10204,7 +10206,8 @@ F:drivers/video/fbdev/s3c-fb.c > > SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS > M:Sangbeom Kim > -M:Krzysztof Kozlowski > +M:Krzysztof Kozlowski > +M:Bartlomiej Zolnierkiewicz > L:linux-kernel@vger.kernel.org > L:linux-samsung-...@vger.kernel.org > S:Supported > -- > 2.7.4 >
Re: [PATCH] ARM: exynos_defconfig: Enable PM_DEBUG
On 07/19/16 23:49, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 07/19/2016 07:09 AM, Krzysztof Kozlowski wrote: >> PM_DEBUG and PM_ADVANCED_DEBUG bring some information useful for >> development and they should not cause any significant overhead. Enable >> them in default configuration so debugging would be slightly easier. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > I agree that it's good to have these enabled to make debugging easier. > I'm back ;-) I agreed...so, Acked-by: Kukjin Kim BTW, I have not seen the kernel log with PM_ADVANCED_DEBUG. Can anyone show me the log?...to be honest I need to setup the dev. environment on my desk at this moment... Thanks, Kukjin > Reviewed-by: Javier Martinez Canillas > > Best regards,
Re: [GIT PULL] ARM: Exynos fixes for v4.4
Krzysztof Kozlowski wrote: > Hi Krzysztof, Looks good to me, but I have no other fixes in my tree so this would be sent to out arm-soc directly :-) Hi Arnd, Olof, Kevin, Please pull this for v4.4. Thanks, Kukjin > Hi Kukjin, > > Two fixes for v4.4 cycle. Rafael wanted the cpufreq fix to go through arm-soc > tree. > > Please note that location of repository has changed to kernel.org. > > > Best regards, > Krzysztof > > > The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: > > Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) > > are available in the git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git > tags/samsung-fixes-4.4 > > for you to fetch changes up to 62f49ee26f14753bd7fa634f51d537a79061bf0f: > > cpufreq: s3c24xx: Do not mark s3c2410_plls_add as __init (2015-11-27 > 10:10:32 +0900) > > > Fixes for Exynos: > 1. Fix potential NULL pointer dereference in Exynos PMU driver. > 2. Remove incorrect __init annotation from s3c24xx cpufreq driver >structures. > > > Arnd Bergmann (1): > cpufreq: s3c24xx: Do not mark s3c2410_plls_add as __init > > Pankaj Dubey (1): > ARM: EXYNOS: Fix potential NULL pointer access in > exynos_sys_powerdown_conf > > arch/arm/mach-exynos/pmu.c | 6 +- > arch/arm/mach-s3c24xx/pll-s3c2440-1200.c | 2 +- > arch/arm/mach-s3c24xx/pll-s3c2440-16934400.c | 2 > +- > drivers/cpufreq/s3c24xx-cpufreq.c| 2 +- > 4 files changed, 8 insertions(+), 4 deletions(-) > --
Re: [PATCH v5 0/8] Add support for Exynos SROM Controller driver
On 10/26/15 15:45, Pavel Fedin wrote: > Hello! > Hi, >> Applied, this whole series. > > Where can i find the recent code to base my series on? I looked at > linux-samsung.git but was unable to find it there. > You may need to fetch again? Anyway the branch is v4.4-next/driver-samsung or tags/samsung-driver... Or just for-next should be fine I think. See below: https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/log/?h=v4.4-next/driver-samsung Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 2/3] dt-bindings: Consolidate Exynos SoC bindings
On 10/23/15 10:39, Krzysztof Kozlowski wrote:
> Exynos SoC Device Tree bindings are spread over arm/exynos/ and
> arm/samsung/ directories. There is no need for that separation and it
> actually confuses. Put power domain bindings under power/ and
> remaining samsung-boards.txt under arm/samsung/.
>
> Signed-off-by: Krzysztof Kozlowski
> Cc: Kukjin Kim
> Reviewed-by: Javier Martinez Canillas
>
> ---
>
> Changes since v2:
> 1. Update path pointing to pd-samsung.txt in samsung,sysmmu.txt.
>
> Changes since v1:
> 1. Move power_domain.txt to power/pd-samsung.txt.
> 2. The smp-sysram.txt is moved in previous patch to sram/ directory
>(Suggested by Rob Herring).
> 3. Added Javier's reviewed-by. Although there are some differences since
>v1 but this is merely re-organization. Please let me know if the
>review tag is no longer valid.
> ---
> Documentation/devicetree/bindings/arm/{ => samsung}/samsung-boards.txt | 0
> Documentation/devicetree/bindings/iommu/samsung,sysmmu.txt | 2
> +-
> .../bindings/{arm/exynos/power_domain.txt => power/pd-samsung.txt} | 0
> 3 files changed, 1 insertion(+), 1 deletion(-)
> rename Documentation/devicetree/bindings/arm/{ =>
> samsung}/samsung-boards.txt (100%)
> rename Documentation/devicetree/bindings/{arm/exynos/power_domain.txt =>
> power/pd-samsung.txt} (100%)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung-boards.txt
> b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> similarity index 100%
> rename from Documentation/devicetree/bindings/arm/samsung-boards.txt
> rename to Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> diff --git a/Documentation/devicetree/bindings/iommu/samsung,sysmmu.txt
> b/Documentation/devicetree/bindings/iommu/samsung,sysmmu.txt
> index 729543c47046..bc620fe32a70 100644
> --- a/Documentation/devicetree/bindings/iommu/samsung,sysmmu.txt
> +++ b/Documentation/devicetree/bindings/iommu/samsung,sysmmu.txt
> @@ -47,7 +47,7 @@ Required properties:
> - clocks: Required if the System MMU is needed to gate its clock.
> - power-domains: Required if the System MMU is needed to gate its power.
> Please refer to the following document:
> - Documentation/devicetree/bindings/arm/exynos/power_domain.txt
> + Documentation/devicetree/bindings/power/pd-samsung.txt
>
> Examples:
> gsc_0: gsc@13e0 {
> diff --git a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt
> b/Documentation/devicetree/bindings/power/pd-samsung.txt
> similarity index 100%
> rename from Documentation/devicetree/bindings/arm/exynos/power_domain.txt
> rename to Documentation/devicetree/bindings/power/pd-samsung.txt
Applied 2/3 and 3/3.
Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 1/3] dt-bindings: Consolidate SRAM bindings from all vendors
On 10/24/15 04:47, Kukjin Kim wrote: > On 10/23/15 10:39, Krzysztof Kozlowski wrote: >> SRAM bindings for various SoCs, using the mmio-sram genalloc >> API, are spread over different places - per SoC vendor. Since all of >> these are quite similar (they depend on mmio-sram) move them to a common >> place. >> >> Signed-off-by: Krzysztof Kozlowski >> Cc: Heiko Stuebner >> Cc: Maxime Ripard >> Cc: Chen-Yu Tsai >> Cc: Kukjin Kim Acked-by: Kukjin Kim >> Suggested-by: Rob Herring >> > Applied with Heiko and Maxime's ack. > + Sudeep Oops, I can't because of ..bindings/arm/arm,scpi.txt, this series should be handled with "DT binding for ARM System Control and Power Interface(SCPI) protocol" - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 1/3] dt-bindings: Consolidate SRAM bindings from all vendors
On 10/23/15 10:39, Krzysztof Kozlowski wrote: > SRAM bindings for various SoCs, using the mmio-sram genalloc > API, are spread over different places - per SoC vendor. Since all of > these are quite similar (they depend on mmio-sram) move them to a common > place. > > Signed-off-by: Krzysztof Kozlowski > Cc: Heiko Stuebner > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Kukjin Kim > Suggested-by: Rob Herring > Applied with Heiko and Maxime's ack. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] MAINTAINERS: ARM: EXYNOS: Add documentation and dt-bindings
On 10/22/15 10:28, Krzysztof Kozlowski wrote: > Extend the Samsung Exynos maintainer entry to match SoC documentation > and SoC dt-bindings directories. Without that some files, like > bindings/arm/samsung/pmu.txt, are not matched by existing patterns. > > This also may serve as a hint where new documentation and bindings (not > matching specific subsystem) should be put. > > Signed-off-by: Krzysztof Kozlowski > Cc: Kukjin Kim > Reviewed-by: Javier Martinez Canillas > > --- > > Changes since v1: > 1. Added Javier's reviewed-by > 2. Cover also power domain and sram bindings located now in separate >directory. > --- > MAINTAINERS | 4 > 1 file changed, 4 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b556aad90930..6339926c77d6 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1459,6 +1459,10 @@ F: drivers/*/*s3c2410* > F: drivers/*/*/*s3c2410* > F: drivers/spi/spi-s3c* > F: sound/soc/samsung/* > +F: Documentation/arm/Samsung/ > +F: Documentation/devicetree/bindings/arm/samsung/ > +F: Documentation/devicetree/bindings/sram/samsung-sram.txt > +F: Documentation/devicetree/bindings/power/pd-samsung.txt > N: exynos > > ARM/SAMSUNG MOBILE MACHINE SUPPORT Applied, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Documentation: ARM: EXYNOS: Update bootloader interface on Exynos542x
On 10/23/15 13:19, Krzysztof Kozlowski wrote: > Update the documentation about: > 1. Usage of PMU_SPARE2 register. >Bootloaders on Exynos542x-based boards often use the register >PMU_SPARE2 (0x908) in the same way as on Exynos3250: as a indicator >the secondary CPU was booted on. The bootloader will set this value >to non-zero, after sucessfull power up of secondary CPU. In the same >time this booted CPU will stuck (spin) waiting for software reset. > 2. Exynos542x entry address for secondary CPU boot up after system >suspend (with MCPM enabled and in non-secure mode). > > See arch/arm/mach-exynos/mcpm-exynos.c for source code. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/arm/Samsung/Bootloader-interface.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/arm/Samsung/Bootloader-interface.txt > b/Documentation/arm/Samsung/Bootloader-interface.txt > index df8d4fb85939..ed494ac0beb2 100644 > --- a/Documentation/arm/Samsung/Bootloader-interface.txt > +++ b/Documentation/arm/Samsung/Bootloader-interface.txt > @@ -19,7 +19,7 @@ executing kernel. > Address: sysram_ns_base_addr > OffsetValuePurpose > = > -0x08 exynos_cpu_resume_ns System suspend > +0x08 exynos_cpu_resume_ns, mcpm_entry_point System suspend > 0x0c 0x0bad (Magic cookie)System suspend > 0x1c exynos4_secondary_startupSecondary CPU boot > 0x1c + 4*cpu exynos4_secondary_startup (Exynos4412) Secondary CPU boot > @@ -56,7 +56,8 @@ OffsetValue > Purpose > Address: pmu_base_addr > OffsetValue Purpose > = > -0x0908Non-zero (only Exynos3250) Secondary CPU boot up indicator > +0x0908Non-zeroSecondary CPU boot up indicator > + on Exynos3250 and Exynos542x > > > 4. Glossary Applied, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] ARM: dts: Exynos for v4.4 (3rd)
On 10/16/15 14:42, Krzysztof Kozlowski wrote: > Dear Kukjin, > > Last batch of changes to DT for Exynos for v4.4. > Includes dependency - clock driver changes. > > Best regards, > Krzysztof > > > The following changes since commit 9aaf43d9b59d6b5d8daeb3a4b9d894ea88fc34c5: > > clk: samsung: exynos5250: Add DISP1 clocks (2015-10-16 08:49:53 +0900) > > are available in the git repository at: > > https://github.com/krzk/linux.git tags/samsung-dt-4.4-3 > > for you to fetch changes up to 1967da5699e660957737ec6c4015cfd8e428f0ff: > > ARM: dts: Add clocks to DISP1 domain in exynos5250 (2015-10-16 14:20:03 > +0900) > > > Last round (from my side) of v4.4 Device Tree improvements for Exynos > based boards: > 1. Fix USB OTG on Exynos3250 (Monk and Rinato), Exynos4210 (Trats >and Universal) and Exynos4412 (Trats2). > 2. Fix HDMI and LVDS display on Snow (Exynos5250) after second Suspend to RAM. > 3. Minor cleanups and fixes. > > > Krzysztof Kozlowski (2): > Merge tag 'samsung-clk-exynos5250-4.4' into dt-for-next Since there is no the branch(tags/samsung-clk-exynos5250-4.4) in clk tree, I think we don't need to keep the branch as a topic and we can just take the patch with Stephen's ack... > dt-bindings: Correct the example for Exynos power domain clocks > > Laurent Pinchart (2): > ARM: dts: Fix typo in regulator enable GPIO property in s5pv210-aquila > ARM: dts: Fix typo in regulator enable GPIO property in s5pv210-goni > > Marek Szyprowski (1): > ARM: dts: Add vbus regulator to USB2 phy nodes on exynos3250, > exynos4210 and exynos4412 boards > > Tomeu Vizoso (1): > ARM: dts: Add clocks to DISP1 domain in exynos5250 > > Documentation/devicetree/bindings/arm/exynos/power_domain.txt | 5 ++--- > arch/arm/boot/dts/exynos3250-monk.dts | 1 + > arch/arm/boot/dts/exynos3250-rinato.dts | 1 + > arch/arm/boot/dts/exynos4210-trats.dts| 2 +- > arch/arm/boot/dts/exynos4210-universal_c210.dts | 2 +- > arch/arm/boot/dts/exynos4412-trats2.dts | 1 + > arch/arm/boot/dts/exynos5250.dtsi | 4 > arch/arm/boot/dts/s5pv210-aquila.dts | 2 +- > arch/arm/boot/dts/s5pv210-goni.dts| 4 ++-- > 9 files changed, 14 insertions(+), 8 deletions(-) In this case, please show all of diff status including merge branch ;-) Applied all of your tags/samsung-dt-4.4-3. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] ARM: defconfig: Exynos improvements for 4.4, 2nd pull
On 10/13/15 09:38, Krzysztof Kozlowski wrote: > Dear Kukjin, > > This is another round of defconfig related changes for 4.4. > > Description along with a tag. > You can find them also on the lists with my reviewed-by. > > Best regards, > Krzysztof > > > The following changes since commit 7fa5ce4e6fcb4596761c17e124e7d1f8cf64fe96: > > ARM: exynos_defconfig: Disable simplefb support (2015-09-13 19:25:39 +0900) > > are available in the git repository at: > > https://github.com/krzk/linux.git tags/samsung-defconfig-4.4-2 > > for you to fetch changes up to 89a0112100e74f50407d269570a02a82fd28ccb8: > > ARM: multi_v7_defconfig: Enable rtl8152 ethernet driver for Odroid-XU4 > (2015-10-12 12:59:50 +0900) > > > Defconfig changes around Exynos based boards: > 1. Change WiFi-Ex from built-in to module to fix issue with probing >the driver before root filesystem is available (driver needs >firmware). > 2. Enable Realtek RTL81t3 ethernet adapter present on Odroid-XU4 >board. > > > Anand Moon (2): > ARM: exynos_defconfig: Enable rtl8152 ethernet driver for Odroid-XU4 > ARM: multi_v7_defconfig: Enable rtl8152 ethernet driver for Odroid-XU4 > > Javier Martinez Canillas (1): > ARM: exynos_defconfig: Enable WiFi-Ex as a module instead built-in > > arch/arm/configs/exynos_defconfig | 5 +++-- > arch/arm/configs/multi_v7_defconfig | 1 + > 2 files changed, 4 insertions(+), 2 deletions(-) Applied, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v5 8/8] ARM: EXYNOS: Remove SROM related register settings from mach-exynos
On 10/20/15 18:15, Pankaj Dubey wrote: > As now we have dedicated driver for SROM controller, it will take care > of saving register banks during S2R so we can safely remove these > settings from mach-exynos. > > Signed-off-by: Pankaj Dubey > Reviewed-by: Krzysztof Kozlowski > --- > arch/arm/mach-exynos/Kconfig | 2 ++ > arch/arm/mach-exynos/exynos.c| 17 - > arch/arm/mach-exynos/include/mach/map.h | 3 -- > arch/arm/mach-exynos/regs-srom.h | 53 > > arch/arm/mach-exynos/suspend.c | 20 ++- > arch/arm/plat-samsung/include/plat/map-s5p.h | 1 - > 6 files changed, 4 insertions(+), 92 deletions(-) > delete mode 100644 arch/arm/mach-exynos/regs-srom.h > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 3a10f1a..62c3139 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -27,6 +27,8 @@ menuconfig ARCH_EXYNOS > select SRAM > select THERMAL > select MFD_SYSCON > + select SOC_SAMSUNG > + select EXYNOS_SROM if PM Please add them in alphabetical next time...I've changed the order in this time. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v5 0/8] Add support for Exynos SROM Controller driver
On 10/23/15 18:49, Pavel Fedin wrote: > Hello! > >>> This patchset, I have tested on Peach-Pi (Exynos5880) based chromebook for >>> boot >>> and S2R functionality. >>> >> >> Entire patchset tested on Trats2 (Exynos4412) board. Unless Kukjin picks >> it also, I plan to take it for v4.5. > > Tested on SMDK5410. By the way, what is current status? If this is final > revision, can i post my Ethernet support patchset on top > of it? > > Tested-by: Pavel Fedin > Applied, this whole series. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach
On 10/16/15 22:48, Javier Martinez Canillas wrote:
> Hello Alim,
>
> On 10/16/2015 01:37 PM, Alim Akhtar wrote:
>> Hi Javier,
>>
>> On 10/15/2015 10:21 PM, Javier Martinez Canillas wrote:
>>> Hello,
>>>
>>> The Exynos Chromebooks DTS don't use the correct card detection properties
>>> since these were carried from the vendor tree that had a reason to do so.
>>>
>>> There are two things that I noticed:
>>>
>>> 1) The Marvell WiFi SDIO is marked as broken-cd instead of non-removable:
>>>
>>> This causes the device to be removed when the system enters into a suspend
>>> state which leads to the following warning when the system is resumed:
>>>
>>> [ 181.944636] mmc2: error -2 during resume (card was removed?)
>>>
>>> The rationale for using broken-cd is explained in downstream commit [0] and
>>> was that using the non-removable property caused issues with the mwifiex
>>> driver since the reset logic called the mmc_{remove,add}_host() functions.
>>>
>>> But the reset logic in the mwifiex mainline driver has changed and this is
>>> no longer the case so it's safe to use the non-removable property AFAICT.
>>>
>> Good to know it is fixed now. This is fixed in firmware or in the driver?
>>
>
> The fix is only in the driver. In fact, I'm using the same firmware from
> the ChromeOS rootfs for both the v3.8 vendor tree and mainline.
>
> So IIUC, the problem with the vendor tree was that the mwifiex SDIO driver
> mwifiex_sdio_reset_work() function did a card reset by calling the functions
> mmc_remove_host() and then mmc_add_host().
>
> But this didn't play nice with MMC_CAP_NONREMOVABLE since mmc_rescan() just
> returns if the flag is set so the card wouldn't be tried to be detected again.
>
> After commit ("b4336a282db8 mwifiex: sdio: reset adapter using mmc_hw_reset"),
> the card is reset by doing a power cycle so that's why "non-removable" can be
> used now instead of "broken-cd".
>
>>> 2) The eMMC node has both broken-cd and non-removable but the MMC DT binding
>>> doc (Documentation/devicetree/bindings/mmc/mmc.txt) mentions that only one
>>> of these card detection properties should be used.
>>>
>> This change looks ok, will take a closer look once I am back to my work
>> station.
>>
Actually, looks good to me +1.
Let me take this series once get the feedback from Alim.
Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks
On 10/17/15 03:56, Tomeu Vizoso wrote: > On 16 October 2015 at 19:26, Stephen Boyd wrote: >> On 10/16, Michael Turquette wrote: >>> Quoting Krzysztof Kozlowski (2015-10-15 16:46:27) On 15.10.2015 19:31, Tomeu Vizoso wrote: > When the DISP1 power domain is powered off, there's two clocks that need > to be temporarily reparented to OSC, and back to their original parents > when the domain is powered on again. > > We expose these two clocks in the DT bindings so that the DT node of the > power domain can reference them. > > Signed-off-by: Tomeu Vizoso > Acked-by: Stephen Boyd > --- > > Changes in v2: > - Reuse mout_aclk200_p > - Rename div_aclk300 as div_aclk300_disp > > drivers/clk/samsung/clk-exynos5250.c | 14 +- > include/dt-bindings/clock/exynos5250.h | 4 +++- > 2 files changed, 16 insertions(+), 2 deletions(-) > Reviewed-by: Krzysztof Kozlowski >>> >>> Applied to clk-next. >>> >> >> I think Tomeu wanted to take this through arm-soc? Otherwise >> we'll need to provide a stable branch for the dt header. > > Hi, Stephen is right, the second patch depends on this one. > So...how can I take 2nd patch of this series in samsung(arm-soc) tree? And this series shouldn't be for fixes for 4.3?...Mike how do you think? Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] ARM: defconfig: Exynos improvements for 4.4
On 09/30/15 11:22, Krzysztof Kozlowski wrote: > Dear Kukjin, > > Few defconfig related changes for 4.4. > > Description along with a tag. > You can find them also on the lists with my reviewed-by. > > Best regards, > Krzysztof > > > The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: > > Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) > > are available in the git repository at: > > https://github.com/krzk/linux.git tags/samsung-defconfig-4.4 > > for you to fetch changes up to 7fa5ce4e6fcb4596761c17e124e7d1f8cf64fe96: > > ARM: exynos_defconfig: Disable simplefb support (2015-09-13 19:25:39 +0900) > > > Defconfig changes around Exynos based boards: > 1. Enable DWC2 USB driver for exynos and multi_v7 defconfigs. >The driver is present on Exynos and Rockhip boards. Enabling also >ethernet gadget allows betwork communication with the device. > 2. Enable LEDS for Odroid XU3/XU4 family boards (provides simple >monitoring of the board). > 3. Disable the simplefb driver because in certain situations (when >U-boot injects simplefb bindings into DTB) it may break display. > > > Anand Moon (1): > ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 > > Javier Martinez Canillas (1): > ARM: exynos_defconfig: Disable simplefb support > > Marek Szyprowski (2): > ARM: exynos_defconfig: Enable DWC2 USB driver and USB ethernet gadget > ARM: multi_v7_defconfig: Enable DWC2 USB driver and USB ethernet gadget > > arch/arm/configs/exynos_defconfig | 9 - > arch/arm/configs/multi_v7_defconfig | 2 ++ > 2 files changed, 10 insertions(+), 1 deletion(-) Pulled, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core
On 10/10/15 16:24, Wolfram Sang wrote: > From: Wolfram Sang > > The core may register clients attached to this master which may use > funtionality from the master. So, RuntimePM must be enabled before, otherwise > this will fail. While here, move drvdata, too. > > Signed-off-by: Wolfram Sang Looks good to me, Acked-by: Kukjin Kim Thanks, Kukjin > --- > > Changes since v2: don't call runtime pm on adaper if it wasn't registered > > Thanks to Krzysztof for testing! > > drivers/i2c/busses/i2c-s3c2410.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: EXYNOS: Fix double of_node_put() when parsing child power domains
On 10/12/15 10:26, Krzysztof Kozlowski wrote:
> On each next iteration of for_each_compatible_node() the reference
> counter for current device node is already decreased by the loop
> iterator. The manual call to of_node_get() is required only on loop
> break which is not happening here.
>
> The double of_node_get() (with enabled CONFIG_OF_DYNAMIC) lead to
> decreasing the counter below expected, initial value.
>
> Signed-off-by: Krzysztof Kozlowski
> Fixes: fe4034a3fad7 ("ARM: EXYNOS: Add missing of_node_put() when parsing
> power domains")
> ---
> arch/arm/mach-exynos/pm_domains.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/pm_domains.c
> b/arch/arm/mach-exynos/pm_domains.c
> index 4a87e86dec45..7c21760f590f 100644
> --- a/arch/arm/mach-exynos/pm_domains.c
> +++ b/arch/arm/mach-exynos/pm_domains.c
> @@ -200,15 +200,15 @@ no_clk:
> args.args_count = 0;
> child_domain = of_genpd_get_from_provider(&args);
> if (IS_ERR(child_domain))
> - goto next_pd;
> + continue;
>
> if (of_parse_phandle_with_args(np, "power-domains",
>"#power-domain-cells", 0, &args) != 0)
> - goto next_pd;
> + continue;
>
> parent_domain = of_genpd_get_from_provider(&args);
> if (IS_ERR(parent_domain))
> - goto next_pd;
> + continue;
>
> if (pm_genpd_add_subdomain(parent_domain, child_domain))
> pr_warn("%s failed to add subdomain: %s\n",
> @@ -216,8 +216,6 @@ no_clk:
> else
> pr_info("%s has as child subdomain: %s.\n",
> parent_domain->name, child_domain->name);
> -next_pd:
> - of_node_put(np);
> }
>
> return 0;
Looks good to me, applied.
Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] arm: dts: Fix audio card detection on peach boards
On 10/12/15 22:04, Krzysztof Kozlowski wrote:
> W dniu 12.10.2015 o 21:37, Alim Akhtar pisze:
>> Since commit 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards"),
>> sound card detection is broken on peach boards and gives below errors:
>>
>> [3.630457] max98090 7-0010: MAX98091 REVID=0x51
>> [3.634233] max98090 7-0010: use default 2.8v micbias
>> [3.640985] snow-audio sound: HiFi <-> 383.i2s mapping ok
>> [3.645307] max98090 7-0010: Invalid master clock frequency
>> [3.650824] snow-audio sound: ASoC: Peach-Pi-I2S-MAX98091 late_probe()
>> failed: -22
>> [3.658914] snow-audio sound: snd_soc_register_card failed (-22)
>> [3.664366] snow-audio: probe of sound failed with error -22
>>
>> This patch adds missing assigned-clocks and assigned-clock-parents for
>> pmu_system_controller node which is used as "mclk" for audio codec.
>>
>> Signed-off-by: Alim Akhtar
>> Fixes: 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards")
>> Cc:
>> ---
>> Changes since v1:
>> Addressed Krzysztof's review comments.
>
> Looks good, thanks!
>
> Reviewed-by: Krzysztof Kozlowski
>
Applied, thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ARM: dts: Use GPIO constants for flags cells in exynos boards
On 10/07/15 22:14, Javier Martinez Canillas wrote: > Hello, > > This series contains trivial patches that use the GPIO constants > defined in include/dt-bindings/gpio/gpio.h to express GPIO polarity > instead of numeric values. > > There is no functional change and the compiled dtbs are unchanged but > is a good practice to use the defined macros instead of magic numbers > since that makes the DTS more readable. > > Since the changes are trivial, I thought that split the changes per > board DTS would create an unnecessary churn but a single patch would > maybe be harder to review so I decided that split it by SoC family > would be a good trade off. > > Please let me know if you prefer another approach. > > Best regards, > Javier > > > Javier Martinez Canillas (5): > ARM: dts: Use GPIO constants for flags cells in exynos3250 boards > ARM: dts: Use GPIO constants for flags cells in exynos4120 boards > ARM: dts: Use GPIO constants for flags cells in exynos4412 boards > ARM: dts: Use GPIO constants for flags cells in exynos5420/5422/5800 > boards > ARM: dts: Use GPIO constants for flags cells in exynos5440 boards > > arch/arm/boot/dts/exynos3250-monk.dts | 8 ++--- > arch/arm/boot/dts/exynos3250-rinato.dts| 10 +++--- > arch/arm/boot/dts/exynos4210-origen.dts| 15 > arch/arm/boot/dts/exynos4210-smdkv310.dts | 3 +- > arch/arm/boot/dts/exynos4210-trats.dts | 29 +++ > arch/arm/boot/dts/exynos4210-universal_c210.dts| 42 > +++--- > arch/arm/boot/dts/exynos4412-odroid-common.dtsi| 15 > arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 +- > arch/arm/boot/dts/exynos4412-odroidx.dts | 8 ++--- > arch/arm/boot/dts/exynos4412-origen.dts| 15 > arch/arm/boot/dts/exynos4412-tiny4412.dts | 9 ++--- > arch/arm/boot/dts/exynos4412-trats2.dts| 34 +- > arch/arm/boot/dts/exynos5420-arndale-octa.dts | 3 +- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 8 ++--- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 7 ++-- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 +-- > arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +-- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 8 ++--- > 18 files changed, 118 insertions(+), 107 deletions(-) > Applied this whole series, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 4/4] ARM: dts: Enable EC vboot context support on Peach boards
On 09/21/15 22:38, Emilio López wrote:
> The Peach boards use the EC to store the vboot context information,
> so add the corresponding properties on the EC node to indicate so.
>
> Reviewed-by: Krzysztof Kozlowski
> Acked-by: Javier Martinez Canillas
> Signed-off-by: Emilio López
> ---
>
> Changes from v1:
> - none
>
> Changes from v2:
> - collect tags from Krzysztof & Javier
>
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index 8f4d76c..ac02fb4 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -935,6 +935,7 @@
> pinctrl-0 = <&ec_spi_cs &ec_irq>;
> reg = <0>;
> spi-max-frequency = <3125000>;
> + google,has-vbc-nvram;
>
> controller-data {
> samsung,spi-feedback-delay = <1>;
> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> index 7d5b386..b60dec0 100644
> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> @@ -898,6 +898,7 @@
> pinctrl-0 = <&ec_spi_cs &ec_irq>;
> reg = <0>;
> spi-max-frequency = <3125000>;
> + google,has-vbc-nvram;
>
> controller-data {
> samsung,spi-feedback-delay = <1>;
Applied, thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] ARM: dts: Exynos improvements for 4.4-2
On 10/06/15 10:54, Krzysztof Kozlowski wrote: > Dear Kukjin, > > This is an updated pull request with DTS related changes for 4.4. > > Description along with a tag. > You can find them also on the lists with my reviewed-by. > > Best regards, > Krzysztof > > > The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: > > Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) > > are available in the git repository at: > > https://github.com/krzk/linux.git tags/samsung-dt-4.4-2 > > for you to fetch changes up to c21dbcfefc9dc9abc42971dc1f2681b6a8677c3c: > > ARM: dts: Remove regulator-compatible usage in exynos4412-trats2 > (2015-10-06 10:47:13 +0900) > > > Device Tree improvements for Exynos based boards (updated pull request): > 1. Enable DMA on Exynos4 serial ports. This old patch uncovered >a number of other issues in dmaengine and samsung serial driver. >All of known issues are resolved so finally enable the DMA for UART. > 2. Fix incorrect location of display-timings node (FIMD->DP node) >on Arndale, SMDK5250 and SMDK5240 boards. > 3. Minor cleanups. > > > Javier Martinez Canillas (1): > ARM: dts: Remove regulator-compatible usage in exynos4412-trats2 > > Robert Baldyga (1): > ARM: dts: Add DMA support for serial ports in exynos4 > > Sean Paul (1): > ARM: dts: Move display-timings node from fimd to dp in > exynos5250-arndale, smdk5250 and smdk5420 > > Tobias Jakobi (2): > ARM: dts: Remove redundant pinctrl settings in exynos4412-odroid > ARM: dts: Unify voltage regulator style in exynos4412-odroid > > Vladimir Zapolskiy (1): > ARM: dts: Fix cpu compatible value for s3c2416 > > arch/arm/boot/dts/exynos4.dtsi | 8 ++ > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 12 +-- > arch/arm/boot/dts/exynos4412-trats2.dts | 105 > > arch/arm/boot/dts/exynos5250-arndale.dts| 8 +- > arch/arm/boot/dts/exynos5250-smdk5250.dts | 16 ++-- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 7 +- > arch/arm/boot/dts/s3c2416.dtsi | 2 +- > 7 files changed, 62 insertions(+), 96 deletions(-) Pulled, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [GIT PULL] arm64: dts: Exynos ARMv8 improvements for 4.4
Krzysztof Kozlowski wrote: > > Dear Kukjin, > > One ARMv8 DTS change for 4.4. > > Best regards, > Krzysztof > > The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: > > Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) > > are available in the git repository at: > > https://github.com/krzk/linux.git tags/samsung-dt64-4.4 > > for you to fetch changes up to 235c8e96f54a76bee201a7c86620c351a30b1ac6: > > arm64: dts: Add BUS1 instance pinctrl support for exynos7 (2015-09-16 > 09:03:09 +0900) > > > Device Tree improvements for Exynos ARMv8 based boards: > 1. Add a BUS1 instance pinctrl for Exynos7 SoC. > > > Alim Akhtar (1): > arm64: dts: Add BUS1 instance pinctrl support for exynos7 > > arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 103 > > arch/arm64/boot/dts/exynos/exynos7.dtsi | 7 ++ > 2 files changed, 110 insertions(+) Looks good to me. Since just one patch in this pull-request if you don't mind, let me take the patch directly with your signed-off. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [GIT PULL] ARM: dts: Exynos improvements for 4.4
Krzysztof Kozlowski wrote: > > Dear Kukjin, > Hi, > DTS related changes for 4.4. > > Description along with a tag. > You can find them also on the lists with my reviewed-by. > I have small comments. Then I could just pull your branch... > Best regards, > Krzysztof > > > The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: > > Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) > > are available in the git repository at: > > https://github.com/krzk/linux.git tags/samsung-dt-4.4 > > for you to fetch changes up to 01dd011b7a0230a426a79475ae452298421a16e4: > > ARM: dts: exynos4412-trats2: remove regulator-compatible usage (2015-09-30 > 09:03:03 +0900) > > > Device Tree improvements for Exynos based boards: > 1. Enable DMA on Exynos4 serial ports. This old patch uncovered >a number of other issues in dmaengine and samsung serial driver. >All of known issues are resolved so finally enable the DMA for UART. > 2. Fix incorrect location of display-timings node (FIMD->DP node). > 3. Minor cleanups. > > > Javier Martinez Canillas (1): > ARM: dts: exynos4412-trats2: remove regulator-compatible usage Can you please move the dt name at the end of subject like others? > > Robert Baldyga (1): > ARM: dts: Add DMA support for serial ports in exynos4 > > Sean Paul (1): > ARM: dts: Move display-timings node from fimd to dp on Exynos For all of exynos? If not, please specify the dt file in subject so that we could realize what has been updated. > > Tobias Jakobi (2): > ARM: dts: Remove redundant pinctrl settings in exynos4412-odroid > ARM: dts: Unify voltage regulator style in exynos4412-odroid > > Vladimir Zapolskiy (1): > ARM: dts: Fix cpu compatible value for s3c2416 > > arch/arm/boot/dts/exynos4.dtsi | 8 ++ > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 12 +-- > arch/arm/boot/dts/exynos4412-trats2.dts | 105 > > arch/arm/boot/dts/exynos5250-arndale.dts| 8 +- > arch/arm/boot/dts/exynos5250-smdk5250.dts | 16 ++-- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 7 +- > arch/arm/boot/dts/s3c2416.dtsi | 2 +- > 7 files changed, 62 insertions(+), 96 deletions(-) - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [GIT PULL] Samsung fixes for v4.3
Krzysztof Kozlowski wrote: > > On 30.09.2015 15:50, Kukjin Kim wrote: > > On 09/30/15 08:59, Krzysztof Kozlowski wrote: > >> Dear Kukjin, > >> > >> Below you will find fixes for current release cycle which are not > >> present yet in your tree. > >> > >> Best regards, > >> Krzysztof > >> > >> > >> The following changes since commit > >> 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: > >> > >> Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) > >> > >> are available in the git repository at: > >> > >> https://github.com/krzk/linux.git tags/samsung-fixes-4.3 > >> > >> for you to fetch changes up to c7d2ecd9f64c351cb4d551f1f472d0fc09c3cae8: > >> > >> ARM: dts: Fix wrong clock binding for sysmmu_fimd1_1 on exynos5420 > >> (2015-09-29 15:39:58 +0900) > >> > >> > >> Fixes for Exynos (DT and mach code): > >> 1. Finally fix booting of all 8 cores on Exynos Octa (Exynos542x): all > >>8 cores are booting and can be used. The fix, based on vendor > >>code and bootloader behavior, is as for time being only > >>for MCPM enabled path. > >> 2. Fix thermal boot issue on SMDK5250. > >> 3. Fix invalid clock used for FIMD IOMMU. > >> > > Pulled, thanks. > > > > Note it will be sent to upstream in a day. > > A day extended to a week. Please do not hold the fixes but send them. If > they reached Linus tree late and they required any further fix, then we > would have less time for any updates. > Sorry for the delay and it's my fault. I'll handle it tonight... > The same applies for regular pull request for 4.4. For previous v4.3 > release many changes were too late (so they could even slip from 4.3 to > 4.4). Can we just avoid such issues and send pull requests earlier? > Krzysztof, I sent a pull request lately because of handling of cross-tree but I don't think so it causes some missing because it was due to cross tree not only mine. Please don't worry about that I'll handle it. Anyway thanks for your gentle reminder. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support
On 09/30/15 09:30, Krzysztof Kozlowski wrote:
> On 29.09.2015 20:57, Javier Martinez Canillas wrote:
>> There are 2 revisions of the Exynos5250 Snow Chromebook that were shipped:
>> Rev4 and Rev5. The only difference between these 2 revisions is the codec,
>> Rev4 has a max98095 codec while Rev5 has a max98090.
>>
>> Mainline only supports Rev4 so this patch moves the common device nodes to
>> a DTSI file and adds a DTS for the Exynos5250 Snow Rev5.
>>
>> The Snow Rev5 DTS is based on the DTS found in the ChromiumOS 3.8 tree.
>>
>> Signed-off-by: Javier Martinez Canillas
>>
>> ---
>>
>> The DTS in the vendor ChromeOS tree are called exynos5250-snow-rev{4,5}.dtb
>> but I decided to leave Rev4 as exynos5250-snow.dtb to avoid breaking u-boot
>> that has CONFIG_DEFAULT_DEVICE_TREE="exynos5250-snow" in snow_defconfig.
>>
>> Also, ChromiumOS Rev4 DTS has "google,snow-rev4" in its compatible string
>> but was not added in mainline since Rev4 firmware fallbacks to "google,snow"
>> and Rev5 searches for "google,snow-rev5". That way the compatible string
>> could be consistent with the DTS naming and still be able to pack both Rev4
>> and Rev5 FDT in the same FIT image and let the firmware pick the correct FDT.
>>
>> arch/arm/boot/dts/Makefile| 1 +
>> arch/arm/boot/dts/exynos5250-snow-common.dtsi | 684
>> ++
>> arch/arm/boot/dts/exynos5250-snow-rev5.dts| 47 ++
>> arch/arm/boot/dts/exynos5250-snow.dts | 666
>> +
>> 4 files changed, 733 insertions(+), 665 deletions(-)
>> create mode 100644 arch/arm/boot/dts/exynos5250-snow-common.dtsi
>> create mode 100644 arch/arm/boot/dts/exynos5250-snow-rev5.dts
>
> Now the exynos5250-snow.dts means in fact Rev4... but there is no
> information in DTS about it. I think adding compatible
> "google,snow-rev4" makes sense:
> 1. For informational purposes (this could be also handled with a comment).
> 2. Later one could decide to switch the default meaning of "google,snow"
> to Rev5 and the real compatible (rev4) will be there already.
>
> Could you add the new compatible and fix patch issues pointed by Doug?
>
Documenting for the compatibles would be required even I already applied
its updated patch...
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] ARM: dts: Add Exynos5250 Snow Rev5+ support
On 09/30/15 15:44, Javier Martinez Canillas wrote:
> There are 2 revisions of the Exynos5250 Snow Chromebook that were shipped:
> Rev4 and Rev5. The only difference between these 2 revisions is the codec,
> Rev4 has a max98095 codec while Rev5 has a max98090.
>
> Mainline only supports Rev4 so this patch moves the common device nodes to
> a DTSI file and adds a DTS for the Exynos5250 Snow Rev5.
>
> The Snow Rev5 DTS is based on the DTS found in the ChromiumOS 3.8 tree.
>
> Signed-off-by: Javier Martinez Canillas
> Tested-by: Mauro Carvalho Chehab
> Reviewed-by: Douglas Anderson
>
> ---
>
> Changes in v2:
> - Add Mauro Carvalho Chehab's Tested-by tag.
> - Add Doug Anderson's Reviewed-by tag.
> - Remove warning about adding a whitespace error. Suggested by Doug Anderson.
> - Make Rev{4,5} codec pinctrl properties to match. Suggested by Doug Anderson.
> - Add "google,snow-rev4" to compatible string. Suggested by Krzysztof
> Kozlowski.
>
> arch/arm/boot/dts/Makefile| 1 +
> arch/arm/boot/dts/exynos5250-snow-common.dtsi | 684
> ++
> arch/arm/boot/dts/exynos5250-snow-rev5.dts| 47 ++
> arch/arm/boot/dts/exynos5250-snow.dts | 671 +
> 4 files changed, 736 insertions(+), 667 deletions(-)
> create mode 100644 arch/arm/boot/dts/exynos5250-snow-common.dtsi
> create mode 100644 arch/arm/boot/dts/exynos5250-snow-rev5.dts
>
Applied, thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] Samsung fixes for v4.3
On 09/30/15 08:59, Krzysztof Kozlowski wrote: > Dear Kukjin, > > Below you will find fixes for current release cycle which are not > present yet in your tree. > > Best regards, > Krzysztof > > > The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: > > Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) > > are available in the git repository at: > > https://github.com/krzk/linux.git tags/samsung-fixes-4.3 > > for you to fetch changes up to c7d2ecd9f64c351cb4d551f1f472d0fc09c3cae8: > > ARM: dts: Fix wrong clock binding for sysmmu_fimd1_1 on exynos5420 > (2015-09-29 15:39:58 +0900) > > > Fixes for Exynos (DT and mach code): > 1. Finally fix booting of all 8 cores on Exynos Octa (Exynos542x): all >8 cores are booting and can be used. The fix, based on vendor >code and bootloader behavior, is as for time being only >for MCPM enabled path. > 2. Fix thermal boot issue on SMDK5250. > 3. Fix invalid clock used for FIMD IOMMU. > Pulled, thanks. Note it will be sent to upstream in a day. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/7] Add support for Exynos SROM Controller driver
On 08/24/15 17:02, Pankaj Dubey wrote: > This patch set adds support for Exynos SROM controller DT based driver. > Currently SROM register sets are used only during S2R, so driver > basically added for taking care of S2R. It will help us in removing > static mapping from exynos.c and other extra code handline during S2R. > > This patch set also updated exynos4 and exynos5 dtsi files for with device > node for srom, and added binding documentation for the same. > > First two patches are some minor cleanup in mach-exynos. > > Patchset v1 was posted here[1] > [1]: https://lkml.org/lkml/2015/4/29/98 > > Changes since v1: > - Rebased to latest kgene tree. > - Addressed review comments from Krzysztof Kozlowski. > - Add two new patches for minor cleanup in exynos.c and map.h > > Pankaj Dubey (7): > ARM: EXYNOS: remove unused static mapping of CMU for exynos5 > ARM: EXYNOS: code cleanup in map.h > drivers: soc: add support for exynos SROM driver > ARM: EXYNOS: Remove SROM related register settings from mach-exynos > ARM: dts: add SROM device node for exynos4 > ARM: dts: add SROM device node for exynos5 > Documentation: dt-bindings: add exynos-srom binding information > > .../bindings/arm/samsung/exynos-srom.txt | 12 ++ > arch/arm/boot/dts/exynos4.dtsi | 5 + > arch/arm/boot/dts/exynos5.dtsi | 5 + > arch/arm/mach-exynos/Kconfig | 2 + > arch/arm/mach-exynos/common.h | 2 - > arch/arm/mach-exynos/exynos.c | 22 > arch/arm/mach-exynos/include/mach/map.h| 8 -- > arch/arm/mach-exynos/regs-srom.h | 53 > arch/arm/mach-exynos/suspend.c | 20 +-- > arch/arm/plat-samsung/include/plat/map-s5p.h | 1 - > drivers/soc/Kconfig| 1 + > drivers/soc/Makefile | 1 + > drivers/soc/samsung/Kconfig| 13 ++ > drivers/soc/samsung/Makefile | 1 + > drivers/soc/samsung/exynos-srom.c | 143 > + > drivers/soc/samsung/exynos-srom.h | 51 > 16 files changed, 236 insertions(+), 104 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt > delete mode 100644 arch/arm/mach-exynos/regs-srom.h > create mode 100644 drivers/soc/samsung/Kconfig > create mode 100644 drivers/soc/samsung/Makefile > create mode 100644 drivers/soc/samsung/exynos-srom.c > create mode 100644 drivers/soc/samsung/exynos-srom.h > Hi Pankaj, Can you please address comments as per Krzysztof's review?... - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: dts: Fix LEDs on exynos5422-odroidxu3
On 09/17/15 08:09, Kukjin Kim wrote: > On 09/02/15 23:48, Krzysztof Kozlowski wrote: >> The LEDs on Odroid XU3 family boards could not properly probe because PWM >> outputs were reduced only to PWM for fan. Fix this to: >> - Odroid XU3 and XU3-Lite: 4 outputs (although the PWM for MIPI >>probably is redundant because board does not have MIPI connector >>available); >> - Odroid XU4: 2 outputs. >> >> This fixes warnings on dmesg: >> [4.838712] samsung-pwm 12dd.pwm: tried to request PWM channel 1 >> without output >> [4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22 >> [4.838767] leds_pwm: probe of pwmleds failed with error -22 >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> Patch depends/is rebased on latest DTS for Odroid XU4 board: >> - http://www.spinics.net/lists/arm-kernel/msg442474.html >> - http://www.spinics.net/lists/arm-kernel/msg442475.html >> --- > > Applied, thanks. > Oops, I mean already this change is included in your another patch. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: dts: Fix LEDs on exynos5422-odroidxu3
On 09/02/15 23:48, Krzysztof Kozlowski wrote: > The LEDs on Odroid XU3 family boards could not properly probe because PWM > outputs were reduced only to PWM for fan. Fix this to: > - Odroid XU3 and XU3-Lite: 4 outputs (although the PWM for MIPI >probably is redundant because board does not have MIPI connector >available); > - Odroid XU4: 2 outputs. > > This fixes warnings on dmesg: > [4.838712] samsung-pwm 12dd.pwm: tried to request PWM channel 1 > without output > [4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22 > [4.838767] leds_pwm: probe of pwmleds failed with error -22 > > Signed-off-by: Krzysztof Kozlowski > > --- > > Patch depends/is rebased on latest DTS for Odroid XU4 board: > - http://www.spinics.net/lists/arm-kernel/msg442474.html > - http://www.spinics.net/lists/arm-kernel/msg442475.html > --- Applied, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] cpufreq: s5pv210: remove superfluous CONFIG_PM ifdefs
On 09/09/15 10:14, Rafael J. Wysocki wrote: > On Tuesday, September 08, 2015 07:02:12 PM Bartlomiej Zolnierkiewicz wrote: >> CONFIG_PM ifdefs are superfluous and can be removed. > > I guess Kukjin can apply this one? > Applied, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] ARM: exynos_defconfig: Enable USB Video Class support
On 09/15/15 09:02, Krzysztof Kozlowski wrote: > On 14.09.2015 21:04, Javier Martinez Canillas wrote: >> The Exynos5420 Peach Pit and Exynos5800 Peach Pi boards have a built-in >> Silicon Motion USB UVC WebCam. Enable support for the USB Video Class >> driver and its needed media Kconfig symbols so the camera is supported. >> >> Signed-off-by: Javier Martinez Canillas >> >> --- >> >> Changes in v2: >> - Enable tristate Kconfig options as module instead of built-in. >> Suggested by Krzysztof Kozlowski. > > Reviewed-by: Krzysztof Kozlowski > Applied, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3
On 09/16/15 08:54, Krzysztof Kozlowski wrote:
> On 16.09.2015 08:35, Kukjin Kim wrote:
>> On 09/13/15 18:32, Krzysztof Kozlowski wrote:
>>> The LEDs on Odroid XU3 family boards could not properly probe because PWM
>>> outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and
>>> XU3-Lite boards by switching to usage of all 4 outputs (although the PWM
>>> for MIPI probably is redundant because board does not have MIPI
>>> connector available).
>>>
>>> This fixes warnings on dmesg:
>>> [4.838712] samsung-pwm 12dd.pwm: tried to request PWM channel 1
>>> without output
>>> [4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22
>>> [4.838767] leds_pwm: probe of pwmleds failed with error -22
>>>
>>> Signed-off-by: Krzysztof Kozlowski
>>>
>>> ---
>>>
>>> Changes since v1:
>>> 1. Do not rebase on patchset adding support for Odroid XU4 board. Rebase
>>>just on current next.
>>> ---
>>
>> Applied, thanks.
>>
>
> Thanks. This is actually a candidate for current v4.3 cycle. It fixes
> issue with LEDs for Odroid XU3 caused by Anand's b685d540cc26:
> The offending commit b685d540cc26 was merged in v4.3.
> I forgot to add "fixes" tag.
> Fixes: b685d540cc26 ("ARM: dts: Add pwm-fan node for
> exynos5422-odroidxu3")
>
> Can you send it to arm-soc during this cycle?
>
Why not? Will do it ;-)
> For current v4.3 Bartlomiej's patch is also an important candidate:
> "ARM: dts: add suspend opp to exynos4412"
>
Thanks for gentle reminder.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/4] cpufreq-dt: add suspend frequency support
On 09/08/15 14:10, Viresh Kumar wrote: > On 08-09-15, 13:48, Krzysztof Kozlowski wrote: >> Somehow my mind stuck on solving Exynos4x12 cpufreq issues. >> >> Right, it should go through Rafael's, probably except DTS patch (4/4) >> because it depends on previous DTS changes. These changes are still in >> arm-soc, not in Linus' tree [0]. > > That's bad :( > > Anyway, 4/4 is kind of independent to this series, in the sense that > it wouldn't harm even if it gets applied separately. > > So, go ahead and apply 4/4 to Samsung's tree and rest of this can be > picked by Rafael. > Applied 4/4 into samsung tree, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3
On 09/13/15 18:32, Krzysztof Kozlowski wrote: > The LEDs on Odroid XU3 family boards could not properly probe because PWM > outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and > XU3-Lite boards by switching to usage of all 4 outputs (although the PWM > for MIPI probably is redundant because board does not have MIPI > connector available). > > This fixes warnings on dmesg: > [4.838712] samsung-pwm 12dd.pwm: tried to request PWM channel 1 > without output > [4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22 > [4.838767] leds_pwm: probe of pwmleds failed with error -22 > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Do not rebase on patchset adding support for Odroid XU4 board. Rebase >just on current next. > --- Applied, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 1/2] ARM: dts: Split audio configuration to separateexynos5422-odroidxu3-audio
On 09/14/15 09:47, Krzysztof Kozlowski wrote: > The Odroid XU4 board does not have audio codec so before adding DTS for > new board split the audio codec to separate DTSI file. Include the audio codec > DTSI in Odroid XU3 and XU3-Lite boards. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Javier Martinez Canillas > Applied 1-2. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2 1/3] mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11
Krzysztof Kozlowski wrote: > > Document a new Device Tree property 'samsung,s2mps11-acokb-ground' > indicating that ACOKB pin of S2MPS11 PMIC is connected to the ground so > the PMIC must manually set PWRHOLD bit in CTRL1 register to turn off the > power. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Javier Martinez Canillas > Acked-by: Lee Jones > > --- > > Changes since v1: > 1. Split bindings documentation to separate patch (suggested by Lee). > 2. Add Javier's reviewed-by and Lee's acked-by. > --- > Documentation/devicetree/bindings/mfd/s2mps11.txt | 4 > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt > b/Documentation/devicetree/bindings/mfd/s2mps11.txt > index 57a045016fca..90eaef393325 100644 > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt > @@ -15,6 +15,10 @@ Optional properties: > - interrupt-parent: Specifies the phandle of the interrupt controller to > which >the interrupts from s2mps11 are delivered to. > - interrupts: Interrupt specifiers for interrupt sources. > +- samsung,s2mps11-acokb-ground: Indicates that ACOKB pin of S2MPS11 PMIC is > + connected to the ground so the PMIC must manually set PWRHOLD bit in CTRL1 > + register to turn off the power. Usually the ACOKB is pulled up to VBATT so > + when PWRHOLD pin goes low, the rising ACOKB will trigger power off. > > Optional nodes: > - clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered > 32.768 > -- > 2.1.4 Applied 1/3 and 3/3. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2] Remove unselectable rule for arm-exynos-cpufreq.o
Krzysztof Kozlowski wrote: > > 2015-08-13 20:33 GMT+09:00 Viresh Kumar : > > On 13-08-15, 13:28, Jonas Rabenstein wrote: > >> Commit "cpufreq: exynos: remove Exynos4x12 specific cpufreq driver > >> support" deleted option ARM_EXYNOS_CPUFREQ but missed to delete a rule > >> in drivers/cpufreq/Makefile which depends on that option. > >> > >> Remove unselectable rule for arm-exynos-cpufreq.o from > >> drivers/cpufreq/Makefile. > >> > >> Signed-off-by: Jonas Rabenstein > >> --- > >> I found this inconsistency using the undertaker and > >> undertaker-checkpatch tools (https://undertaker.cs.fau.de/). > >> > >> drivers/cpufreq/Makefile | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile > >> index bbc4a9f..958be2b 100644 > >> --- a/drivers/cpufreq/Makefile > >> +++ b/drivers/cpufreq/Makefile > >> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += > >> arm_big_little_dt.o > >> > >> obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o > >> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o > >> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o > >> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o > >> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o > >> obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o > > > > Acked-by: Viresh Kumar > > And again from me: > Reviewed-by: Krzysztof Kozlowski > > Dear Kukjin, > Can you take it and send in (updated) pull request with Exynos4x12 > cpufreq patches? > OK, sure. I'll take this. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2] ARM: dts: exynos4412-odroidu3: Enable SPI1.
Krzysztof Kozlowski wrote: > > W dniu 13.08.2015 o 18:06, Alexis Ballier pisze: > > SPI1 is available on IO Port #2 (as depicted on their website) in > > PCB Revision 0.5 of Hardkernel Odroid U3 board. > > The shield connects a 256KiB spi-nor flash on that bus. > > > > Signed-off-by: Alexis Ballier > > > > --- > > > > Changes in v2: Use GPIO_ACTIVE_HIGH (Krzysztof Kozlowski) > > > > arch/arm/boot/dts/exynos4412-odroidu3.dts | 8 > > 1 file changed, 8 insertions(+) > > Thanks for fixing, looks good: > > Reviewed-by: Krzysztof Kozlowski > Applied, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] ARM: exynos_defconfig: Enable cpufreq-dt driver
Javier Martinez Canillas wrote: > > Hello Krzysztof, > > On 08/11/2015 04:15 AM, Krzysztof Kozlowski wrote: > > With the latest patches the cpufreq-dt can be used on multiple > > Exynos SoCs: 3250, 4210, 4212, 4412 and 5250. > > > > Enable it along with default ondemand governor to conserve the energy, > > reduce temperature while maintaining acceptable performance. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > arch/arm/configs/exynos_defconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm/configs/exynos_defconfig > > b/arch/arm/configs/exynos_defconfig > > index 67965cedeb69..2263cd94cb93 100644 > > --- a/arch/arm/configs/exynos_defconfig > > +++ b/arch/arm/configs/exynos_defconfig > > @@ -27,6 +27,8 @@ CONFIG_ARM_APPENDED_DTB=y > > CONFIG_ARM_ATAG_DTB_COMPAT=y > > CONFIG_CMDLINE="root=/dev/ram0 rw ramdisk=8192 initrd=0x4100,8M > > console=ttySAC1,115200 > init=/linuxrc mem=256M" > > CONFIG_CPU_FREQ=y > > +CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y > > +CONFIG_CPUFREQ_DT=y > > CONFIG_CPU_IDLE=y > > CONFIG_ARM_EXYNOS_CPUIDLE=y > > CONFIG_VFP=y > > > > Reviewed-by: Javier Martinez Canillas > Thanks, applied. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
Krzysztof Kozlowski wrote: > > On 10.08.2015 10:27, Kukjin Kim wrote: > > Krzysztof Kozlowski wrote: > >> > >> W dniu 08.08.2015 o 11:07, Viresh Kumar pisze: > >>> On 08-08-15, 00:24, Rafael J. Wysocki wrote: > >>>> OK, so please let me know which patches you want me to pick up. > >>>> > >>>> Ideally, I'd prefer them to be resent in a separate series with ACKs and > >>>> all > >>>> with a cover letter clearly stating whose tree they are being targeted > >>>> at. > >>> > >>> He already sent it separately, let me send a confirmatory mail in > >>> reply to that. > >> > >> Dear Kukjin, > >> > >> Can you apply the 2-5 of this series to v4.3? It's getting late but > >> maybe they still could go? > >> > > Once my previous pull-request landed into arm-soc, I'll try to send out this > > series 2-5 for v4.3. > > Additionally (better late than never): Sure ;-) > Patches 2-5 tested on Trats2 board (Exynos4412) > > Tested-by: Krzysztof Kozlowski > Applied with Krzysztof's 'Tested-by'. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [GIT PULL] Samsung mach fixes for 4.2
Hi arm-soc guys, Can you please pull this into arm-soc fixes for v4.2 directly? I don't have other samsung fixes in my tree at this moment. Thanks, Kukjin Krzysztof Kozlowski wrote: > > Dear Kukjin, > > Please find latest two fixes for v4.2 cycle. You can find more detailed > description with the tag. > > Best regards, > Krzysztof > > > The following changes since commit d770e558e21961ad6cfdf0ff7df0eb5d7d4f0754: > > Linux 4.2-rc1 (2015-07-05 11:01:52 -0700) > > are available in the git repository at: > > https://github.com/krzk/linux.git tags/samsung-mach-fixes-4.2 > > for you to fetch changes up to 3e9f798784b30293012682021d5a0352f78658b8: > > ARM: EXYNOS: fix double of_node_put() on error path (2015-07-31 10:12:17 > +0900) > > > Two fixes for bugs in Exynos power domain error exit path: > 1. kfree() of read-only memory (name of power domain returned >by kstrdup_const()), > 2. Doubled of_node_put() leading to invalid ref count for OF node. > > > Vladimir Zapolskiy (2): > ARM: EXYNOS: Fix potentian kfree() of ro memory > ARM: EXYNOS: fix double of_node_put() on error path > > arch/arm/mach-exynos/pm_domains.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
Krzysztof Kozlowski wrote: > > W dniu 08.08.2015 o 11:07, Viresh Kumar pisze: > > On 08-08-15, 00:24, Rafael J. Wysocki wrote: > >> OK, so please let me know which patches you want me to pick up. > >> > >> Ideally, I'd prefer them to be resent in a separate series with ACKs and > >> all > >> with a cover letter clearly stating whose tree they are being targeted at. > > > > He already sent it separately, let me send a confirmatory mail in > > reply to that. > > Dear Kukjin, > > Can you apply the 2-5 of this series to v4.3? It's getting late but > maybe they still could go? > Once my previous pull-request landed into arm-soc, I'll try to send out this series 2-5 for v4.3. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
Bartlomiej Zolnierkiewicz wrote: > > Hi, > Hi Bart, > This patch series removes the use of Exynos4x12 specific support > from cpufreq-exynos driver and enables the use of cpufreq-dt driver > for this platform. > Thanks for this series. > This patch series has been tested on Exynos4412 based Odroid-U3 and > Trats2 boards. > Sounds good. > Depends on: > - next-20150806 branch of linux-next kernel tree > - "[PATCH V3 00/16] OPP: Add code to support operating-points-v2 bindings" > (http://www.spinics.net/lists/arm-kernel/msg435408.html) > BTW, hmm...how can we see this series in v4.3?...to be honest, I don't think it can be done in v4.3 because of dependencies with PM / OPP series and previous exynos CPU OPP series in each cross trees...maybe that's why you created based on linux-next...any idea? Thanks, Kukjin > Changes since v3 > (http://thread.gmane.org/gmane.linux.power-management.general/63464): > - rebased on top of next-20150806 branch of linux-next kernel tree > - made ARCH_EXYNOS config option select thermal support > - made scaling_boost_freqs sysfs attribute available only when boost > support is enabled > - added Acked-by tag from Viresh to patches #3, #4 and #5 > - added Tested-by tag from Tobias to patches #2-5 > - added Reviewed-by tag from Krzysztof to patch #4 > > Changes since v2 > (http://thread.gmane.org/gmane.linux.kernel.samsung-soc/46653): > - rebased on top of next-20150730 branch of linux-next kernel tree > - ported over V3 of opp-v2 bindings support patch series > - put cpu0 nodes in alphabetical order in dts files > - added Reviewed-by tags from Javier and Krzysztof > - added Acked-by tag from Sylwester > > Changes since v1 > (http://thread.gmane.org/gmane.linux.kernel.samsung-soc/44361): > - rebased on top of next-20150629 branch of linux-next kernel tree > - rebased on top of Exynos5250 cpufreq-dt support patch series > - fixed if-statement in exynos4_clk_init() (noticed by Tobias Jakobi) > - ported over opp-v2 bindings (requested by Viresh Kumar) > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > > Bartlomiej Zolnierkiewicz (6): > cpufreq: make scaling_boost_freqs sysfs attr available when boost is > enabled > clk: samsung: exynos4x12: add cpu clock configuration data and > instantiate cpu clock > ARM: dts: Exynos4x12: add CPU OPP and regulator supply property > ARM: Exynos: switch to using generic cpufreq driver for Exynos4x12 > cpufreq: exynos: remove Exynos4x12 specific cpufreq driver support > cpufreq: remove no longer needed CPU_FREQ_BOOST_SW config option > > arch/arm/boot/dts/exynos4212.dtsi | 81 > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 + > arch/arm/boot/dts/exynos4412-origen.dts | 4 + > arch/arm/boot/dts/exynos4412-trats2.dts | 4 + > arch/arm/boot/dts/exynos4412.dtsi | 83 + > arch/arm/mach-exynos/Kconfig| 2 + > arch/arm/mach-exynos/exynos.c | 2 + > drivers/clk/samsung/clk-exynos4.c | 50 + > drivers/cpufreq/Kconfig | 4 - > drivers/cpufreq/Kconfig.arm | 38 > drivers/cpufreq/Makefile| 2 - > drivers/cpufreq/cpufreq-dt.c| 3 + > drivers/cpufreq/exynos-cpufreq.c| 236 > > drivers/cpufreq/exynos-cpufreq.h| 72 > drivers/cpufreq/exynos4x12-cpufreq.c| 236 > > drivers/cpufreq/freq_table.c| 10 +- > include/linux/cpufreq.h | 1 + > 17 files changed, 241 insertions(+), 591 deletions(-) > delete mode 100644 drivers/cpufreq/exynos-cpufreq.c > delete mode 100644 drivers/cpufreq/exynos-cpufreq.h > delete mode 100644 drivers/cpufreq/exynos4x12-cpufreq.c > > -- > 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/7] cpufreq: opp: fix handling of turbo modes
On 07/27/15 20:47, Bartlomiej Zolnierkiewicz wrote: > On Monday, July 27, 2015 05:06:41 PM Viresh Kumar wrote: >> On 27-07-15, 13:14, Bartlomiej Zolnierkiewicz wrote: >>> Sorry but you don't seem to understand the issue. >> >> :) >> >> No, I did. I understand that if someone uses opp bindings today with >> some entries as turbo OPPs, cpufreq will use them as normal >> frequencies. And that may harm the board. >> >> BUT, opp-v2 code isn't ready to be used yet. And platforms should see >> what all is implemented before trying to use them. > > OK. > >> All I was saying is, this isn't a FIX as we haven't introduced the >> feature yet. Otherwise I had no issues with the patch. > > I will update the description for the next patchset revision. > Hi Bart, When will you re-post v3? Because I have a plan to send a pull-request to arm-soc until this weekend... - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 0/3] clocksource: exynos_mct: allow mct to use 64-bit counter from coprocessor
On 07/29/15 08:29, Doug Anderson wrote: > Hi, > Hi, > On Tue, Jul 28, 2015 at 9:20 AM, Alexey Klimov wrote: >> Hi Doug, >> >> On Tue, Jul 28, 2015 at 6:24 PM, Doug Anderson wrote: >>> Alexey, >>> >>> On Mon, Jul 27, 2015 at 2:28 PM, Alexey Klimov >>> wrote: Hi all, year(s) ago it was discovered that MCT timer and ARM architectured timer are the same hardware with different interface. Here [1]. I followed mail-list discussions about removing MCT and using arch timer for Exynos5-based SoCs but things aren't moving at least latest upstream kernel on odroid-xu3 will use MCT as default timers. Maybe the reason are some power-management related things that very specific to Samsung. I don't know. Idea of this draft patchset comes from Doug patches when he tried to optimize read of 64-bit counter located in mmio. [2] Why not using cp15 counter instead if possible? >>> >>> I hate to burst your bubble here, but... >>> >>> ...I think it would be a bad idea to use the cp15 counter on exynos >>> 5422. According to Samsung, there are issues where using cp15 could >>> sometimes return the wrong value, especially if you happen to read it >>> while on an A7 instead of an A15. It will tend to work pretty well, >>> but Samsung claimed that it might not work right on some CPUs or at >>> some temperatures. >> >> I think this is right time when I can say "If only I had known about >> it before!". > > Yeah, we spent a whole lot of time on this too before giving up after > we found out it was not possible to use. > > >> That's quite interesting especially about temperature issues. >> Maybe it's worth to insert comments in driver/docs about this. > > Maybe not a bad idea. Depends if you think someone else will try to > do this... ...and if they do, will they check mailing list traffic. > > >>> Generally I'd say that if the arch timer works for you: use the arch >>> timer. If the arch timer doesn't work for you, use the MCT. >>> One more thing, if you change it for your own private platform, it's up to you but if not, i.e., for mass product, please don't change it. Because it's not guaranteed even you haven't seen its failure... >>> -Doug >> >> I possess no knowledge if there're any different hw revisions of >> odroid-xu3 on the field >> but looks like arch timer works fine for me on odroid-xu3 Exynos5422 >> SoC with upstream kernel. > > Well, it looked like it worked for us too. In fact, I never saw a > failure. All I know is that Samsung said: don't do this, it's not a > good idea. The performance gain wasn't enough to go against that... > That's when I started trying to optimize the MCT a little bit. ;) > Yeah and it was tough time for me when I discussed about that with hardware designer at that time ... haha... Thanks, Doug. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v3] ARM: dts: Add SPI CS on exynos5250-snow
Michal Suchanek wrote:
>
> Although there is only one choice of chipselect it is necessary to
> specify it. The driver cannot claim the gpio otherwise.
>
> Signed-off-by: Michal Suchanek
> Acked-by: Javier Martinez Canillas
> Acked-by: Krzysztof Kozlowski
>
>From here ---8<8<---
> --
> - don't move unrelated line
> - use symbolic GPIO_ACTIVE_HIGH
to here ---8<8<---
should be added under the following '---'.
Please add some additional comments like above 'changes since previous version'
under the following '---' not '--', because all comments will be logged before
the '---' and I don't want to keep the changes basically.
Anyway, applied with removing above comments.
Thanks,
Kukjin
> ---
> arch/arm/boot/dts/exynos5250-snow.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
> b/arch/arm/boot/dts/exynos5250-snow.dts
> index b7f4122..2d6a976 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -688,6 +688,7 @@
> status = "okay";
> samsung,spi-src-clk = <0>;
> num-cs = <1>;
> + cs-gpios = <&gpa2 5 GPIO_ACTIVE_HIGH>;
> };
>
> &usbdrd_dwc3 {
> --
> 2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250
Krzysztof Kozlowski wrote: > > On 24.07.2015 12:40, Kukjin Kim wrote: > > On 07/24/15 09:30, Michael Turquette wrote: > >> Quoting Kukjin Kim (2015-07-07 07:43:31) > >>> Bartlomiej Zolnierkiewicz wrote: > > > > [...] > > > >>>>> Chanwoo Choi (3): > >>>>> clk: samsung: exynos3250: Add cpu clock configuration data and > >>>>> instaniate cpu clock > >>>>> ARM: dts: Add CPU OPP and regulator supply property for Exynos3250 > >>>>> ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver > >>>>> > >>>>> arch/arm/boot/dts/exynos3250-monk.dts | 4 > >>>>> arch/arm/boot/dts/exynos3250-rinato.dts | 4 > >>>>> arch/arm/boot/dts/exynos3250.dtsi | 15 +++ > >>>>> arch/arm/mach-exynos/exynos.c | 1 + > >>>>> drivers/clk/samsung/clk-exynos3250.c| 32 > >>>>> ++-- > >>>>> include/dt-bindings/clock/exynos3250.h | 1 + > >>>>> 6 files changed, 55 insertions(+), 2 deletions(-) > >>>> > >>>> Reviewed-by: Bartlomiej Zolnierkiewicz > >>>> > >>>> Thank you for working on this. > >>>> > >>> +1 Thanks. > >>> > >>> Mike and Sylwester, if you're OK on this series, I'd like to pick up in > >>> Samsung > >>> tree together. And if you want, I could provide topic branch for clk tree. > >> > >> Kukjin, > >> > >> A topic branch would be great. > >> > > Sure, BTW it means you did 'ack' on this clk change? If not, please let > > em know ;-) I'll let you know once the topic branch is ready. > > Dear Kukjin, > > Will you handle this patchset and dependants (ARM: dts: Add CPU cooling > binding for Exynos3250-based Rinato/Monk board) for v4.3? > You mean Chanwoo's patch. Yes, I'll. Thanks for your gentle reminder. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [GIT PULL] ARM: defconfig: Improvements for 4.3
Krzysztof Kozlowski > > 2015-07-17 15:51 GMT+09:00 Krzysztof Kozlowski : > > Dear Kukjin, > > > > Few defconfig related changes. > > > > Description along with a tag. > > You can find them also on the lists with my reviewed-by. > > > > Best regards, > > Krzysztof > > Any comments on this pull request? > Will pick them up, thanks. > Best regards, > Krzysztof > > > > > > > > The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93: > > > > Merge tag 'ext4_for_linus_stable' of > > git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 > (2015-07-05 16:24:54 -0700) Please don't make a branch based on some random commit, just use 'rc' as a basis. Note that usually '-rc1' is used if there is no reason to use another 'rc' because of dependency. - Kukjin > > > > are available in the git repository at: > > > > > > https://github.com/krzk/linux.git tags/samsung-defconfig-4.3 > > > > for you to fetch changes up to 5efedc7617df7add295702f21f11dd7e7a67b76e: > > > > ARM: multi_v7_defconfig: Enable max77802 regulator (2015-07-16 15:57:31 > > +0900) > > > > > > Defconfig changes around Exynos based boards: > > 1. Enable sound on Odroid XU3 on exynos defconfig. > > 2. Enable NTC thermistors for Chromebooks on exynos and multi_v7. > > 3. Enable main PMIC regulator for Chromebooks on multi_v7. > > 4. Clean up in multi_v7 - remove old (non-existing) configs. > > > > > > Anand Moon (1): > > ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3 > > > > Javier Martinez Canillas (4): > > ARM: multi_v7_defconfig: Remove old Samsung USB PHY configs > > ARM: multi_v7_defconfig: Enable NTC Thermistors support > > ARM: exynos_defconfig: Enable NTC Thermistors support > > ARM: multi_v7_defconfig: Enable max77802 regulator > > > > arch/arm/configs/exynos_defconfig | 3 +++ > > arch/arm/configs/multi_v7_defconfig | 5 +++-- > > 2 files changed, 6 insertions(+), 2 deletions(-) > > -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2/9] ARM: multi_v7_defconfig: Enable max77802 regulator, rtc and clock drivers
Olof Johansson wrote:
>
> Hi,
>
Hi,
> On Fri, Jul 17, 2015 at 11:47 AM, Javier Martinez Canillas
> wrote:
> > Hello Olof,
> >
> > On Fri, Jul 17, 2015 at 6:49 PM, Olof Johansson wrote:
> >> On Thu, Jul 16, 2015 at 09:42:47AM +0900, Krzysztof Kozlowski wrote:
> >>> On 16.07.2015 00:38, Javier Martinez Canillas wrote:
> >>> > Hello,
> >>> >
> >>> > On Thu, May 14, 2015 at 5:40 PM, Javier Martinez Canillas
> >>> > wrote:
> >>> >> The Maxim max77802 Power Management IC is used on many Exynos machines.
> >>> >> Besides a bunch of regulators, this chip has a Real-Time-Clock (RTC)
> >>> >> and 2-channel 32kHz clock outputs.
> >>> >>
> >>> >> Enable the kernel config options to have the drivers for these devices
> >>> >> built as a module.
> >>> >>
> >>> >> Signed-off-by: Javier Martinez Canillas
> >>> >>
> >>> >> ---
> >>> >> arch/arm/configs/multi_v7_defconfig | 3 +++
> >>> >> 1 file changed, 3 insertions(+)
> >>> >>
> >>> >> diff --git a/arch/arm/configs/multi_v7_defconfig
> >>> >> b/arch/arm/configs/multi_v7_defconfig
> >>> >> index 2349584b6e08..080120fe5580 100644
> >>> >> --- a/arch/arm/configs/multi_v7_defconfig
> >>> >> +++ b/arch/arm/configs/multi_v7_defconfig
> >>> >> @@ -373,6 +373,7 @@ CONFIG_POWER_RESET_SYSCON=y
> >>> >> CONFIG_REGULATOR_MAX8907=y
> >>> >> CONFIG_REGULATOR_MAX8973=y
> >>> >> CONFIG_REGULATOR_MAX77686=y
> >>> >> +CONFIG_REGULATOR_MAX77802=m
> >>> >
> >>> > I noticed that the version that landed in 4.2-rc1 as commit
> >>> > f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802 regulator, rtc
> >>> > and clock drivers") doesn't include this symbol. I guess it was caused
> >>> > by a wrong resolved conflict? I'll post a patch to enable the
> >>> > regulator again.
> >>>
> >>> As you can see in mentioned mainline commit Kukjin removed it manually:
> >>> [kg...@kernel.org: removing useless REGULATOR_MAX77802 config]
> >>>
> >>> I wonder why?
> >>
> >> Seems odd. exynos_defconfig still enables it.
> >>
It has been removed when I did 'make savedefconfig' at that time maybe because
of dependency with other configs...
> > Yeah since it is needed for at least the Exynos5420 Peach Pit and
> > Exynos5800 Peach Pi Chromebooks that use this PMIC.
> >
> >> Javier or Krzysztof, please send an incremental fix to enable and I'll pick
> >> it up as a fix.
> >>
> >
> > I already posted an incremental patch [0] and Krzysztof is pushing it
> > through Kukjin for 4.3 [1].
> >
Yes. I'll send it out to arm-soc in this weekend.
> > I guess that's OK and there is no need to add it as a fix for the 4.2
> > -rc cycle since this is not really a regression. I mean, the max77802
> > regulator driver was never enabled for multi_v7_defconfig before.
>
> Yeah, I came across those emails a little further down. :-) It's all
> good, we'll see it come in later.
>
Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [GIT PULL] Non-critical fixes for v4.3
Krzysztof Kozlowski wrote: > > 2015-07-24 20:04 GMT+09:00 Bartlomiej Zolnierkiewicz > : > > > > Hi, > > > > On Friday, July 24, 2015 03:34:55 PM Krzysztof Kozlowski wrote: > >> Dear Kukjin, > >> > >> Previously you did not picked up the fix for cpufreq memory leak. > >> I am sending it again with respective acks from LKML. Also another > >> minor improvement in the set. > >> > >> Best regards, > >> Krzysztof > >> > >> > >> The following changes since commit > >> 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93: > >> > >> Merge tag 'ext4_for_linus_stable' of > >> git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 > (2015-07-05 16:24:54 -0700) > >> > >> are available in the git repository at: > >> > >> > >> https://github.com/krzk/linux.git tags/samsung-fixes-non-critical-v4.3-2 > >> > >> for you to fetch changes up to 434213f727c12fab8657c8db3d23da4b0463365d: > >> > >> video: fbdev: s3c-fb: Constify platform_device_id (2015-07-24 15:17:32 > >> +0900) > >> > >> > >> Improvements for Exynos boards: > >> 1. Fix memory leak in cpufreq error path. > >> 2. Constify platform_device_id in video/fbdev/s3c-fb. > >> > >> > >> Krzysztof Kozlowski (1): > >> video: fbdev: s3c-fb: Constify platform_device_id > >> > >> Shailendra Verma (1): > >> cpufreq: exynos: Fix for memory leak in case SOC name does not match > > > > I would suggest merging this fix in v4.2 not v4.3: > > > > - it is obvious and touches only error paths > > Indeed, good point, thanks for pointing this. Although these are not > regressions for issues introduced in current release but they are are > non-intrusive. > > Kukjin, do you agree? Can you pull them for second round of v4.2 fixes (not > 4.3) > Agreed. OK. > > - (hopefully) in v4.3 the exynos-cpufreq driver will be completely > > replaced by using cpufreq-dt for Exynos platforms (thus there will be > > no benefits of having this fix in v4.3 but there will be potential > > risk of merge conflicts due to exynos-cpufreq driver removal) > > > > We'll see... The Exynos 4x12 requires OPP patches. Are these ready for 4.3? > I think, if any conflicts based on fixes during -rc, can be handled by maintainer. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250
On 07/24/15 12:40, Kukjin Kim wrote: > On 07/24/15 09:30, Michael Turquette wrote: >> Quoting Kukjin Kim (2015-07-07 07:43:31) >>> Bartlomiej Zolnierkiewicz wrote: > > [...] > >>>>> Chanwoo Choi (3): >>>>> clk: samsung: exynos3250: Add cpu clock configuration data and >>>>> instaniate cpu clock >>>>> ARM: dts: Add CPU OPP and regulator supply property for Exynos3250 >>>>> ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver >>>>> >>>>> arch/arm/boot/dts/exynos3250-monk.dts | 4 >>>>> arch/arm/boot/dts/exynos3250-rinato.dts | 4 >>>>> arch/arm/boot/dts/exynos3250.dtsi | 15 +++ >>>>> arch/arm/mach-exynos/exynos.c | 1 + >>>>> drivers/clk/samsung/clk-exynos3250.c| 32 >>>>> ++-- >>>>> include/dt-bindings/clock/exynos3250.h | 1 + >>>>> 6 files changed, 55 insertions(+), 2 deletions(-) >>>> >>>> Reviewed-by: Bartlomiej Zolnierkiewicz >>>> >>>> Thank you for working on this. >>>> >>> +1 Thanks. >>> >>> Mike and Sylwester, if you're OK on this series, I'd like to pick up in >>> Samsung >>> tree together. And if you want, I could provide topic branch for clk tree. >> >> Kukjin, >> >> A topic branch would be great. >> > Sure, BTW it means you did 'ack' on this clk change? If not, please let > em know ;-) I'll let you know once the topic branch is ready. > Mike, Done, the topic branch 'v4.3-topic/clk-samsung' in samsung tree is for your clk tree. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 1/3] clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock
On 07/20/15 09:23, Chanwoo Choi wrote:
> Hi Sylwester,
>
Hi Chanwoo,
> Please review this patch.
>
Applied with Mike's ack BTW please make sure your patch has no problem
with checkpatch before submittingI've fixed them when I applied.
Thanks,
Kukjin
ERROR: code indent should use tabs where possible
#49: FILE: drivers/clk/samsung/clk-exynos3250.c:779:
+ (((apll) << 24) | ((pclk_dbg) << 20) | ((atb) << 16) | \$
WARNING: please, no spaces at the start of a line
#49: FILE: drivers/clk/samsung/clk-exynos3250.c:779:
+ (((apll) << 24) | ((pclk_dbg) << 20) | ((atb) << 16) | \$
ERROR: code indent should use tabs where possible
#50: FILE: drivers/clk/samsung/clk-exynos3250.c:780:
+ ((corem) << 4))$
WARNING: please, no spaces at the start of a line
#50: FILE: drivers/clk/samsung/clk-exynos3250.c:780:
+ ((corem) << 4))$
WARNING: please, no spaces at the start of a line
#55: FILE: drivers/clk/samsung/clk-exynos3250.c:785:
+ { 100, E3250_CPU_DIV0(1, 7, 4, 1), E3250_CPU_DIV1(7, 7), },$
WARNING: please, no spaces at the start of a line
#56: FILE: drivers/clk/samsung/clk-exynos3250.c:786:
+ { 90, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },$
WARNING: please, no spaces at the start of a line
#57: FILE: drivers/clk/samsung/clk-exynos3250.c:787:
+ { 80, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },$
WARNING: please, no spaces at the start of a line
#58: FILE: drivers/clk/samsung/clk-exynos3250.c:788:
+ { 70, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },$
WARNING: please, no spaces at the start of a line
#59: FILE: drivers/clk/samsung/clk-exynos3250.c:789:
+ { 60, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },$
WARNING: please, no spaces at the start of a line
#60: FILE: drivers/clk/samsung/clk-exynos3250.c:790:
+ { 50, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },$
WARNING: please, no spaces at the start of a line
#61: FILE: drivers/clk/samsung/clk-exynos3250.c:791:
+ { 40, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },$
WARNING: please, no spaces at the start of a line
#62: FILE: drivers/clk/samsung/clk-exynos3250.c:792:
+ { 30, E3250_CPU_DIV0(1, 5, 3, 1), E3250_CPU_DIV1(7, 7), },$
WARNING: please, no spaces at the start of a line
#63: FILE: drivers/clk/samsung/clk-exynos3250.c:793:
+ { 20, E3250_CPU_DIV0(1, 3, 3, 1), E3250_CPU_DIV1(7, 7), },$
WARNING: please, no spaces at the start of a line
#64: FILE: drivers/clk/samsung/clk-exynos3250.c:794:
+ { 10, E3250_CPU_DIV0(1, 1, 1, 1), E3250_CPU_DIV1(7, 7), },$
WARNING: please, no spaces at the start of a line
#65: FILE: drivers/clk/samsung/clk-exynos3250.c:795:
+ { 0 },$
total: 2 errors, 13 warnings, 63 lines checked
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
[PATCH v6 1_3] clk: samsung: exynos3250: Add cpu clock configuration
data and instaniate cpu clock.eml has style problems, please review.
> Best Regards,
> Chanwoo Choi
>
> On 07/16/2015 04:46 PM, Krzysztof Kozlowski wrote:
>> 2015-07-02 9:42 GMT+09:00 Chanwoo Choi :
>>> This patch add CPU clock configuration data and instantiate the CPU clock
>>> type
>>> for Exynos3250 to support Samsung specific cpu-clock type.
>>>
>>> Cc: Sylwester Nawrocki
>>> Cc: Tomasz Figa
>>> Signed-off-by: Chanwoo Choi
>>> Acked-by: Kyungmin Park
>>> Reviewed-by: Krzysztof Kozlowski
>>> ---
>>> drivers/clk/samsung/clk-exynos3250.c | 32
>>> ++--
>>> include/dt-bindings/clock/exynos3250.h | 1 +
>>
>> Sylwester,
>>
>> I think this patch also waits for your review or ack.
>> The patchset is rebased on Bartlomiej's series for Exynos5250 cpufreq
>> so the easiest way would be to take it through samsung-soc tree.
>>
>> Best regards,
>> Krzysztof
>>
>>
>>> 2 files changed, 31 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/clk/samsung/clk-exynos3250.c
>>> b/drivers/clk/samsung/clk-exynos3250.c
>>> index 538de66a759e..378ad5ad3492 100644
>>> --- a/drivers/clk/samsung/clk-exynos3250.c
>>> +++ b/drivers/clk/samsung/clk-exynos3250.c
>>> @@ -19,6 +19,7 @@
>>> #include
>>>
>>> #include "clk.h"
>>> +#include "clk-cpu.h"
>>> #include "clk-pll.h"
>>>
>>> #define SRC_LEFTBUS0x4200
>>> @@ -319,8 +320,10 @@ static struct samsung_mux_clock mux_clks[] __initdata
>>> = {
>>> MUX(CLK_MOUT_MPLL_USER_C, "mout_mpll_user_c", mout_mpll_user_p,
>>> SRC_CPU, 24, 1),
>>> MUX(CLK_MOUT_HPM, "mout_hpm", mout_hpm_p, SRC_CPU, 20, 1),
>>> - MUX(CLK_MOUT_CORE, "mout_core", mout_core_p, SRC_CPU, 16, 1),
>>> - MUX(CLK_MOUT_APLL, "mout_apll", mout_apll_p, SRC_CPU, 0, 1),
>>> + MUX_F(CLK_MOUT_CORE, "mout_core", mout_core_p, SRC_CPU, 16, 1,
>>> + CLK_SET_RATE_PARENT, 0),
>>> + MUX_F(CLK_MOUT_APLL, "mout_apll", mout_apll_p, SRC_CPU, 0, 1,
>>> +
Re: [PATCH v3 1/4] clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock
On 07/24/15 09:39, Michael Turquette wrote: > Quoting Bartlomiej Zolnierkiewicz (2015-07-01 06:10:35) >> From: Thomas Abraham >> >> With the addition of the new Samsung specific cpu-clock type, the >> arm clock can be represented as a cpu-clock type. Add the CPU clock >> configuration data and instantiate the CPU clock type for Exynos5250. >> >> Changes by Bartlomiej: >> - split Exynos5250 support from the original patch >> - moved E5250_CPU_DIV[0,1]() macros to clk-exynos5250.c >> >> Cc: Tomasz Figa >> Cc: Michael Turquette >> Cc: Javier Martinez Canillas >> Signed-off-by: Thomas Abraham >> Signed-off-by: Bartlomiej Zolnierkiewicz > > Acked-by: Michael Turquette > Thanks, Mike. > If Kukjin wants to merge this through the samsung tree then an immutable > branch would be much appreciated. > Here is the topic branch for clk tree and it will not be rebased. git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v4.3-topic/clk-samsung If any problems, please kindly let me know. Thanks, Kukjin > Regards, > Mike > >> --- >> drivers/clk/samsung/clk-exynos5250.c | 31 +++ >> include/dt-bindings/clock/exynos5250.h | 1 + >> 2 files changed, 32 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250
On 07/24/15 09:30, Michael Turquette wrote: > Quoting Kukjin Kim (2015-07-07 07:43:31) >> Bartlomiej Zolnierkiewicz wrote: [...] >>>> Chanwoo Choi (3): >>>> clk: samsung: exynos3250: Add cpu clock configuration data and >>>> instaniate cpu clock >>>> ARM: dts: Add CPU OPP and regulator supply property for Exynos3250 >>>> ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver >>>> >>>> arch/arm/boot/dts/exynos3250-monk.dts | 4 >>>> arch/arm/boot/dts/exynos3250-rinato.dts | 4 >>>> arch/arm/boot/dts/exynos3250.dtsi | 15 +++ >>>> arch/arm/mach-exynos/exynos.c | 1 + >>>> drivers/clk/samsung/clk-exynos3250.c| 32 >>>> ++-- >>>> include/dt-bindings/clock/exynos3250.h | 1 + >>>> 6 files changed, 55 insertions(+), 2 deletions(-) >>> >>> Reviewed-by: Bartlomiej Zolnierkiewicz >>> >>> Thank you for working on this. >>> >> +1 Thanks. >> >> Mike and Sylwester, if you're OK on this series, I'd like to pick up in >> Samsung >> tree together. And if you want, I could provide topic branch for clk tree. > > Kukjin, > > A topic branch would be great. > Sure, BTW it means you did 'ack' on this clk change? If not, please let em know ;-) I'll let you know once the topic branch is ready. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3
Kukjin Kim wrote: > > Krzysztof Kozlowski wrote: > > > > On 21.07.2015 14:21, Krzysztof Kozlowski wrote: > > > 2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski : > > >> 2015-07-21 14:02 GMT+09:00 Kukjin Kim : > > >>> Krzysztof Kozlowski wrote: > > [...] > > > >>>> -- > > >>> > > >>> Applied above changes into fixes/non-critical, next/cleanup-samsung, > > >>> next/dt-samsung and next/cpufreq-clk-samsung according to the change. > > > > > > Cc-ed Bartlomiej, > > > > > > One issue found: splitting DTS change for Exynos 5250 cpufreq to > > > separate branch will break bisectability. The commit "ARM: dts: > > > Exynos5250: add CPU OPP and regulator supply property": > > > 1. MUST be put after "clk: samsung: exynos5250: add cpu clock > > > configuration data and instantiate cpu clock" to prevent build > > > failures, > > > 2. should be put before "ARM: Exynos: switch to using generic cpufreq > > > driver for Exynos5250" to prevent lost cpufreq functionality. > > > > > > Doing otherwise would lose bisectability which is really unfortunate > > > when you can simply avoid it. This should remain in the same branch - > > > next/cpufreq-clk-samsung. > > > > Dear Kukjin, > > > > Nothing changed since yesterday... so let me point this in a more clear > > way. The way you divided the patchset causes build errors: > > > > -- > > HEAD is now at 565872a601c4... ARM: dts: add CPU OPP and regulator > > supply property for exynos5250 > > > > ERROR: Failed build: -A arm -c exynos on > > 565872a601c4d91a75b917b1fb40ff27ad7ebb08 > > > > LOGS: > > Error: ../arch/arm/boot/dts/exynos5250.dtsi:65.21-22 syntax error > > FATAL ERROR: Unable to parse input tree > > make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1 > > make[1]: *** [dtbs] Error 2 > > make[1]: *** Waiting for unfinished jobs > > make: *** [sub-make] Error 2 > > -- > > > > This breaks bisectability without any special valid reason. > > > Hi, > > I couldn't check e-mail yesterday because of annual health check. > Anyway, I'll look at the error and handle it soon. > OK, the change for the include/dt-bindings/clock/exynos5250.h file which is in next/cpufreq-clk-samsung branch should be provided in next/dt-samsung branch. It should be fine tonight in my time. One more thing, the splitting changes into dt and driver side would be required generally and if it has dependency like this, proper merge topic branch is required by maintainer. But I've missed last action :( Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3
Krzysztof Kozlowski wrote: > > On 21.07.2015 14:21, Krzysztof Kozlowski wrote: > > 2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski : > >> 2015-07-21 14:02 GMT+09:00 Kukjin Kim : > >>> Krzysztof Kozlowski wrote: [...] > >>>> -- > >>> > >>> Applied above changes into fixes/non-critical, next/cleanup-samsung, > >>> next/dt-samsung and next/cpufreq-clk-samsung according to the change. > > > > Cc-ed Bartlomiej, > > > > One issue found: splitting DTS change for Exynos 5250 cpufreq to > > separate branch will break bisectability. The commit "ARM: dts: > > Exynos5250: add CPU OPP and regulator supply property": > > 1. MUST be put after "clk: samsung: exynos5250: add cpu clock > > configuration data and instantiate cpu clock" to prevent build > > failures, > > 2. should be put before "ARM: Exynos: switch to using generic cpufreq > > driver for Exynos5250" to prevent lost cpufreq functionality. > > > > Doing otherwise would lose bisectability which is really unfortunate > > when you can simply avoid it. This should remain in the same branch - > > next/cpufreq-clk-samsung. > > Dear Kukjin, > > Nothing changed since yesterday... so let me point this in a more clear > way. The way you divided the patchset causes build errors: > > -- > HEAD is now at 565872a601c4... ARM: dts: add CPU OPP and regulator > supply property for exynos5250 > > ERROR: Failed build: -A arm -c exynos on > 565872a601c4d91a75b917b1fb40ff27ad7ebb08 > > LOGS: > Error: ../arch/arm/boot/dts/exynos5250.dtsi:65.21-22 syntax error > FATAL ERROR: Unable to parse input tree > make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1 > make[1]: *** [dtbs] Error 2 > make[1]: *** Waiting for unfinished jobs > make: *** [sub-make] Error 2 > -- > > This breaks bisectability without any special valid reason. > Hi, I couldn't check e-mail yesterday because of annual health check. Anyway, I'll look at the error and handle it soon. Thanks for your check. Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3
Krzysztof Kozlowski wrote: > > Dear Kukjin, > > Exynos mach-code related improvements. Description along with a tag. > You can find them also on the lists with my reviewed-by. > > Best regards, > Krzysztof > > > The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93: > > Merge tag 'ext4_for_linus_stable' of > git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2015- > 07-05 16:24:54 -0700) > > are available in the git repository at: > > > https://github.com/krzk/linux.git tags/samsung-mach-4.3 > > for you to fetch changes up to 70f83b6716ea0e5944071c12ff1716f93a9c2d8d: > > cpufreq: exynos: remove Exynos5250 specific cpufreq driver support > (2015-07-16 10:39:56 +0900) > > > Improvements for Exynos based boards: > 1. Switch to generic cpufreq-dt driver for Exynos5250. The old driver >is removed. > 2. Fix memory leak in cpufreq error path. > 3. Cleanups: remove duplicated define with bootloader's sleep magic >constant, staticize local function, drop 'owner' from >platform driver, fix cast of iomem to ERR_PTR. > > > Bartlomiej Zolnierkiewicz (1): > cpufreq: exynos: remove Exynos5250 specific cpufreq driver support > > Krzysztof Kozlowski (4): > ARM: EXYNOS: pmu: Make local function static > ARM: EXYNOS: Remove duplicated define of SLEEP_MAGIC > ARM: EXYNOS: pmu: Drop owner assignment > ARM: EXYNOS: Use IOMEM_ERR_PTR when function returns iomem > > Shailendra Verma (1): > cpufreq: exynos: Fix for memory leak in case SOC name does not match > > Thomas Abraham (3): > clk: samsung: exynos5250: add cpu clock configuration data and > instantiate cpu clock > ARM: dts: Exynos5250: add CPU OPP and regulator supply property > ARM: Exynos: switch to using generic cpufreq driver for Exynos5250 > > arch/arm/boot/dts/exynos5250-arndale.dts | 4 + > arch/arm/boot/dts/exynos5250-smdk5250.dts | 4 + > arch/arm/boot/dts/exynos5250-snow.dts | 4 + > arch/arm/boot/dts/exynos5250-spring.dts | 4 + > arch/arm/boot/dts/exynos5250.dtsi | 22 > arch/arm/mach-exynos/common.h | 6 + > arch/arm/mach-exynos/exynos.c | 1 + > arch/arm/mach-exynos/firmware.c | 2 - > arch/arm/mach-exynos/platsmp.c| 2 +- > arch/arm/mach-exynos/pmu.c| 3 +- > arch/arm/mach-exynos/suspend.c| 4 +- > drivers/clk/samsung/clk-exynos5250.c | 31 + > drivers/cpufreq/Kconfig.arm | 11 -- > drivers/cpufreq/Makefile | 1 - > drivers/cpufreq/exynos-cpufreq.c | 9 +- > drivers/cpufreq/exynos-cpufreq.h | 17 --- > drivers/cpufreq/exynos5250-cpufreq.c | 210 > -- > include/dt-bindings/clock/exynos5250.h| 1 + > 18 files changed, 84 insertions(+), 252 deletions(-) > delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c > -- Applied above changes into fixes/non-critical, next/cleanup-samsung, next/dt-samsung and next/cpufreq-clk-samsung according to the change. BTW since I can't see any ack from cpufreq guy for the patch "cpufreq: exynos: Fix for memory leak in case SOC name does not match" so I couldn't. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [GIT PULL] ARM: EXYNOS: dts: Improvements for 4.3
Krzysztof Kozlowski wrote: > > Dear Kukjin, > Hi Krzysztof, > DTS related improvements. Description along with a tag. > You can find them also on the lists with my reviewed-by. > > Best regards, > Krzysztof > > > The following changes since commit a419d78a6f97f8c977fe55d5d590cd0654ecd1ee: > > ARM: dts: Exynos4210: add CPU OPP and regulator supply property (2015-07-13 > 21:16:05 +0900) > > are available in the git repository at: > > https://github.com/krzk/linux.git tags/samsung-dt-4.3 > > for you to fetch changes up to cd0b551be420d49c2bde8dcf5ea147278dc89ffb: > > ARM: dts: Extend exynos5420-pinctrl nodes using labels instead of paths > (2015-07-16 11:22:11 +0900) > > > Device Tree improvements for Exynos based boards: > 1. Enable proper USB 3.0 regulators on Odroid XU3 board. > 2. Set over-heat and over-voltage thresholds for Trats2 board fuel >gauge. > 3. Fix missing display frequency on Exynos3250 Rinato board >(necessary to fix the display). > 4. Enable thermal management and fan control on Odroid XU3 board. >The speed of fan is adjusted to current temperature of SoC. > 5. Cleanups and usage of label-notation for overriding nodes. > > > Anand Moon (5): > ARM: dts: odroidxu3: Enable USB3 regulators > ARM: dts: exynos5422-odroidxu3: Add pwm-fan node > ARM: dts: exynos5422-odroidxu3: Enable TMU at Exynos5422 base > ARM: dts: exynos5422-odroidxu3: Define default thermal-zones > ARM: dts: exynos5422-odroidxu3: Enable thermal-zones > > Andreas Färber (1): > ARM: dts: Clean up exynos5410-smdk5410 indentation > > Hyungwon Hwang (1): > ARM: dts: fix the clock-frequency of exynos3250-rinato board's panel > > Javier Martinez Canillas (4): > ARM: dts: Include exynos5250-pinctrl after the nodes were defined > ARM: dts: Extend exynos5250-pinctrl nodes using labels instead of paths > ARM: dts: Include exynos5420-pinctrl after the nodes were defined > ARM: dts: Extend exynos5420-pinctrl nodes using labels instead of paths > > Krzysztof Kozlowski (2): > ARM: dts: Set max17047 over heat and over voltage thresholds > ARM: dts: Use labels for overriding nodes in exynos4210-universal > > arch/arm/boot/dts/exynos3250-rinato.dts|2 +- > arch/arm/boot/dts/exynos4210-universal_c210.dts| 620 > arch/arm/boot/dts/exynos4412-trats2.dts|3 + > arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 1600 > ++-- > arch/arm/boot/dts/exynos5250.dtsi |3 +- > arch/arm/boot/dts/exynos5410-smdk5410.dts |6 +- > arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 1411 + > arch/arm/boot/dts/exynos5420.dtsi |3 +- > arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi | 59 + > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 46 + > 10 files changed, 1930 insertions(+), 1823 deletions(-) > create mode 100644 arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi > -- Applied all of changes into fixes/non-critical and next/dt-samsung. Note will be sent out to arm-soc in a couple of days. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] ARM: multi_v7_defconfig: Remove old Samsung USB PHY configs
Javier Martinez Canillas wrote:
>
> The old drivers/usb/phy/phy-samsung-usb{2,3} are now deleted since
> were replaced by newers drivers that use the Generic PHY framework
> but their Kconfig options were left over in multi_v7_defconfig.
>
> Signed-off-by: Javier Martinez Canillas
>
Acked-by: Kukjin Kim
I think, this can be handled by arm-soc guy directly.
Thanks,
Kukjin
> ---
>
> arch/arm/configs/multi_v7_defconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig
> b/arch/arm/configs/multi_v7_defconfig
> index 77f4b76d16e9..e3fdc3dd02f6 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -493,8 +493,6 @@ CONFIG_USB_CHIPIDEA_HOST=y
> CONFIG_AB8500_USB=y
> CONFIG_KEYSTONE_USB_PHY=y
> CONFIG_OMAP_USB3=y
> -CONFIG_SAMSUNG_USB2PHY=y
> -CONFIG_SAMSUNG_USB3PHY=y
> CONFIG_USB_GPIO_VBUS=y
> CONFIG_USB_ISP1301=y
> CONFIG_USB_MXS_PHY=y
> --
> 2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [GIT PULL] ARM: EXYNOS: dts: Fixes for 4.2
Krzysztof Kozlowski wrote: > > 2015-07-14 17:26 GMT+09:00 Kukjin Kim : > > Krzysztof Kozlowski wrote: > >> > >> Dear Kukjin, > >> > > Hi, > > > > Thanks for your pull-request and I'll sort them out for 4.2-rc soon. > > > > BTW, the Thomas' patch is enough to support exynos4210 cpufreq without other > > patches in the series? I didn't think so... > > All other patches were already applied by Mike and sent to Linus > during 4.2 merge window. > Sounds good. OK, I'll handle this series in this -rc round. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [GIT PULL] ARM: EXYNOS: dts: Fixes for 4.2
Krzysztof Kozlowski wrote: > > Dear Kukjin, > Hi, Thanks for your pull-request and I'll sort them out for 4.2-rc soon. BTW, the Thomas' patch is enough to support exynos4210 cpufreq without other patches in the series? I didn't think so... - Kukjin > These are candidates for fixes during this RC cycle. > Description below (under signed tag). > > Best regards, > Krzysztof > > > The following changes since commit d770e558e21961ad6cfdf0ff7df0eb5d7d4f0754: > > Linux 4.2-rc1 (2015-07-05 11:01:52 -0700) > > are available in the git repository at: > > https://github.com/krzk/linux.git tags/samsung-dt-fixes-4.2 > > for you to fetch changes up to a419d78a6f97f8c977fe55d5d590cd0654ecd1ee: > > ARM: dts: Exynos4210: add CPU OPP and regulator supply property (2015-07-13 > 21:16:05 +0900) > > > Samsung DTS fixes: > 1. Fix Exynos3250 MIPI DSI display and MIPI CSIS-2 camera sensor after >adding support for PMU regmap in exynos-video-mipi driver >(issue introduced in v4.0). > 2. Bring back cpufreq for Exynos4210 after incomplete switch to >cpufreq-dt driver in 4.2 merge window. The necessary DTS change >for Exynos4210 cpufreq was not applied to the same tree as >rest of patchset because of multiple conflicts between >clk and arm-soc DTS trees. It was also too late to send it >to arm-soc for 4.2. Unfortunately without the change the Exynos4210 >boards loose cpufreq feature. > > > Beata Michalska (1): > ARM: dts: Update video-phy node with syscon phandle for Exynos3250 > > Thomas Abraham (1): > ARM: dts: Exynos4210: add CPU OPP and regulator supply property > > arch/arm/boot/dts/exynos3250.dtsi | 2 +- > arch/arm/boot/dts/exynos4210-origen.dts | 4 > arch/arm/boot/dts/exynos4210-trats.dts | 4 > arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 > arch/arm/boot/dts/exynos4210.dtsi | 12 > 5 files changed, 25 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] serial: samsung: Remove redundant DEBUG_LL check
Krzysztof Kozlowski wrote:
>
> On 13.07.2015 20:18, Javier Martinez Canillas wrote:
> > Commit 84f57d9e3685 ("tty: serial/samsung: fix modular build") fixed
> > build issues when the driver was built as a module. One of those was
> > that printascii is only accessible when the driver is built-in.
> >
> > But there is no need to check for defined(CONFIG_DEBUG_LL) since the
> > SERIAL_SAMSUNG_DEBUG Kconfig symbol already depends on DEBUG_LL.
> >
> > Signed-off-by: Javier Martinez Canillas
Acked-by: Kukjin Kim
Thanks,
Kukjin
> >
> > ---
> >
> > drivers/tty/serial/samsung.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Although this redundancy is not harmful the patch seems fine, so:
> Reviewed-by: Krzysztof Kozlowski
>
> Best regards,
> Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250
Bartlomiej Zolnierkiewicz wrote: > > Hi, > Hi, > On Thursday, July 02, 2015 09:42:38 AM Chanwoo Choi wrote: > > This patchset use cpufreq-dt driver to support Exynos3250 cpufreq and > > tested it > > on Exynos3250-based Rinato board. > > > > Depends on: > > - next-20150701 tag (master branch) of linux-next kernel tree > > - This patch-set is based on Exynos5250 patch-set[1] because two patch-set > > modify the 'arch/arm/mach-exynos/exynos.c' to add the compatible string. > > [1] https://lkml.org/lkml/2015/6/29/361 > > : [PATCH v2 0/4] cpufreq: use generic cpufreq drivers for Exynos5250 > > platform > > > > Changes from v5: > > (https://lkml.org/lkml/2015/7/1/324) > > - Reorder the cpu dt node in exynos3250-rinato/monk.dts alpabetically. > > - Add reviewed-by tag of Krzysztof Kozlowski > > > > Changes from v4: > > (https://lkml.org/lkml/2014/10/20/215) > > - Rebased on latest linux-next git repository. > > - Remove unnecessary divider clock flag from divider of DIV_CPU0/DIV_CPU1 > > register > > > > Changes from v3: > > - This patchset is based on 3.18-rc1 with new patchset[3] of Thomas Abraham > > [3] [PATCH v11 0/6] cpufreq: use generic cpufreq drivers for exynos > > platforms > > - http://www.spinics.net/lists/arm-kernel/msg370412.html > > > > Changes from v2: > > - Rebased on new patchset of Thomas Abraham > > and for-next branch of samsunc-clk.git of Tomasz Figa > > > > Changes from v1: > > - Rebased on new patchset[1] by Thomas Abraham > > [1] [PATCH v10 0/6] cpufreq: use generic cpufreq drivers for exynos > > platforms > > - http://www.spinics.net/lists/arm-kernel/msg364790.html > > - Modify clk-cpu.c to support Exynos3250 > > - Drop documentation patch on previous patchset[2] > > [2] http://www.spinics.net/lists/cpufreq/msg10265.html > > - Add only operating-points for Exynos3250 without armclk-divider-table > > > > Chanwoo Choi (3): > > clk: samsung: exynos3250: Add cpu clock configuration data and instaniate > > cpu clock > > ARM: dts: Add CPU OPP and regulator supply property for Exynos3250 > > ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver > > > > arch/arm/boot/dts/exynos3250-monk.dts | 4 > > arch/arm/boot/dts/exynos3250-rinato.dts | 4 > > arch/arm/boot/dts/exynos3250.dtsi | 15 +++ > > arch/arm/mach-exynos/exynos.c | 1 + > > drivers/clk/samsung/clk-exynos3250.c| 32 > > ++-- > > include/dt-bindings/clock/exynos3250.h | 1 + > > 6 files changed, 55 insertions(+), 2 deletions(-) > > Reviewed-by: Bartlomiej Zolnierkiewicz > > Thank you for working on this. > +1 Thanks. Mike and Sylwester, if you're OK on this series, I'd like to pick up in Samsung tree together. And if you want, I could provide topic branch for clk tree. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 4/6] ARM: dts: Exynos4210: add CPU OPP and regulator supply property
Krzysztof Kozlowski wrote: > > On 22.06.2015 10:38, Kukjin Kim wrote: > > Krzysztof Kozlowski wrote: > >> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski : > >>> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz > >>> : > >>>> From: Thomas Abraham > >>>> > >>>> For Exynos4210 platforms, add CPU operating points and CPU > >>>> regulator supply properties for migrating from Exynos specific > >>>> cpufreq driver to using generic cpufreq driver. > >>>> > >>>> Changes by Bartlomiej: > >>>> - removed Exynos5250 and Exynos5420 support for now > >>>> > >>>> Cc: Kukjin Kim > >>>> Cc: Doug Anderson > >>>> Cc: Javier Martinez Canillas > >>>> Cc: Andreas Faerber > >>>> Cc: Sachin Kamat > >>>> Cc: Andreas Farber > >>>> Cc: Javier Martinez Canillas > >>>> Signed-off-by: Thomas Abraham > >>>> Signed-off-by: Bartlomiej Zolnierkiewicz > >>> > >>> Acked-by: Krzysztof Kozlowski > >> > >> Rebased and applied to my tree, I'll sent it later to Kukjin unless he > >> picks it by himself from LKML. > >> > > Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based > > on > > v4.2-rc1 after v4.2-rc1 release. > > You mean it is for v4.3, not v4.2? > Oops, yes v4.3. Thanks for the correction. Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 4/6] ARM: dts: Exynos4210: add CPU OPP and regulator supply property
Krzysztof Kozlowski wrote: > 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski : > > 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz > > : > >> From: Thomas Abraham > >> > >> For Exynos4210 platforms, add CPU operating points and CPU > >> regulator supply properties for migrating from Exynos specific > >> cpufreq driver to using generic cpufreq driver. > >> > >> Changes by Bartlomiej: > >> - removed Exynos5250 and Exynos5420 support for now > >> > >> Cc: Kukjin Kim > >> Cc: Doug Anderson > >> Cc: Javier Martinez Canillas > >> Cc: Andreas Faerber > >> Cc: Sachin Kamat > >> Cc: Andreas Farber > >> Cc: Javier Martinez Canillas > >> Signed-off-by: Thomas Abraham > >> Signed-off-by: Bartlomiej Zolnierkiewicz > > > > Acked-by: Krzysztof Kozlowski > > Rebased and applied to my tree, I'll sent it later to Kukjin unless he > picks it by himself from LKML. > Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on v4.2-rc1 after v4.2-rc1 release. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] cpufreq: use generic cpufreq drivers forExynos4210platform
On 05/14/15 22:07, Kukjin Kim wrote: > On 05/14/15 14:10, Viresh Kumar wrote: >> On 14-05-15, 13:07, Kukjin Kim wrote: >>> On 05/13/15 23:08, Bartlomiej Zolnierkiewicz wrote: >>>> >>>> Hi, >>>> >>> Hi Bart, >>> >>>> On Friday, April 03, 2015 06:43:43 PM Bartlomiej Zolnierkiewicz wrote: >>>>> Hi, >>>>> >>>>> This patch series removes the use of Exynos4210 specific support >>>>> from cpufreq-exynos driver and enables the use of cpufreq-dt driver >>>>> for this platform. >>>> >>>> Gentle Ping. Mike/Kukjin/Viresh could you please review/ack relevant >>>> patches (patches #1-3 are for clock subsystem, patches #4-5 for Exynos >>>> mach/dts and patch #6 is for cpufreq subsystem)? >> >> Sorry I thought I already Acked an older version of this set and so >> didn't went for it again. Done now. >> >>> Yes, I totally agreed with this patches for arch side changes and this >>> approach when Thomas posted. >>> >>>> Also what is your >>>> preferred way to upstream them (patches are not independent so it would >>>> be best to merge them through one tree, otherwise synchronization of >>>> git pulls between different subsystem trees will be needed)? >>>> >>> I can provide topic branch for arch side changes even it is small. I >>> think once Viresh and Mike make each topic branch based on -rc or the >>> smallest changes from each subsystem then I could handle this series or >>> Viresh or Mike need to handle this series with merging each topic >>> branches in subsystem. I'm fine either way. >>> >>> Viresh and Mike, how do you think about that? >> >> For cpufreq subsystem changes, you can take them in your tree. >> > Hi Viresh, OK, I will take the cpufreq changes with your ack. Thanks for > your confirmation. > > Hi Mike and Sylwester, > How can we handle this series well without any problems? hmm... > Still I need to get clock guys' ack or any comments on this series... - Kukjin >>>> I'm still hoping that this patchset will make it into v4.2 as there are >>>> no known issues with it (except minor coding nit for patch #5)... >>>> >>> Sure, why not :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/2] ARM: multi_v7_defconfig: Enable display on Trats2board
On 05/24/15 05:27, Arnd Bergmann wrote: > On Saturday 23 May 2015 11:18:58 Kukjin Kim wrote: >> On 05/22/15 18:11, Javier Martinez Canillas wrote: >>> Hello Krzysztof, >>> >>> On 05/22/2015 02:48 AM, Krzysztof Kozlowski wrote: >>>> Enable the Exynos DSI and S6E8AA0 panel for full X11 display on Trats2. >>>> >>>> Signed-off-by: Krzysztof Kozlowski >>>> --- >>>> arch/arm/configs/multi_v7_defconfig | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/arch/arm/configs/multi_v7_defconfig >>>> b/arch/arm/configs/multi_v7_defconfig >>>> index 0848337a2a01..e9785020aab1 100644 >>>> --- a/arch/arm/configs/multi_v7_defconfig >>>> +++ b/arch/arm/configs/multi_v7_defconfig >>>> @@ -413,10 +413,12 @@ CONFIG_DRM=y >>>> CONFIG_DRM_PTN3460=m >>>> CONFIG_DRM_PS8622=m >>>> CONFIG_DRM_EXYNOS=m >>>> +CONFIG_DRM_EXYNOS_DSI=y >>>> CONFIG_DRM_EXYNOS_FIMD=y >>>> CONFIG_DRM_EXYNOS_HDMI=y >>>> CONFIG_DRM_RCAR_DU=m >>>> CONFIG_DRM_TEGRA=y >>>> +CONFIG_DRM_PANEL_S6E8AA0=m >>>> CONFIG_DRM_PANEL_SIMPLE=y >>>> CONFIG_FB_ARMCLCD=y >>>> CONFIG_FB_WM8505=y >>>> >>> >>> Reviewed-by: Javier Martinez Canillas >>> >> Looks good to me and this would be handled by arm-soc guys directly >> >> Acked-by: Kukjin Kim >> > > I'd actually prefer if you could put this into the same branch as your > other defconfig changes. We'll handle any conflicts when merging that in. > OK, done. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] ARM: EXYNOS: DTS improvements for 4.2, 3rd
Krzysztof Kozlowski wrote: > Dear Kukjin, > > Quite big set of changes, mostly refactor. > > You can find them also on the lists with my reviewed-by. Thanks for your gentle reminder and gathering. I'm sorting them out and it should be fine tonight in my tree... If any differences with yours, I'll let you know and please check them tomorrow morning so that it could be sent out to arm-soc tomorrow for 4.2. Thanks, Kukjin > > Best regards, > Krzysztof > > > The following changes since commit 5c78bc1b466701c1b13d7b734f5b39cdd65babab: > > Merge branch 'samsung-defconfig-2nd' into for-next (2015-05-23 12:28:59 > +0900) > > are available in the git repository at: > > https://github.com/krzk/linux.git tags/samsung-dt-for-4.2-3 > > for you to fetch changes up to a33a220172cd832fd4b9f8c26f4e6053899d68c4: > > ARM: dts: Add Odroid XU3 Lite support (2015-05-30 13:22:45 +0900) > > > Device Tree improvements for Exynos based boards: > 1. Refactor DT sources to label notation. All new Exynos boards follow >this convention so only old DTS are changed: Exynos4 family, Exynos5 >and s3c2416. >This convention reduces duplication of addresses in nodes >and reduces possible mistakes when overriding nodes. > 2. Switch LEDs on Odroid XU3 to PWM control. > 3. Add nodes for JPEG codec on Exynos542x. > 4. Enable wake alarm on Odroid XU3. > 5. Add support for new board: Odroid XU3 Lite. The board is actually >very similar to existing Odroid XU3. > > > Andrzej Pietrasiewicz (1): > ARM: dts: exynos5420: add nodes for jpeg codec > > Krzysztof Kozlowski (26): > ARM: dts: Add labels to exynos4 nodes > ARM: dts: Use labels for overriding nodes in exynos4210 > ARM: dts: Use labels for overriding nodes in exynos4210-origen > ARM: dts: Use labels for overriding nodes in exynos4210-smdkv310 > ARM: dts: Use labels for overriding nodes in exynos4210-trats > ARM: dts: Use labels for overriding nodes in exynos4212 > ARM: dts: Use labels for overriding nodes in exynos4x12 > ARM: dts: Use labels for overriding nodes in exynos4412 > ARM: dts: Use labels for overriding nodes in exynos4412-odroid > ARM: dts: Use labels for overriding nodes in exynos4412-smdk4412 > ARM: dts: Use labels for overriding nodes in exynos4412-trats2 > ARM: dts: Use labels for overriding nodes in exynos4412-origen > ARM: dts: Use labels for overriding nodes in exynos4412-tiny4412 > ARM: dts: Add labels to exynos5 nodes > ARM: dts: Use labels for overriding nodes in exynos5250 > ARM: dts: Remove duplicated I2C7 nodes in exynos5250-snow > ARM: dts: Use labels for overriding nodes in exynos5420-arndale-octa > ARM: dts: Use labels for overriding nodes in exynos542x > ARM: dts: Use labels for overriding nodes in exynos5420-smdk5420 > ARM: dts: Use labels for overriding nodes in exynos5440 boards > ARM: dts: Use labels for overriding nodes in exynos5422-odroidxu3 > ARM: dts: s3c2416: Add labels to S3C2416 nodes > ARM: dts: s3c2416: Use labels for overriding nodes in SMDK2416 > ARM: dts: odroidxu3: Enable wake alarm of S2MPS11 RTC > of: Add vendor prefix for Hardkernel > ARM: dts: Add Odroid XU3 Lite support > > Peter Chubb (1): > ARM: dts: exynos5422-odroidxu3: Hook up PWM and use it for LEDs > > .../devicetree/bindings/vendor-prefixes.txt|1 + > arch/arm/boot/dts/Makefile |1 + > arch/arm/boot/dts/exynos4.dtsi | 22 +- > arch/arm/boot/dts/exynos4210-origen.dts| 418 +++--- > arch/arm/boot/dts/exynos4210-smdkv310.dts | 280 ++-- > arch/arm/boot/dts/exynos4210-trats.dts | 592 - > arch/arm/boot/dts/exynos4210.dtsi | 49 +- > arch/arm/boot/dts/exynos4212.dtsi | 12 +- > arch/arm/boot/dts/exynos4412-odroid-common.dtsi| 732 +-- > arch/arm/boot/dts/exynos4412-odroidx.dts | 16 +- > arch/arm/boot/dts/exynos4412-origen.dts| 892 ++--- > arch/arm/boot/dts/exynos4412-smdk4412.dts | 210 +-- > arch/arm/boot/dts/exynos4412-tiny4412.dts | 54 +- > arch/arm/boot/dts/exynos4412-trats2.dts| 1332 ++-- > arch/arm/boot/dts/exynos4412.dtsi | 20 +- > arch/arm/boot/dts/exynos4x12-pinctrl.dtsi |8 +- > arch/arm/boot/dts/exynos4x12.dtsi | 218 ++-- > arch/arm/boot/dts/exynos5.dtsi |6 +- > arch/arm/boot/dts/exynos5250-snow.dts | 46 +- > arch/arm/boot/dts/exynos5250.dtsi | 82 +- > arch/arm/boot/dts/exynos5420-arndale-octa.dts | 634 +- > arch/arm/boot/dts/exynos5420-peach-pit.dts |2 +- > arch/arm/boot/dts/exynos5420-s
Re: [PATCH v4 0/8] ARM: dts: exynos5: labels for overriding nodes
On 05/17/15 17:26, Krzysztof Kozlowski wrote: > Hi, > > > Changes since v3 > > 1. Rebased on current Kukjin's for-next branch: >v4.1-rc3-34-gfcfae6b049cf > > Changes since v2 > > 1. New patch 8/8: ARM: dts: Use labels for overriding nodes >in exynos5422-odroidxu3 > 2. To avoid conflicts rebased on my "for-next" branch of >https://github.com/krzk/linux >The branch above contains some patches for Exynos5 boards >applied from LKML. > > Changes since v1 > > 1. Re-phrased the description (phandle->label). Suggested by Arnd. > > > Description > === > The label-based notation reduces possible mistakes when overriding > nodes by child DTSI and board files and reduces duplication > of addresses. > > The patchset refactors Exynos5 boards to use labels for overriding nodes. > > Tested by comparison of decompiled DTB for each commit. > Same, will sort out. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 00/13] ARM: dts: exynos4: labels for overriding nodes
On 05/17/15 17:09, Krzysztof Kozlowski wrote: > Hi, > Hi, > > Changes since v5 > > 1. Rebased on current Kukjin's for-next branch: >v4.1-rc3-34-gfcfae6b049cf > > Changes since v4 > > 1. Patch 1: Don't add labels in exynos4210-pinctrl.dtsi because >these are already defined in exynos4210.dtsi. > 2. Patch 9: Add ack from Eduardo Valentin. > > Changes since v3 > > 1. New patches (12 and 13) for Exynos4412 Origen and Tiny4412. > 2. Rebased on top of my DTS-for-next branch: >repo: https://github.com/krzk/linux/ >tag: samsung-dt-for-next-4.2-2 > > Changes since v2 > > 1. Fix typo in commit msg (lablels -> labels). > > Changes since v1 > > 1. Re-phrased the description (phandle->label). Suggested by Arnd. > > Description > === > > The label-based notation reduces possible mistakes when overriding > nodes by child DTSI and board files and reduces duplication > of addresses. > > The patchset refactors Exynos4 boards to use labels for overriding nodes. > > Tested by comparison of decompiled DTB for each commit. The output DTB > is the same. > Thanks for your resending. Looks good to me and I'll sort them out in this weekend. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ARM: dts: exynos4: Remove obsolete MIPI DPHY 'reg' property
On 05/21/15 16:23, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On Thu, May 21, 2015 at 4:18 AM, Krzysztof Kozlowski
> wrote:
>> Since e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
>> support for PMU regmap") the Exynos PMU driver provides regmap to access
>> the MIPI DPHY registers. The MIPI DPHY node uses a phandle to syscon to
>> get this regmap. The 'reg' field is obsolete.
>>
>> Signed-off-by: Krzysztof Kozlowski
>> ---
>> arch/arm/boot/dts/exynos4.dtsi | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>> index 1c74c1296ab7..6e7f0b4afa84 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -78,7 +78,6 @@
>>
>> mipi_phy: video-phy@10020710 {
>> compatible = "samsung,s5pv210-mipi-video-phy";
>> - reg = <0x10020710 8>;
>> #phy-cells = <1>;
>> syscon = <&pmu_system_controller>;
>> };
>
> Indeed, is even removed from the DT binding so this is clearly a left over.
>
> Reviewed-by: Javier Martinez Canillas
>
Thanks, applied this series.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/2] ARM: multi_v7_defconfig: Enable display on Trats2board
On 05/22/15 18:11, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/22/2015 02:48 AM, Krzysztof Kozlowski wrote: >> Enable the Exynos DSI and S6E8AA0 panel for full X11 display on Trats2. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm/configs/multi_v7_defconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/configs/multi_v7_defconfig >> b/arch/arm/configs/multi_v7_defconfig >> index 0848337a2a01..e9785020aab1 100644 >> --- a/arch/arm/configs/multi_v7_defconfig >> +++ b/arch/arm/configs/multi_v7_defconfig >> @@ -413,10 +413,12 @@ CONFIG_DRM=y >> CONFIG_DRM_PTN3460=m >> CONFIG_DRM_PS8622=m >> CONFIG_DRM_EXYNOS=m >> +CONFIG_DRM_EXYNOS_DSI=y >> CONFIG_DRM_EXYNOS_FIMD=y >> CONFIG_DRM_EXYNOS_HDMI=y >> CONFIG_DRM_RCAR_DU=m >> CONFIG_DRM_TEGRA=y >> +CONFIG_DRM_PANEL_S6E8AA0=m >> CONFIG_DRM_PANEL_SIMPLE=y >> CONFIG_FB_ARMCLCD=y >> CONFIG_FB_WM8505=y >> > > Reviewed-by: Javier Martinez Canillas > Looks good to me and this would be handled by arm-soc guys directly :-) Acked-by: Kukjin Kim Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ARM: exynos_defconfig: Enable display on Trats2 board
On 05/22/15 18:09, Javier Martinez Canillas wrote: > Hello Krzysztof, > Hi, > On 05/22/2015 02:48 AM, Krzysztof Kozlowski wrote: >> Enable the Exynos DSI and S6E8AA0 panel for full X11 display on Trats2. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm/configs/exynos_defconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/configs/exynos_defconfig >> b/arch/arm/configs/exynos_defconfig >> index d034c96c039b..e7ccec487422 100644 >> --- a/arch/arm/configs/exynos_defconfig >> +++ b/arch/arm/configs/exynos_defconfig >> @@ -135,9 +135,11 @@ CONFIG_DRM_BRIDGE=y >> CONFIG_DRM_PTN3460=y >> CONFIG_DRM_PS8622=y >> CONFIG_DRM_EXYNOS=y >> +CONFIG_DRM_EXYNOS_DSI=y >> CONFIG_DRM_EXYNOS_FIMD=y >> CONFIG_DRM_EXYNOS_DP=y >> CONFIG_DRM_PANEL=y >> +CONFIG_DRM_PANEL_S6E8AA0=y >> CONFIG_DRM_PANEL_SIMPLE=y >> CONFIG_FB=y >> CONFIG_FB_MODE_HELPERS=y >> > > Reviewed-by: Javier Martinez Canillas > Thanks, applied. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] ARM: EXYNOS: Improvements for 4.2, second try
On 05/19/15 15:21, Kukjin Kim wrote: > On 05/17/15 17:52, Krzysztof Kozlowski wrote: >> 2015-05-11 12:14 GMT+09:00 Krzysztof Kozlowski : >>> Dear Kukjin, >>> >>> Updated pull request, replacing also the usage of soc_is_exynos4() >>> with of_machine_is_compatible(). You requested this in comments >>> for "ARM: EXYNOS: Fix failed second suspend on Exynos4". >>> >>> This adds coupled cpuidle for Exynos3250 and improves the Exynos >>> code in few places. Everything for upcoming 4.2 merge window. >>> Description along with a tag. >>> >>> Best regards, >>> Krzysztof >>> >>> >>> The following changes since commit b82f3a05ff0b5eaf2c9900eeb34e58a6624db8d9: >>> >>> ARM: EXYNOS: Fix failed second suspend on Exynos4 (2015-05-11 11:03:09 >>> +0900) >>> >>> are available in the git repository at: >>> >>> https://github.com/krzk/linux.git tags/samsung-for-next-4.2-2 >>> >>> for you to fetch changes up to c91889378098ff0bb5fe6f422a3c0eb554b34930: >>> >>> ARM: plat-samsung: Constify platform_device_id (2015-05-11 11:05:31 +0900) >>> >>> >>> Extending cpuidle driver and improvements for Exynos based boards: >>> 1. Replace soc_is_exynos4() with of_machine_is_compatible(). >>> 2. Add missing return-value checks and of_node_put() for power domain >>>driver. >>> 3. Fix missing clk_prepare in S3C24XX ADC driver. >>> 4. Rework clock handling when switching power domains on/off. Instead >>>of settting fixed parent in DTS we grab the parent clock before >>>turning the domain off. >>> 5. Add coupled cpuidle support for Exynos3250 to an existing >>>cpuidle-exynos driver. As a result it enables AFTR mode >>>(ARM-Off Top-Running) to be used by default on Exynos3250 >>>without the need to hot unplug CPU1 first. >>> 6. Constify irq_domain_ops and platform_device_id. >> >> Dear Kukjin, >> >> Just humbly reminding - this stuff still waits for you :). >> > Sure, why not. I'll update it soon ;-) > Done, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: manual merge of the samsung tree with the arm-soc andat91 trees
On 05/21/15 10:20, Krzysztof Kozlowski wrote: > 2015-05-20 18:47 GMT+09:00 Geert Uytterhoeven : >> On Wed, May 20, 2015 at 11:16 AM, Alexandre Belloni >> wrote: >>> On 20/05/2015 at 09:35:36 +0900, Krzysztof Kozlowski wrote : 2015-05-20 9:27 GMT+09:00 Stephen Rothwell : > Today's linux-next merge of the samsung tree got a conflict in > arch/arm/configs/multi_v7_defconfig between various commits from the > arm-soc and at91 trees and various commits from the samsung tree. > > I fixed it up (see below) and can carry the fix as necessary (no action > is required). Hi, Thanks for the merge. The parts coming from samsung-soc related to manually toggling stuff (by me and Javier) look fine. The rest (coming from Kukjin's savedefconfig) I don't know - too much of them. >>> >>> Hum, last time I asked, we were not supposed to do a savedefconfig on >>> multi_v7... >> >> Yeah, IMHO it's something the arm-soc maintainers should do only right >> after rc1. >> >> Doing it at any other point in time may remove options that have just been >> added to multi_v7_defconfig by an arm-soc submaintainer, and that depend on >> a Kconfig change queued in another maintainer's for-next branch. > > It also depends on which tree and branch the savedefconfig was > performed. If on Linus' master then probably it is not a good idea at > any time. > >> Personally, I think no arm-soc submaintainer should touch multi_v7_defconfig, >> and all changes should be applied by the arm-soc maintainers. > > Actually Arnd suggested this: > https://lkml.org/lkml/2015/5/15/303 > [PATCH 0/9] multi_v7_defconfig: Enable options for Exynos Chromebooks > Thanks you guys. I've sent a pull-request for the update of multi_v7_defconfig just now. And IMHO need to keep it with savedefconfig from now on... - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] ARM: EXYNOS: Improvements for 4.2, second try
On 05/17/15 17:52, Krzysztof Kozlowski wrote: > 2015-05-11 12:14 GMT+09:00 Krzysztof Kozlowski : >> Dear Kukjin, >> >> Updated pull request, replacing also the usage of soc_is_exynos4() >> with of_machine_is_compatible(). You requested this in comments >> for "ARM: EXYNOS: Fix failed second suspend on Exynos4". >> >> This adds coupled cpuidle for Exynos3250 and improves the Exynos >> code in few places. Everything for upcoming 4.2 merge window. >> Description along with a tag. >> >> Best regards, >> Krzysztof >> >> >> The following changes since commit b82f3a05ff0b5eaf2c9900eeb34e58a6624db8d9: >> >> ARM: EXYNOS: Fix failed second suspend on Exynos4 (2015-05-11 11:03:09 >> +0900) >> >> are available in the git repository at: >> >> https://github.com/krzk/linux.git tags/samsung-for-next-4.2-2 >> >> for you to fetch changes up to c91889378098ff0bb5fe6f422a3c0eb554b34930: >> >> ARM: plat-samsung: Constify platform_device_id (2015-05-11 11:05:31 +0900) >> >> >> Extending cpuidle driver and improvements for Exynos based boards: >> 1. Replace soc_is_exynos4() with of_machine_is_compatible(). >> 2. Add missing return-value checks and of_node_put() for power domain >>driver. >> 3. Fix missing clk_prepare in S3C24XX ADC driver. >> 4. Rework clock handling when switching power domains on/off. Instead >>of settting fixed parent in DTS we grab the parent clock before >>turning the domain off. >> 5. Add coupled cpuidle support for Exynos3250 to an existing >>cpuidle-exynos driver. As a result it enables AFTR mode >>(ARM-Off Top-Running) to be used by default on Exynos3250 >>without the need to hot unplug CPU1 first. >> 6. Constify irq_domain_ops and platform_device_id. > > Dear Kukjin, > > Just humbly reminding - this stuff still waits for you :). > Sure, why not. I'll update it soon ;-) Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 3/4] ARM: multi_v7_defconfig: Enable TMU for Exynos
On 05/19/15 15:01, Krzysztof Kozlowski wrote: > 2015-05-19 14:57 GMT+09:00 Kukjin Kim : >> On 05/18/15 10:47, Krzysztof Kozlowski wrote: >>> From: Krzysztof Kozlowski >>> >>> Enable support for Thermal Monitoring Unit present on Exynos SoCs. This >>> allows detection of overheat and handling this gracefully. >>> >>> Signed-off-by: Krzysztof Kozlowski >> >> Krzysztof, you want to use gmail account on this, you used samsung >> accoung on 1st and 2nd patches though? > > Yes, that is correct. I know that it seems mixed up and sorry for the > confusion. > OK, I see. > I use the gmail account when I am developing at home to distinguish my > personal and company's rights. So in one patchset I got some old > patches done in company (@samsung.com) and newer one prepared during > my free time. > I've kept your origin email address. If any problems, please let me know. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/4] ARM: multi_v7_defconfig: Stuff for Exynos
On 05/18/15 16:03, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On Mon, May 18, 2015 at 3:47 AM, Krzysztof Kozlowski > wrote: >> Dear Kukjin, >> >> >> Changes since v1: >> = >> 1. Select drivers as modules, whenever possible. Suggested by Javier. >> 2. Patch 2: The I2C_GPIO is already enabled as module. >> >> >> Description >> === >> The patchset enables various config options on multi_v7 config >> for Exynos boards. >> >> Arnd suggested [0] that this can go through your tree. >> >> Patchset is rebased on next-20150515 and Javier's patchset [1] >> (to avoid conflicts around regulators and clocks). >> >> Please let me know if this should be rebased on other commit. >> >> [0] http://www.spinics.net/lists/kernel/msg1991518.html >> [1] http://www.spinics.net/lists/kernel/msg1990767.html >> >> >> Best regards, >> Krzysztof >> >> Krzysztof Kozlowski (4): >> ARM: multi_v7_defconfig: Enable CPU idle for Exynos >> ARM: multi_v7_defconfig: Enable PMIC and MUIC drivers for Exynos >> boards >> ARM: multi_v7_defconfig: Enable TMU for Exynos >> ARM: multi_v7_defconfig: Enable OHCI on Exynos >> >> arch/arm/configs/multi_v7_defconfig | 13 + >> 1 file changed, 13 insertions(+) >> > > For all the series: > > Reviewed-by: Javier Martinez Canillas > Applied, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 3/4] ARM: multi_v7_defconfig: Enable TMU for Exynos
On 05/18/15 10:47, Krzysztof Kozlowski wrote: > From: Krzysztof Kozlowski > > Enable support for Thermal Monitoring Unit present on Exynos SoCs. This > allows detection of overheat and handling this gracefully. > > Signed-off-by: Krzysztof Kozlowski Krzysztof, you want to use gmail account on this, you used samsung accoung on 1st and 2nd patches though? - Kukjin > --- > arch/arm/configs/multi_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/multi_v7_defconfig > b/arch/arm/configs/multi_v7_defconfig > index f09ae2089284..8fa7171b12f3 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -342,6 +342,7 @@ CONFIG_SENSORS_LM90=y > CONFIG_SENSORS_LM95245=y > CONFIG_THERMAL=y > CONFIG_CPU_THERMAL=y > +CONFIG_EXYNOS_THERMAL=m > CONFIG_RCAR_THERMAL=y > CONFIG_ARMADA_THERMAL=y > CONFIG_DAVINCI_WATCHDOG -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] ARM: EXYNOS: dts: Improvements for 4.2, second try
On 05/11/15 12:13, Krzysztof Kozlowski wrote: > Dear Kukjin, > > I gathered various improvements for upcoming 4.2 merge window. > Description along with a tag. > > Best regards, > Krzysztof > > > The following changes since commit 2495ae559826c60e3ccde9850e3b38815725b9c9: > > ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards > (2015-05-11 11:00:00 +0900) > > are available in the git repository at: > > https://github.com/krzk/linux.git tags/samsung-dt-for-next-4.2-2 > > for you to fetch changes up to c5f41228c9fad4c7343df8547b870766163b76dc: > > ARM: dts: exynos3250-rinato: add support for JPEG codec (2015-05-11 > 11:01:57 +0900) > Hi, I've applied all of changes you requested with sorting them out. Thanks and please test on your own boards with samsung's for-next then if anything, let us know. Note, I think re-post to use lables in dt would be better based on current for-next. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] ARM: dts: Add syscon property to the MIPI phy in exynos5420
On 05/15/15 22:22, Krzysztof Kozlowski wrote:
> 2015-05-14 21:40 GMT+09:00 Tomeu Vizoso :
>> Since e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by
>> adding support for PMU regmap") the syscon property is required in
>> samsung,s5pv210-mipi-video-phy nodes, but this DTS hadn't been updated
>> yet.
>>
>> Signed-off-by: Tomeu Vizoso
>> Reviewed-by: Javier Martinez Canillas
>> Cc: Sylwester Nawrocki
>> Cc: Krzysztof Kozłowski
>>
>> --
>
> Triple-dash please, because this won't be cut by "git am".
>
> Everything else looks fine, thank you.
> Reviewed-by: Krzysztof Kozlowski
>
Applied, thanks for you guys' effort.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/9] multi_v7_defconfig: Enable options for Exynos Chromebooks
On 05/15/15 21:00, Krzysztof Kozlowski wrote: > 2015-05-15 20:37 GMT+09:00 Arnd Bergmann : >> On Thursday 14 May 2015 17:40:07 Javier Martinez Canillas wrote: >>> Hello arm-soc maintainers, >>> >>> This series is an attempt to reduce the delta between exynos_defconfig >>> and multi_v7_defconfig. Primarily to enable the needed Kconfig symbols >>> to make all Exynos Chromebooks peripherals to be working when building >>> an image using the ARMv7 multi-platform default config. >>> >>> Since the policy is now to now enable as much as possible, I did build >>> as a module all the Kconfig symbols that were tristate and only enable >>> as built-in those that can't be a module because are boolean options. >>> >>> A nice side effect of this series is that I found that many drivers >>> were not working properly when built as a module because the modalias >>> information was not filled properly or at all. I've posted patches to >>> fix the issues I found when testing this series. >>> >>> The patches have been tested on an Exynos5250 Snow, Exynos5420 Peach >>> Pit and Exynos5800 Peach Pi Chromebooks but most config options will >>> be useful for others Exynos5 or other Samsung SoCs. >>> >>> The series is composed of the following patches that can be applied on >>> top of your next/defconfig branch [0]. >> >> Looks good to me. My preferred approach for merging would be to have >> Kukjin pick up these patches and send a pull request, along with other >> defconfig changes he might have for exynos. > OK, I'll in this weekend. > I have some other old patches in the same topic - related to important > stuff for Exynos boards. I'll rebase them and ask Kukjin for picking. > Yeah, OK. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] cpufreq: use generic cpufreq drivers forExynos4210platform
On 05/14/15 14:10, Viresh Kumar wrote: > On 14-05-15, 13:07, Kukjin Kim wrote: >> On 05/13/15 23:08, Bartlomiej Zolnierkiewicz wrote: >>> >>> Hi, >>> >> Hi Bart, >> >>> On Friday, April 03, 2015 06:43:43 PM Bartlomiej Zolnierkiewicz wrote: >>>> Hi, >>>> >>>> This patch series removes the use of Exynos4210 specific support >>>> from cpufreq-exynos driver and enables the use of cpufreq-dt driver >>>> for this platform. >>> >>> Gentle Ping. Mike/Kukjin/Viresh could you please review/ack relevant >>> patches (patches #1-3 are for clock subsystem, patches #4-5 for Exynos >>> mach/dts and patch #6 is for cpufreq subsystem)? > > Sorry I thought I already Acked an older version of this set and so > didn't went for it again. Done now. > >> Yes, I totally agreed with this patches for arch side changes and this >> approach when Thomas posted. >> >>> Also what is your >>> preferred way to upstream them (patches are not independent so it would >>> be best to merge them through one tree, otherwise synchronization of >>> git pulls between different subsystem trees will be needed)? >>> >> I can provide topic branch for arch side changes even it is small. I >> think once Viresh and Mike make each topic branch based on -rc or the >> smallest changes from each subsystem then I could handle this series or >> Viresh or Mike need to handle this series with merging each topic >> branches in subsystem. I'm fine either way. >> >> Viresh and Mike, how do you think about that? > > For cpufreq subsystem changes, you can take them in your tree. > Hi Viresh, OK, I will take the cpufreq changes with your ack. Thanks for your confirmation. Hi Mike and Sylwester, How can we handle this series well without any problems? hmm... >>> I'm still hoping that this patchset will make it into v4.2 as there are >>> no known issues with it (except minor coding nit for patch #5)... >>> >> Sure, why not :-) > > One thing that looked wrong to me is the email id of Thomas.. > I believe he has already left Samsung and his id wouldn't exist > anymore. Right ? > > Then I wouldn't recommend something that doesn't exist to get merged > now. Probably use another email id of his. As Bart replied, Thomas is still Samsung guy, maybe you meant Tomasz? he moved to another company last year. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] MAINTAINERS: ARM: EXYNOS: Add Krzysztof Kozlowski asco-maintainer
On 05/14/15 21:15, Krzysztof Kozlowski wrote: > Add Krzysztof Kozlowski as a co-maintainer of Samsung Exynos ARM > architecture to review the patches. Patches will go as usual - picked up > by Kukjin Kim. > Hi Krzysztof, Sorry, I don't agree with this patch because you can review any exynos patches without maintainer title. And I can focus on the maintainer'r role more than now because of change of role ;-) Of course your review would be helpful to me. Thanks, Kukjin > Cc: Russell King > Cc: Kukjin Kim > Cc: Kevin Hilman > Cc: Arnd Bergmann > Cc: Olof Johansson > Cc: linux-samsung-...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Signed-off-by: Krzysztof Kozlowski > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 2dc517cd4835..a3cb77c0ae23 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1380,6 +1380,7 @@ N: rockchip > > ARM/SAMSUNG EXYNOS ARM ARCHITECTURES > M: Kukjin Kim > +M: Krzysztof Kozlowski > L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) > L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers) > S: Maintained -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] cpufreq: use generic cpufreq drivers for Exynos4210platform
On 05/13/15 23:08, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
Hi Bart,
> On Friday, April 03, 2015 06:43:43 PM Bartlomiej Zolnierkiewicz wrote:
>> Hi,
>>
>> This patch series removes the use of Exynos4210 specific support
>> from cpufreq-exynos driver and enables the use of cpufreq-dt driver
>> for this platform.
>
> Gentle Ping. Mike/Kukjin/Viresh could you please review/ack relevant
> patches (patches #1-3 are for clock subsystem, patches #4-5 for Exynos
> mach/dts and patch #6 is for cpufreq subsystem)?
Yes, I totally agreed with this patches for arch side changes and this
approach when Thomas posted.
> Also what is your
> preferred way to upstream them (patches are not independent so it would
> be best to merge them through one tree, otherwise synchronization of
> git pulls between different subsystem trees will be needed)?
>
I can provide topic branch for arch side changes even it is small. I
think once Viresh and Mike make each topic branch based on -rc or the
smallest changes from each subsystem then I could handle this series or
Viresh or Mike need to handle this series with merging each topic
branches in subsystem. I'm fine either way.
Viresh and Mike, how do you think about that?
> I'm still hoping that this patchset will make it into v4.2 as there are
> no known issues with it (except minor coding nit for patch #5)...
>
Sure, why not :-)
Thanks,
Kukjin
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
>> It consists of a modified "[PATCH v12 0/6] cpufreq: use generic
>> cpufreq drivers for exynos platforms" [1] patch series from Thomas
>> Abraham. As there have not been updates of this patchset since
>> November 2014 I decided to dust it off myself. I updated Thomas'
>> patchset to current kernels, fixed bugs that I noticed and removed
>> non-Exynos4210 support for now (to speed up inclusion in upstream
>> kernel). Since some modifications were not trivial I dropped all
>> Reviewed-by:, Tested-by: and Acked-by: tags. Please review/test
>> this patchset and reply with revelant tag (Thank You!). I also
>> plan to work on Exynos4x12 support next (which was missing in
>> the original patchset) and then on Exynos5250/Exynos5420 one.
>>
>> This patch series has been tested on Exynos4210 based Origen and
>> Trats boards.
>>
>> Depends on:
>> - next-20150330 branch of linux-next kernel tree
>> (mfd tree contains a crucial fix for MAX8997 PMIC support)
>> - "[PATCH] clk: samsung: exynos4: Disable ARMCLK down feature on
>> Exynos4210 SoC" [2]
>>
>> [1] https://www.marc.info/?l=linux-arm-kernel&m=141657611003803&w=2
>> [2] https://lkml.org/lkml/2015/3/27/568
>>
>> Changes over Thomas' code:
>> - fixed issue with wrong dividers being setup by Common Clock Framework
>> (by an addition of CLK_RECALC_NEW_RATES clock flag to mout_apll clock,
>> without this change cpufreq-dt driver showed ~10 mA larger energy
>> consumption when compared to cpufreq-exynos one when "performance"
>> cpufreq governor was used on Exynos4210 SoC based Origen board), this
>> was probably meant to be workarounded by use of CLK_GET_RATE_NOCACHE
>> and CLK_DIVIDER_READ_ONLY clock flags in the original patchset (in
>> "[PATCH v12 6/6] clk: samsung: remove unused clock aliases and update
>> clock flags") but using these flags is not sufficient to fix the issue
>> observed
>> - fixed issue with setting lower dividers before the parent clock speed
>> was lowered (the issue resulted in lockup on Exynos4210 SoC based
>> Origen board when "ondemand" cpufreq governor was stress tested)
>> - fixed missing spin_unlock on error in exynos_cpuclk_post_rate_change()
>> problem by moving cfg_data search outside of the spin locked area
>> - removed leftover kfree() in exynos_register_cpu_clock() that could
>> result in dereferencing the NULL pointer on error
>> - moved spin_lock earlier in exynos_cpuclk_pre_rate_change() to cover
>> reading of E4210_SRC_CPU and E4210_DIV_CPU1 registers
>> - added missing "last chance" checks to wait_until_divider_stable() and
>> wait_until_mux_stable() (needed in case that IRQ handling took long
>> time to proceed and resulted in function printing incorrect error
>> message about timeout)
>> - moved E4210_CPU_DIV[0,1]() macros just before their only users,
>> this resulted in moving them from patch #2 to patch #3/6 ("clk:
>> samsung: exynos4: add cpu clock configuration data and instantiate
>> cpu clock")
>> - added my Copyrights to drivers/clk/samsung/clk-cpu.c
>> - updated exynos-cpufreq.[c,h]
>> - removed non-Exynos4210 support for now
>> - dropped "[PATCH v12 6/6] clk: samsung: remove unused clock aliases and
>> update clock flags" altogether for now
>>
>> Best regards,
>> --
>> Bartlomiej Zolnierkiewicz
>> Samsung R&D Institute Poland
>> Samsung Electronics
>>
>>
>> Bartlomiej Zolnierkiewicz (1):
>> clk: add CLK_RECALC_NEW_RATES clock flag for Exynos cpu clock support
>>
>> Thomas Abraham (5):
>
Re: [PATCH v3 2/2] ARM: EXYNOS: Use of_machine_is_compatible instead ofsoc_is_exynos4
On 05/11/15 10:27, Krzysztof Kozlowski wrote:
> of_machine_is_compatible() seems to be preferred over soc_is_exynos4().
>
> Signed-off-by: Krzysztof Kozlowski
>
> ---
> Changes since v2:
> 1. New patch, requested by Kukjin Kim.
> ---
> arch/arm/mach-exynos/exynos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> index c3bfbba3006d..5917a30eee33 100644
> --- a/arch/arm/mach-exynos/exynos.c
> +++ b/arch/arm/mach-exynos/exynos.c
> @@ -179,7 +179,7 @@ static void __init exynos_init_io(void)
> */
> void exynos_set_delayed_reset_assertion(bool enable)
> {
> - if (soc_is_exynos4()) {
> + if (of_machine_is_compatible("samsung,exynos4")) {
> unsigned int tmp, core_id;
>
> for (core_id = 0; core_id < num_possible_cpus(); core_id++) {
Maybe we need to change the compatible for exynos4415.dtsi? because no
exynos4 in the compatible...Applied, anyway.
Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 03/13] ARM: dts: exynos4: Use labels for overriding nodes in Exynos4210 Origen
On 05/11/15 22:42, Krzysztof Kozlowski wrote:
> Usage of labels instead of full paths reduces possible mistakes when
> overriding nodes.
>
In case of this changes, I have no objection.
But I can't see the 'codec' node you deleted in this patch?
And if possible, can you please put the labels in alphabetically when
you create this patch again? so that we could find the labels easily...
- Kukjin
> Signed-off-by: Krzysztof Kozlowski
> ---
> arch/arm/boot/dts/exynos4210-origen.dts | 418
>
> 1 file changed, 209 insertions(+), 209 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
> b/arch/arm/boot/dts/exynos4210-origen.dts
> index b81146141402..e0abfc3324d1 100644
> --- a/arch/arm/boot/dts/exynos4210-origen.dts
> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> @@ -50,209 +50,6 @@
> };
> };
>
> - watchdog@1006 {
> - status = "okay";
> - };
> -
> - rtc@1007 {
> - status = "okay";
> - };
> -
> - tmu@100C {
> - status = "okay";
> - };
> -
> - sdhci@1253 {
> - bus-width = <4>;
> - pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sd2_cd>;
> - pinctrl-names = "default";
> - vmmc-supply = <&mmc_reg>;
> - status = "okay";
> - };
> -
> - sdhci@1251 {
> - bus-width = <4>;
> - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_cd>;
> - pinctrl-names = "default";
> - vmmc-supply = <&mmc_reg>;
> - status = "okay";
> - };
> -
> - g2d@1280 {
> - status = "okay";
> - };
> -
> - codec@1340 {
> - samsung,mfc-r = <0x4300 0x80>;
> - samsung,mfc-l = <0x5100 0x80>;
> - status = "okay";
> - };
> -
> - serial@1380 {
> - status = "okay";
> - };
> -
> - serial@1381 {
> - status = "okay";
> - };
> -
> - serial@1382 {
> - status = "okay";
> - };
> -
> - serial@1383 {
> - status = "okay";
> - };
> -
> - i2c@1386 {
> - status = "okay";
> - samsung,i2c-sda-delay = <100>;
> - samsung,i2c-max-bus-freq = <2>;
> - pinctrl-0 = <&i2c0_bus>;
> - pinctrl-names = "default";
> -
> - max8997_pmic@66 {
> - compatible = "maxim,max8997-pmic";
> - reg = <0x66>;
> - interrupt-parent = <&gpx0>;
> - interrupts = <4 0>, <3 0>;
> -
> - max8997,pmic-buck1-dvs-voltage = <135>;
> - max8997,pmic-buck2-dvs-voltage = <110>;
> - max8997,pmic-buck5-dvs-voltage = <120>;
> -
> - regulators {
> - ldo1_reg: LDO1 {
> - regulator-name = "VDD_ABB_3.3V";
> - regulator-min-microvolt = <330>;
> - regulator-max-microvolt = <330>;
> - };
> -
> - ldo2_reg: LDO2 {
> - regulator-name = "VDD_ALIVE_1.1V";
> - regulator-min-microvolt = <110>;
> - regulator-max-microvolt = <110>;
> - regulator-always-on;
> - };
> -
> - ldo3_reg: LDO3 {
> - regulator-name = "VMIPI_1.1V";
> - regulator-min-microvolt = <110>;
> - regulator-max-microvolt = <110>;
> - };
> -
> - ldo4_reg: LDO4 {
> - regulator-name = "VDD_RTC_1.8V";
> - regulator-min-microvolt = <180>;
> - regulator-max-microvolt = <180>;
> - regulator-always-on;
> - };
> -
> - ldo6_reg: LDO6 {
> - regulator-name = "VMIPI_1.8V";
> - regulator-min-microvolt = <180>;
> - regulator-max-microvolt = <180>;
> - regulator-always-on;
> - };
> -
> - ldo7_reg: LDO7 {
> - regulator-name = "VDD_AUD_1.8V";
> - regulator-min-microvolt = <180>;
> - regulator-max-microvolt = <180>;
> - };
> -
> - ldo8
Re: [PATCH v4 02/13] ARM: dts: exynos4: Use labels for overriding nodesin Exynos4210
On 05/11/15 22:42, Krzysztof Kozlowski wrote:
> Usage of labels instead of full paths reduces possible mistakes when
> overriding nodes.
>
Well, I'm not sure what kind of the possible mistakes you mentioned...?
I don't think we need to use the label for gic, combiner.
- Kukjin
> Signed-off-by: Krzysztof Kozlowski
> ---
> arch/arm/boot/dts/exynos4210.dtsi | 43
> +++
> 1 file changed, 21 insertions(+), 22 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210.dtsi
> b/arch/arm/boot/dts/exynos4210.dtsi
> index 76b84852f29c..a9a55304e31a 100644
> --- a/arch/arm/boot/dts/exynos4210.dtsi
> +++ b/arch/arm/boot/dts/exynos4210.dtsi
> @@ -52,16 +52,6 @@
> };
> };
>
> - pmu_system_controller: system-controller@1002 {
> - clock-names = "clkout0", "clkout1", "clkout2", "clkout3",
> - "clkout4", "clkout8", "clkout9";
> - clocks = <&clock CLK_OUT_DMC>, <&clock CLK_OUT_TOP>,
> - <&clock CLK_OUT_LEFTBUS>, <&clock CLK_OUT_RIGHTBUS>,
> - <&clock CLK_OUT_CPU>, <&clock CLK_XXTI>,
> - <&clock CLK_XUSBXTI>;
> - #clock-cells = <1>;
> - };
> -
> sysram: sysram@0202 {
> compatible = "mmio-sram";
> reg = <0x0202 0x2>;
> @@ -95,18 +85,6 @@
> arm,data-latency = <2 2 1>;
> };
>
> - gic: interrupt-controller@1049 {
> - cpu-offset = <0x8000>;
> - };
> -
> - combiner: interrupt-controller@1044 {
> - samsung,combiner-nr = <16>;
> - interrupts = <0 0 0>, <0 1 0>, <0 2 0>, <0 3 0>,
> - <0 4 0>, <0 5 0>, <0 6 0>, <0 7 0>,
> - <0 8 0>, <0 9 0>, <0 10 0>, <0 11 0>,
> - <0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>;
> - };
> -
> mct: mct@1005 {
> compatible = "samsung,exynos4210-mct";
> reg = <0x1005 0x800>;
> @@ -245,3 +223,24 @@
> status = "disabled";
> };
> };
> +
> +&gic {
> + cpu-offset = <0x8000>;
> +};
> +
> +&combiner {
> + samsung,combiner-nr = <16>;
> + interrupts = <0 0 0>, <0 1 0>, <0 2 0>, <0 3 0>,
> + <0 4 0>, <0 5 0>, <0 6 0>, <0 7 0>,
> + <0 8 0>, <0 9 0>, <0 10 0>, <0 11 0>,
> + <0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>;
> +};
> +
> +&pmu_system_controller {
> + clock-names = "clkout0", "clkout1", "clkout2", "clkout3",
> + "clkout4", "clkout8", "clkout9";
> + clocks = <&clock CLK_OUT_DMC>, <&clock CLK_OUT_TOP>,
> + <&clock CLK_OUT_LEFTBUS>, <&clock CLK_OUT_RIGHTBUS>,
> + <&clock CLK_OUT_CPU>, <&clock CLK_XXTI>, <&clock CLK_XUSBXTI>;
> + #clock-cells = <1>;
> +};
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 01/13] ARM: dts: Add labels to Exynos4 nodes
On 05/11/15 22:42, Krzysztof Kozlowski wrote:
> Add new labels to certain nodes so they could be easily referenced by
> Exynos4 board DTS files.
>
> Signed-off-by: Krzysztof Kozlowski
> ---
> arch/arm/boot/dts/exynos4.dtsi| 22 +++---
> arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 6 +++---
> arch/arm/boot/dts/exynos4210.dtsi | 6 +++---
> arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 8
> arch/arm/boot/dts/exynos4x12.dtsi | 2 +-
> 5 files changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 1c74c1296ab7..0ec292d25b6e 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
[...]
> diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> index a7c212891674..4704e7bb2628 100644
> --- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> @@ -15,7 +15,7 @@
> */
>
> / {
> - pinctrl@1140 {
> + pinctrl_0: pinctrl@1140 {
> gpa0: gpa0 {
> gpio-controller;
> #gpio-cells = <2>;
> @@ -421,7 +421,7 @@
> };
> };
>
> - pinctrl@1100 {
> + pinctrl_1: pinctrl@1100 {
> gpj0: gpj0 {
> gpio-controller;
> #gpio-cells = <2>;
> @@ -822,7 +822,7 @@
> };
> };
>
> - pinctrl@0386 {
> + pinctrl_3: pinctrl@0386 {
Maybe,
+ pinctrl_2: pinctrl@0386 { ?
> gpz: gpz {
> gpio-controller;
> #gpio-cells = <2>;
[...]
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: EXYNOS: Fix dereference of ERR_PTR returned byof_genpd_get_from_provider
On 05/13/15 12:17, Krzysztof Kozlowski wrote:
> ERR_PTR was dereferenced during sub domain parsing, if parent domain
> could not be obtained (because of invalid phandle or deferred
> registration of parent domain).
>
> The Exynos power domain code checked whether
> of_genpd_get_from_provider() returned NULL and in that case it skipped
> that power domain node. However this function returns ERR_PTR or valid
> pointer, not NULL.
>
> Signed-off-by: Krzysztof Kozlowski
> Cc:
Maybe [4.0+]? but as you mentioned this patch has a dependency with
Patch "ARM: EXYNOS: Add missing of_node_put() when parsing power domain"
and it means this cannot be applied into stable tree...
So I'll apply this patch firstly then please re-submit them I've missed
before based on samsung tree. I think, it would be better...
> Fixes: 0f7807518fe1 ("ARM: EXYNOS: add support for sub-power domains")
>
> ---
>
> The patchset is rebased on top of my fixes for pm_domains.c to avoid the
> conflicts:
> https://lkml.org/lkml/2015/3/27/321
> ---
> arch/arm/mach-exynos/pm_domains.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/pm_domains.c
> b/arch/arm/mach-exynos/pm_domains.c
> index 1a90c5da2fd7..440324c94d28 100644
> --- a/arch/arm/mach-exynos/pm_domains.c
> +++ b/arch/arm/mach-exynos/pm_domains.c
> @@ -209,7 +209,7 @@ no_clk:
> args.np = np;
> args.args_count = 0;
> child_domain = of_genpd_get_from_provider(&args);
> - if (!child_domain)
> + if (IS_ERR(child_domain))
> goto next_pd;
>
> if (of_parse_phandle_with_args(np, "power-domains",
> @@ -217,7 +217,7 @@ no_clk:
> goto next_pd;
>
> parent_domain = of_genpd_get_from_provider(&args);
> - if (!parent_domain)
> + if (IS_ERR(parent_domain))
> goto next_pd;
>
> if (pm_genpd_add_subdomain(parent_domain, child_domain))
Applied into fixes with resolving conflict.
Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
