Re: [PATCH] MIPS: fix tc_id calculation

2012-07-28 Thread RongQing Li
Any advice

2012/7/2  :
> From: RongQing.Li 
>
> Now the tc_id is:
>   (read_c0_tcbind() >> TCBIND_CURTC_SHIFT) & TCBIND_CURTC;
> After substitute macro:
>   (read_c0_tcbind() >> 21) & ((0xff) << 21)
> It should be:
>   (read_c0_tcbind() & ((0xff)<< 21)) >>21
>
> Signed-off-by: RongQing.Li 
> ---
>  arch/mips/kernel/smp-cmp.c |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/kernel/smp-cmp.c b/arch/mips/kernel/smp-cmp.c
> index e7e03ec..afc379c 100644
> --- a/arch/mips/kernel/smp-cmp.c
> +++ b/arch/mips/kernel/smp-cmp.c
> @@ -102,7 +102,7 @@ static void cmp_init_secondary(void)
> c->vpe_id = (read_c0_tcbind() >> TCBIND_CURVPE_SHIFT) & TCBIND_CURVPE;
>  #endif
>  #ifdef CONFIG_MIPS_MT_SMTC
> -   c->tc_id  = (read_c0_tcbind() >> TCBIND_CURTC_SHIFT) & TCBIND_CURTC;
> +   c->tc_id  = (read_c0_tcbind() & TCBIND_CURTC) >> TCBIND_CURTC_SHIFT;
>  #endif
>  }
>
> --
> 1.7.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] MIPS: fix tc_id calculation

2012-07-28 Thread RongQing Li
Any advice

2012/7/2  roy.qing...@gmail.com:
 From: RongQing.Li roy.qing...@gmail.com

 Now the tc_id is:
   (read_c0_tcbind()  TCBIND_CURTC_SHIFT)  TCBIND_CURTC;
 After substitute macro:
   (read_c0_tcbind()  21)  ((0xff)  21)
 It should be:
   (read_c0_tcbind()  ((0xff) 21)) 21

 Signed-off-by: RongQing.Li roy.qing...@gmail.com
 ---
  arch/mips/kernel/smp-cmp.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

 diff --git a/arch/mips/kernel/smp-cmp.c b/arch/mips/kernel/smp-cmp.c
 index e7e03ec..afc379c 100644
 --- a/arch/mips/kernel/smp-cmp.c
 +++ b/arch/mips/kernel/smp-cmp.c
 @@ -102,7 +102,7 @@ static void cmp_init_secondary(void)
 c-vpe_id = (read_c0_tcbind()  TCBIND_CURVPE_SHIFT)  TCBIND_CURVPE;
  #endif
  #ifdef CONFIG_MIPS_MT_SMTC
 -   c-tc_id  = (read_c0_tcbind()  TCBIND_CURTC_SHIFT)  TCBIND_CURTC;
 +   c-tc_id  = (read_c0_tcbind()  TCBIND_CURTC)  TCBIND_CURTC_SHIFT;
  #endif
  }

 --
 1.7.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/