Re: [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM
On 4/5/21 5:30 AM, Greg KH wrote: On Sun, Apr 04, 2021 at 10:20:26AM -0500, Dinh Nguyen wrote: On 4/4/21 9:08 AM, Greg KH wrote: On Sun, Apr 04, 2021 at 07:46:09AM -0500, Dinh Nguyen wrote: From: Krzysztof Kozlowski The Stratix10 service layer and RCU drivers are useful only on Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM fails: drivers/firmware/stratix10-rsu.c: In function 'rsu_status_callback': include/linux/compiler_types.h:320:38: error: call to '__compiletime_assert_179' declared with attribute error: FIELD_GET: type of reg too small for mask _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ... drivers/firmware/stratix10-rsu.c:96:26: note: in expansion of macro 'FIELD_GET' priv->status.version = FIELD_GET(RSU_VERSION_MASK, Fixes: 4483397b0353 ("ARM: socfpga: drop ARCH_SOCFPGA") Where is this commit id? I don't see it in Linus's tree, is it somewhere else? It's in the for-next branch in the soc tree. This patch fixes a patch that was just recently submitted by Krzysztof. Then it needs to go through that tree, while you sent it "To:" me, and I can't do anything with it at the moment :( Ah okay, got it, thanks! Dinh
Re: [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM
On Sun, Apr 04, 2021 at 10:20:26AM -0500, Dinh Nguyen wrote: > > > On 4/4/21 9:08 AM, Greg KH wrote: > > On Sun, Apr 04, 2021 at 07:46:09AM -0500, Dinh Nguyen wrote: > > > From: Krzysztof Kozlowski > > > > > > The Stratix10 service layer and RCU drivers are useful only on > > > Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM > > > fails: > > > > > >drivers/firmware/stratix10-rsu.c: In function 'rsu_status_callback': > > >include/linux/compiler_types.h:320:38: error: call to > > > '__compiletime_assert_179' > > > declared with attribute error: FIELD_GET: type of reg too small for > > > mask > > > _compiletime_assert(condition, msg, __compiletime_assert_, > > > __COUNTER__) > > >... > > >drivers/firmware/stratix10-rsu.c:96:26: note: in expansion of macro > > > 'FIELD_GET' > > > priv->status.version = FIELD_GET(RSU_VERSION_MASK, > > > > > > Fixes: 4483397b0353 ("ARM: socfpga: drop ARCH_SOCFPGA") > > > > Where is this commit id? I don't see it in Linus's tree, is it > > somewhere else? > > > > It's in the for-next branch in the soc tree. This patch fixes a patch that > was just recently submitted by Krzysztof. Then it needs to go through that tree, while you sent it "To:" me, and I can't do anything with it at the moment :( thanks, greg k-h
Re: [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM
On 4/4/21 9:08 AM, Greg KH wrote: On Sun, Apr 04, 2021 at 07:46:09AM -0500, Dinh Nguyen wrote: From: Krzysztof Kozlowski The Stratix10 service layer and RCU drivers are useful only on Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM fails: drivers/firmware/stratix10-rsu.c: In function 'rsu_status_callback': include/linux/compiler_types.h:320:38: error: call to '__compiletime_assert_179' declared with attribute error: FIELD_GET: type of reg too small for mask _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ... drivers/firmware/stratix10-rsu.c:96:26: note: in expansion of macro 'FIELD_GET' priv->status.version = FIELD_GET(RSU_VERSION_MASK, Fixes: 4483397b0353 ("ARM: socfpga: drop ARCH_SOCFPGA") Where is this commit id? I don't see it in Linus's tree, is it somewhere else? It's in the for-next branch in the soc tree. This patch fixes a patch that was just recently submitted by Krzysztof. Dinh
Re: [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM
On Sun, Apr 04, 2021 at 07:46:09AM -0500, Dinh Nguyen wrote: > From: Krzysztof Kozlowski > > The Stratix10 service layer and RCU drivers are useful only on > Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM > fails: > > drivers/firmware/stratix10-rsu.c: In function 'rsu_status_callback': > include/linux/compiler_types.h:320:38: error: call to > '__compiletime_assert_179' > declared with attribute error: FIELD_GET: type of reg too small for mask > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ... > drivers/firmware/stratix10-rsu.c:96:26: note: in expansion of macro > 'FIELD_GET' > priv->status.version = FIELD_GET(RSU_VERSION_MASK, > > Fixes: 4483397b0353 ("ARM: socfpga: drop ARCH_SOCFPGA") Where is this commit id? I don't see it in Linus's tree, is it somewhere else? thanks, greg k-h
[PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM
From: Krzysztof Kozlowski The Stratix10 service layer and RCU drivers are useful only on Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM fails: drivers/firmware/stratix10-rsu.c: In function 'rsu_status_callback': include/linux/compiler_types.h:320:38: error: call to '__compiletime_assert_179' declared with attribute error: FIELD_GET: type of reg too small for mask _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ... drivers/firmware/stratix10-rsu.c:96:26: note: in expansion of macro 'FIELD_GET' priv->status.version = FIELD_GET(RSU_VERSION_MASK, Fixes: 4483397b0353 ("ARM: socfpga: drop ARCH_SOCFPGA") Signed-off-by: Krzysztof Kozlowski Reported-by: kernel test robot Acked-by: Richard Gong Signed-off-by: Dinh Nguyen --- v2: add Fixes tag --- drivers/firmware/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index 6a4e882e448d..08bd4d01fb04 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig @@ -206,7 +206,7 @@ config FW_CFG_SYSFS_CMDLINE config INTEL_STRATIX10_SERVICE tristate "Intel Stratix10 Service Layer" - depends on ARCH_INTEL_SOCFPGA && HAVE_ARM_SMCCC + depends on ARCH_INTEL_SOCFPGA && ARM64 && HAVE_ARM_SMCCC default n help Intel Stratix10 service layer runs at privileged exception level, -- 2.25.1