Re: [PATCH] davinci: fix return value check by using IS_ERR in tnetv107x_devices_init()

[Sekhar Nori]

Hi Wei,

On 9/21/2012 11:42 AM, Wei Yongjun wrote:
> From: Wei Yongjun 
> 
> In case of error, the function clk_get() returns ERR_PTR() not
> NULL pointer. The NULL test in the error handling should be
> replaced with IS_ERR().
> 
> dpatch engine is used to auto generated this patch.
> (https://github.com/weiyj/dpatch)
> 
> Signed-off-by: Wei Yongjun 

Queuing this for v3.8. While committing, I added ARM: prefix to the
subject line as is the norm with all arch/arm/* patches.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] davinci: fix return value check by using IS_ERR in tnetv107x_devices_init()

[Wei Yongjun]

From: Wei Yongjun 

In case of error, the function clk_get() returns ERR_PTR() not
NULL pointer. The NULL test in the error handling should be
replaced with IS_ERR().

dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun 
---
 arch/arm/mach-davinci/devices-tnetv107x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-davinci/devices-tnetv107x.c 
b/arch/arm/mach-davinci/devices-tnetv107x.c
index 29b17f7..773ab07 100644
--- a/arch/arm/mach-davinci/devices-tnetv107x.c
+++ b/arch/arm/mach-davinci/devices-tnetv107x.c
@@ -374,7 +374,7 @@ void __init tnetv107x_devices_init(struct 
tnetv107x_device_info *info)
 * complete sample conversion in time.
 */
tsc_clk = clk_get(NULL, "sys_tsc_clk");
-   if (tsc_clk) {
+   if (!IS_ERR(tsc_clk)) {
error = clk_set_rate(tsc_clk, 500);
WARN_ON(error < 0);
clk_put(tsc_clk);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/