Re: [PATCH] perf: Skip running the feature tests for 'make install-doc'
Em Wed, Aug 10, 2016 at 04:49:08PM +0800, Rui Teng escreveu: > It is a requirement from the perf todo list: > The feature tests should be performed only when a file that needs those tests, > or at least only when some .c or .h file will be rebuilt > An initial step would be for 'make install-doc' not to run the feature > tests, > there it is not needed at all. Thanks for working on that! As soon as I push this out to Ingo I'll move that entry from the TODO to a DONE section, adding the URL to the cset where it was done. Now pick another one! :-) - Arnaldo > By adding 'install-doc' to the NON_CONFIG_TARGETS, it will skip running the > feature tests for such target. The Auto-detecting system features list will > not be displayed: > > $ make install-doc > BUILD: Doing 'make -j2' parallel build > SUBDIR Documentation > make[2]: Nothing to be done for 'install'. > > Signed-off-by: Rui Teng> --- > tools/perf/Makefile.perf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index 2d90875..9c1dac6 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -165,7 +165,7 @@ SUBCMD_DIR= $(srctree)/tools/lib/subcmd/ > # non-config cases > config := 1 > > -NON_CONFIG_TARGETS := clean TAGS tags cscope help > +NON_CONFIG_TARGETS := clean TAGS tags cscope help install-doc > > ifdef MAKECMDGOALS > ifeq ($(filter-out $(NON_CONFIG_TARGETS),$(MAKECMDGOALS)),) > -- > 2.7.4
Re: [PATCH] perf: Skip running the feature tests for 'make install-doc'
Em Wed, Aug 10, 2016 at 04:49:08PM +0800, Rui Teng escreveu: > It is a requirement from the perf todo list: > The feature tests should be performed only when a file that needs those tests, > or at least only when some .c or .h file will be rebuilt > An initial step would be for 'make install-doc' not to run the feature > tests, > there it is not needed at all. Thanks for working on that! As soon as I push this out to Ingo I'll move that entry from the TODO to a DONE section, adding the URL to the cset where it was done. Now pick another one! :-) - Arnaldo > By adding 'install-doc' to the NON_CONFIG_TARGETS, it will skip running the > feature tests for such target. The Auto-detecting system features list will > not be displayed: > > $ make install-doc > BUILD: Doing 'make -j2' parallel build > SUBDIR Documentation > make[2]: Nothing to be done for 'install'. > > Signed-off-by: Rui Teng > --- > tools/perf/Makefile.perf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index 2d90875..9c1dac6 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -165,7 +165,7 @@ SUBCMD_DIR= $(srctree)/tools/lib/subcmd/ > # non-config cases > config := 1 > > -NON_CONFIG_TARGETS := clean TAGS tags cscope help > +NON_CONFIG_TARGETS := clean TAGS tags cscope help install-doc > > ifdef MAKECMDGOALS > ifeq ($(filter-out $(NON_CONFIG_TARGETS),$(MAKECMDGOALS)),) > -- > 2.7.4
[PATCH] perf: Skip running the feature tests for 'make install-doc'
It is a requirement from the perf todo list: The feature tests should be performed only when a file that needs those tests, or at least only when some .c or .h file will be rebuilt An initial step would be for 'make install-doc' not to run the feature tests, there it is not needed at all. By adding 'install-doc' to the NON_CONFIG_TARGETS, it will skip running the feature tests for such target. The Auto-detecting system features list will not be displayed: $ make install-doc BUILD: Doing 'make -j2' parallel build SUBDIR Documentation make[2]: Nothing to be done for 'install'. Signed-off-by: Rui Teng--- tools/perf/Makefile.perf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 2d90875..9c1dac6 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -165,7 +165,7 @@ SUBCMD_DIR = $(srctree)/tools/lib/subcmd/ # non-config cases config := 1 -NON_CONFIG_TARGETS := clean TAGS tags cscope help +NON_CONFIG_TARGETS := clean TAGS tags cscope help install-doc ifdef MAKECMDGOALS ifeq ($(filter-out $(NON_CONFIG_TARGETS),$(MAKECMDGOALS)),) -- 2.7.4
[PATCH] perf: Skip running the feature tests for 'make install-doc'
It is a requirement from the perf todo list: The feature tests should be performed only when a file that needs those tests, or at least only when some .c or .h file will be rebuilt An initial step would be for 'make install-doc' not to run the feature tests, there it is not needed at all. By adding 'install-doc' to the NON_CONFIG_TARGETS, it will skip running the feature tests for such target. The Auto-detecting system features list will not be displayed: $ make install-doc BUILD: Doing 'make -j2' parallel build SUBDIR Documentation make[2]: Nothing to be done for 'install'. Signed-off-by: Rui Teng --- tools/perf/Makefile.perf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 2d90875..9c1dac6 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -165,7 +165,7 @@ SUBCMD_DIR = $(srctree)/tools/lib/subcmd/ # non-config cases config := 1 -NON_CONFIG_TARGETS := clean TAGS tags cscope help +NON_CONFIG_TARGETS := clean TAGS tags cscope help install-doc ifdef MAKECMDGOALS ifeq ($(filter-out $(NON_CONFIG_TARGETS),$(MAKECMDGOALS)),) -- 2.7.4