Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Wednesday, June 19, 2013 05:22:04 PM Toshi Kani wrote: > On Thu, 2013-06-20 at 00:24 +0200, Rafael J. Wysocki wrote: > > On Wednesday, June 19, 2013 10:37:27 AM Tony Luck wrote: > > > > Can you please apply the appended patch on top of it and see if the > > > > system > > > > still works then? > > > > > > Still works with this patch. > > > > Cool, thanks! :-) > > > > If you don't mind, I'll queue up > > https://patchwork.kernel.org/patch/2712741/ and > > this for 3.11. > > For both patches: > > Acked-by: Toshi Kani Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Thu, 2013-06-20 at 00:24 +0200, Rafael J. Wysocki wrote: > On Wednesday, June 19, 2013 10:37:27 AM Tony Luck wrote: > > > Can you please apply the appended patch on top of it and see if the system > > > still works then? > > > > Still works with this patch. > > Cool, thanks! :-) > > If you don't mind, I'll queue up https://patchwork.kernel.org/patch/2712741/ > and > this for 3.11. For both patches: Acked-by: Toshi Kani Thanks, -Toshi > > Thanks, > Rafael > > > > > --- > > > drivers/acpi/scan.c |3 +++ > > > drivers/acpi/video.c |3 --- > > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > > > Index: linux-pm/drivers/acpi/scan.c > > > === > > > --- linux-pm.orig/drivers/acpi/scan.c > > > +++ linux-pm/drivers/acpi/scan.c > > > @@ -939,6 +939,9 @@ static int acpi_device_probe(struct devi > > > struct acpi_driver *acpi_drv = to_acpi_driver(dev->driver); > > > int ret; > > > > > > + if (acpi_dev->handler) > > > + return -EINVAL; > > > + > > > if (!acpi_drv->ops.add) > > > return -ENOSYS; > > > > > > Index: linux-pm/drivers/acpi/video.c > > > === > > > --- linux-pm.orig/drivers/acpi/video.c > > > +++ linux-pm/drivers/acpi/video.c > > > @@ -1722,9 +1722,6 @@ static int acpi_video_bus_add(struct acp > > > int error; > > > acpi_status status; > > > > > > - if (device->handler) > > > - return -EINVAL; > > > - > > > status = acpi_walk_namespace(ACPI_TYPE_DEVICE, > > > device->parent->handle, 1, > > > acpi_video_bus_match, NULL, > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Wednesday, June 19, 2013 03:40:21 PM Tony Luck wrote: > > If you don't mind, I'll queue up > > https://patchwork.kernel.org/patch/2712741/ and > > this for 3.11. > > Mark them > > Tested-by: Tony Luck > > if you like. I will, thank you! Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
> If you don't mind, I'll queue up https://patchwork.kernel.org/patch/2712741/ > and > this for 3.11. Mark them Tested-by: Tony Luck if you like. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Wednesday, June 19, 2013 10:37:27 AM Tony Luck wrote: > > Can you please apply the appended patch on top of it and see if the system > > still works then? > > Still works with this patch. Cool, thanks! :-) If you don't mind, I'll queue up https://patchwork.kernel.org/patch/2712741/ and this for 3.11. Thanks, Rafael > > --- > > drivers/acpi/scan.c |3 +++ > > drivers/acpi/video.c |3 --- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > Index: linux-pm/drivers/acpi/scan.c > > === > > --- linux-pm.orig/drivers/acpi/scan.c > > +++ linux-pm/drivers/acpi/scan.c > > @@ -939,6 +939,9 @@ static int acpi_device_probe(struct devi > > struct acpi_driver *acpi_drv = to_acpi_driver(dev->driver); > > int ret; > > > > + if (acpi_dev->handler) > > + return -EINVAL; > > + > > if (!acpi_drv->ops.add) > > return -ENOSYS; > > > > Index: linux-pm/drivers/acpi/video.c > > === > > --- linux-pm.orig/drivers/acpi/video.c > > +++ linux-pm/drivers/acpi/video.c > > @@ -1722,9 +1722,6 @@ static int acpi_video_bus_add(struct acp > > int error; > > acpi_status status; > > > > - if (device->handler) > > - return -EINVAL; > > - > > status = acpi_walk_namespace(ACPI_TYPE_DEVICE, > > device->parent->handle, 1, > > acpi_video_bus_match, NULL, > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
> Can you please apply the appended patch on top of it and see if the system > still works then? Still works with this patch. -Tony > --- > drivers/acpi/scan.c |3 +++ > drivers/acpi/video.c |3 --- > 2 files changed, 3 insertions(+), 3 deletions(-) > > Index: linux-pm/drivers/acpi/scan.c > === > --- linux-pm.orig/drivers/acpi/scan.c > +++ linux-pm/drivers/acpi/scan.c > @@ -939,6 +939,9 @@ static int acpi_device_probe(struct devi > struct acpi_driver *acpi_drv = to_acpi_driver(dev->driver); > int ret; > > + if (acpi_dev->handler) > + return -EINVAL; > + > if (!acpi_drv->ops.add) > return -ENOSYS; > > Index: linux-pm/drivers/acpi/video.c > === > --- linux-pm.orig/drivers/acpi/video.c > +++ linux-pm/drivers/acpi/video.c > @@ -1722,9 +1722,6 @@ static int acpi_video_bus_add(struct acp > int error; > acpi_status status; > > - if (device->handler) > - return -EINVAL; > - > status = acpi_walk_namespace(ACPI_TYPE_DEVICE, > device->parent->handle, 1, > acpi_video_bus_match, NULL, > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
Can you please apply the appended patch on top of it and see if the system still works then? Still works with this patch. -Tony --- drivers/acpi/scan.c |3 +++ drivers/acpi/video.c |3 --- 2 files changed, 3 insertions(+), 3 deletions(-) Index: linux-pm/drivers/acpi/scan.c === --- linux-pm.orig/drivers/acpi/scan.c +++ linux-pm/drivers/acpi/scan.c @@ -939,6 +939,9 @@ static int acpi_device_probe(struct devi struct acpi_driver *acpi_drv = to_acpi_driver(dev-driver); int ret; + if (acpi_dev-handler) + return -EINVAL; + if (!acpi_drv-ops.add) return -ENOSYS; Index: linux-pm/drivers/acpi/video.c === --- linux-pm.orig/drivers/acpi/video.c +++ linux-pm/drivers/acpi/video.c @@ -1722,9 +1722,6 @@ static int acpi_video_bus_add(struct acp int error; acpi_status status; - if (device-handler) - return -EINVAL; - status = acpi_walk_namespace(ACPI_TYPE_DEVICE, device-parent-handle, 1, acpi_video_bus_match, NULL, -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Wednesday, June 19, 2013 10:37:27 AM Tony Luck wrote: Can you please apply the appended patch on top of it and see if the system still works then? Still works with this patch. Cool, thanks! :-) If you don't mind, I'll queue up https://patchwork.kernel.org/patch/2712741/ and this for 3.11. Thanks, Rafael --- drivers/acpi/scan.c |3 +++ drivers/acpi/video.c |3 --- 2 files changed, 3 insertions(+), 3 deletions(-) Index: linux-pm/drivers/acpi/scan.c === --- linux-pm.orig/drivers/acpi/scan.c +++ linux-pm/drivers/acpi/scan.c @@ -939,6 +939,9 @@ static int acpi_device_probe(struct devi struct acpi_driver *acpi_drv = to_acpi_driver(dev-driver); int ret; + if (acpi_dev-handler) + return -EINVAL; + if (!acpi_drv-ops.add) return -ENOSYS; Index: linux-pm/drivers/acpi/video.c === --- linux-pm.orig/drivers/acpi/video.c +++ linux-pm/drivers/acpi/video.c @@ -1722,9 +1722,6 @@ static int acpi_video_bus_add(struct acp int error; acpi_status status; - if (device-handler) - return -EINVAL; - status = acpi_walk_namespace(ACPI_TYPE_DEVICE, device-parent-handle, 1, acpi_video_bus_match, NULL, -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
If you don't mind, I'll queue up https://patchwork.kernel.org/patch/2712741/ and this for 3.11. Mark them Tested-by: Tony Luck tony.l...@intel.com if you like. -Tony -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Wednesday, June 19, 2013 03:40:21 PM Tony Luck wrote: If you don't mind, I'll queue up https://patchwork.kernel.org/patch/2712741/ and this for 3.11. Mark them Tested-by: Tony Luck tony.l...@intel.com if you like. I will, thank you! Rafael -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Thu, 2013-06-20 at 00:24 +0200, Rafael J. Wysocki wrote: On Wednesday, June 19, 2013 10:37:27 AM Tony Luck wrote: Can you please apply the appended patch on top of it and see if the system still works then? Still works with this patch. Cool, thanks! :-) If you don't mind, I'll queue up https://patchwork.kernel.org/patch/2712741/ and this for 3.11. For both patches: Acked-by: Toshi Kani toshi.k...@hp.com Thanks, -Toshi Thanks, Rafael --- drivers/acpi/scan.c |3 +++ drivers/acpi/video.c |3 --- 2 files changed, 3 insertions(+), 3 deletions(-) Index: linux-pm/drivers/acpi/scan.c === --- linux-pm.orig/drivers/acpi/scan.c +++ linux-pm/drivers/acpi/scan.c @@ -939,6 +939,9 @@ static int acpi_device_probe(struct devi struct acpi_driver *acpi_drv = to_acpi_driver(dev-driver); int ret; + if (acpi_dev-handler) + return -EINVAL; + if (!acpi_drv-ops.add) return -ENOSYS; Index: linux-pm/drivers/acpi/video.c === --- linux-pm.orig/drivers/acpi/video.c +++ linux-pm/drivers/acpi/video.c @@ -1722,9 +1722,6 @@ static int acpi_video_bus_add(struct acp int error; acpi_status status; - if (device-handler) - return -EINVAL; - status = acpi_walk_namespace(ACPI_TYPE_DEVICE, device-parent-handle, 1, acpi_video_bus_match, NULL, -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Wednesday, June 19, 2013 05:22:04 PM Toshi Kani wrote: On Thu, 2013-06-20 at 00:24 +0200, Rafael J. Wysocki wrote: On Wednesday, June 19, 2013 10:37:27 AM Tony Luck wrote: Can you please apply the appended patch on top of it and see if the system still works then? Still works with this patch. Cool, thanks! :-) If you don't mind, I'll queue up https://patchwork.kernel.org/patch/2712741/ and this for 3.11. For both patches: Acked-by: Toshi Kani toshi.k...@hp.com Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Friday, June 14, 2013 03:32:42 PM Tony Luck wrote: > On Fri, Jun 14, 2013 at 3:23 PM, Rafael J. Wysocki wrote: > > Can you please just test patch [5/5] alone without patches [1-4/5]? We > > believe > > that this should work too and if that's the case, we'll only need that patch > > and a reworked [1/5]. > > Your belief is sound - I popped all five patches and then applied just > 5/5 ... and > the system still works. Great, thanks! Can you please apply the appended patch on top of it and see if the system still works then? Rafael --- From: Rafael J. Wysocki Subject: ACPI / scan: Do not bind ACPI drivers to objects with scan handlers ACPI drivers must not be bound to device objects having scan handlers attatched to them, so make acpi_device_probe() fail with -EINVAL if the device object being probed has an ACPI scan handler. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/scan.c |3 +++ drivers/acpi/video.c |3 --- 2 files changed, 3 insertions(+), 3 deletions(-) Index: linux-pm/drivers/acpi/scan.c === --- linux-pm.orig/drivers/acpi/scan.c +++ linux-pm/drivers/acpi/scan.c @@ -939,6 +939,9 @@ static int acpi_device_probe(struct devi struct acpi_driver *acpi_drv = to_acpi_driver(dev->driver); int ret; + if (acpi_dev->handler) + return -EINVAL; + if (!acpi_drv->ops.add) return -ENOSYS; Index: linux-pm/drivers/acpi/video.c === --- linux-pm.orig/drivers/acpi/video.c +++ linux-pm/drivers/acpi/video.c @@ -1722,9 +1722,6 @@ static int acpi_video_bus_add(struct acp int error; acpi_status status; - if (device->handler) - return -EINVAL; - status = acpi_walk_namespace(ACPI_TYPE_DEVICE, device->parent->handle, 1, acpi_video_bus_match, NULL, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Fri, Jun 14, 2013 at 3:23 PM, Rafael J. Wysocki wrote: > Can you please just test patch [5/5] alone without patches [1-4/5]? We > believe > that this should work too and if that's the case, we'll only need that patch > and a reworked [1/5]. Your belief is sound - I popped all five patches and then applied just 5/5 ... and the system still works. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Friday, June 14, 2013 06:01:41 PM Luck, Tony wrote: > >> Tony promised me to test those patches on his box, so we'll know for sure > >> in a while. > > Tested this series - and the box boots just fine with no unexpected messages. Thanks! > But I should note that this box doesn't have anything that is hot pluggable, > so I > couldn't test hotplug (which seems to be deeply involved with things that this > patch is touching). > > Of course that means that I haven't been testing hotplug - so it might have > been > broken for years and I'd never have noticed. Can you please just test patch [5/5] alone without patches [1-4/5]? We believe that this should work too and if that's the case, we'll only need that patch and a reworked [1/5]. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
>> Tony promised me to test those patches on his box, so we'll know for sure >> in a while. Tested this series - and the box boots just fine with no unexpected messages. But I should note that this box doesn't have anything that is hot pluggable, so I couldn't test hotplug (which seems to be deeply involved with things that this patch is touching). Of course that means that I haven't been testing hotplug - so it might have been broken for years and I'd never have noticed. -Tony
RE: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
Tony promised me to test those patches on his box, so we'll know for sure in a while. Tested this series - and the box boots just fine with no unexpected messages. But I should note that this box doesn't have anything that is hot pluggable, so I couldn't test hotplug (which seems to be deeply involved with things that this patch is touching). Of course that means that I haven't been testing hotplug - so it might have been broken for years and I'd never have noticed. -Tony
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Friday, June 14, 2013 06:01:41 PM Luck, Tony wrote: Tony promised me to test those patches on his box, so we'll know for sure in a while. Tested this series - and the box boots just fine with no unexpected messages. Thanks! But I should note that this box doesn't have anything that is hot pluggable, so I couldn't test hotplug (which seems to be deeply involved with things that this patch is touching). Of course that means that I haven't been testing hotplug - so it might have been broken for years and I'd never have noticed. Can you please just test patch [5/5] alone without patches [1-4/5]? We believe that this should work too and if that's the case, we'll only need that patch and a reworked [1/5]. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Fri, Jun 14, 2013 at 3:23 PM, Rafael J. Wysocki r...@sisk.pl wrote: Can you please just test patch [5/5] alone without patches [1-4/5]? We believe that this should work too and if that's the case, we'll only need that patch and a reworked [1/5]. Your belief is sound - I popped all five patches and then applied just 5/5 ... and the system still works. -Tony -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Friday, June 14, 2013 03:32:42 PM Tony Luck wrote: On Fri, Jun 14, 2013 at 3:23 PM, Rafael J. Wysocki r...@sisk.pl wrote: Can you please just test patch [5/5] alone without patches [1-4/5]? We believe that this should work too and if that's the case, we'll only need that patch and a reworked [1/5]. Your belief is sound - I popped all five patches and then applied just 5/5 ... and the system still works. Great, thanks! Can you please apply the appended patch on top of it and see if the system still works then? Rafael --- From: Rafael J. Wysocki rafael.j.wyso...@intel.com Subject: ACPI / scan: Do not bind ACPI drivers to objects with scan handlers ACPI drivers must not be bound to device objects having scan handlers attatched to them, so make acpi_device_probe() fail with -EINVAL if the device object being probed has an ACPI scan handler. Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com --- drivers/acpi/scan.c |3 +++ drivers/acpi/video.c |3 --- 2 files changed, 3 insertions(+), 3 deletions(-) Index: linux-pm/drivers/acpi/scan.c === --- linux-pm.orig/drivers/acpi/scan.c +++ linux-pm/drivers/acpi/scan.c @@ -939,6 +939,9 @@ static int acpi_device_probe(struct devi struct acpi_driver *acpi_drv = to_acpi_driver(dev-driver); int ret; + if (acpi_dev-handler) + return -EINVAL; + if (!acpi_drv-ops.add) return -ENOSYS; Index: linux-pm/drivers/acpi/video.c === --- linux-pm.orig/drivers/acpi/video.c +++ linux-pm/drivers/acpi/video.c @@ -1722,9 +1722,6 @@ static int acpi_video_bus_add(struct acp int error; acpi_status status; - if (device-handler) - return -EINVAL; - status = acpi_walk_namespace(ACPI_TYPE_DEVICE, device-parent-handle, 1, acpi_video_bus_match, NULL, -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Fri, 2013-06-14 at 00:13 +0200, Rafael J. Wysocki wrote: > On Thursday, June 13, 2013 03:28:59 PM Toshi Kani wrote: > > On Thu, 2013-06-13 at 01:23 +0200, Rafael J. Wysocki wrote: > > > Hi All, > > > > > > It turns out that some BIOSes add container device IDs as _CIDs to device > > > object that in principle may be matched against the other scan handlers > > > (or > > > ACPI drivers, but that's not a problem, because the container scan handler > > > can co-exist with an ACPI driver). That's why our recent fix for an issue > > > related to the ACPI video driver had to be reverted right before -rc5. > > > > I am familiar with this firmware, although I no longer have access to > > the systems. An SBA device object has _HID with an HP-specific PNPID > > and _CID with a generic container PNPID. The _HID allows an OS with the > > HP SBA driver (which recognizes the _HID) to enable the SBA's I/O TLB > > functionality, while the _CID allows an OS without the HP SBA driver to > > boot-up by treating this SBA as a container. The _CID is needed because > > some OS skips scanning underneath when it finds an unrecognized object. > > How cute. > > > > Although I submitted an alternative fix for that bug, I think the problem > > > with the container scan handler possibly matching devices already having > > > some other scan handlers attached needs addressing, because we may need to > > > use the container hotplug profile for those devices. The following patch > > > series is supposed to address it. > > > > When the HP SBA driver is bound to the SBA object, this driver needs to > > handle a hotplug request when it is supported. This is because the I/O > > TLB functionality requires its hot-delete operation as well. The > > container scan handler can be used only when this driver is bound to the > > SBA object as a container and therefore its I/O TLB functionality is not > > used. > > Ah, so in fact those device IDs are kind of mutually exclusive? That is, > we only should use the _CID if we don't use the _HID, right? Yes and yes. > We have a bug there, then, but it probably is bening enough for 3.10 to be > left > as is. > > > > [1/5] ACPI / scan: Do not bind ACPI drivers to objects with scan handlers > > >(this version shouldn't break the Tony's IA64 HP box the previous one > > > broke) > > > [2/5] ACPI / scan: Separate hotplug profiles from scan handlers > > > [3/5] ACPI / scan: Add hotplug profile pointer to struct acpi_device > > > [4/5] ACPI / scan: Use container hotplug profile for matching device > > > objects > > > [5/5] ACPI / ia64 / sba_iommu: Use ACPI scan handler for discovery > > > > > > Patches [1-4/5] were run on my Toshiba test box and didn't break it, but > > > it > > > really doesn't do any ACPI hotplug notifications. > > > > > > Patch [5/5] is kind of additional, but it wouldn't work correctly without > > > the > > > previous ones (to be honest, I haven't tried to compile it yet, but here > > > it > > > goes for completness). > > > > I think we only need patch [5/5] to address the problem. We have > > enhanced the match function of scan handlers to match a proper driver > > with respect to their priority order, i.e. matching with _HID first and > > then with _CIDs. Patch [5/5] should assure that the HP SBA driver is > > bound to an SBA object when this driver is configured to the kernel. > > OK, but then I'd like to apply a modified version of [1/5] that won't > check if the scan handler is the container handler, but will just return > -EINVAL if any scan handler has been set already. And the changelog of > [5/5] needs to be modified slightly. Agreed. > Tony promised me to test those patches on his box, so we'll know for sure > in a while. Cool. Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Thursday, June 13, 2013 03:28:59 PM Toshi Kani wrote: > On Thu, 2013-06-13 at 01:23 +0200, Rafael J. Wysocki wrote: > > Hi All, > > > > It turns out that some BIOSes add container device IDs as _CIDs to device > > object that in principle may be matched against the other scan handlers (or > > ACPI drivers, but that's not a problem, because the container scan handler > > can co-exist with an ACPI driver). That's why our recent fix for an issue > > related to the ACPI video driver had to be reverted right before -rc5. > > I am familiar with this firmware, although I no longer have access to > the systems. An SBA device object has _HID with an HP-specific PNPID > and _CID with a generic container PNPID. The _HID allows an OS with the > HP SBA driver (which recognizes the _HID) to enable the SBA's I/O TLB > functionality, while the _CID allows an OS without the HP SBA driver to > boot-up by treating this SBA as a container. The _CID is needed because > some OS skips scanning underneath when it finds an unrecognized object. How cute. > > Although I submitted an alternative fix for that bug, I think the problem > > with the container scan handler possibly matching devices already having > > some other scan handlers attached needs addressing, because we may need to > > use the container hotplug profile for those devices. The following patch > > series is supposed to address it. > > When the HP SBA driver is bound to the SBA object, this driver needs to > handle a hotplug request when it is supported. This is because the I/O > TLB functionality requires its hot-delete operation as well. The > container scan handler can be used only when this driver is bound to the > SBA object as a container and therefore its I/O TLB functionality is not > used. Ah, so in fact those device IDs are kind of mutually exclusive? That is, we only should use the _CID if we don't use the _HID, right? We have a bug there, then, but it probably is bening enough for 3.10 to be left as is. > > [1/5] ACPI / scan: Do not bind ACPI drivers to objects with scan handlers > >(this version shouldn't break the Tony's IA64 HP box the previous one > > broke) > > [2/5] ACPI / scan: Separate hotplug profiles from scan handlers > > [3/5] ACPI / scan: Add hotplug profile pointer to struct acpi_device > > [4/5] ACPI / scan: Use container hotplug profile for matching device objects > > [5/5] ACPI / ia64 / sba_iommu: Use ACPI scan handler for discovery > > > > Patches [1-4/5] were run on my Toshiba test box and didn't break it, but it > > really doesn't do any ACPI hotplug notifications. > > > > Patch [5/5] is kind of additional, but it wouldn't work correctly without > > the > > previous ones (to be honest, I haven't tried to compile it yet, but here it > > goes for completness). > > I think we only need patch [5/5] to address the problem. We have > enhanced the match function of scan handlers to match a proper driver > with respect to their priority order, i.e. matching with _HID first and > then with _CIDs. Patch [5/5] should assure that the HP SBA driver is > bound to an SBA object when this driver is configured to the kernel. OK, but then I'd like to apply a modified version of [1/5] that won't check if the scan handler is the container handler, but will just return -EINVAL if any scan handler has been set already. And the changelog of [5/5] needs to be modified slightly. Tony promised me to test those patches on his box, so we'll know for sure in a while. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Thu, 2013-06-13 at 01:23 +0200, Rafael J. Wysocki wrote: > Hi All, > > It turns out that some BIOSes add container device IDs as _CIDs to device > object that in principle may be matched against the other scan handlers (or > ACPI drivers, but that's not a problem, because the container scan handler > can co-exist with an ACPI driver). That's why our recent fix for an issue > related to the ACPI video driver had to be reverted right before -rc5. I am familiar with this firmware, although I no longer have access to the systems. An SBA device object has _HID with an HP-specific PNPID and _CID with a generic container PNPID. The _HID allows an OS with the HP SBA driver (which recognizes the _HID) to enable the SBA's I/O TLB functionality, while the _CID allows an OS without the HP SBA driver to boot-up by treating this SBA as a container. The _CID is needed because some OS skips scanning underneath when it finds an unrecognized object. > Although I submitted an alternative fix for that bug, I think the problem > with the container scan handler possibly matching devices already having > some other scan handlers attached needs addressing, because we may need to > use the container hotplug profile for those devices. The following patch > series is supposed to address it. When the HP SBA driver is bound to the SBA object, this driver needs to handle a hotplug request when it is supported. This is because the I/O TLB functionality requires its hot-delete operation as well. The container scan handler can be used only when this driver is bound to the SBA object as a container and therefore its I/O TLB functionality is not used. > [1/5] ACPI / scan: Do not bind ACPI drivers to objects with scan handlers >(this version shouldn't break the Tony's IA64 HP box the previous one > broke) > [2/5] ACPI / scan: Separate hotplug profiles from scan handlers > [3/5] ACPI / scan: Add hotplug profile pointer to struct acpi_device > [4/5] ACPI / scan: Use container hotplug profile for matching device objects > [5/5] ACPI / ia64 / sba_iommu: Use ACPI scan handler for discovery > > Patches [1-4/5] were run on my Toshiba test box and didn't break it, but it > really doesn't do any ACPI hotplug notifications. > > Patch [5/5] is kind of additional, but it wouldn't work correctly without the > previous ones (to be honest, I haven't tried to compile it yet, but here it > goes for completness). I think we only need patch [5/5] to address the problem. We have enhanced the match function of scan handlers to match a proper driver with respect to their priority order, i.e. matching with _HID first and then with _CIDs. Patch [5/5] should assure that the HP SBA driver is bound to an SBA object when this driver is configured to the kernel. Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Thu, 2013-06-13 at 01:23 +0200, Rafael J. Wysocki wrote: Hi All, It turns out that some BIOSes add container device IDs as _CIDs to device object that in principle may be matched against the other scan handlers (or ACPI drivers, but that's not a problem, because the container scan handler can co-exist with an ACPI driver). That's why our recent fix for an issue related to the ACPI video driver had to be reverted right before -rc5. I am familiar with this firmware, although I no longer have access to the systems. An SBA device object has _HID with an HP-specific PNPID and _CID with a generic container PNPID. The _HID allows an OS with the HP SBA driver (which recognizes the _HID) to enable the SBA's I/O TLB functionality, while the _CID allows an OS without the HP SBA driver to boot-up by treating this SBA as a container. The _CID is needed because some OS skips scanning underneath when it finds an unrecognized object. Although I submitted an alternative fix for that bug, I think the problem with the container scan handler possibly matching devices already having some other scan handlers attached needs addressing, because we may need to use the container hotplug profile for those devices. The following patch series is supposed to address it. When the HP SBA driver is bound to the SBA object, this driver needs to handle a hotplug request when it is supported. This is because the I/O TLB functionality requires its hot-delete operation as well. The container scan handler can be used only when this driver is bound to the SBA object as a container and therefore its I/O TLB functionality is not used. [1/5] ACPI / scan: Do not bind ACPI drivers to objects with scan handlers (this version shouldn't break the Tony's IA64 HP box the previous one broke) [2/5] ACPI / scan: Separate hotplug profiles from scan handlers [3/5] ACPI / scan: Add hotplug profile pointer to struct acpi_device [4/5] ACPI / scan: Use container hotplug profile for matching device objects [5/5] ACPI / ia64 / sba_iommu: Use ACPI scan handler for discovery Patches [1-4/5] were run on my Toshiba test box and didn't break it, but it really doesn't do any ACPI hotplug notifications. Patch [5/5] is kind of additional, but it wouldn't work correctly without the previous ones (to be honest, I haven't tried to compile it yet, but here it goes for completness). I think we only need patch [5/5] to address the problem. We have enhanced the match function of scan handlers to match a proper driver with respect to their priority order, i.e. matching with _HID first and then with _CIDs. Patch [5/5] should assure that the HP SBA driver is bound to an SBA object when this driver is configured to the kernel. Thanks, -Toshi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Thursday, June 13, 2013 03:28:59 PM Toshi Kani wrote: On Thu, 2013-06-13 at 01:23 +0200, Rafael J. Wysocki wrote: Hi All, It turns out that some BIOSes add container device IDs as _CIDs to device object that in principle may be matched against the other scan handlers (or ACPI drivers, but that's not a problem, because the container scan handler can co-exist with an ACPI driver). That's why our recent fix for an issue related to the ACPI video driver had to be reverted right before -rc5. I am familiar with this firmware, although I no longer have access to the systems. An SBA device object has _HID with an HP-specific PNPID and _CID with a generic container PNPID. The _HID allows an OS with the HP SBA driver (which recognizes the _HID) to enable the SBA's I/O TLB functionality, while the _CID allows an OS without the HP SBA driver to boot-up by treating this SBA as a container. The _CID is needed because some OS skips scanning underneath when it finds an unrecognized object. How cute. Although I submitted an alternative fix for that bug, I think the problem with the container scan handler possibly matching devices already having some other scan handlers attached needs addressing, because we may need to use the container hotplug profile for those devices. The following patch series is supposed to address it. When the HP SBA driver is bound to the SBA object, this driver needs to handle a hotplug request when it is supported. This is because the I/O TLB functionality requires its hot-delete operation as well. The container scan handler can be used only when this driver is bound to the SBA object as a container and therefore its I/O TLB functionality is not used. Ah, so in fact those device IDs are kind of mutually exclusive? That is, we only should use the _CID if we don't use the _HID, right? We have a bug there, then, but it probably is bening enough for 3.10 to be left as is. [1/5] ACPI / scan: Do not bind ACPI drivers to objects with scan handlers (this version shouldn't break the Tony's IA64 HP box the previous one broke) [2/5] ACPI / scan: Separate hotplug profiles from scan handlers [3/5] ACPI / scan: Add hotplug profile pointer to struct acpi_device [4/5] ACPI / scan: Use container hotplug profile for matching device objects [5/5] ACPI / ia64 / sba_iommu: Use ACPI scan handler for discovery Patches [1-4/5] were run on my Toshiba test box and didn't break it, but it really doesn't do any ACPI hotplug notifications. Patch [5/5] is kind of additional, but it wouldn't work correctly without the previous ones (to be honest, I haven't tried to compile it yet, but here it goes for completness). I think we only need patch [5/5] to address the problem. We have enhanced the match function of scan handlers to match a proper driver with respect to their priority order, i.e. matching with _HID first and then with _CIDs. Patch [5/5] should assure that the HP SBA driver is bound to an SBA object when this driver is configured to the kernel. OK, but then I'd like to apply a modified version of [1/5] that won't check if the scan handler is the container handler, but will just return -EINVAL if any scan handler has been set already. And the changelog of [5/5] needs to be modified slightly. Tony promised me to test those patches on his box, so we'll know for sure in a while. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
On Fri, 2013-06-14 at 00:13 +0200, Rafael J. Wysocki wrote: On Thursday, June 13, 2013 03:28:59 PM Toshi Kani wrote: On Thu, 2013-06-13 at 01:23 +0200, Rafael J. Wysocki wrote: Hi All, It turns out that some BIOSes add container device IDs as _CIDs to device object that in principle may be matched against the other scan handlers (or ACPI drivers, but that's not a problem, because the container scan handler can co-exist with an ACPI driver). That's why our recent fix for an issue related to the ACPI video driver had to be reverted right before -rc5. I am familiar with this firmware, although I no longer have access to the systems. An SBA device object has _HID with an HP-specific PNPID and _CID with a generic container PNPID. The _HID allows an OS with the HP SBA driver (which recognizes the _HID) to enable the SBA's I/O TLB functionality, while the _CID allows an OS without the HP SBA driver to boot-up by treating this SBA as a container. The _CID is needed because some OS skips scanning underneath when it finds an unrecognized object. How cute. Although I submitted an alternative fix for that bug, I think the problem with the container scan handler possibly matching devices already having some other scan handlers attached needs addressing, because we may need to use the container hotplug profile for those devices. The following patch series is supposed to address it. When the HP SBA driver is bound to the SBA object, this driver needs to handle a hotplug request when it is supported. This is because the I/O TLB functionality requires its hot-delete operation as well. The container scan handler can be used only when this driver is bound to the SBA object as a container and therefore its I/O TLB functionality is not used. Ah, so in fact those device IDs are kind of mutually exclusive? That is, we only should use the _CID if we don't use the _HID, right? Yes and yes. We have a bug there, then, but it probably is bening enough for 3.10 to be left as is. [1/5] ACPI / scan: Do not bind ACPI drivers to objects with scan handlers (this version shouldn't break the Tony's IA64 HP box the previous one broke) [2/5] ACPI / scan: Separate hotplug profiles from scan handlers [3/5] ACPI / scan: Add hotplug profile pointer to struct acpi_device [4/5] ACPI / scan: Use container hotplug profile for matching device objects [5/5] ACPI / ia64 / sba_iommu: Use ACPI scan handler for discovery Patches [1-4/5] were run on my Toshiba test box and didn't break it, but it really doesn't do any ACPI hotplug notifications. Patch [5/5] is kind of additional, but it wouldn't work correctly without the previous ones (to be honest, I haven't tried to compile it yet, but here it goes for completness). I think we only need patch [5/5] to address the problem. We have enhanced the match function of scan handlers to match a proper driver with respect to their priority order, i.e. matching with _HID first and then with _CIDs. Patch [5/5] should assure that the HP SBA driver is bound to an SBA object when this driver is configured to the kernel. OK, but then I'd like to apply a modified version of [1/5] that won't check if the scan handler is the container handler, but will just return -EINVAL if any scan handler has been set already. And the changelog of [5/5] needs to be modified slightly. Agreed. Tony promised me to test those patches on his box, so we'll know for sure in a while. Cool. Thanks, -Toshi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
Hi All, It turns out that some BIOSes add container device IDs as _CIDs to device object that in principle may be matched against the other scan handlers (or ACPI drivers, but that's not a problem, because the container scan handler can co-exist with an ACPI driver). That's why our recent fix for an issue related to the ACPI video driver had to be reverted right before -rc5. Although I submitted an alternative fix for that bug, I think the problem with the container scan handler possibly matching devices already having some other scan handlers attached needs addressing, because we may need to use the container hotplug profile for those devices. The following patch series is supposed to address it. [1/5] ACPI / scan: Do not bind ACPI drivers to objects with scan handlers (this version shouldn't break the Tony's IA64 HP box the previous one broke) [2/5] ACPI / scan: Separate hotplug profiles from scan handlers [3/5] ACPI / scan: Add hotplug profile pointer to struct acpi_device [4/5] ACPI / scan: Use container hotplug profile for matching device objects [5/5] ACPI / ia64 / sba_iommu: Use ACPI scan handler for discovery Patches [1-4/5] were run on my Toshiba test box and didn't break it, but it really doesn't do any ACPI hotplug notifications. Patch [5/5] is kind of additional, but it wouldn't work correctly without the previous ones (to be honest, I haven't tried to compile it yet, but here it goes for completness). The patches are against the linux-next branch of the linux-pm.git tree. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/5] ACPI / scan: Make it possible to use the container hotplug with other scan handlers
Hi All, It turns out that some BIOSes add container device IDs as _CIDs to device object that in principle may be matched against the other scan handlers (or ACPI drivers, but that's not a problem, because the container scan handler can co-exist with an ACPI driver). That's why our recent fix for an issue related to the ACPI video driver had to be reverted right before -rc5. Although I submitted an alternative fix for that bug, I think the problem with the container scan handler possibly matching devices already having some other scan handlers attached needs addressing, because we may need to use the container hotplug profile for those devices. The following patch series is supposed to address it. [1/5] ACPI / scan: Do not bind ACPI drivers to objects with scan handlers (this version shouldn't break the Tony's IA64 HP box the previous one broke) [2/5] ACPI / scan: Separate hotplug profiles from scan handlers [3/5] ACPI / scan: Add hotplug profile pointer to struct acpi_device [4/5] ACPI / scan: Use container hotplug profile for matching device objects [5/5] ACPI / ia64 / sba_iommu: Use ACPI scan handler for discovery Patches [1-4/5] were run on my Toshiba test box and didn't break it, but it really doesn't do any ACPI hotplug notifications. Patch [5/5] is kind of additional, but it wouldn't work correctly without the previous ones (to be honest, I haven't tried to compile it yet, but here it goes for completness). The patches are against the linux-next branch of the linux-pm.git tree. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
