Re: [PATCH 3/4] cpufreq: schedutil: Don't pass flags to sugov_set_iowait_boost()

[Juri Lelli]

Hi,

On 13/12/17 15:23, Viresh Kumar wrote:
> We are already passing sg_cpu as argument to sugov_set_iowait_boost()
> helper and the same can be used to retrieve the flags value. Get rid of
> the redundant argument.
> 
> Signed-off-by: Viresh Kumar 

Reviewed-by: Juri Lelli 

Best,

- Juri

Re: [PATCH 3/4] cpufreq: schedutil: Don't pass flags to sugov_set_iowait_boost()

[Juri Lelli]

Hi,

On 13/12/17 15:23, Viresh Kumar wrote:
> We are already passing sg_cpu as argument to sugov_set_iowait_boost()
> helper and the same can be used to retrieve the flags value. Get rid of
> the redundant argument.
> 
> Signed-off-by: Viresh Kumar 

Reviewed-by: Juri Lelli 

Best,

- Juri

[PATCH 3/4] cpufreq: schedutil: Don't pass flags to sugov_set_iowait_boost()

[Viresh Kumar]

We are already passing sg_cpu as argument to sugov_set_iowait_boost()
helper and the same can be used to retrieve the flags value. Get rid of
the redundant argument.

Signed-off-by: Viresh Kumar 
---
 kernel/sched/cpufreq_schedutil.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 60a2dea4c8cc..7edfdc59ee8f 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -187,10 +187,9 @@ static void sugov_get_util(unsigned long *util, unsigned 
long *max, int cpu)
*max = cfs_max;
 }
 
-static void sugov_set_iowait_boost(struct sugov_cpu *sg_cpu, u64 time,
-  unsigned int flags)
+static void sugov_set_iowait_boost(struct sugov_cpu *sg_cpu, u64 time)
 {
-   if (flags & SCHED_CPUFREQ_IOWAIT) {
+   if (sg_cpu->flags & SCHED_CPUFREQ_IOWAIT) {
sg_cpu->flags &= ~SCHED_CPUFREQ_IOWAIT;
 
if (sg_cpu->iowait_boost_pending)
@@ -273,7 +272,7 @@ static void sugov_update_single(struct update_util_data 
*hook, u64 time,
 
sg_cpu->flags |= flags;
 
-   sugov_set_iowait_boost(sg_cpu, time, flags);
+   sugov_set_iowait_boost(sg_cpu, time);
sg_cpu->last_update = time;
 
if (!sugov_should_update_freq(sg_policy, time))
@@ -363,7 +362,7 @@ static void sugov_update_shared(struct update_util_data 
*hook, u64 time,
sg_cpu->max = max;
sg_cpu->flags |= flags;
 
-   sugov_set_iowait_boost(sg_cpu, time, flags);
+   sugov_set_iowait_boost(sg_cpu, time);
sg_cpu->last_update = time;
 
if (sugov_should_update_freq(sg_policy, time)) {
-- 
2.15.0.194.g9af6a3dea062

[PATCH 3/4] cpufreq: schedutil: Don't pass flags to sugov_set_iowait_boost()

[Viresh Kumar]

We are already passing sg_cpu as argument to sugov_set_iowait_boost()
helper and the same can be used to retrieve the flags value. Get rid of
the redundant argument.

Signed-off-by: Viresh Kumar 
---
 kernel/sched/cpufreq_schedutil.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 60a2dea4c8cc..7edfdc59ee8f 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -187,10 +187,9 @@ static void sugov_get_util(unsigned long *util, unsigned 
long *max, int cpu)
*max = cfs_max;
 }
 
-static void sugov_set_iowait_boost(struct sugov_cpu *sg_cpu, u64 time,
-  unsigned int flags)
+static void sugov_set_iowait_boost(struct sugov_cpu *sg_cpu, u64 time)
 {
-   if (flags & SCHED_CPUFREQ_IOWAIT) {
+   if (sg_cpu->flags & SCHED_CPUFREQ_IOWAIT) {
sg_cpu->flags &= ~SCHED_CPUFREQ_IOWAIT;
 
if (sg_cpu->iowait_boost_pending)
@@ -273,7 +272,7 @@ static void sugov_update_single(struct update_util_data 
*hook, u64 time,
 
sg_cpu->flags |= flags;
 
-   sugov_set_iowait_boost(sg_cpu, time, flags);
+   sugov_set_iowait_boost(sg_cpu, time);
sg_cpu->last_update = time;
 
if (!sugov_should_update_freq(sg_policy, time))
@@ -363,7 +362,7 @@ static void sugov_update_shared(struct update_util_data 
*hook, u64 time,
sg_cpu->max = max;
sg_cpu->flags |= flags;
 
-   sugov_set_iowait_boost(sg_cpu, time, flags);
+   sugov_set_iowait_boost(sg_cpu, time);
sg_cpu->last_update = time;
 
if (sugov_should_update_freq(sg_policy, time)) {
-- 
2.15.0.194.g9af6a3dea062