Re: [PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU

2018-02-15 Thread Simon Horman 
On Thu, Feb 15, 2018 at 02:30:28PM +, Kieran Bingham wrote:
> Hi Laurent, Simon,
> 
> On 15/02/18 14:12, Laurent Pinchart wrote:
> > Hi Kieran,
> > 
> > Thank you for the patch.
> > 
> > On Thursday, 15 February 2018 10:38:21 EET Kieran Bingham wrote:
> >> From: Kieran Bingham 
> >>
> >> Enable the DU, providing only the VGA output for now.
> >>
> >> Signed-off-by: Kieran Bingham 
> > 
> > Reviewed-by: Laurent Pinchart 
> > 
> > I assume Simon will take care of this patch.
> 
> That will be great, - One small caveat on this patch though:
> 
> 
> >> ---
> >>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 51 
> >> +++
> >>  1 file changed, 51 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> >> b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index
> >> af07da240be0..668e246dfc5d 100644
> >> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> >> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> >> @@ -27,6 +27,38 @@
> >>stdout-path = "serial0:115200n8";
> >>};
> >>
> >> +  vga {
> >> +  compatible = "vga-connector";
> >> +
> >> +  port {
> >> +  vga_in: endpoint {
> >> +  remote-endpoint = <_out>;
> >> +  };
> >> +  };
> >> +  };
> >> +
> >> +  vga-encoder {
> >> +  compatible = "adi,adv7123";
> >> +
> >> +  ports {
> >> +  #address-cells = <1>;
> >> +  #size-cells = <0>;
> >> +
> >> +  port@0 {
> >> +  reg = <0>;
> >> +  adv7123_in: endpoint {
> >> +  remote-endpoint = <_out_rgb>;
> >> +  };
> >> +  };
> >> +  port@1 {
> >> +  reg = <1>;
> >> +  adv7123_out: endpoint {
> >> +  remote-endpoint = <_in>;
> >> +  };
> >> +  };
> >> +  };
> >> +  };
> >> +
> >>memory@4800 {
> >>device_type = "memory";
> >>/* first 128MB is reserved for secure area. */
> >> @@ -46,6 +78,11 @@
> >>};
> >>};
> >>
> >> +  du_pins: du {
> >> +  groups = "du_rgb888", "du_sync", "du_disp", "du_dotclkout0";
> 
> The du_dotclkout0 is named differently in Uli's patch. (Of course I believe my
> version is correct, but there is some precedent set it would seem).
> 
> Anyway, If Uli's version of the PFC is accepted (Which I'm sure it will be),
> then I will have to re-spin this patch with the 'different' "du_clk_out_0" 
> value
> in the groups.

Thanks, please repost once this has been shaken out.

Re: [PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU

2018-02-15 Thread Simon Horman 
On Thu, Feb 15, 2018 at 02:30:28PM +, Kieran Bingham wrote:
> Hi Laurent, Simon,
> 
> On 15/02/18 14:12, Laurent Pinchart wrote:
> > Hi Kieran,
> > 
> > Thank you for the patch.
> > 
> > On Thursday, 15 February 2018 10:38:21 EET Kieran Bingham wrote:
> >> From: Kieran Bingham 
> >>
> >> Enable the DU, providing only the VGA output for now.
> >>
> >> Signed-off-by: Kieran Bingham 
> > 
> > Reviewed-by: Laurent Pinchart 
> > 
> > I assume Simon will take care of this patch.
> 
> That will be great, - One small caveat on this patch though:
> 
> 
> >> ---
> >>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 51 
> >> +++
> >>  1 file changed, 51 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> >> b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index
> >> af07da240be0..668e246dfc5d 100644
> >> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> >> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> >> @@ -27,6 +27,38 @@
> >>stdout-path = "serial0:115200n8";
> >>};
> >>
> >> +  vga {
> >> +  compatible = "vga-connector";
> >> +
> >> +  port {
> >> +  vga_in: endpoint {
> >> +  remote-endpoint = <_out>;
> >> +  };
> >> +  };
> >> +  };
> >> +
> >> +  vga-encoder {
> >> +  compatible = "adi,adv7123";
> >> +
> >> +  ports {
> >> +  #address-cells = <1>;
> >> +  #size-cells = <0>;
> >> +
> >> +  port@0 {
> >> +  reg = <0>;
> >> +  adv7123_in: endpoint {
> >> +  remote-endpoint = <_out_rgb>;
> >> +  };
> >> +  };
> >> +  port@1 {
> >> +  reg = <1>;
> >> +  adv7123_out: endpoint {
> >> +  remote-endpoint = <_in>;
> >> +  };
> >> +  };
> >> +  };
> >> +  };
> >> +
> >>memory@4800 {
> >>device_type = "memory";
> >>/* first 128MB is reserved for secure area. */
> >> @@ -46,6 +78,11 @@
> >>};
> >>};
> >>
> >> +  du_pins: du {
> >> +  groups = "du_rgb888", "du_sync", "du_disp", "du_dotclkout0";
> 
> The du_dotclkout0 is named differently in Uli's patch. (Of course I believe my
> version is correct, but there is some precedent set it would seem).
> 
> Anyway, If Uli's version of the PFC is accepted (Which I'm sure it will be),
> then I will have to re-spin this patch with the 'different' "du_clk_out_0" 
> value
> in the groups.

Thanks, please repost once this has been shaken out.

Re: [PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU

2018-02-15 Thread Kieran Bingham 
Hi Laurent, Simon,

On 15/02/18 14:12, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Thursday, 15 February 2018 10:38:21 EET Kieran Bingham wrote:
>> From: Kieran Bingham 
>>
>> Enable the DU, providing only the VGA output for now.
>>
>> Signed-off-by: Kieran Bingham 
> 
> Reviewed-by: Laurent Pinchart 
> 
> I assume Simon will take care of this patch.

That will be great, - One small caveat on this patch though:


>> ---
>>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 51 +++
>>  1 file changed, 51 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
>> b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index
>> af07da240be0..668e246dfc5d 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
>> @@ -27,6 +27,38 @@
>>  stdout-path = "serial0:115200n8";
>>  };
>>
>> +vga {
>> +compatible = "vga-connector";
>> +
>> +port {
>> +vga_in: endpoint {
>> +remote-endpoint = <_out>;
>> +};
>> +};
>> +};
>> +
>> +vga-encoder {
>> +compatible = "adi,adv7123";
>> +
>> +ports {
>> +#address-cells = <1>;
>> +#size-cells = <0>;
>> +
>> +port@0 {
>> +reg = <0>;
>> +adv7123_in: endpoint {
>> +remote-endpoint = <_out_rgb>;
>> +};
>> +};
>> +port@1 {
>> +reg = <1>;
>> +adv7123_out: endpoint {
>> +remote-endpoint = <_in>;
>> +};
>> +};
>> +};
>> +};
>> +
>>  memory@4800 {
>>  device_type = "memory";
>>  /* first 128MB is reserved for secure area. */
>> @@ -46,6 +78,11 @@
>>  };
>>  };
>>
>> +du_pins: du {
>> +groups = "du_rgb888", "du_sync", "du_disp", "du_dotclkout0";

The du_dotclkout0 is named differently in Uli's patch. (Of course I believe my
version is correct, but there is some precedent set it would seem).

Anyway, If Uli's version of the PFC is accepted (Which I'm sure it will be),
then I will have to re-spin this patch with the 'different' "du_clk_out_0" value
in the groups.

--
Kieran


>> +function = "du";
>> +};
>> +
>>  i2c0_pins: i2c0 {
>>  groups = "i2c0";
>>  function = "i2c0";
>> @@ -95,6 +132,20 @@
>>  status = "okay";
>>  };
>>
>> + {
>> +pinctrl-0 = <_pins>;
>> +pinctrl-names = "default";
>> +status = "okay";
>> +
>> +ports {
>> +port@0 {
>> +endpoint {
>> +remote-endpoint = <_in>;
>> +};
>> +};
>> +};
>> +};
>> +
>>   {
>>  status = "okay";
>>  };
> 
>

Re: [PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU

2018-02-15 Thread Kieran Bingham 
Hi Laurent, Simon,

On 15/02/18 14:12, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Thursday, 15 February 2018 10:38:21 EET Kieran Bingham wrote:
>> From: Kieran Bingham 
>>
>> Enable the DU, providing only the VGA output for now.
>>
>> Signed-off-by: Kieran Bingham 
> 
> Reviewed-by: Laurent Pinchart 
> 
> I assume Simon will take care of this patch.

That will be great, - One small caveat on this patch though:


>> ---
>>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 51 +++
>>  1 file changed, 51 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
>> b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index
>> af07da240be0..668e246dfc5d 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
>> @@ -27,6 +27,38 @@
>>  stdout-path = "serial0:115200n8";
>>  };
>>
>> +vga {
>> +compatible = "vga-connector";
>> +
>> +port {
>> +vga_in: endpoint {
>> +remote-endpoint = <_out>;
>> +};
>> +};
>> +};
>> +
>> +vga-encoder {
>> +compatible = "adi,adv7123";
>> +
>> +ports {
>> +#address-cells = <1>;
>> +#size-cells = <0>;
>> +
>> +port@0 {
>> +reg = <0>;
>> +adv7123_in: endpoint {
>> +remote-endpoint = <_out_rgb>;
>> +};
>> +};
>> +port@1 {
>> +reg = <1>;
>> +adv7123_out: endpoint {
>> +remote-endpoint = <_in>;
>> +};
>> +};
>> +};
>> +};
>> +
>>  memory@4800 {
>>  device_type = "memory";
>>  /* first 128MB is reserved for secure area. */
>> @@ -46,6 +78,11 @@
>>  };
>>  };
>>
>> +du_pins: du {
>> +groups = "du_rgb888", "du_sync", "du_disp", "du_dotclkout0";

The du_dotclkout0 is named differently in Uli's patch. (Of course I believe my
version is correct, but there is some precedent set it would seem).

Anyway, If Uli's version of the PFC is accepted (Which I'm sure it will be),
then I will have to re-spin this patch with the 'different' "du_clk_out_0" value
in the groups.

--
Kieran


>> +function = "du";
>> +};
>> +
>>  i2c0_pins: i2c0 {
>>  groups = "i2c0";
>>  function = "i2c0";
>> @@ -95,6 +132,20 @@
>>  status = "okay";
>>  };
>>
>> + {
>> +pinctrl-0 = <_pins>;
>> +pinctrl-names = "default";
>> +status = "okay";
>> +
>> +ports {
>> +port@0 {
>> +endpoint {
>> +remote-endpoint = <_in>;
>> +};
>> +};
>> +};
>> +};
>> +
>>   {
>>  status = "okay";
>>  };
> 
>

Re: [PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU

2018-02-15 Thread Laurent Pinchart 
Hi Kieran,

Thank you for the patch.

On Thursday, 15 February 2018 10:38:21 EET Kieran Bingham wrote:
> From: Kieran Bingham 
> 
> Enable the DU, providing only the VGA output for now.
> 
> Signed-off-by: Kieran Bingham 

Reviewed-by: Laurent Pinchart 

I assume Simon will take care of this patch.

> ---
>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 51 +++
>  1 file changed, 51 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index
> af07da240be0..668e246dfc5d 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> @@ -27,6 +27,38 @@
>   stdout-path = "serial0:115200n8";
>   };
> 
> + vga {
> + compatible = "vga-connector";
> +
> + port {
> + vga_in: endpoint {
> + remote-endpoint = <_out>;
> + };
> + };
> + };
> +
> + vga-encoder {
> + compatible = "adi,adv7123";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + adv7123_in: endpoint {
> + remote-endpoint = <_out_rgb>;
> + };
> + };
> + port@1 {
> + reg = <1>;
> + adv7123_out: endpoint {
> + remote-endpoint = <_in>;
> + };
> + };
> + };
> + };
> +
>   memory@4800 {
>   device_type = "memory";
>   /* first 128MB is reserved for secure area. */
> @@ -46,6 +78,11 @@
>   };
>   };
> 
> + du_pins: du {
> + groups = "du_rgb888", "du_sync", "du_disp", "du_dotclkout0";
> + function = "du";
> + };
> +
>   i2c0_pins: i2c0 {
>   groups = "i2c0";
>   function = "i2c0";
> @@ -95,6 +132,20 @@
>   status = "okay";
>  };
> 
> + {
> + pinctrl-0 = <_pins>;
> + pinctrl-names = "default";
> + status = "okay";
> +
> + ports {
> + port@0 {
> + endpoint {
> + remote-endpoint = <_in>;
> + };
> + };
> + };
> +};
> +
>   {
>   status = "okay";
>  };


-- 
Regards,

Laurent Pinchart

Re: [PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU

2018-02-15 Thread Laurent Pinchart 
Hi Kieran,

Thank you for the patch.

On Thursday, 15 February 2018 10:38:21 EET Kieran Bingham wrote:
> From: Kieran Bingham 
> 
> Enable the DU, providing only the VGA output for now.
> 
> Signed-off-by: Kieran Bingham 

Reviewed-by: Laurent Pinchart 

I assume Simon will take care of this patch.

> ---
>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 51 +++
>  1 file changed, 51 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index
> af07da240be0..668e246dfc5d 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> @@ -27,6 +27,38 @@
>   stdout-path = "serial0:115200n8";
>   };
> 
> + vga {
> + compatible = "vga-connector";
> +
> + port {
> + vga_in: endpoint {
> + remote-endpoint = <_out>;
> + };
> + };
> + };
> +
> + vga-encoder {
> + compatible = "adi,adv7123";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + adv7123_in: endpoint {
> + remote-endpoint = <_out_rgb>;
> + };
> + };
> + port@1 {
> + reg = <1>;
> + adv7123_out: endpoint {
> + remote-endpoint = <_in>;
> + };
> + };
> + };
> + };
> +
>   memory@4800 {
>   device_type = "memory";
>   /* first 128MB is reserved for secure area. */
> @@ -46,6 +78,11 @@
>   };
>   };
> 
> + du_pins: du {
> + groups = "du_rgb888", "du_sync", "du_disp", "du_dotclkout0";
> + function = "du";
> + };
> +
>   i2c0_pins: i2c0 {
>   groups = "i2c0";
>   function = "i2c0";
> @@ -95,6 +132,20 @@
>   status = "okay";
>  };
> 
> + {
> + pinctrl-0 = <_pins>;
> + pinctrl-names = "default";
> + status = "okay";
> +
> + ports {
> + port@0 {
> + endpoint {
> + remote-endpoint = <_in>;
> + };
> + };
> + };
> +};
> +
>   {
>   status = "okay";
>  };


-- 
Regards,

Laurent Pinchart

[PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU

2018-02-15 Thread Kieran Bingham 
From: Kieran Bingham 

Enable the DU, providing only the VGA output for now.

Signed-off-by: Kieran Bingham 
---
 arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 51 ++
 1 file changed, 51 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts 
b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
index af07da240be0..668e246dfc5d 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
@@ -27,6 +27,38 @@
stdout-path = "serial0:115200n8";
};
 
+   vga {
+   compatible = "vga-connector";
+
+   port {
+   vga_in: endpoint {
+   remote-endpoint = <_out>;
+   };
+   };
+   };
+
+   vga-encoder {
+   compatible = "adi,adv7123";
+
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   port@0 {
+   reg = <0>;
+   adv7123_in: endpoint {
+   remote-endpoint = <_out_rgb>;
+   };
+   };
+   port@1 {
+   reg = <1>;
+   adv7123_out: endpoint {
+   remote-endpoint = <_in>;
+   };
+   };
+   };
+   };
+
memory@4800 {
device_type = "memory";
/* first 128MB is reserved for secure area. */
@@ -46,6 +78,11 @@
};
};
 
+   du_pins: du {
+   groups = "du_rgb888", "du_sync", "du_disp", "du_dotclkout0";
+   function = "du";
+   };
+
i2c0_pins: i2c0 {
groups = "i2c0";
function = "i2c0";
@@ -95,6 +132,20 @@
status = "okay";
 };
 
+ {
+   pinctrl-0 = <_pins>;
+   pinctrl-names = "default";
+   status = "okay";
+
+   ports {
+   port@0 {
+   endpoint {
+   remote-endpoint = <_in>;
+   };
+   };
+   };
+};
+
  {
status = "okay";
 };
-- 
2.7.4

[PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU

2018-02-15 Thread Kieran Bingham 
From: Kieran Bingham 

Enable the DU, providing only the VGA output for now.

Signed-off-by: Kieran Bingham 
---
 arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 51 ++
 1 file changed, 51 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts 
b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
index af07da240be0..668e246dfc5d 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
@@ -27,6 +27,38 @@
stdout-path = "serial0:115200n8";
};
 
+   vga {
+   compatible = "vga-connector";
+
+   port {
+   vga_in: endpoint {
+   remote-endpoint = <_out>;
+   };
+   };
+   };
+
+   vga-encoder {
+   compatible = "adi,adv7123";
+
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   port@0 {
+   reg = <0>;
+   adv7123_in: endpoint {
+   remote-endpoint = <_out_rgb>;
+   };
+   };
+   port@1 {
+   reg = <1>;
+   adv7123_out: endpoint {
+   remote-endpoint = <_in>;
+   };
+   };
+   };
+   };
+
memory@4800 {
device_type = "memory";
/* first 128MB is reserved for secure area. */
@@ -46,6 +78,11 @@
};
};
 
+   du_pins: du {
+   groups = "du_rgb888", "du_sync", "du_disp", "du_dotclkout0";
+   function = "du";
+   };
+
i2c0_pins: i2c0 {
groups = "i2c0";
function = "i2c0";
@@ -95,6 +132,20 @@
status = "okay";
 };
 
+ {
+   pinctrl-0 = <_pins>;
+   pinctrl-names = "default";
+   status = "okay";
+
+   ports {
+   port@0 {
+   endpoint {
+   remote-endpoint = <_in>;
+   };
+   };
+   };
+};
+
  {
status = "okay";
 };
-- 
2.7.4