Re: [PATCH v9 2/2] ARM: dts: add TOPEET itop elite based board
On Wed, Oct 19, 2016 at 4:15 AM, Ayaka wrote: > > > 從我的 iPad 傳送 > >> Krzysztof Kozlowski 於 2016年10月19日 上午1:37 寫道： >> >>> On Wed, Oct 19, 2016 at 01:18:49AM +0800, Randy Li wrote: >>> The TOPEET itop exynos 4412 have three versions base board. The >>> Elite version is the cheap one without too much peripheral devices >>> on it. >>> >>> Currently supported are serial console, wired networking(USB), >>> USB OTG in peripheral mode, USB host, SD storage, GPIO buttons, >>> PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also >>> enabled. >>> >>> The FIMC is not used for camera currently, I enabled it just for a >>> colorspace converter. >>> >>> Signed-off-by: Randy Li >>> Reviewed-by: Krzysztof Kozlowski >> >> Thanks, applied, with missing Rob's ack, minor changes in commit msg and >> fix in pin function (you used macro for pull up/down instead of >> function). > The last time I saw the other dts have applied that, but they are not now. A > header file is also missed reported by kbuild, but I didn't meet that. I wonder why I didn't encounter the build error on my machine... This needs a follow up fix. Best regards, Krzysztof
Re: [PATCH v9 2/2] ARM: dts: add TOPEET itop elite based board
從我的 iPad 傳送 > Krzysztof Kozlowski 於 2016年10月19日 上午1:37 寫道： > >> On Wed, Oct 19, 2016 at 01:18:49AM +0800, Randy Li wrote: >> The TOPEET itop exynos 4412 have three versions base board. The >> Elite version is the cheap one without too much peripheral devices >> on it. >> >> Currently supported are serial console, wired networking(USB), >> USB OTG in peripheral mode, USB host, SD storage, GPIO buttons, >> PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also >> enabled. >> >> The FIMC is not used for camera currently, I enabled it just for a >> colorspace converter. >> >> Signed-off-by: Randy Li >> Reviewed-by: Krzysztof Kozlowski > > Thanks, applied, with missing Rob's ack, minor changes in commit msg and > fix in pin function (you used macro for pull up/down instead of > function). The last time I saw the other dts have applied that, but they are not now. A header file is also missed reported by kbuild, but I didn't meet that. > > Best regards, > Krzysztof
Re: [PATCH v9 2/2] ARM: dts: add TOPEET itop elite based board
On Tue, Oct 18, 2016 at 8:47 PM, Krzysztof Kozlowski wrote: > On Tue, Oct 18, 2016 at 08:37:48PM +0300, Krzysztof Kozlowski wrote: >> On Wed, Oct 19, 2016 at 01:18:49AM +0800, Randy Li wrote: >> > The TOPEET itop exynos 4412 have three versions base board. The >> > Elite version is the cheap one without too much peripheral devices >> > on it. >> > >> > Currently supported are serial console, wired networking(USB), >> > USB OTG in peripheral mode, USB host, SD storage, GPIO buttons, >> > PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also >> > enabled. >> > >> > The FIMC is not used for camera currently, I enabled it just for a >> > colorspace converter. >> > >> > Signed-off-by: Randy Li >> > Reviewed-by: Krzysztof Kozlowski >> >> Thanks, applied, with missing Rob's ack, minor changes in commit msg and >> fix in pin function (you used macro for pull up/down instead of >> function). > > I also changed your name in commit message from "ayaka" to "Randy Li". > The author of a patch (equal to "From:" in email) should match the > Signed-off-by. For the future, please fix your gitconfig and/or mail > transfer program. Ahhh, it is not your fault but patchwork's. Damn it. Patchwork stores the first username he encounters and uses it further even if From is different. I will send an email to kernel.org Patchwork admin about this. Best regards, Krzysztof
Re: [PATCH v9 2/2] ARM: dts: add TOPEET itop elite based board
On Tue, Oct 18, 2016 at 08:37:48PM +0300, Krzysztof Kozlowski wrote: > On Wed, Oct 19, 2016 at 01:18:49AM +0800, Randy Li wrote: > > The TOPEET itop exynos 4412 have three versions base board. The > > Elite version is the cheap one without too much peripheral devices > > on it. > > > > Currently supported are serial console, wired networking(USB), > > USB OTG in peripheral mode, USB host, SD storage, GPIO buttons, > > PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also > > enabled. > > > > The FIMC is not used for camera currently, I enabled it just for a > > colorspace converter. > > > > Signed-off-by: Randy Li > > Reviewed-by: Krzysztof Kozlowski > > Thanks, applied, with missing Rob's ack, minor changes in commit msg and > fix in pin function (you used macro for pull up/down instead of > function). I also changed your name in commit message from "ayaka" to "Randy Li". The author of a patch (equal to "From:" in email) should match the Signed-off-by. For the future, please fix your gitconfig and/or mail transfer program. Sample gitconfig regarding this: [user] name = Mr Foo Bar email = foo...@gmail.com [sendemail] smtpencryption = tls smtpserver = smtp.gmail.com smtpuser = foo...@gmail.com smtpserverport = 587 confirm = auto Best regards, Krzysztof
Re: [PATCH v9 2/2] ARM: dts: add TOPEET itop elite based board
On Wed, Oct 19, 2016 at 01:18:49AM +0800, Randy Li wrote: > The TOPEET itop exynos 4412 have three versions base board. The > Elite version is the cheap one without too much peripheral devices > on it. > > Currently supported are serial console, wired networking(USB), > USB OTG in peripheral mode, USB host, SD storage, GPIO buttons, > PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also > enabled. > > The FIMC is not used for camera currently, I enabled it just for a > colorspace converter. > > Signed-off-by: Randy Li > Reviewed-by: Krzysztof Kozlowski Thanks, applied, with missing Rob's ack, minor changes in commit msg and fix in pin function (you used macro for pull up/down instead of function). Best regards, Krzysztof
[PATCH v9 2/2] ARM: dts: add TOPEET itop elite based board
The TOPEET itop exynos 4412 have three versions base board. The
Elite version is the cheap one without too much peripheral devices
on it.
Currently supported are serial console, wired networking(USB),
USB OTG in peripheral mode, USB host, SD storage, GPIO buttons,
PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also
enabled.
The FIMC is not used for camera currently, I enabled it just for a
colorspace converter.
Signed-off-by: Randy Li
Reviewed-by: Krzysztof Kozlowski
---
.../bindings/arm/samsung/samsung-boards.txt| 3 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/exynos4412-itop-elite.dts| 240 +
3 files changed, 244 insertions(+)
create mode 100644 arch/arm/boot/dts/exynos4412-itop-elite.dts
diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
index 0ea7f14..5160fa5 100644
--- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
@@ -22,6 +22,9 @@ Required root node properties:
* FriendlyARM
- "friendlyarm,tiny4412" - for Exynos4412-based FriendlyARM
TINY4412 board.
+ * TOPEET
+ - "topeet,itop4412-elite" - for Exynos4412-based TOPEET
+Elite base board.
* Google
- "google,pi" - for Exynos5800-based Google Peach Pi
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index befcd26..d709f74 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -136,6 +136,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
exynos4210-smdkv310.dtb \
exynos4210-trats.dtb \
exynos4210-universal_c210.dtb \
+ exynos4412-itop-elite.dtb \
exynos4412-odroidu3.dtb \
exynos4412-odroidx.dtb \
exynos4412-odroidx2.dtb \
diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts
b/arch/arm/boot/dts/exynos4412-itop-elite.dts
new file mode 100644
index 000..7440e54
--- /dev/null
+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
@@ -0,0 +1,240 @@
+/*
+ * TOPEET's Exynos4412 based itop board device tree source
+ *
+ * Copyright (c) 2016 SUMOMO Computer Association
+ * https://www.sumomo.mobi
+ * Randy Li
+ *
+ * Device tree source file for TOPEET iTop Exynos 4412 core board
+ * which is based on Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+/dts-v1/;
+#include
+#include
+#include "exynos4412-itop-scp-core.dtsi"
+
+/ {
+ model = "TOPEET iTop 4412 Elite board based on Exynos4412";
+ compatible = "topeet,itop4412-elite", "samsung,exynos4412",
"samsung,exynos4";
+
+ chosen {
+ bootargs = "root=/dev/mmcblk0p2 rw rootfstype=ext4 rootdelay=1
rootwait";
+ stdout-path = "serial2:115200n8";
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ led2 {
+ label = "red:system";
+ gpios = <&gpx1 0 GPIO_ACTIVE_HIGH>;
+ default-state = "off";
+ linux,default-trigger = "heartbeat";
+ };
+
+ led3 {
+ label = "red:user";
+ gpios = <&gpk1 1 GPIO_ACTIVE_HIGH>;
+ default-state = "off";
+ };
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+
+ home {
+ label = "GPIO Key Home";
+ linux,code = ;
+ gpios = <&gpx1 1 GPIO_ACTIVE_LOW>;
+ };
+
+ back {
+ label = "GPIO Key Back";
+ linux,code = ;
+ gpios = <&gpx1 2 GPIO_ACTIVE_LOW>;
+ };
+
+ sleep {
+ label = "GPIO Key Sleep";
+ linux,code = ;
+ gpios = <&gpx3 3 GPIO_ACTIVE_LOW>;
+ };
+
+ vol-up {
+ label = "GPIO Key Vol+";
+ linux,code = ;
+ gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
+ };
+
+ vol-down {
+ label = "GPIO Key Vol-";
+ linux,code = ;
+ gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
+ };
+ };
+
+ sound {
+ compatible = "simple-audio-card";
+ simple-audio-card,name = "wm-sound";
+
+ assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
+ <&clock_audss EXYNOS_MOUT_I2S>,
+ <&clock_audss EXY
