Re: [PATCH 4.14 053/118] Revert "Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find.""
On Tue, Jan 16, 2018 at 10:32:38AM -0500, David Miller wrote: > From: Steffen Klassert > Date: Tue, 16 Jan 2018 07:33:39 +0100 > > > Maybe you started to look again into this because Nicolas Dichtel > > (Cced) asked to queue this patch on Jan 5, the patch was already > > in the stable tree (Jan 4) but probably not in an actual release > > at this time. > > Yeah that's part of why I was confused. > > > I think we can we can just drop this. > > > > Unless Nicolas knows something that is still missing, v4.14.12 and > > above should be ok as is. > > Ok, then Greg please drop this. Now dropped, thanks. greg k-h
Re: [PATCH 4.14 053/118] Revert "Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find.""
From: Steffen Klassert Date: Tue, 16 Jan 2018 07:33:39 +0100 > Maybe you started to look again into this because Nicolas Dichtel > (Cced) asked to queue this patch on Jan 5, the patch was already > in the stable tree (Jan 4) but probably not in an actual release > at this time. Yeah that's part of why I was confused. > I think we can we can just drop this. > > Unless Nicolas knows something that is still missing, v4.14.12 and > above should be ok as is. Ok, then Greg please drop this. Thanks Steffen.
Re: [PATCH 4.14 053/118] Revert "Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find.""
On Tue, Jan 16, 2018 at 08:44:41AM +0100, Nicolas Dichtel wrote: > Le 16/01/2018 à 07:33, Steffen Klassert a écrit : > > > > Maybe you started to look again into this because Nicolas Dichtel > > (Cced) asked to queue this patch on Jan 5, the patch was already > > in the stable tree (Jan 4) but probably not in an actual release > > at this time. > Oh, I didn't find it at this time in the linux-stable tree nor in the stable > patchwork. Bad timing :/ > > I still don't find it in the patchwork: > http://patchwork.ozlabs.org/bundle/davem/stable/?series=&submitter=1442&state=*&q=&archive=both > Am I missing something? Not so sure which patches are included here, maybe just the ones that still needs to be submitted to stable. Anyway, the commit we need is included in v4.14.12: commit 2d01ac8cc12b973668bf898b03bf9ffb12d83b83 Author: Steffen Klassert Date: Wed, 15 Nov 2017 06:40:57 +0100 Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find." commit 94802151894d482e82c324edf2c658f8e6b96508 upstream. This reverts commit c9f3f813d462c72dbe412cee6a5cbacf13c4ad5e. This commit breaks transport mode when the policy template has widlcard addresses configured, so revert it. Signed-off-by: Steffen Klassert Cc: From: Derek Robson Signed-off-by: Greg Kroah-Hartman > > > > >> > >> We can drop this, but you need to then tell us whether 4.14 needs > >> the revert any longer and if so what the correct SHA ID would > >> be. > > > > I think we can we can just drop this. > > > > Unless Nicolas knows something that is still missing, v4.14.12 and > > above should be ok as is. > I agree, we can drop this. Ok, so let's drop it. Thanks!
Re: [PATCH 4.14 053/118] Revert "Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find.""
Le 16/01/2018 à 07:33, Steffen Klassert a écrit : > On Mon, Jan 15, 2018 at 11:56:12AM -0500, David Miller wrote: >> From: Steffen Klassert >> Date: Mon, 15 Jan 2018 14:23:29 +0100 >> >>> On Mon, Jan 15, 2018 at 01:34:40PM +0100, Greg Kroah-Hartman wrote: 4.14-stable review patch. If anyone has any objections, please let me know. -- From: "David S. Miller" This reverts commit 94802151894d482e82c324edf2c658f8e6b96508. It breaks transport mode when the policy template has wildcard addresses configured. Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman >>> >>> Hm, this seems to be one revert too much. >>> >>> commit 94802151894d482e82c324edf2c658f8e6b96508 reverted already >>> the buggy commit. Reverting the revert will bring the bug back. >> >> Steffen, in the email where you asked me to revert that is the >> commit ID you referenced. > > I think there was a misunderstanding. I asked you to queue the > commit with that ID to stable on Dec 23 (this commit ID is the > revert of the buggy patch). This commit was included to stable > on Jan 4 then: > > https://www.spinics.net/lists/stable/msg208727.html > > So with this, everything was ok. > > Maybe you started to look again into this because Nicolas Dichtel > (Cced) asked to queue this patch on Jan 5, the patch was already > in the stable tree (Jan 4) but probably not in an actual release > at this time. Oh, I didn't find it at this time in the linux-stable tree nor in the stable patchwork. Bad timing :/ I still don't find it in the patchwork: http://patchwork.ozlabs.org/bundle/davem/stable/?series=&submitter=1442&state=*&q=&archive=both Am I missing something? > >> >> We can drop this, but you need to then tell us whether 4.14 needs >> the revert any longer and if so what the correct SHA ID would >> be. > > I think we can we can just drop this. > > Unless Nicolas knows something that is still missing, v4.14.12 and > above should be ok as is. I agree, we can drop this. Thank you, Nicolas
Re: [PATCH 4.14 053/118] Revert "Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find.""
On Mon, Jan 15, 2018 at 11:56:12AM -0500, David Miller wrote: > From: Steffen Klassert > Date: Mon, 15 Jan 2018 14:23:29 +0100 > > > On Mon, Jan 15, 2018 at 01:34:40PM +0100, Greg Kroah-Hartman wrote: > >> 4.14-stable review patch. If anyone has any objections, please let me > >> know. > >> > >> -- > >> > >> From: "David S. Miller" > >> > >> > >> This reverts commit 94802151894d482e82c324edf2c658f8e6b96508. > >> > >> It breaks transport mode when the policy template has > >> wildcard addresses configured. > >> > >> Signed-off-by: David S. Miller > >> Signed-off-by: Greg Kroah-Hartman > > > > Hm, this seems to be one revert too much. > > > > commit 94802151894d482e82c324edf2c658f8e6b96508 reverted already > > the buggy commit. Reverting the revert will bring the bug back. > > Steffen, in the email where you asked me to revert that is the > commit ID you referenced. I think there was a misunderstanding. I asked you to queue the commit with that ID to stable on Dec 23 (this commit ID is the revert of the buggy patch). This commit was included to stable on Jan 4 then: https://www.spinics.net/lists/stable/msg208727.html So with this, everything was ok. Maybe you started to look again into this because Nicolas Dichtel (Cced) asked to queue this patch on Jan 5, the patch was already in the stable tree (Jan 4) but probably not in an actual release at this time. > > We can drop this, but you need to then tell us whether 4.14 needs > the revert any longer and if so what the correct SHA ID would > be. I think we can we can just drop this. Unless Nicolas knows something that is still missing, v4.14.12 and above should be ok as is.
Re: [PATCH 4.14 053/118] Revert "Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find.""
From: Steffen Klassert Date: Mon, 15 Jan 2018 14:23:29 +0100 > On Mon, Jan 15, 2018 at 01:34:40PM +0100, Greg Kroah-Hartman wrote: >> 4.14-stable review patch. If anyone has any objections, please let me know. >> >> -- >> >> From: "David S. Miller" >> >> >> This reverts commit 94802151894d482e82c324edf2c658f8e6b96508. >> >> It breaks transport mode when the policy template has >> wildcard addresses configured. >> >> Signed-off-by: David S. Miller >> Signed-off-by: Greg Kroah-Hartman > > Hm, this seems to be one revert too much. > > commit 94802151894d482e82c324edf2c658f8e6b96508 reverted already > the buggy commit. Reverting the revert will bring the bug back. Steffen, in the email where you asked me to revert that is the commit ID you referenced. We can drop this, but you need to then tell us whether 4.14 needs the revert any longer and if so what the correct SHA ID would be.
Re: [PATCH 4.14 053/118] Revert "Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find.""
On Mon, Jan 15, 2018 at 02:23:29PM +0100, Steffen Klassert wrote: > On Mon, Jan 15, 2018 at 01:34:40PM +0100, Greg Kroah-Hartman wrote: > > 4.14-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: "David S. Miller" > > > > > > This reverts commit 94802151894d482e82c324edf2c658f8e6b96508. > > > > It breaks transport mode when the policy template has > > wildcard addresses configured. > > > > Signed-off-by: David S. Miller > > Signed-off-by: Greg Kroah-Hartman > > Hm, this seems to be one revert too much. > > commit 94802151894d482e82c324edf2c658f8e6b96508 reverted already > the buggy commit. Reverting the revert will bring the bug back. Really? I have no idea what is going on here, I just take the patches that David gives me :) David, should I drop this one? thanks, greg k-h
Re: [PATCH 4.14 053/118] Revert "Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find.""
On Mon, Jan 15, 2018 at 01:34:40PM +0100, Greg Kroah-Hartman wrote: > 4.14-stable review patch. If anyone has any objections, please let me know. > > -- > > From: "David S. Miller" > > > This reverts commit 94802151894d482e82c324edf2c658f8e6b96508. > > It breaks transport mode when the policy template has > wildcard addresses configured. > > Signed-off-by: David S. Miller > Signed-off-by: Greg Kroah-Hartman Hm, this seems to be one revert too much. commit 94802151894d482e82c324edf2c658f8e6b96508 reverted already the buggy commit. Reverting the revert will bring the bug back.