Re: linux-next: build warning after merge of the clk tree
Quoting Stephen Rothwell (2020-07-08 04:10:44) > Hi all, > > On Tue, 30 Jun 2020 10:11:15 +0200 Maxime Ripard wrote: > > > > On Tue, Jun 30, 2020 at 09:53:41AM +1000, Stephen Rothwell wrote: > > > After merging the clk tree, today's linux-next build (x86_64 allmodconfig) > > > produced this warning: > > > > > > WARNING: modpost: missing MODULE_LICENSE() in > > > drivers/clk/bcm/clk-bcm2711-dvp.o > > > > > > Introduced by commit > > > > > > 1bc95972715a ("clk: bcm: Add BCM2711 DVP driver") > > > > I've posted a patch solving this already: > > https://lore.kernel.org/linux-clk/20200626112513.90816-1-max...@cerno.tech/ > > > > And it's supposed to be in clk-next since friday, but it looks like > > stephen didn't push his branch? > > I am still getting this warning. > Sorry I forgot to push it out. Should be fixed now.
Re: linux-next: build warning after merge of the clk tree
Hi all, On Tue, 30 Jun 2020 10:11:15 +0200 Maxime Ripard wrote: > > On Tue, Jun 30, 2020 at 09:53:41AM +1000, Stephen Rothwell wrote: > > After merging the clk tree, today's linux-next build (x86_64 allmodconfig) > > produced this warning: > > > > WARNING: modpost: missing MODULE_LICENSE() in > > drivers/clk/bcm/clk-bcm2711-dvp.o > > > > Introduced by commit > > > > 1bc95972715a ("clk: bcm: Add BCM2711 DVP driver") > > I've posted a patch solving this already: > https://lore.kernel.org/linux-clk/20200626112513.90816-1-max...@cerno.tech/ > > And it's supposed to be in clk-next since friday, but it looks like > stephen didn't push his branch? I am still getting this warning. -- Cheers, Stephen Rothwell pgpkz_2ob4ojP.pgp Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the clk tree
Hi, On Tue, Jun 30, 2020 at 09:53:41AM +1000, Stephen Rothwell wrote: > After merging the clk tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > WARNING: modpost: missing MODULE_LICENSE() in > drivers/clk/bcm/clk-bcm2711-dvp.o > > Introduced by commit > > 1bc95972715a ("clk: bcm: Add BCM2711 DVP driver") I've posted a patch solving this already: https://lore.kernel.org/linux-clk/20200626112513.90816-1-max...@cerno.tech/ And it's supposed to be in clk-next since friday, but it looks like stephen didn't push his branch? Maxime signature.asc Description: PGP signature
linux-next: build warning after merge of the clk tree
Hi all, After merging the clk tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/bcm/clk-bcm2711-dvp.o Introduced by commit 1bc95972715a ("clk: bcm: Add BCM2711 DVP driver") -- Cheers, Stephen Rothwell pgp5fz3jxfSAT.pgp Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the clk tree
Quoting Stephen Rothwell (2019-08-15 16:57:32) > Hi all, > > After merging the clk tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > drivers/clk/actions/owl-common.c: In function 'owl_clk_probe': > drivers/clk/actions/owl-common.c:71:24: warning: 'hw' may be used > uninitialized in this function [-Wmaybe-uninitialized] >const char *name = hw->init->name; > ~~^~ > > Introduced by commit > > 20cac6d02815 ("clk: actions: Don't reference clk_init_data after > registration") > > Clearly not a false positive. :-( > Thanks. I fixed it now.
linux-next: build warning after merge of the clk tree
Hi all, After merging the clk tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/clk/actions/owl-common.c: In function 'owl_clk_probe': drivers/clk/actions/owl-common.c:71:24: warning: 'hw' may be used uninitialized in this function [-Wmaybe-uninitialized] const char *name = hw->init->name; ~~^~ Introduced by commit 20cac6d02815 ("clk: actions: Don't reference clk_init_data after registration") Clearly not a false positive. :-( -- Cheers, Stephen Rothwell pgpz_j1OaFoNa.pgp Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the clk tree
Hi Anson, On Tue, 30 Apr 2019 01:44:58 + Anson Huang wrote: > > Thanks for notice. > As it is intentional, I will send out a patch to add "/* fall through > */" to avoid this build warning, Excellent, thanks. -- Cheers, Stephen Rothwell pgpWOKjnAq9zo.pgp Description: OpenPGP digital signature
RE: linux-next: build warning after merge of the clk tree
Hi, Stephen Thanks for notice. As it is intentional, I will send out a patch to add "/* fall through */" to avoid this build warning, Anson. > -Original Message- > From: Stephen Rothwell [mailto:s...@canb.auug.org.au] > Sent: Tuesday, April 30, 2019 8:20 AM > To: Mike Turquette ; Stephen Boyd > > Cc: Linux Next Mailing List ; Linux Kernel Mailing > List ; Anson Huang ; > Gustavo A. R. Silva ; Kees Cook > > Subject: linux-next: build warning after merge of the clk tree > > Hi all, > > After merging the clk tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall through > [- > Wimplicit-fallthrough=] >pll->denom_offset = PLL_IMX7_DENOM_OFFSET; > ^ > drivers/clk/imx/clk-pllv3.c:454:2: note: here > case IMX_PLLV3_AV: > ^~~~ > > Introduced by commit > > 01d0a541ff4b ("clk: imx: correct i.MX7D AV PLL num/denom offset") > > I get this warning because I am building with -Wimplicit-fallthrough in > attempt to catch new additions early. The gcc warning can be turned off by > adding a /* fall through */ comment at the point the fall through happens > (assuming that the fall through is intentional). > > -- > Cheers, > Stephen Rothwell
linux-next: build warning after merge of the clk tree
Hi all, After merging the clk tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall through [-Wimplicit-fallthrough=] pll->denom_offset = PLL_IMX7_DENOM_OFFSET; ^ drivers/clk/imx/clk-pllv3.c:454:2: note: here case IMX_PLLV3_AV: ^~~~ Introduced by commit 01d0a541ff4b ("clk: imx: correct i.MX7D AV PLL num/denom offset") I get this warning because I am building with -Wimplicit-fallthrough in attempt to catch new additions early. The gcc warning can be turned off by adding a /* fall through */ comment at the point the fall through happens (assuming that the fall through is intentional). -- Cheers, Stephen Rothwell pgpR5FqmhWY5J.pgp Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the clk tree
Quoting Stephen Rothwell (2018-10-17 14:51:53) > Hi all, > > After merging the clk tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/qcom/gcc-sdm660.o > see include/linux/module.h for more information > > Introduced by commit > > f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for > SDM660") > Thanks! I silenced it.
linux-next: build warning after merge of the clk tree
Hi all, After merging the clk tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/qcom/gcc-sdm660.o see include/linux/module.h for more information Introduced by commit f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for SDM660") -- Cheers, Stephen Rothwell pgp3FfFnVjYlC.pgp Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the clk tree
Hi Boris, On Mon, 12 Dec 2016 09:05:21 +0100 Boris Brezillon wrote: > > May I ask which toolchain you're using, because my gcc failed to detect > this uninitialized variable (and this is not the first time I have this > problem). I use a powerpc-le hosted cross compiler gcc-5.2.0. -- Cheers, Stephen Rothwell
Re: linux-next: build warning after merge of the clk tree
+Eric Hi Stephen, On Mon, 12 Dec 2016 08:39:44 +1100 Stephen Rothwell wrote: > Hi all, > > After merging the clk tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/clk/bcm/clk-bcm2835.c: In function 'bcm2835_clock_determine_rate': > drivers/clk/bcm/clk-bcm2835.c:1069:18: warning: 'best_rate' may be used > uninitialized in this function [-Wmaybe-uninitialized] > *prate = curdiv * best_rate; > ^ > drivers/clk/bcm/clk-bcm2835.c:1032:16: note: 'best_rate' was declared here > unsigned long best_rate; > ^ > > Introduced by commit > > 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks") > Thanks for the report (I just sent a patch fixing this warning). May I ask which toolchain you're using, because my gcc failed to detect this uninitialized variable (and this is not the first time I have this problem). Regards, Boris
linux-next: build warning after merge of the clk tree
Hi all, After merging the clk tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/clk/bcm/clk-bcm2835.c: In function 'bcm2835_clock_determine_rate': drivers/clk/bcm/clk-bcm2835.c:1069:18: warning: 'best_rate' may be used uninitialized in this function [-Wmaybe-uninitialized] *prate = curdiv * best_rate; ^ drivers/clk/bcm/clk-bcm2835.c:1032:16: note: 'best_rate' was declared here unsigned long best_rate; ^ Introduced by commit 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks") -- Cheers, Stephen Rothwell
Re: linux-next: build warning after merge of the clk tree
On 05/06, Stephen Rothwell wrote: > Hi all, > > After merging the clk tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > drivers/clk/clk.c:2231:13: warning: 'clk_is_orphan' defined but not used > [-Wunused-function] > static bool clk_is_orphan(const struct clk *clk) > ^ > > Introduced by commit ece3ffbe1b7b ("clk: prevent orphan clocks from > being used"). > > CONFIG_OF is not set for this build ... Thanks for the report. kbuild robot also reported this problem the other day. We came up with a way to not have this function at all though so this problem should go away tomorrow. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build warning after merge of the clk tree
Hi all, After merging the clk tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/clk/clk.c:2231:13: warning: 'clk_is_orphan' defined but not used [-Wunused-function] static bool clk_is_orphan(const struct clk *clk) ^ Introduced by commit ece3ffbe1b7b ("clk: prevent orphan clocks from being used"). CONFIG_OF is not set for this build ... -- Cheers, Stephen Rothwells...@canb.auug.org.au pgp2RFVV5FHul.pgp Description: OpenPGP digital signature