Re: [PATCH v3 00/10]HDMI: Split hdmi.c in DSS to seperate OMAP dependent
Hi, On Mon, Sep 5, 2011 at 6:52 PM, K, Mythri P mythr...@ti.com wrote: Hi, On Mon, Sep 5, 2011 at 5:45 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2011-09-02 at 16:17 +0530, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com HDMI IP block is common between TI OMAP4 Procerssor and Netra processor although the Display subsytem is different.Also the IP block in future OMAP may differ from the one existing in OMAP4. Thus to reuse the code between these two processors , and maintain the multi omap build functionality in DSS. HDMI IP dependant code is seperated out from hdmi.c and moved to new library file hdmi_ti_4xxx_ip.c.From the DSS dependent HDMI code only the function pointer to functionality/features offered by HDMI is called. This patch series does the split and also renames hdmi_omap4_panel.c to hdmi_panel.c as that file has nothing specific to OMAP4 and can be reused for other OMAP family of processors as well. This patch series is based on Tomi's LO-DSS2 master branch. The kernel doesn't compile at all after enabling SND_OMAP_SOC_OMAP4_HDMI. Looks like you didn't move any of the sound stuff, but just left them in hdmi.c file. I shall check this, may be i should handle some dependency but i didnt think there were any direct dependency , i guess you need to enable some audio files as well? let me check. There is a dependency on the audio files on the register writers and i was not very sure on what would be a genuine API v's what can be a static function. Ricardo any comments would you like to post a patch on top of this series ? thanks and regards, Mythri. Tomi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/10]HDMI: Split hdmi.c in DSS to seperate OMAP dependent
Hi, On Tue, Sep 6, 2011 at 3:09 PM, K, Mythri P mythr...@ti.com wrote: Hi, On Mon, Sep 5, 2011 at 6:52 PM, K, Mythri P mythr...@ti.com wrote: Hi, On Mon, Sep 5, 2011 at 5:45 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2011-09-02 at 16:17 +0530, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com HDMI IP block is common between TI OMAP4 Procerssor and Netra processor although the Display subsytem is different.Also the IP block in future OMAP may differ from the one existing in OMAP4. Thus to reuse the code between these two processors , and maintain the multi omap build functionality in DSS. HDMI IP dependant code is seperated out from hdmi.c and moved to new library file hdmi_ti_4xxx_ip.c.From the DSS dependent HDMI code only the function pointer to functionality/features offered by HDMI is called. This patch series does the split and also renames hdmi_omap4_panel.c to hdmi_panel.c as that file has nothing specific to OMAP4 and can be reused for other OMAP family of processors as well. This patch series is based on Tomi's LO-DSS2 master branch. The kernel doesn't compile at all after enabling SND_OMAP_SOC_OMAP4_HDMI. Looks like you didn't move any of the sound stuff, but just left them in hdmi.c file. I shall check this, may be i should handle some dependency but i didnt think there were any direct dependency , i guess you need to enable some audio files as well? let me check. There is a dependency on the audio files on the register writers and i was not very sure on what would be a genuine API v's what can be a static function. Ricardo any comments would you like to post a patch on top of this series ? I have made a temporary patch to move the IP dependent audio functions to ti_hdmi_4xxx_ip.c and i see it compiles fine, later on we can decide on what could be the API's and move the audio(non IP dependent ) portion out of DSS ? are you ok with that ? Thanks and regards, Mythri. thanks and regards, Mythri. Tomi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/10]HDMI: Split hdmi.c in DSS to seperate OMAP dependent
On Fri, 2011-09-02 at 16:17 +0530, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com HDMI IP block is common between TI OMAP4 Procerssor and Netra processor although the Display subsytem is different.Also the IP block in future OMAP may differ from the one existing in OMAP4. Thus to reuse the code between these two processors , and maintain the multi omap build functionality in DSS. HDMI IP dependant code is seperated out from hdmi.c and moved to new library file hdmi_ti_4xxx_ip.c.From the DSS dependent HDMI code only the function pointer to functionality/features offered by HDMI is called. This patch series does the split and also renames hdmi_omap4_panel.c to hdmi_panel.c as that file has nothing specific to OMAP4 and can be reused for other OMAP family of processors as well. This patch series is based on Tomi's LO-DSS2 master branch. The kernel doesn't compile at all after enabling SND_OMAP_SOC_OMAP4_HDMI. Looks like you didn't move any of the sound stuff, but just left them in hdmi.c file. Tomi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/10]HDMI: Split hdmi.c in DSS to seperate OMAP dependent
Hi, On Mon, Sep 5, 2011 at 5:45 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2011-09-02 at 16:17 +0530, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com HDMI IP block is common between TI OMAP4 Procerssor and Netra processor although the Display subsytem is different.Also the IP block in future OMAP may differ from the one existing in OMAP4. Thus to reuse the code between these two processors , and maintain the multi omap build functionality in DSS. HDMI IP dependant code is seperated out from hdmi.c and moved to new library file hdmi_ti_4xxx_ip.c.From the DSS dependent HDMI code only the function pointer to functionality/features offered by HDMI is called. This patch series does the split and also renames hdmi_omap4_panel.c to hdmi_panel.c as that file has nothing specific to OMAP4 and can be reused for other OMAP family of processors as well. This patch series is based on Tomi's LO-DSS2 master branch. The kernel doesn't compile at all after enabling SND_OMAP_SOC_OMAP4_HDMI. Looks like you didn't move any of the sound stuff, but just left them in hdmi.c file. I shall check this, may be i should handle some dependency but i didnt think there were any direct dependency , i guess you need to enable some audio files as well? let me check. Tomi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/10]HDMI: Split hdmi.c in DSS to seperate OMAP dependent
On Fri, 2011-09-02 at 16:17 +0530, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com HDMI IP block is common between TI OMAP4 Procerssor and Netra processor although the Display subsytem is different.Also the IP block in future OMAP may differ from the one existing in OMAP4. Thus to reuse the code between these two processors , and maintain the multi omap build functionality in DSS. HDMI IP dependant code is seperated out from hdmi.c and moved to new library file hdmi_ti_4xxx_ip.c.From the DSS dependent HDMI code only the function pointer to functionality/features offered by HDMI is called. This patch series does the split and also renames hdmi_omap4_panel.c to hdmi_panel.c as that file has nothing specific to OMAP4 and can be reused for other OMAP family of processors as well. This patch series is based on Tomi's LO-DSS2 master branch. changes since V2: Rename certain files/function to have standard format and handle scenario when hdmi is disabled. V1: Function pointer approach to call the HDMI IP functions from DSS HDMI No change log for this version. It'd be nice to have it, so it's easier to see what changes made into this version. I also see this when compiling with sparse: drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c:166:5: warning: symbol 'hdmi_set_pll_pwr' was not declared. Should it be static? Tomi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/10]HDMI: Split hdmi.c in DSS to seperate OMAP dependent
Hi, On Mon, Sep 5, 2011 at 1:10 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2011-09-02 at 16:17 +0530, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com HDMI IP block is common between TI OMAP4 Procerssor and Netra processor although the Display subsytem is different.Also the IP block in future OMAP may differ from the one existing in OMAP4. Thus to reuse the code between these two processors , and maintain the multi omap build functionality in DSS. HDMI IP dependant code is seperated out from hdmi.c and moved to new library file hdmi_ti_4xxx_ip.c.From the DSS dependent HDMI code only the function pointer to functionality/features offered by HDMI is called. This patch series does the split and also renames hdmi_omap4_panel.c to hdmi_panel.c as that file has nothing specific to OMAP4 and can be reused for other OMAP family of processors as well. This patch series is based on Tomi's LO-DSS2 master branch. changes since V2: Rename certain files/function to have standard format and handle scenario when hdmi is disabled. V1: Function pointer approach to call the HDMI IP functions from DSS HDMI I guess i shall change the description , it is changes since , so v2 would be actually changes since v2 to v3. No change log for this version. It'd be nice to have it, so it's easier to see what changes made into this version. I also see this when compiling with sparse: drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c:166:5: warning: symbol 'hdmi_set_pll_pwr' was not declared. Should it be static? I missed running sparse i shall fix it and send out. Tomi Thanks and regards, Mythri. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/10]HDMI: Split hdmi.c in DSS to seperate OMAP dependent
On Mon, 2011-09-05 at 16:05 +0530, K, Mythri P wrote: Hi, On Mon, Sep 5, 2011 at 1:10 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2011-09-02 at 16:17 +0530, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com HDMI IP block is common between TI OMAP4 Procerssor and Netra processor although the Display subsytem is different.Also the IP block in future OMAP may differ from the one existing in OMAP4. Thus to reuse the code between these two processors , and maintain the multi omap build functionality in DSS. HDMI IP dependant code is seperated out from hdmi.c and moved to new library file hdmi_ti_4xxx_ip.c.From the DSS dependent HDMI code only the function pointer to functionality/features offered by HDMI is called. This patch series does the split and also renames hdmi_omap4_panel.c to hdmi_panel.c as that file has nothing specific to OMAP4 and can be reused for other OMAP family of processors as well. This patch series is based on Tomi's LO-DSS2 master branch. changes since V2: Rename certain files/function to have standard format and handle scenario when hdmi is disabled. V1: Function pointer approach to call the HDMI IP functions from DSS HDMI I guess i shall change the description , it is changes since , so v2 would be actually changes since v2 to v3. Ah, my mistake, I didn't read it carefully. I expected the change log to be missing as there was only one change note, and there were other things changed also in this version. So I'll change my comment to: It'd be nice to list most (if not all) of the changes made, so it's easier for the reviewers to see that their comments were applied into this version. Tomi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 00/10]HDMI: Split hdmi.c in DSS to seperate OMAP dependent
From: Mythri P K mythr...@ti.com
HDMI IP block is common between TI OMAP4 Procerssor and Netra processor although
the Display subsytem is different.Also the IP block in future OMAP may differ
from the one existing in OMAP4. Thus to reuse the code between these two
processors , and maintain the multi omap build functionality in DSS.
HDMI IP dependant code is seperated out from hdmi.c and moved to
new library file hdmi_ti_4xxx_ip.c.From the DSS dependent HDMI code only the
function pointer to functionality/features offered by HDMI is called.
This patch series does the split and also renames hdmi_omap4_panel.c to
hdmi_panel.c as that file has nothing specific to OMAP4 and can be reused for
other OMAP family of processors as well.
This patch series is based on Tomi's LO-DSS2 master branch.
changes since
V2: Rename certain files/function to have standard format and handle scenario
when hdmi is disabled.
V1: Function pointer approach to call the HDMI IP functions from DSS HDMI
Mythri P K (10):
OMAP4: DSS: HDMI: HDMI clean up to pass base_address dynamically
to IP dependant functions of HDMI
MAP4: DSS: HDMI: Move pll and video configuration info to
ip_data structure
OMAP4: DSS: HDMI: Use specific HDMI timings structure instead of
OMAP DSS timings
OMAP4: DSS: HDMI: Move IP independent common header file
definition to generic header file
OMAP4 : DSS : HDMI : Move the EDID portion from HDMI IP header
OMAP4: DSS2: HDMI: Split the HDMI driver to DSS and IP
specific portion.
OMAP4: DSS: HDMI: Rename the functions in HDMI IP library to IP
specific name
OMAP4: DSS: HDMI: Move the common HDMI header file definition to
Include/video
OMAP4: DSS2: HDMI: Function pointer approach to call HDMI IP
driver function from DSS
OMAP4: DSS: Rename hdmi_omap4_panel.c to hdmi_panel.c
drivers/video/omap2/dss/Makefile |2 +-
drivers/video/omap2/dss/dss.h | 10 -
drivers/video/omap2/dss/dss_features.c | 20 +
drivers/video/omap2/dss/dss_features.h |3 +
drivers/video/omap2/dss/hdmi.c | 928
drivers/video/omap2/dss/hdmi.h | 631 -
.../omap2/dss/{hdmi_omap4_panel.c = hdmi_panel.c} |2 +-
drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c | 772
drivers/video/omap2/dss/ti_hdmi_4xxx_ip.h | 575
include/video/omapdss.h| 23 +
include/video/ti_hdmi.h| 103 +++
11 files changed, 1647 insertions(+), 1422 deletions(-)
delete mode 100644 drivers/video/omap2/dss/hdmi.h
rename drivers/video/omap2/dss/{hdmi_omap4_panel.c = hdmi_panel.c} (99%)
create mode 100644 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
create mode 100644 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.h
create mode 100644 include/video/ti_hdmi.h
--
1.7.5.4
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
