Re: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework
Quoting Tomasz Figa (2013-01-21 08:22:39) > Hi Thomas, Sylwester, > > On Monday 21 of January 2013 15:29:16 Sylwester Nawrocki wrote: > > On 12/30/2012 01:33 AM, Thomas Abraham wrote: > > > Changes since v4: > > > - Rebased to linux-3.8-rc1. > > > > > > Changes since v3: > > > - Includes changes suggested by Tomasz Figa > > > > > > This patch series migrates the Samsung Exynos4 SoC clock code to adopt > > > the common clock framework. The use of Samsung specific clock > > > structures has been removed and all board support code has been > > > updated. imx-style of clock registration and lookup has been adopted > > > for device tree based exynos4 platforms. > > > > > > This patch series depends on this series: > > > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg14471 > > > .html and this patch > > > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg14472 > > > .html> > > > Thomas Abraham (12): > > > clk: samsung: add common clock framework helper functions for > > > Samsung platforms clk: samsung: add pll clock registration helper > > > functions > > > clk: exynos4: register clocks using common clock framework > > > ARM: Exynos: Rework timer initialization sequence > > > ARM: Exynos4: Migrate clock support to common clock framework > > > ARM: dts: add exynos4 clock controller nodes > > > ARM: dts: add xxti and xusbxti fixed rate clock nodes for exynos4 > > > based platforms ARM: Exynos4: allow legacy board support to specify > > > xxti and xusbxti clock speed ARM: dts: add clock provider > > > information for all controllers in Exynos4 SoC ARM: Exynos4: remove > > > auxdata table from machine file > > > ARM: Exynos: use fin_pll clock as the tick clock source for mct > > > ARM: Exynos: add support for mct clock setup > > > > > > .../devicetree/bindings/clock/exynos4-clock.txt| 215 +++ > > > arch/arm/boot/dts/exynos4.dtsi | 50 ++ > > > arch/arm/boot/dts/exynos4210-origen.dts| 12 + > > > arch/arm/boot/dts/exynos4210-smdkv310.dts | 12 + > > > arch/arm/boot/dts/exynos4210.dtsi |6 + > > > arch/arm/boot/dts/exynos4412-origen.dts| 12 + > > > arch/arm/boot/dts/exynos4412-smdk4412.dts | 12 + > > > arch/arm/boot/dts/exynos4x12.dtsi |6 + > > > arch/arm/mach-exynos/Kconfig |1 + > > > arch/arm/mach-exynos/Makefile |3 - > > > arch/arm/mach-exynos/clock-exynos4.h | 35 - > > > arch/arm/mach-exynos/clock-exynos4210.c| 188 -- > > > arch/arm/mach-exynos/clock-exynos4212.c| 192 -- > > > arch/arm/mach-exynos/common.c | 57 ++- > > > arch/arm/mach-exynos/common.h | 21 +- > > > arch/arm/mach-exynos/mach-armlex4210.c |3 +- > > > arch/arm/mach-exynos/mach-exynos4-dt.c | 72 +-- > > > arch/arm/mach-exynos/mach-exynos5-dt.c |2 +- > > > arch/arm/mach-exynos/mach-nuri.c |5 +- > > > arch/arm/mach-exynos/mach-origen.c |5 +- > > > arch/arm/mach-exynos/mach-smdk4x12.c |5 +- > > > arch/arm/mach-exynos/mach-smdkv310.c |7 +- > > > arch/arm/mach-exynos/mach-universal_c210.c |3 +- > > > arch/arm/mach-exynos/mct.c | 32 +- > > > arch/arm/plat-samsung/Kconfig |4 +- > > > drivers/clk/Makefile |1 + > > > drivers/clk/samsung/Makefile |6 + > > > drivers/clk/samsung/clk-exynos4.c | 655 > > > drivers/clk/samsung/clk-pll.c > > > | 400 drivers/clk/samsung/clk-pll.h > > > | 38 ++ > > > drivers/clk/samsung/clk.c | 180 ++ > > > drivers/clk/samsung/clk.h | 216 +++ > > > 32 files changed, 1919 insertions(+), 537 deletions(-) > > > create mode 100644 > > > Documentation/devicetree/bindings/clock/exynos4-clock.txt delete > > > mode 100644 arch/arm/mach-exynos/clock-exynos4.h > > > delete mode 100644 arch/arm/mach-exynos/clock-exynos4210.c > > > delete mode 100644 arch/arm/mach-exynos/clock-exynos4212.c > > > create mode 100644 drivers/clk/samsung/Makefile > > > create mode 100644 drivers/clk/samsung/clk-exynos4.c > > > create mode 100644 drivers/clk/samsung/clk-pll.c > > > create mode 100644 drivers/clk/samsung/clk-pll.h > > > create mode 100644 drivers/clk/samsung/clk.c > > > create mode 100644 drivers/clk/samsung/clk.h > > > > Thanks Thomas! The patch series generally looks good to me, I've tested > > it on an Exynos4412 based board. I have applied couple fixes that Tomasz > > Figa has sent you off the mailing list. And to make a MIPI-CSI2 camera > > working a small fixup patch as below.
Re: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework
Hi Thomas, Sylwester, On Monday 21 of January 2013 15:29:16 Sylwester Nawrocki wrote: > On 12/30/2012 01:33 AM, Thomas Abraham wrote: > > Changes since v4: > > - Rebased to linux-3.8-rc1. > > > > Changes since v3: > > - Includes changes suggested by Tomasz Figa > > > > This patch series migrates the Samsung Exynos4 SoC clock code to adopt > > the common clock framework. The use of Samsung specific clock > > structures has been removed and all board support code has been > > updated. imx-style of clock registration and lookup has been adopted > > for device tree based exynos4 platforms. > > > > This patch series depends on this series: > > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg14471 > > .html and this patch > > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg14472 > > .html> > > Thomas Abraham (12): > > clk: samsung: add common clock framework helper functions for > > Samsung platforms clk: samsung: add pll clock registration helper > > functions > > clk: exynos4: register clocks using common clock framework > > ARM: Exynos: Rework timer initialization sequence > > ARM: Exynos4: Migrate clock support to common clock framework > > ARM: dts: add exynos4 clock controller nodes > > ARM: dts: add xxti and xusbxti fixed rate clock nodes for exynos4 > > based platforms ARM: Exynos4: allow legacy board support to specify > > xxti and xusbxti clock speed ARM: dts: add clock provider > > information for all controllers in Exynos4 SoC ARM: Exynos4: remove > > auxdata table from machine file > > ARM: Exynos: use fin_pll clock as the tick clock source for mct > > ARM: Exynos: add support for mct clock setup > > > > .../devicetree/bindings/clock/exynos4-clock.txt| 215 +++ > > arch/arm/boot/dts/exynos4.dtsi | 50 ++ > > arch/arm/boot/dts/exynos4210-origen.dts| 12 + > > arch/arm/boot/dts/exynos4210-smdkv310.dts | 12 + > > arch/arm/boot/dts/exynos4210.dtsi |6 + > > arch/arm/boot/dts/exynos4412-origen.dts| 12 + > > arch/arm/boot/dts/exynos4412-smdk4412.dts | 12 + > > arch/arm/boot/dts/exynos4x12.dtsi |6 + > > arch/arm/mach-exynos/Kconfig |1 + > > arch/arm/mach-exynos/Makefile |3 - > > arch/arm/mach-exynos/clock-exynos4.h | 35 - > > arch/arm/mach-exynos/clock-exynos4210.c| 188 -- > > arch/arm/mach-exynos/clock-exynos4212.c| 192 -- > > arch/arm/mach-exynos/common.c | 57 ++- > > arch/arm/mach-exynos/common.h | 21 +- > > arch/arm/mach-exynos/mach-armlex4210.c |3 +- > > arch/arm/mach-exynos/mach-exynos4-dt.c | 72 +-- > > arch/arm/mach-exynos/mach-exynos5-dt.c |2 +- > > arch/arm/mach-exynos/mach-nuri.c |5 +- > > arch/arm/mach-exynos/mach-origen.c |5 +- > > arch/arm/mach-exynos/mach-smdk4x12.c |5 +- > > arch/arm/mach-exynos/mach-smdkv310.c |7 +- > > arch/arm/mach-exynos/mach-universal_c210.c |3 +- > > arch/arm/mach-exynos/mct.c | 32 +- > > arch/arm/plat-samsung/Kconfig |4 +- > > drivers/clk/Makefile |1 + > > drivers/clk/samsung/Makefile |6 + > > drivers/clk/samsung/clk-exynos4.c | 655 > > drivers/clk/samsung/clk-pll.c > > | 400 drivers/clk/samsung/clk-pll.h > > | 38 ++ > > drivers/clk/samsung/clk.c | 180 ++ > > drivers/clk/samsung/clk.h | 216 +++ > > 32 files changed, 1919 insertions(+), 537 deletions(-) > > create mode 100644 > > Documentation/devicetree/bindings/clock/exynos4-clock.txt delete > > mode 100644 arch/arm/mach-exynos/clock-exynos4.h > > delete mode 100644 arch/arm/mach-exynos/clock-exynos4210.c > > delete mode 100644 arch/arm/mach-exynos/clock-exynos4212.c > > create mode 100644 drivers/clk/samsung/Makefile > > create mode 100644 drivers/clk/samsung/clk-exynos4.c > > create mode 100644 drivers/clk/samsung/clk-pll.c > > create mode 100644 drivers/clk/samsung/clk-pll.h > > create mode 100644 drivers/clk/samsung/clk.c > > create mode 100644 drivers/clk/samsung/clk.h > > Thanks Thomas! The patch series generally looks good to me, I've tested > it on an Exynos4412 based board. I have applied couple fixes that Tomasz > Figa has sent you off the mailing list. And to make a MIPI-CSI2 camera > working a small fixup patch as below. > > I have just one remark, but this could possibly be done as a follow up > patch. Namely it may make sense to rename various sclk_* clocks to just > "sclk", so for instance we don't have "fimd", "sclk_fimd", "fimc
Re: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework
On 12/30/2012 01:33 AM, Thomas Abraham wrote: > Changes since v4: > - Rebased to linux-3.8-rc1. > > Changes since v3: > - Includes changes suggested by Tomasz Figa > > This patch series migrates the Samsung Exynos4 SoC clock code to adopt the > common clock framework. The use of Samsung specific clock structures has > been removed and all board support code has been updated. imx-style of > clock registration and lookup has been adopted for device tree based > exynos4 platforms. > > This patch series depends on this series: > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg14471.html > and this patch > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg14472.html > > Thomas Abraham (12): > clk: samsung: add common clock framework helper functions for Samsung > platforms > clk: samsung: add pll clock registration helper functions > clk: exynos4: register clocks using common clock framework > ARM: Exynos: Rework timer initialization sequence > ARM: Exynos4: Migrate clock support to common clock framework > ARM: dts: add exynos4 clock controller nodes > ARM: dts: add xxti and xusbxti fixed rate clock nodes for exynos4 based > platforms > ARM: Exynos4: allow legacy board support to specify xxti and xusbxti clock > speed > ARM: dts: add clock provider information for all controllers in Exynos4 SoC > ARM: Exynos4: remove auxdata table from machine file > ARM: Exynos: use fin_pll clock as the tick clock source for mct > ARM: Exynos: add support for mct clock setup > > .../devicetree/bindings/clock/exynos4-clock.txt| 215 +++ > arch/arm/boot/dts/exynos4.dtsi | 50 ++ > arch/arm/boot/dts/exynos4210-origen.dts| 12 + > arch/arm/boot/dts/exynos4210-smdkv310.dts | 12 + > arch/arm/boot/dts/exynos4210.dtsi |6 + > arch/arm/boot/dts/exynos4412-origen.dts| 12 + > arch/arm/boot/dts/exynos4412-smdk4412.dts | 12 + > arch/arm/boot/dts/exynos4x12.dtsi |6 + > arch/arm/mach-exynos/Kconfig |1 + > arch/arm/mach-exynos/Makefile |3 - > arch/arm/mach-exynos/clock-exynos4.h | 35 - > arch/arm/mach-exynos/clock-exynos4210.c| 188 -- > arch/arm/mach-exynos/clock-exynos4212.c| 192 -- > arch/arm/mach-exynos/common.c | 57 ++- > arch/arm/mach-exynos/common.h | 21 +- > arch/arm/mach-exynos/mach-armlex4210.c |3 +- > arch/arm/mach-exynos/mach-exynos4-dt.c | 72 +-- > arch/arm/mach-exynos/mach-exynos5-dt.c |2 +- > arch/arm/mach-exynos/mach-nuri.c |5 +- > arch/arm/mach-exynos/mach-origen.c |5 +- > arch/arm/mach-exynos/mach-smdk4x12.c |5 +- > arch/arm/mach-exynos/mach-smdkv310.c |7 +- > arch/arm/mach-exynos/mach-universal_c210.c |3 +- > arch/arm/mach-exynos/mct.c | 32 +- > arch/arm/plat-samsung/Kconfig |4 +- > drivers/clk/Makefile |1 + > drivers/clk/samsung/Makefile |6 + > drivers/clk/samsung/clk-exynos4.c | 655 > > drivers/clk/samsung/clk-pll.c | 400 > drivers/clk/samsung/clk-pll.h | 38 ++ > drivers/clk/samsung/clk.c | 180 ++ > drivers/clk/samsung/clk.h | 216 +++ > 32 files changed, 1919 insertions(+), 537 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/exynos4-clock.txt > delete mode 100644 arch/arm/mach-exynos/clock-exynos4.h > delete mode 100644 arch/arm/mach-exynos/clock-exynos4210.c > delete mode 100644 arch/arm/mach-exynos/clock-exynos4212.c > create mode 100644 drivers/clk/samsung/Makefile > create mode 100644 drivers/clk/samsung/clk-exynos4.c > create mode 100644 drivers/clk/samsung/clk-pll.c > create mode 100644 drivers/clk/samsung/clk-pll.h > create mode 100644 drivers/clk/samsung/clk.c > create mode 100644 drivers/clk/samsung/clk.h Thanks Thomas! The patch series generally looks good to me, I've tested it on an Exynos4412 based board. I have applied couple fixes that Tomasz Figa has sent you off the mailing list. And to make a MIPI-CSI2 camera working a small fixup patch as below. I have just one remark, but this could possibly be done as a follow up patch. Namely it may make sense to rename various sclk_* clocks to just "sclk", so for instance we don't have "fimd", "sclk_fimd", "fimc", "sclk_fimc" but e.g. "bus" or "gate" and "sclk" for each device. Such naming might be better for handling devices at core subsystems level, e.g. Runtime PM or devfreq. Please feel free to add: Reviewed-by: Sylwester Nawrocki Tested-by: Sylwester Nawrocki
Re: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework
On Sun, Dec 30, 2012 at 05:37:08PM -0800, Kukjin Kim wrote: > Olof Johansson wrote: > > > > On Sat, Dec 29, 2012 at 04:33:29PM -0800, Thomas Abraham wrote: > > > Changes since v4: > > > - Rebased to linux-3.8-rc1. > > > > > > Changes since v3: > > > - Includes changes suggested by Tomasz Figa > > > > > > This patch series migrates the Samsung Exynos4 SoC clock code to adopt > > the > > > common clock framework. The use of Samsung specific clock structures has > > > been removed and all board support code has been updated. imx-style of > > > clock registration and lookup has been adopted for device tree based > > > exynos4 platforms. > > > > I'd prefer to see if exynos4 and 5 were kept common here, and both > > transitioned > > at the same time. Especially since there are no legacy boards for exynos5, > it > > would mean you could have a very clean transition there. What's the plan > to > > follow up with 5? > > > Yeah, I'm working on EXYNOS5250 common clk stuff and Thomas is working on > EXYNOS5440. So I think, we can move on exynos4 and 5 both common clk at the > same time. Note, EXYNOS5 common clk stuff will be submitted in the beginning > of Jan. As per the other reply, that sounds good -- it doesn't make sense to merge one without the other but it sounds like maybe they can both be ready in time for 3.9. > > What are the plans to remove legacy board files on exynos4 at this time > > and switch them to DT-only? You could do it gradually like Stephen Warren > > did on Tegra, with hooks that call out to some of the legacy code, but > > configure the board through device tree and do away with the classic > > machine descriptors, etc. > > > I had a plan to remove non-DT support on EXYNOS4 for v3.10, but if possible, > I will try to do it for v3.9. If any updates, let you know. There's no hurry, 3.10 is ok as a target as long as it's taking place. The main reason for why I was asking was that there was still some legacy board file updates posted, and that I hadn't seen much patches lately that made it obvious that there was an effort in that direction. 3.10 sounds like a good target. > Happy New Year! Thanks, you too. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework
On Sun, Dec 30, 2012 at 09:35:16PM -0800, Thomas Abraham wrote: > On 29 December 2012 21:29, Olof Johansson wrote: > > On Sat, Dec 29, 2012 at 04:33:29PM -0800, Thomas Abraham wrote: > >> Changes since v4: > >> - Rebased to linux-3.8-rc1. > >> > >> Changes since v3: > >> - Includes changes suggested by Tomasz Figa > >> > >> This patch series migrates the Samsung Exynos4 SoC clock code to adopt the > >> common clock framework. The use of Samsung specific clock structures has > >> been removed and all board support code has been updated. imx-style of > >> clock registration and lookup has been adopted for device tree based > >> exynos4 platforms. > > > > I'd prefer to see if exynos4 and 5 were kept common here, and both > > transitioned > > at the same time. Especially since there are no legacy boards for exynos5, > > it > > would mean you could have a very clean transition there. What's the plan to > > follow up with 5? > > Ok. I have been looking into Exynos4 since Mr. Kim was already onto > Exynos5 common clock. Sure, we could do a cleaner Exynos4/5 common > clock series for v3.9. That would let both exynos4/5 to be built > together which otherwise this patch series would not allow. Great, that sounds good. Regressing exynos 4+5 builds would definitely be a bad thing. In other words, it makes sense to hold off merging the exynos4 pieces until the 5 counterparts are ready. > > What are the plans to remove legacy board files on exynos4 at this time > > and switch them to DT-only? You could do it gradually like Stephen Warren > > did on Tegra, with hooks that call out to some of the legacy code, but > > configure the board through device tree and do away with the classic > > machine descriptors, etc. > > I did try this sometime back for exynos4210 based origen board. But > did not make much progress since certain portions require the older > samsung gpiolib support and exynos4210 mainline device tree support > has migrated to newer pinctrl framework. There is some work here to do > and I will work with Mr. Kim on this. Great, thanks. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework
On 29 December 2012 21:29, Olof Johansson wrote: > On Sat, Dec 29, 2012 at 04:33:29PM -0800, Thomas Abraham wrote: >> Changes since v4: >> - Rebased to linux-3.8-rc1. >> >> Changes since v3: >> - Includes changes suggested by Tomasz Figa >> >> This patch series migrates the Samsung Exynos4 SoC clock code to adopt the >> common clock framework. The use of Samsung specific clock structures has >> been removed and all board support code has been updated. imx-style of >> clock registration and lookup has been adopted for device tree based >> exynos4 platforms. > > I'd prefer to see if exynos4 and 5 were kept common here, and both > transitioned > at the same time. Especially since there are no legacy boards for exynos5, it > would mean you could have a very clean transition there. What's the plan to > follow up with 5? Ok. I have been looking into Exynos4 since Mr. Kim was already onto Exynos5 common clock. Sure, we could do a cleaner Exynos4/5 common clock series for v3.9. That would let both exynos4/5 to be built together which otherwise this patch series would not allow. > > What are the plans to remove legacy board files on exynos4 at this time > and switch them to DT-only? You could do it gradually like Stephen Warren > did on Tegra, with hooks that call out to some of the legacy code, but > configure the board through device tree and do away with the classic > machine descriptors, etc. I did try this sometime back for exynos4210 based origen board. But did not make much progress since certain portions require the older samsung gpiolib support and exynos4210 mainline device tree support has migrated to newer pinctrl framework. There is some work here to do and I will work with Mr. Kim on this. Thanks, Thomas. > > > > -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework
Olof Johansson wrote: > > On Sat, Dec 29, 2012 at 04:33:29PM -0800, Thomas Abraham wrote: > > Changes since v4: > > - Rebased to linux-3.8-rc1. > > > > Changes since v3: > > - Includes changes suggested by Tomasz Figa > > > > This patch series migrates the Samsung Exynos4 SoC clock code to adopt > the > > common clock framework. The use of Samsung specific clock structures has > > been removed and all board support code has been updated. imx-style of > > clock registration and lookup has been adopted for device tree based > > exynos4 platforms. > > I'd prefer to see if exynos4 and 5 were kept common here, and both > transitioned > at the same time. Especially since there are no legacy boards for exynos5, it > would mean you could have a very clean transition there. What's the plan to > follow up with 5? > Yeah, I'm working on EXYNOS5250 common clk stuff and Thomas is working on EXYNOS5440. So I think, we can move on exynos4 and 5 both common clk at the same time. Note, EXYNOS5 common clk stuff will be submitted in the beginning of Jan. > What are the plans to remove legacy board files on exynos4 at this time > and switch them to DT-only? You could do it gradually like Stephen Warren > did on Tegra, with hooks that call out to some of the legacy code, but > configure the board through device tree and do away with the classic > machine descriptors, etc. > I had a plan to remove non-DT support on EXYNOS4 for v3.10, but if possible, I will try to do it for v3.9. If any updates, let you know. Thanks. Happy New Year! - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework
On Sat, Dec 29, 2012 at 04:33:29PM -0800, Thomas Abraham wrote: > Changes since v4: > - Rebased to linux-3.8-rc1. > > Changes since v3: > - Includes changes suggested by Tomasz Figa > > This patch series migrates the Samsung Exynos4 SoC clock code to adopt the > common clock framework. The use of Samsung specific clock structures has > been removed and all board support code has been updated. imx-style of > clock registration and lookup has been adopted for device tree based > exynos4 platforms. I'd prefer to see if exynos4 and 5 were kept common here, and both transitioned at the same time. Especially since there are no legacy boards for exynos5, it would mean you could have a very clean transition there. What's the plan to follow up with 5? What are the plans to remove legacy board files on exynos4 at this time and switch them to DT-only? You could do it gradually like Stephen Warren did on Tegra, with hooks that call out to some of the legacy code, but configure the board through device tree and do away with the classic machine descriptors, etc. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
