Re: [PATCH 4/6] qla2xxx: Send FC4 type NVMe to the management server
> On Jun 21, 2017, at 12:07 AM, Johannes Thumshirn wrote: > > Ah and I think you forgot to Cc the linux-nvme [1] list on your submission. It > would be good to have it on linux-nvme as well as on linux-scsi so Sagi, > Christoph and Keith see it as well. Sounds good. I’ll cc linux-nvme on v2 of the series that i am going to send out in few hours today. Thanks, - Himanshu
Re: [PATCH 4/6] qla2xxx: Send FC4 type NVMe to the management server
On Tue, Jun 20, 2017 at 10:13:04PM +, Madhani, Himanshu wrote: > Somehow in the actual code this does not look like issue. (i.e. correct > indentation is seen) > i am not sure why in patch view its showing one space off. Strange. I guess we'll have to live with it then. Ah and I think you forgot to Cc the linux-nvme [1] list on your submission. It would be good to have it on linux-nvme as well as on linux-scsi so Sagi, Christoph and Keith see it as well. Byte, Johannes [1] linux-n...@lists.infradead.org -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 4/6] qla2xxx: Send FC4 type NVMe to the management server
Hi Johannes, > On Jun 19, 2017, at 3:06 AM, Johannes Thumshirn wrote: > > On Fri, Jun 16, 2017 at 03:47:42PM -0700, Himanshu Madhani wrote: >> From: Duane Grigsby >> >> This patch adds switch command support for FC-4 type of FC-NVMe (0x28) >> for resgistering HBA port to the management server. RFT_ID command is >> used to register FC-4 type of 0x28 and RFF_ID is used to register >> FC-4 features bits for FC-NVMe port. >> >> Signed-off-by: Darren Trapp >> Signed-off-by: Duane Grigsby >> Signed-off-by: Anil Gurumurthy >> Signed-off-by: Giridhar Malavali >> Signed-off-by: Himanshu Madhani >> --- > > [...] > >> + ct_rsp = &fcport->ct_desc.ct_sns->p.rsp; >> + /* >> +* FC-GS-7, 5.2.3.12 FC-4 Features - format >> +* The format of the FC-4 Features object, as defined by the FC-4, >> +* Shall be an array of 4-bit values, one for each type code value >> +*/ > > Indentation looks a bit odd here. Did you run checkpatch.pl on the series? > forgot to reply to this earlier. Yes. I ran checkpatch.pl on this series. Somehow in the actual code this does not look like issue. (i.e. correct indentation is seen) i am not sure why in patch view its showing one space off. >> @@ -4634,6 +4637,12 @@ qla2x00_configure_fabric(scsi_qla_host_t *vha) >> &vha->dpc_flags)) >> break; >> } >> +if (vha->flags.nvme_enabled) { >> +if (qla2x00_rff_id(vha, FC4_TYPE_NVME)) { > > if (vha->flags.nvme_enabled && > qla2x00_rff_id(vha, FC4_TYPE_NVME)) > ql_dbg(ql_dbg_disc, vha, 0x2049, ) > >> +ql_dbg(ql_dbg_disc, vha, 0x2049, >> +"Register NVME FC Type Features >> failed.\n"); >> +} >> +} > > -- > Johannes Thumshirn Storage > jthumsh...@suse.de+49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 Thanks, - Himanshu
Re: [PATCH 4/6] qla2xxx: Send FC4 type NVMe to the management server
On 6/16/2017 3:47 PM, Himanshu Madhani wrote: From: Duane Grigsby This patch adds switch command support for FC-4 type of FC-NVMe (0x28) for resgistering HBA port to the management server. RFT_ID command is used to register FC-4 type of 0x28 and RFF_ID is used to register FC-4 features bits for FC-NVMe port. Signed-off-by: Darren Trapp Signed-off-by: Duane Grigsby Signed-off-by: Anil Gurumurthy Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- Reviewed-By: James Smart
Re: [PATCH 4/6] qla2xxx: Send FC4 type NVMe to the management server
On Fri, Jun 16, 2017 at 03:47:42PM -0700, Himanshu Madhani wrote: > From: Duane Grigsby > > This patch adds switch command support for FC-4 type of FC-NVMe (0x28) > for resgistering HBA port to the management server. RFT_ID command is > used to register FC-4 type of 0x28 and RFF_ID is used to register > FC-4 features bits for FC-NVMe port. > > Signed-off-by: Darren Trapp > Signed-off-by: Duane Grigsby > Signed-off-by: Anil Gurumurthy > Signed-off-by: Giridhar Malavali > Signed-off-by: Himanshu Madhani > --- [...] > + ct_rsp = &fcport->ct_desc.ct_sns->p.rsp; > + /* > + * FC-GS-7, 5.2.3.12 FC-4 Features - format > + * The format of the FC-4 Features object, as defined by the FC-4, > + * Shall be an array of 4-bit values, one for each type code value > + */ Indentation looks a bit odd here. Did you run checkpatch.pl on the series? > @@ -4634,6 +4637,12 @@ qla2x00_configure_fabric(scsi_qla_host_t *vha) > &vha->dpc_flags)) > break; > } > + if (vha->flags.nvme_enabled) { > + if (qla2x00_rff_id(vha, FC4_TYPE_NVME)) { if (vha->flags.nvme_enabled && qla2x00_rff_id(vha, FC4_TYPE_NVME)) ql_dbg(ql_dbg_disc, vha, 0x2049, ) > + ql_dbg(ql_dbg_disc, vha, 0x2049, > + "Register NVME FC Type Features > failed.\n"); > + } > + } -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850