Re: [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101
> Hmm.. currently I prefer to remove it, because it is not a uc101 special > wdt driver. When this wdt driver go in mainline, it is easy to readd it > to this board support. Great, another one interested in a mainline GPIO-WDT-driver :) I'll check again what happened last time and summarize it later this day. The we can hopefully work out something. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101
Hello Grant, Grant Likely wrote: > On Mon, Oct 5, 2009 at 4:12 AM, Heiko Schocher wrote: >> Wolfram Sang wrote: >>> Is this an official binding? I also did an gpio-watchdog a while ago and >>> there >>> were some issues with the binding, IIRC. Would be nice if this has been >>> solved >>> meanwhile. >> Oh, sorry, no. I remove it. > > You don't need to remove it, but choose a compatible value within the > board/manufacturer namespace. ie. 'manroland,uc101-watchdog'. You Hmm.. currently I prefer to remove it, because it is not a uc101 special wdt driver. When this wdt driver go in mainline, it is easy to readd it to this board support. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101
On Mon, Oct 5, 2009 at 4:12 AM, Heiko Schocher wrote: > Wolfram Sang wrote: >> Is this an official binding? I also did an gpio-watchdog a while ago and >> there >> were some issues with the binding, IIRC. Would be nice if this has been >> solved >> meanwhile. > > Oh, sorry, no. I remove it. You don't need to remove it, but choose a compatible value within the board/manufacturer namespace. ie. 'manroland,uc101-watchdog'. You also need to document what it means in Documentation/powerpc/dts-bindings/. If you do want to do some kind of generic gpio watchdog binding, then write a documentation patch for it and post it to devicetree-discuss for review. Make sure you cc: both me and Wolfram when you post it. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101
Hello Wolfram,
Wolfram Sang wrote:
> On Mon, Oct 05, 2009 at 09:46:43AM +0200, Heiko Schocher wrote:
>
>> - serial Console on PSC1
>> - 64MB SDRAM
>> - MTD CFI Flash
>> - Ethernet FEC
>> - IDE support
>>
>> Signed-off-by: Heiko Schocher
[...]
> [...]
>> +wdt {
>> +compatible = "generic,gpio-wdt";
>> +reg = <0x600 0x10>;
>> +gpios = <&gpt0 0 0>;
>> +period = <500>; // WDT trigger period in msec
>> +};
>
> Is this an official binding? I also did an gpio-watchdog a while ago and there
> were some issues with the binding, IIRC. Would be nice if this has been solved
> meanwhile.
Oh, sorry, no. I remove it.
> Other than that, it looks okay to me.
Ok, thanks for reviewing, I resent soon an update
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101
On Mon, Oct 05, 2009 at 09:46:43AM +0200, Heiko Schocher wrote:
> - serial Console on PSC1
> - 64MB SDRAM
> - MTD CFI Flash
> - Ethernet FEC
> - IDE support
>
> Signed-off-by: Heiko Schocher
> ---
> - based on:
> git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
>
> - checked with:
> $ ./scripts/checkpatch.pl
> 0001-mpc5200-support-for-the-MAN-mpc5200-based-board-uc1.patch
> total: 0 errors, 0 warnings, 324 lines checked
>
> 0001-mpc5200-support-for-the-MAN-mpc5200-based-board-uc1.patch has no obvious
> style problems and is ready for submission.
> $
>
> changes since v1:
>
> - add comments from Grant Likely
> use mpc5200_defconfig as default configuration
> - add comments from Wolfram Sang
> - rebase against current next
>
> arch/powerpc/boot/dts/uc101.dts | 317
> ++
> arch/powerpc/platforms/52xx/mpc5200_simple.c |1 +
> 2 files changed, 318 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/boot/dts/uc101.dts
>
[...]
> + wdt {
> + compatible = "generic,gpio-wdt";
> + reg = <0x600 0x10>;
> + gpios = <&gpt0 0 0>;
> + period = <500>; // WDT trigger period in msec
> + };
Is this an official binding? I also did an gpio-watchdog a while ago and there
were some issues with the binding, IIRC. Would be nice if this has been solved
meanwhile.
Other than that, it looks okay to me.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101
- serial Console on PSC1
- 64MB SDRAM
- MTD CFI Flash
- Ethernet FEC
- IDE support
Signed-off-by: Heiko Schocher
---
- based on:
git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
- checked with:
$ ./scripts/checkpatch.pl
0001-mpc5200-support-for-the-MAN-mpc5200-based-board-uc1.patch
total: 0 errors, 0 warnings, 324 lines checked
0001-mpc5200-support-for-the-MAN-mpc5200-based-board-uc1.patch has no obvious
style problems and is ready for submission.
$
changes since v1:
- add comments from Grant Likely
use mpc5200_defconfig as default configuration
- add comments from Wolfram Sang
- rebase against current next
arch/powerpc/boot/dts/uc101.dts | 317 ++
arch/powerpc/platforms/52xx/mpc5200_simple.c |1 +
2 files changed, 318 insertions(+), 0 deletions(-)
create mode 100644 arch/powerpc/boot/dts/uc101.dts
diff --git a/arch/powerpc/boot/dts/uc101.dts b/arch/powerpc/boot/dts/uc101.dts
new file mode 100644
index 000..9d79e48
--- /dev/null
+++ b/arch/powerpc/boot/dts/uc101.dts
@@ -0,0 +1,317 @@
+/*
+ * uc101 board Device Tree Source
+ *
+ * Copyright (C) 2009 DENX Software Engineering GmbH
+ * Heiko Schocher
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ */
+
+/dts-v1/;
+
+/ {
+ model = "manroland,uc101";
+ compatible = "manroland,uc101";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ interrupt-parent = <&mpc5200_pic>;
+
+ cpus {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ PowerPC,5...@0 {
+ device_type = "cpu";
+ reg = <0>;
+ d-cache-line-size = <32>;
+ i-cache-line-size = <32>;
+ d-cache-size = <0x4000>;// L1, 16K
+ i-cache-size = <0x4000>;// L1, 16K
+ timebase-frequency = <0>; // from bootloader
+ bus-frequency = <0>;// from bootloader
+ clock-frequency = <0>; // from bootloader
+ };
+ };
+
+ memory {
+ device_type = "memory";
+ reg = <0x 0x0400>; // 64MB
+ };
+
+ soc5...@f000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "fsl,mpc5200-immr",
+ "fsl,mpc5200b-immr";
+ ranges = <0 0xf000 0xc000>;
+ reg = <0xf000 0x0100>;
+ bus-frequency = <0>;// from bootloader
+ system-frequency = <0>; // from bootloader
+
+ c...@200 {
+ compatible = "fsl,mpc5200b-cdm","fsl,mpc5200-cdm";
+ reg = <0x200 0x38>;
+ };
+
+ mpc5200_pic: interrupt-control...@500 {
+ // 5200 interrupts are encoded into two levels;
+ interrupt-controller;
+ #interrupt-cells = <3>;
+ compatible = "fsl,mpc5200b-pic","fsl,mpc5200-pic";
+ reg = <0x500 0x80>;
+ interrupts = <0 0 3>;
+ };
+
+ gpt0: ti...@600 { // GPT 0 in GPIO mode
+ compatible = "fsl,mpc5200b-gpt-gpio",
+ "fsl,mpc5200-gpt-gpio";
+ #gpio-cells = <2>;
+ reg = <0x600 0x10>;
+ interrupts = <1 9 0>;
+ gpio-controller;
+ };
+
+ gpt1: ti...@610 { // GPT 1 in GPIO mode
+ compatible = "fsl,mpc5200b-gpt-gpio",
+ "fsl,mpc5200-gpt-gpio";
+ #gpio-cells = <2>;
+ reg = <0x610 0x10>;
+ interrupts = <1 10 0>;
+ gpio-controller;
+ };
+
+ gpt2: ti...@620 { // GPT 2 in GPIO mode
+ compatible = "fsl,mpc5200b-gpt-gpio",
+ "fsl,mpc5200-gpt-gpio";
+ #gpio-cells = <2>;
+ reg = <0x620 0x10>;
+ interrupts = <1 11 0>;
+ gpio-controller;
+ };
+
+ gpt3: ti...@630 { // GPT 3 in GPIO mode
+ compatible = "fsl,mpc5200b-gpt-gpio",
+ "fsl,mpc5200-gpt-gpio";
+ #gpio-cells = <2>;
+ reg = <0x630 0x10>;
+ interrupts = <1 12 0>;
+ gpi
