Re: [patch 5/5] arch/powerpc/platforms/pseries/eeh_driver.c: fix warning

[Andrew Morton]

On Tue, 10 Jun 2008 09:47:02 +1000
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:

> On Mon, 2008-06-09 at 16:26 -0700, [EMAIL PROTECTED] wrote:
> > From: Andrew Morton <[EMAIL PROTECTED]>
> > 
> > Fix this:
> > 
> > /usr/src/devel/arch/powerpc/platforms/pseries/eeh_driver.c: In function 
> > 'print_device_node_tree':
> > /usr/src/devel/arch/powerpc/platforms/pseries/eeh_driver.c:55: warning: ISO 
> > C90 forbids mixed declarations and code
> > 
> > also make that function look like it's part of Linux.  I mean, wtf are you
> > guys up to down there??
> 
> The EEH code ... oh well. It does need some love...

Feel free to make the changelog more family-friendly.  You can always
tell how many build errors I fixed in the predecing six hours..

> > [EMAIL PROTECTED]: coding-style fixes]
> 
> Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>

Thanks.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [patch 5/5] arch/powerpc/platforms/pseries/eeh_driver.c: fix warning

[Benjamin Herrenschmidt]

On Mon, 2008-06-09 at 16:26 -0700, [EMAIL PROTECTED] wrote:
> From: Andrew Morton <[EMAIL PROTECTED]>
> 
> Fix this:
> 
> /usr/src/devel/arch/powerpc/platforms/pseries/eeh_driver.c: In function 
> 'print_device_node_tree':
> /usr/src/devel/arch/powerpc/platforms/pseries/eeh_driver.c:55: warning: ISO 
> C90 forbids mixed declarations and code
> 
> also make that function look like it's part of Linux.  I mean, wtf are you
> guys up to down there??

The EEH code ... oh well. It does need some love...

> [EMAIL PROTECTED]: coding-style fixes]

Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>

> Cc: Paul Mackerras <[EMAIL PROTECTED]>
> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
> ---



___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

[patch 5/5] arch/powerpc/platforms/pseries/eeh_driver.c: fix warning

[akpm]

From: Andrew Morton <[EMAIL PROTECTED]>

Fix this:

/usr/src/devel/arch/powerpc/platforms/pseries/eeh_driver.c: In function 
'print_device_node_tree':
/usr/src/devel/arch/powerpc/platforms/pseries/eeh_driver.c:55: warning: ISO C90 
forbids mixed declarations and code

also make that function look like it's part of Linux.  I mean, wtf are you
guys up to down there??

[EMAIL PROTECTED]: coding-style fixes]
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Cc: Paul Mackerras <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 arch/powerpc/platforms/pseries/eeh_driver.c |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

diff -puN 
arch/powerpc/platforms/pseries/eeh_driver.c~arch-powerpc-platforms-pseries-eeh_driverc-fix-warning
 arch/powerpc/platforms/pseries/eeh_driver.c
--- 
a/arch/powerpc/platforms/pseries/eeh_driver.c~arch-powerpc-platforms-pseries-eeh_driverc-fix-warning
+++ a/arch/powerpc/platforms/pseries/eeh_driver.c
@@ -42,17 +42,20 @@ static inline const char * pcid_name (st
 }
 
 #ifdef DEBUG
-static void print_device_node_tree (struct pci_dn *pdn, int dent)
+static void print_device_node_tree(struct pci_dn *pdn, int dent)
 {
int i;
-   if (!pdn) return;
-   for (i=0;inode->name, pdn->eeh_mode, pdn->eeh_config_addr,
pdn->eeh_pe_config_addr, pdn->node->full_name);
dent += 3;
-   struct device_node *pc = pdn->node->child;
+   pc = pdn->node->child;
while (pc) {
print_device_node_tree(PCI_DN(pc), dent);
pc = pc->sibling;
_
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev