Re: [PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards
On Mon, Jun 30, 2008 at 02:15:25PM +1000, David Gibson wrote:
On Fri, Jun 27, 2008 at 04:10:17PM -0500, Kumar Gala wrote:
Added DMA nodes for the elo/elo-plus DMA engines.
Renamed the interrupt controller alias in mpc832x_rdb.dts to ipic so that
its the same as all the other boards.
Signed-off-by: Kumar Gala [EMAIL PROTECTED]
[snip]
diff --git a/arch/powerpc/boot/dts/asp834x-redboot.dts
b/arch/powerpc/boot/dts/asp834x-redboot.dts
index 972cf78..8b1bb0e 100644
--- a/arch/powerpc/boot/dts/asp834x-redboot.dts
+++ b/arch/powerpc/boot/dts/asp834x-redboot.dts
@@ -118,6 +118,41 @@
mode = cpu;
};
+ [EMAIL PROTECTED] {
+ #address-cells = 1;
+ #size-cells = 1;
+ compatible = fsl,mpc8347-dma, fsl,elo-dma;
+ reg = 0x82a8 4;
+ ranges = 0 0x8100 0x1a8;
+ interrupt-parent = ipic;
+ interrupts = 71 8;
+ cell-index = 0;
What's the cell-index in these nodes used to index? Given the
confusion there's been about the proper use of this property, a
comment indicating which shared registers this is used to index is
probably a good idea.
There's supposed to be a cell-index in the *channels* to index into the
shared summary register (the reg of the dma node itself). I don't see any
purpose for a cell-index in the main dma node, though.
-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards
On Jun 30, 2008, at 10:35 AM, Scott Wood wrote:
On Mon, Jun 30, 2008 at 02:15:25PM +1000, David Gibson wrote:
On Fri, Jun 27, 2008 at 04:10:17PM -0500, Kumar Gala wrote:
Added DMA nodes for the elo/elo-plus DMA engines.
Renamed the interrupt controller alias in mpc832x_rdb.dts to ipic
so that
its the same as all the other boards.
Signed-off-by: Kumar Gala [EMAIL PROTECTED]
[snip]
diff --git a/arch/powerpc/boot/dts/asp834x-redboot.dts b/arch/
powerpc/boot/dts/asp834x-redboot.dts
index 972cf78..8b1bb0e 100644
--- a/arch/powerpc/boot/dts/asp834x-redboot.dts
+++ b/arch/powerpc/boot/dts/asp834x-redboot.dts
@@ -118,6 +118,41 @@
mode = cpu;
};
+ [EMAIL PROTECTED] {
+ #address-cells = 1;
+ #size-cells = 1;
+ compatible = fsl,mpc8347-dma, fsl,elo-dma;
+ reg = 0x82a8 4;
+ ranges = 0 0x8100 0x1a8;
+ interrupt-parent = ipic;
+ interrupts = 71 8;
+ cell-index = 0;
What's the cell-index in these nodes used to index? Given the
confusion there's been about the proper use of this property, a
comment indicating which shared registers this is used to index is
probably a good idea.
There's supposed to be a cell-index in the *channels* to index into
the
shared summary register (the reg of the dma node itself). I don't
see any
purpose for a cell-index in the main dma node, though.
I believe this comes into play when we have more than one DMA
controller and sometimes there are special uses like on 8610.
- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards
Kumar Gala wrote: I believe this comes into play when we have more than one DMA controller and sometimes there are special uses like on 8610. Maybe, though I'd just use a phandle to express that (unless you need to program the number that you're using, rather than just use a specific one). Could you add cell-index to the individual channels, though (you have it in some dts files, and not others)? -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards
What's the cell-index in these nodes used to index? Given the confusion there's been about the proper use of this property, a comment indicating which shared registers this is used to index is probably a good idea. There's supposed to be a cell-index in the *channels* to index into the shared summary register (the reg of the dma node itself). I don't see any purpose for a cell-index in the main dma node, though. I believe this comes into play when we have more than one DMA controller and sometimes there are special uses like on 8610. There is no need to guess what it is or isn't used for. Just look it up in the binding for this device. Segher ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards
On Fri, Jun 27, 2008 at 04:10:17PM -0500, Kumar Gala wrote:
Added DMA nodes for the elo/elo-plus DMA engines.
Renamed the interrupt controller alias in mpc832x_rdb.dts to ipic so that
its the same as all the other boards.
Signed-off-by: Kumar Gala [EMAIL PROTECTED]
[snip]
diff --git a/arch/powerpc/boot/dts/asp834x-redboot.dts
b/arch/powerpc/boot/dts/asp834x-redboot.dts
index 972cf78..8b1bb0e 100644
--- a/arch/powerpc/boot/dts/asp834x-redboot.dts
+++ b/arch/powerpc/boot/dts/asp834x-redboot.dts
@@ -118,6 +118,41 @@
mode = cpu;
};
+ [EMAIL PROTECTED] {
+ #address-cells = 1;
+ #size-cells = 1;
+ compatible = fsl,mpc8347-dma, fsl,elo-dma;
+ reg = 0x82a8 4;
+ ranges = 0 0x8100 0x1a8;
+ interrupt-parent = ipic;
+ interrupts = 71 8;
+ cell-index = 0;
What's the cell-index in these nodes used to index? Given the
confusion there's been about the proper use of this property, a
comment indicating which shared registers this is used to index is
probably a good idea.
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards
Added DMA nodes for the elo/elo-plus DMA engines.
Renamed the interrupt controller alias in mpc832x_rdb.dts to ipic so that
its the same as all the other boards.
Signed-off-by: Kumar Gala [EMAIL PROTECTED]
---
Some copy/paste bugs are now fixed (thanks Scott for actually looking at the
patch).
- k
arch/powerpc/boot/dts/asp834x-redboot.dts | 35
arch/powerpc/boot/dts/ksi8560.dts | 41 ++
arch/powerpc/boot/dts/mpc8313erdb.dts | 35
arch/powerpc/boot/dts/mpc8315erdb.dts | 35
arch/powerpc/boot/dts/mpc832x_mds.dts | 35
arch/powerpc/boot/dts/mpc832x_rdb.dts | 71 ++--
arch/powerpc/boot/dts/mpc8349emitx.dts | 35
arch/powerpc/boot/dts/mpc8349emitxgp.dts | 35
arch/powerpc/boot/dts/mpc834x_mds.dts | 35
arch/powerpc/boot/dts/mpc836x_mds.dts | 35
arch/powerpc/boot/dts/mpc836x_rdk.dts | 35
arch/powerpc/boot/dts/mpc8377_mds.dts | 70
arch/powerpc/boot/dts/mpc8377_rdb.dts | 35
arch/powerpc/boot/dts/mpc8378_mds.dts | 35
arch/powerpc/boot/dts/mpc8378_rdb.dts | 35
arch/powerpc/boot/dts/mpc8379_mds.dts | 35
arch/powerpc/boot/dts/mpc8379_rdb.dts | 35
arch/powerpc/boot/dts/mpc8540ads.dts | 41 ++
arch/powerpc/boot/dts/mpc8541cds.dts | 41 ++
arch/powerpc/boot/dts/mpc8548cds.dts | 41 ++
arch/powerpc/boot/dts/mpc8555cds.dts | 41 ++
arch/powerpc/boot/dts/mpc8560ads.dts | 41 ++
arch/powerpc/boot/dts/mpc8568mds.dts | 41 ++
arch/powerpc/boot/dts/mpc8572ds.dts| 82
arch/powerpc/boot/dts/mpc8641_hpcn.dts | 41 ++
arch/powerpc/boot/dts/sbc8349.dts | 35
arch/powerpc/boot/dts/sbc8548.dts | 41 ++
arch/powerpc/boot/dts/sbc8560.dts | 41 ++
arch/powerpc/boot/dts/sbc8641d.dts | 41 ++
arch/powerpc/boot/dts/stx_gp3_8560.dts | 41 ++
arch/powerpc/boot/dts/tqm8540.dts | 41 ++
arch/powerpc/boot/dts/tqm8541.dts | 41 ++
arch/powerpc/boot/dts/tqm8548-bigflash.dts | 41 ++
arch/powerpc/boot/dts/tqm8548.dts | 41 ++
arch/powerpc/boot/dts/tqm8555.dts | 41 ++
arch/powerpc/boot/dts/tqm8560.dts | 41 ++
36 files changed, 1433 insertions(+), 53 deletions(-)
diff --git a/arch/powerpc/boot/dts/asp834x-redboot.dts
b/arch/powerpc/boot/dts/asp834x-redboot.dts
index 972cf78..8b1bb0e 100644
--- a/arch/powerpc/boot/dts/asp834x-redboot.dts
+++ b/arch/powerpc/boot/dts/asp834x-redboot.dts
@@ -118,6 +118,41 @@
mode = cpu;
};
+ [EMAIL PROTECTED] {
+ #address-cells = 1;
+ #size-cells = 1;
+ compatible = fsl,mpc8347-dma, fsl,elo-dma;
+ reg = 0x82a8 4;
+ ranges = 0 0x8100 0x1a8;
+ interrupt-parent = ipic;
+ interrupts = 71 8;
+ cell-index = 0;
+ [EMAIL PROTECTED] {
+ compatible = fsl,mpc8347-dma-channel,
fsl,elo-dma-channel;
+ reg = 0 0x80;
+ interrupt-parent = ipic;
+ interrupts = 71 8;
+ };
+ [EMAIL PROTECTED] {
+ compatible = fsl,mpc8347-dma-channel,
fsl,elo-dma-channel;
+ reg = 0x80 0x80;
+ interrupt-parent = ipic;
+ interrupts = 71 8;
+ };
+ [EMAIL PROTECTED] {
+ compatible = fsl,mpc8347-dma-channel,
fsl,elo-dma-channel;
+ reg = 0x100 0x80;
+ interrupt-parent = ipic;
+ interrupts = 71 8;
+ };
+ [EMAIL PROTECTED] {
+ compatible = fsl,mpc8347-dma-channel,
fsl,elo-dma-channel;
+ reg = 0x180 0x28;
+ interrupt-parent = ipic;
+ interrupts = 71 8;
+ };
+ };
+
/* phy type (ULPI or SERIAL) are only types supported for MPH */
/* port = 0 or 1 */
[EMAIL PROTECTED] {
diff --git a/arch/powerpc/boot/dts/ksi8560.dts
b/arch/powerpc/boot/dts/ksi8560.dts
index
