Re: Build regressions/improvements in v4.1-rc1
cc Chris On Tue, Apr 28, 2015 at 2:24 PM, Rusty Russell wrote: > Geert Uytterhoeven writes: >>> Can't see that one with a simple grep: can you post warning? >> >> /home/kisskb/slave/src/arch/tile/kernel/setup.c: In function >> 'zone_sizes_init': >> /home/kisskb/slave/src/arch/tile/kernel/setup.c:777:3: warning: >> passing argument 2 of 'cpumask_test_cpu' from incompatible pointer >> type [enabled by default] >> /home/kisskb/slave/src/include/linux/cpumask.h:294:19: note: expected >> 'const struct cpumask *' but argument is of type 'struct nodemask_t *' > > Um, I turned the cpu_isset() into cpumask_test_cpu(), but that just > showed this bug up. The tile maintainers need to fix this one. > > Thanks, > Rusty. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: Build regressions/improvements in v4.1-rc1
Geert Uytterhoeven writes: >> Can't see that one with a simple grep: can you post warning? > > /home/kisskb/slave/src/arch/tile/kernel/setup.c: In function > 'zone_sizes_init': > /home/kisskb/slave/src/arch/tile/kernel/setup.c:777:3: warning: > passing argument 2 of 'cpumask_test_cpu' from incompatible pointer > type [enabled by default] > /home/kisskb/slave/src/include/linux/cpumask.h:294:19: note: expected > 'const struct cpumask *' but argument is of type 'struct nodemask_t *' Um, I turned the cpu_isset() into cpumask_test_cpu(), but that just showed this bug up. The tile maintainers need to fix this one. Thanks, Rusty. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: Build regressions/improvements in v4.1-rc1
On Tue, Apr 28, 2015 at 6:39 AM, Rusty Russell wrote:
>>> + /home/kisskb/slave/src/arch/mips/cavium-octeon/smp.c: error: passing
>>> argument 2 of 'cpumask_clear_cpu' discards 'volatile' qualifier from
>>> pointer target type [-Werror]: => 242:2
>>> + /home/kisskb/slave/src/arch/mips/kernel/process.c: error: passing
>>> argument 2 of 'cpumask_test_cpu' discards 'volatile' qualifier from pointer
>>> target type [-Werror]: => 52:2
>>> + /home/kisskb/slave/src/arch/mips/kernel/smp.c: error: passing argument
>>> 2 of 'cpumask_set_cpu' discards 'volatile' qualifier from pointer target
>>> type [-Werror]: => 149:2, 211:2
>>> + /home/kisskb/slave/src/arch/mips/kernel/smp.c: error: passing argument
>>> 2 of 'cpumask_test_cpu' discards 'volatile' qualifier from pointer target
>>> type [-Werror]: => 221:2
> and related warnings due to lack of -Werror on
>> tilegx_defconfig
>
> Can't see that one with a simple grep: can you post warning?
/home/kisskb/slave/src/arch/tile/kernel/setup.c: In function 'zone_sizes_init':
/home/kisskb/slave/src/arch/tile/kernel/setup.c:777:3: warning:
passing argument 2 of 'cpumask_test_cpu' from incompatible pointer
type [enabled by default]
/home/kisskb/slave/src/include/linux/cpumask.h:294:19: note: expected
'const struct cpumask *' but argument is of type 'struct nodemask_t *'
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: Build regressions/improvements in v4.1-rc1
Geert Uytterhoeven writes: > On Mon, Apr 27, 2015 at 11:51 AM, Geert Uytterhoeven > wrote: >> Below is the list of build error/warning regressions/improvements in >> v4.1-rc1[1] compared to v4.0[2]. >> >> Summarized: >> - build errors: +34/-11 >> - build warnings: +135/-163 >> >> As I haven't mastered kup yet, there's no verbose summary at >> http://www.kernel.org/pub/linux/kernel/people/geert/linux-log/v4.1-rc1.summary.gz >> >> Happy fixing! ;-) >> >> Thanks to the linux-next team for providing the build service. >> >> [1] http://kisskb.ellerman.id.au/kisskb/head/8779/ (254 out of 257 configs) >> [2] http://kisskb.ellerman.id.au/kisskb/head/8710/ (254 out of 257 configs) >> >> >> *** ERRORS *** >> >> 34 regressions: > > The quiet days are over... > >> + /home/kisskb/slave/src/arch/mips/cavium-octeon/smp.c: error: passing >> argument 2 of 'cpumask_clear_cpu' discards 'volatile' qualifier from pointer >> target type [-Werror]: => 242:2 >> + /home/kisskb/slave/src/arch/mips/kernel/process.c: error: passing >> argument 2 of 'cpumask_test_cpu' discards 'volatile' qualifier from pointer >> target type [-Werror]: => 52:2 >> + /home/kisskb/slave/src/arch/mips/kernel/smp.c: error: passing argument 2 >> of 'cpumask_set_cpu' discards 'volatile' qualifier from pointer target type >> [-Werror]: => 149:2, 211:2 >> + /home/kisskb/slave/src/arch/mips/kernel/smp.c: error: passing argument 2 >> of 'cpumask_test_cpu' discards 'volatile' qualifier from pointer target type >> [-Werror]: => 221:2 > > mips/bigsur_defconfig > mips/malta_defconfig > mips/cavium_octeon_defconfig > mips/ip27_defconfig Already fixed in other thread... > and related warnings due to lack of -Werror on > ia64-defconfig That fix is fairly obvious, I'll post separately. > tilegx_defconfig Can't see that one with a simple grep: can you post warning? > m32r/m32700ut.smp_defconfig Will post fix for this too. > cpumask also gives fishy warnings: > > lib/cpumask.c:167:25: warning: the address of 'cpu_all_bits' will > always evaluate as 'true' [-Waddress] > > on sparc (e.g. sparc64/sparc64-allmodconfig) and powerpc (e.g. > powerpc/ppc64_defconfig), which seem to have been reported 6 months > ago... Hmm, this is cpumask_of_node? That's... Oh my, that requires a separate post. > Can we throw some bitcoins at the cpumasks? ;-) I think I should be throwing bitcoins at you, instead! Thanks, Rusty. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: Build regressions/improvements in v4.1-rc1
On Mon, Apr 27, 2015 at 12:03:32PM +0200, Geert Uytterhoeven wrote: > On Mon, Apr 27, 2015 at 11:51 AM, Geert Uytterhoeven > wrote: > > Below is the list of build error/warning regressions/improvements in > > v4.1-rc1[1] compared to v4.0[2]. > > > > Summarized: > > - build errors: +34/-11 > > - build warnings: +135/-163 > > > > As I haven't mastered kup yet, there's no verbose summary at > > http://www.kernel.org/pub/linux/kernel/people/geert/linux-log/v4.1-rc1.summary.gz > > > > Happy fixing! ;-) > > > > Thanks to the linux-next team for providing the build service. > > > > [1] http://kisskb.ellerman.id.au/kisskb/head/8779/ (254 out of 257 configs) > > [2] http://kisskb.ellerman.id.au/kisskb/head/8710/ (254 out of 257 configs) > > > > > > *** ERRORS *** > > > > 34 regressions: > > The quiet days are over... > Is it just my impression, or is the code quality in this commit window a bit lower than usual (very politely said) ? Guenter ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: Build regressions/improvements in v4.1-rc1
Hi, On Mon, Apr 27, 2015 at 12:03:32PM +0200, Geert Uytterhoeven wrote: > > *** ERRORS *** > > > > 34 regressions: > > The quiet days are over... > > > + /home/kisskb/slave/src/arch/mips/cavium-octeon/smp.c: error: passing > > argument 2 of 'cpumask_clear_cpu' discards 'volatile' qualifier from > > pointer target type [-Werror]: => 242:2 > > + /home/kisskb/slave/src/arch/mips/kernel/process.c: error: passing > > argument 2 of 'cpumask_test_cpu' discards 'volatile' qualifier from pointer > > target type [-Werror]: => 52:2 > > + /home/kisskb/slave/src/arch/mips/kernel/smp.c: error: passing argument > > 2 of 'cpumask_set_cpu' discards 'volatile' qualifier from pointer target > > type [-Werror]: => 149:2, 211:2 For these there is a fix proposal: http://patchwork.linux-mips.org/patch/9828/ A. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: Build regressions/improvements in v4.1-rc1
On Mon, Apr 27, 2015 at 11:51 AM, Geert Uytterhoeven
wrote:
> Below is the list of build error/warning regressions/improvements in
> v4.1-rc1[1] compared to v4.0[2].
>
> Summarized:
> - build errors: +34/-11
> - build warnings: +135/-163
>
> As I haven't mastered kup yet, there's no verbose summary at
> http://www.kernel.org/pub/linux/kernel/people/geert/linux-log/v4.1-rc1.summary.gz
>
> Happy fixing! ;-)
>
> Thanks to the linux-next team for providing the build service.
>
> [1] http://kisskb.ellerman.id.au/kisskb/head/8779/ (254 out of 257 configs)
> [2] http://kisskb.ellerman.id.au/kisskb/head/8710/ (254 out of 257 configs)
>
>
> *** ERRORS ***
>
> 34 regressions:
The quiet days are over...
> + /home/kisskb/slave/src/arch/mips/cavium-octeon/smp.c: error: passing
> argument 2 of 'cpumask_clear_cpu' discards 'volatile' qualifier from pointer
> target type [-Werror]: => 242:2
> + /home/kisskb/slave/src/arch/mips/kernel/process.c: error: passing
> argument 2 of 'cpumask_test_cpu' discards 'volatile' qualifier from pointer
> target type [-Werror]: => 52:2
> + /home/kisskb/slave/src/arch/mips/kernel/smp.c: error: passing argument 2
> of 'cpumask_set_cpu' discards 'volatile' qualifier from pointer target type
> [-Werror]: => 149:2, 211:2
> + /home/kisskb/slave/src/arch/mips/kernel/smp.c: error: passing argument 2
> of 'cpumask_test_cpu' discards 'volatile' qualifier from pointer target type
> [-Werror]: => 221:2
mips/bigsur_defconfig
mips/malta_defconfig
mips/cavium_octeon_defconfig
mips/ip27_defconfig
and related warnings due to lack of -Werror on
ia64-defconfig
tilegx_defconfig
m32r/m32700ut.smp_defconfig
cpumask also gives fishy warnings:
lib/cpumask.c:167:25: warning: the address of 'cpu_all_bits' will
always evaluate as 'true' [-Waddress]
on sparc (e.g. sparc64/sparc64-allmodconfig) and powerpc (e.g.
powerpc/ppc64_defconfig), which seem to have been reported 6 months ago...
Can we throw some bitcoins at the cpumasks? ;-)
> + /home/kisskb/slave/src/arch/mips/sgi-ip32/ip32-platform.c: error:
> 'sgio2_cmos_devinit' undeclared here (not in a function): => 138:1
> + /home/kisskb/slave/src/arch/mips/sgi-ip32/ip32-platform.c: error:
> expected identifier or '(' before '+' token: => 133:1
mips/ip32_defconfig
> + /home/kisskb/slave/src/arch/powerpc/include/asm/spinlock.h: error:
> "arch_read_can_lock" redefined [-Werror]: => 185:0
> + /home/kisskb/slave/src/arch/powerpc/include/asm/spinlock.h: error:
> "arch_write_can_lock" redefined [-Werror]: => 186:0
> + /home/kisskb/slave/src/arch/powerpc/include/asm/spinlock.h: error:
> "smp_mb__after_unlock_lock" redefined [-Werror]: => 31:0
> + /home/kisskb/slave/src/arch/powerpc/include/asm/spinlock.h: error:
> 'arch_rwlock_t' has no member named 'lock': => 267:12, 303:4, 214:12,
> 295:11, 253:12, 238:25
> + /home/kisskb/slave/src/arch/powerpc/include/asm/spinlock.h: error:
> 'arch_spinlock_t' has no member named 'slock': => 86:27, 59:13
> + /home/kisskb/slave/src/arch/powerpc/include/asm/spinlock.h: error:
> expected ')' before '(' token: => 62:19
> + /home/kisskb/slave/src/arch/powerpc/include/asm/spinlock.h: error:
> expected identifier or '(' before 'do': => 159:20, 139:6, 168:13, 123:20
> + /home/kisskb/slave/src/arch/powerpc/include/asm/spinlock.h: error:
> expected identifier or '(' before 'void': => 62:19
> + /home/kisskb/slave/src/arch/powerpc/include/asm/spinlock.h: error:
> expected identifier or '(' before 'while': => 168:13, 123:20, 139:6, 159:20
> + /home/kisskb/slave/src/arch/powerpc/include/asm/spinlock.h: error:
> expected identifier or '(' before '{' token: => 92:19
powerpc/ppc64_defconfig+UP
> +
> /home/kisskb/slave/src/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c:
> error: implicit declaration of function 'dma_alloc_attrs'
> [-Werror=implicit-function-declaration]: => 218:2
> +
> /home/kisskb/slave/src/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c:
> error: implicit declaration of function 'dma_free_attrs'
> [-Werror=implicit-function-declaration]: => 154:2
xtensa-allmodconfig
powerpc/mpc85xx_defconfig
> + /home/kisskb/slave/src/drivers/spi/spi-bcm2835.c: error: dereferencing
> pointer to incomplete type: => 356:21, 387:21
> + /home/kisskb/slave/src/drivers/spi/spi-bcm2835.c: error: implicit
> declaration of function 'gpiochip_find'
> [-Werror=implicit-function-declaration]: => 382:2
m68k-allmodconfig
s390-allyesconfig
s390-allmodconfig
parisc-allmodconfig
sh-allmodconfig
sh-allyesconfig
mips-allmodconfig
(fix stuck in the spi tree?)
> + /home/kisskb/slave/src/fs/dax.c: error: implicit declaration of function
> 'copy_user_page' [-Werror=implicit-function-declaration]: => 265:2
sh-randconfig
> + /home/kisskb/slave/src/fs/hostfs/hostfs_user.c: error: 'AT_FDCWD'
> undeclared (first use in this function): => 373
> + /home/kisskb/slave/src/fs/hostfs/hostfs_user.c: error: (Each undeclared
> identifier is reported only o
