Re: [PATCH 4/9] Add Synopsys DesignWare HS USB OTG Controller driver.
Dear David Daney, In message <4c2a8038.50...@caviumnetworks.com> you wrote: > > > Why are you posting this old driver version without trying to sync > > against our tree which includes a number of fixes - you should know > > about these. > > > > This could be a question with an obvious answer, but which tree are you > referring to when you say 'our tree'? git://git.denx.de/linux-2.6-denx.git Fushen Chen should know this, as the fixes I've mentioned were part of contract/support work for Applied Micro. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The Wright Bothers weren't the first to fly. They were just the first not to crash. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 4/9] Add Synopsys DesignWare HS USB OTG Controller driver.
On 06/29/2010 04:13 PM, Wolfgang Denk wrote: Dear Fushen Chen, In message<1277846824673-git-send-email-fc...@apm.com> you wrote: Implements DWC OTG USB Host Controller Driver (HCD) and interface to USB Host controller Driver framework. Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld --- drivers/usb/otg/dwc_otg_hcd.c | 2397 + drivers/usb/otg/dwc_otg_hcd.h | 421 2 files changed, 2818 insertions(+), 0 deletions(-) create mode 100644 drivers/usb/otg/dwc_otg_hcd.c create mode 100644 drivers/usb/otg/dwc_otg_hcd.h Why are you posting this old driver version without trying to sync against our tree which includes a number of fixes - you should know about these. This could be a question with an obvious answer, but which tree are you referring to when you say 'our tree'? David Daney ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 4/9] Add Synopsys DesignWare HS USB OTG Controller driver.
Dear Fushen Chen,
In message <1277846824673-git-send-email-fc...@apm.com> you wrote:
> Implements DWC OTG USB Host Controller Driver (HCD) and interface to
> USB Host controller Driver framework.
>
> Signed-off-by: Fushen Chen
> Signed-off-by: Mark Miesfeld
> ---
> drivers/usb/otg/dwc_otg_hcd.c | 2397
> +
> drivers/usb/otg/dwc_otg_hcd.h | 421
> 2 files changed, 2818 insertions(+), 0 deletions(-)
> create mode 100644 drivers/usb/otg/dwc_otg_hcd.c
> create mode 100644 drivers/usb/otg/dwc_otg_hcd.h
Why are you posting this old driver version without trying to sync
against our tree which includes a number of fixes - you should know
about these.
...
> + do {
> + hcchar.d32 = dwc_read_reg32(&hc_regs->hcchar);
> + if (++count > 1) {
> + printk(KERN_ERR "%s: Unable to clear halt on "
> + "channel %d\n", __func__, i);
> + break;
> + }
> + } while (hcchar.b.chen);
> + }
For example, here you are missing
commit 018b43db153da063182c87be2eaad037cba2d879
Author: Stefan Roese
Date: Thu Sep 24 17:15:06 2009 +0200
USB: Fix timeout problem with polling loops in DWC USB-OTG driver
In [PATCH 6/9] Add Synopsys DesignWare HS USB OTG Controller driver
you are missing
commit 538fe70d696bc5e694ab08e9627a99a0b11358ec
Author: Stefan Roese
Date: Wed Sep 23 08:50:29 2009 +0200
USB: Fix problem with reconnection in DWC USB-OTG driver
etc.
Please update your code and resubmit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The biggest difference between time and space is that you can't reuse
time. - Merrick Furst
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
