[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Don't show confirm dialog when switching to NWE
jenkins-bot has submitted this change and it was merged. Change subject: Don't show confirm dialog when switching to NWE .. Don't show confirm dialog when switching to NWE Bug: T148099 Change-Id: Icd756dc31ef8628795915ea972bb0ded385532ed --- M modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Alex Monk: Looks good to me, but someone else must approve Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js b/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js index 3106049..7364224 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js @@ -125,6 +125,16 @@ /** * @inheritdoc */ +ve.init.mw.DesktopWikitextArticleTarget.prototype.editSource = function () { + // Don't bother with a confirm dialog when switching to the new wikitext editor. + // Second argument (modified) is never checked if we are keeping changes, so + // don't bother computing it. + this.switchToWikitextEditor( false ); +}; + +/** + * @inheritdoc + */ ve.init.mw.DesktopWikitextArticleTarget.prototype.onWindowPopState = function ( e ) { var veaction, mode; -- To view, visit https://gerrit.wikimedia.org/r/316293 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd756dc31ef8628795915ea972bb0ded385532ed Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Esanders Gerrit-Reviewer: Alex Monk Gerrit-Reviewer: Jforrester Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Don't show confirm dialog when switching to NWE
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/316293 Change subject: Don't show confirm dialog when switching to NWE .. Don't show confirm dialog when switching to NWE Bug: T148099 Change-Id: Icd756dc31ef8628795915ea972bb0ded385532ed --- M modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/93/316293/1 diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js b/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js index 4cdfad2..8836380 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js @@ -105,6 +105,14 @@ /** * @inheritdoc */ +ve.init.mw.DesktopWikitextArticleTarget.prototype.editSource = function () { + // Don't bother with a confirm dialog when switching to the new wikitext editor + this.switchToWikitextEditor( true, false ); +}; + +/** + * @inheritdoc + */ ve.init.mw.DesktopWikitextArticleTarget.prototype.onWindowPopState = function ( e ) { var veaction, mode; -- To view, visit https://gerrit.wikimedia.org/r/316293 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icd756dc31ef8628795915ea972bb0ded385532ed Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Esanders ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits