[MediaWiki-commits] [Gerrit] NSString contains: is new in ios 8 :P - change (apps...wikipedia)

2014-12-05 Thread Mhurd (Code Review) 
Mhurd has submitted this change and it was merged.

Change subject: NSString contains: is new in ios 8 :P
..


NSString contains: is new in ios 8 :P

Change-Id: I317d971fe0bd5b950fc69a34376ab2f68e48f536
---
M MediaWikiKit/MediaWikiKit/MWKDataObject.m
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Mhurd: Verified; Looks good to me, approved



diff --git a/MediaWikiKit/MediaWikiKit/MWKDataObject.m 
b/MediaWikiKit/MediaWikiKit/MWKDataObject.m
index 0f24fff..5715f7b 100644
--- a/MediaWikiKit/MediaWikiKit/MWKDataObject.m
+++ b/MediaWikiKit/MediaWikiKit/MWKDataObject.m
@@ -77,7 +77,8 @@
 
 - (NSNumber *)numberWithString:(NSString *)str
 {
-if ([str containsString:@.] || [str containsString:@e]) {
+if ([str rangeOfString:@.].location != NSNotFound ||
+[str rangeOfString:@e].location != NSNotFound) {
 double val = [str doubleValue];
 return [NSNumber numberWithDouble:val];
 } else {

-- 
To view, visit https://gerrit.wikimedia.org/r/177407
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I317d971fe0bd5b950fc69a34376ab2f68e48f536
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER br...@wikimedia.org
Gerrit-Reviewer: Mhurd mh...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] NSString contains: is new in ios 8 :P - change (apps...wikipedia)

2014-12-03 Thread Brion VIBBER (Code Review) 
Brion VIBBER has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/177407

Change subject: NSString contains: is new in ios 8 :P
..

NSString contains: is new in ios 8 :P

Change-Id: I317d971fe0bd5b950fc69a34376ab2f68e48f536
---
M MediaWikiKit/MediaWikiKit/MWKDataObject.m
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/07/177407/1

diff --git a/MediaWikiKit/MediaWikiKit/MWKDataObject.m 
b/MediaWikiKit/MediaWikiKit/MWKDataObject.m
index 0f24fff..5715f7b 100644
--- a/MediaWikiKit/MediaWikiKit/MWKDataObject.m
+++ b/MediaWikiKit/MediaWikiKit/MWKDataObject.m
@@ -77,7 +77,8 @@
 
 - (NSNumber *)numberWithString:(NSString *)str
 {
-if ([str containsString:@.] || [str containsString:@e]) {
+if ([str rangeOfString:@.].location != NSNotFound ||
+[str rangeOfString:@e].location != NSNotFound) {
 double val = [str doubleValue];
 return [NSNumber numberWithDouble:val];
 } else {

-- 
To view, visit https://gerrit.wikimedia.org/r/177407
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I317d971fe0bd5b950fc69a34376ab2f68e48f536
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER br...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits