[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Handle missing error.debug

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/383050 )

Change subject: Handle missing error.debug
..


Handle missing error.debug

In some cases, server may fail without specifying an error,
in which case the error.debug will be undefined, which causes
an error in the later regex parsing.

Change-Id: I2fefdc063c1bf8376c062e7126601ff573ae0400
---
M wikibase/queryService/ui/ResultView.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Lucas Werkmeister (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wikibase/queryService/ui/ResultView.js 
b/wikibase/queryService/ui/ResultView.js
index f54a3de..a643abe 100644
--- a/wikibase/queryService/ui/ResultView.js
+++ b/wikibase/queryService/ui/ResultView.js
@@ -311,7 +311,7 @@
this._actionBar.show( errorMessageKey || '', error.message || 
'', 'danger' );
this._track( 'result.error.' + ( errorMessageKey || 'unknown' ) 
);
 
-   return error.debug;
+   return error.debug === undefined ? '' : error.debug;
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/383050
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2fefdc063c1bf8376c062e7126601ff573ae0400
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Yurik 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: Lucas Werkmeister (WMDE) 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: Yurik 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Handle missing error.debug

[Yurik (Code Review)]

Yurik has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383050 )

Change subject: Handle missing error.debug
..

Handle missing error.debug

In some cases, server may fail without specifying an error,
in which case the error.debug will be undefined, which causes
an error in the later regex parsing.

Change-Id: I2fefdc063c1bf8376c062e7126601ff573ae0400
---
M wikibase/queryService/ui/ResultView.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui 
refs/changes/50/383050/1

diff --git a/wikibase/queryService/ui/ResultView.js 
b/wikibase/queryService/ui/ResultView.js
index f54a3de..a643abe 100644
--- a/wikibase/queryService/ui/ResultView.js
+++ b/wikibase/queryService/ui/ResultView.js
@@ -311,7 +311,7 @@
this._actionBar.show( errorMessageKey || '', error.message || 
'', 'danger' );
this._track( 'result.error.' + ( errorMessageKey || 'unknown' ) 
);
 
-   return error.debug;
+   return error.debug === undefined ? '' : error.debug;
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/383050
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fefdc063c1bf8376c062e7126601ff573ae0400
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Yurik 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits