Re: [Mesa-dev] [PATCH] radv: enable shaderInt8 on SI and CIK

2019-04-15 Thread Bas Nieuwenhuizen
r-b

On Mon, Apr 15, 2019 at 5:42 PM Samuel Pitoiset
 wrote:
>
> No CTS failures.
>
> Signed-off-by: Samuel Pitoiset 
> ---
>  src/amd/vulkan/radv_device.c  | 5 ++---
>  src/amd/vulkan/radv_extensions.py | 2 +-
>  2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index c517b56cd0f..998d6f02eb2 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -901,9 +901,8 @@ void radv_GetPhysicalDeviceFeatures2(
> case 
> VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FLOAT16_INT8_FEATURES_KHR: {
> VkPhysicalDeviceFloat16Int8FeaturesKHR *features =
> (VkPhysicalDeviceFloat16Int8FeaturesKHR*)ext;
> -   bool enabled = pdevice->rad_info.chip_class >= VI;
> -   features->shaderFloat16 = enabled && HAVE_LLVM >= 
> 0x0800;
> -   features->shaderInt8 = enabled;
> +   features->shaderFloat16 = 
> pdevice->rad_info.chip_class >= VI && HAVE_LLVM >= 0x0800;
> +   features->shaderInt8 = true;
> break;
> }
> default:
> diff --git a/src/amd/vulkan/radv_extensions.py 
> b/src/amd/vulkan/radv_extensions.py
> index 3d0a0c4343e..13fe391e623 100644
> --- a/src/amd/vulkan/radv_extensions.py
> +++ b/src/amd/vulkan/radv_extensions.py
> @@ -82,7 +82,7 @@ EXTENSIONS = [
>  Extension('VK_KHR_relaxed_block_layout',  1, True),
>  Extension('VK_KHR_sampler_mirror_clamp_to_edge',  1, True),
>  Extension('VK_KHR_shader_draw_parameters',1, True),
> -Extension('VK_KHR_shader_float16_int8',   1, 
> 'device->rad_info.chip_class >= VI'),
> +Extension('VK_KHR_shader_float16_int8',   1, True),
>  Extension('VK_KHR_storage_buffer_storage_class',  1, True),
>  Extension('VK_KHR_surface',  25, 
> 'RADV_HAS_SURFACE'),
>  Extension('VK_KHR_surface_protected_capabilities',1, 
> 'RADV_HAS_SURFACE'),
> --
> 2.21.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radv: enable shaderInt8 on SI and CIK

2019-04-15 Thread Samuel Pitoiset
No CTS failures.

Signed-off-by: Samuel Pitoiset 
---
 src/amd/vulkan/radv_device.c  | 5 ++---
 src/amd/vulkan/radv_extensions.py | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index c517b56cd0f..998d6f02eb2 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -901,9 +901,8 @@ void radv_GetPhysicalDeviceFeatures2(
case 
VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FLOAT16_INT8_FEATURES_KHR: {
VkPhysicalDeviceFloat16Int8FeaturesKHR *features =
(VkPhysicalDeviceFloat16Int8FeaturesKHR*)ext;
-   bool enabled = pdevice->rad_info.chip_class >= VI;
-   features->shaderFloat16 = enabled && HAVE_LLVM >= 
0x0800;
-   features->shaderInt8 = enabled;
+   features->shaderFloat16 = pdevice->rad_info.chip_class 
>= VI && HAVE_LLVM >= 0x0800;
+   features->shaderInt8 = true;
break;
}
default:
diff --git a/src/amd/vulkan/radv_extensions.py 
b/src/amd/vulkan/radv_extensions.py
index 3d0a0c4343e..13fe391e623 100644
--- a/src/amd/vulkan/radv_extensions.py
+++ b/src/amd/vulkan/radv_extensions.py
@@ -82,7 +82,7 @@ EXTENSIONS = [
 Extension('VK_KHR_relaxed_block_layout',  1, True),
 Extension('VK_KHR_sampler_mirror_clamp_to_edge',  1, True),
 Extension('VK_KHR_shader_draw_parameters',1, True),
-Extension('VK_KHR_shader_float16_int8',   1, 
'device->rad_info.chip_class >= VI'),
+Extension('VK_KHR_shader_float16_int8',   1, True),
 Extension('VK_KHR_storage_buffer_storage_class',  1, True),
 Extension('VK_KHR_surface',  25, 
'RADV_HAS_SURFACE'),
 Extension('VK_KHR_surface_protected_capabilities',1, 
'RADV_HAS_SURFACE'),
-- 
2.21.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev