Re: [PATCH] telit: support RS232 modems

[Aleksander Morgado]

On Thu, Mar 16, 2017 at 10:57 AM, Daniele Palmas  wrote:
> Tested with GL865 and working fine
>
> daniele@L2122:~$ mmcli -m 0
>
> /org/freedesktop/ModemManager1/Modem/0 (device id
> 'e31ff4d485c411511410e55f1f682373f9f68e2f')
>  -
>  Hardware |   manufacturer: 'Telit'
>   |  model: 'GL865-QUAD'
>   |   revision: '10.01.143'
>   |  supported: 'gsm-umts'
>   |current: 'gsm-umts'
>   |   equipment id: '356308040051861'
>  -
>  System   | device: '/sys/devices/pnp0/00:05'
>   |drivers: 'serial'
>   | plugin: 'Telit'
>   |   primary port: 'ttyS0'
>   |  ports: 'ttyS0 (at)'
>  -
>  Numbers  |   own : '9876543210'
>  -
>  Status   |   lock: 'none'
>   | unlock retries: 'unknown'
>   |  state: 'connected'
>   |power state: 'on'
>   |access tech: 'unknown'
>   | signal quality: '61' (recent)
>  -
>  Modes|  supported: 'allowed: 2g; preferred: none'
>   |current: 'allowed: 2g; preferred: none'
>  -
>  Bands|  supported: 'egsm, dcs, pcs, g850'
>   |current: 'egsm, dcs'
>  -
>  IP   |  supported: 'ipv4, ipv6'
>  -
>  3GPP |   imei: '356308040051861'
>   |  enabled locks: 'none'
>   |operator id: '22201'
>   |  operator name: 'I TIM'
>   |   subscription: 'unknown'
>   |   registration: 'home'
>  -
>  SIM  |   path: '/org/freedesktop/ModemManager1/SIM/0'
>
>  -
>  Bearers  |  paths: '/org/freedesktop/ModemManager1/Bearer/0'

Great! thanks for testing

-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: [PATCH] telit: support RS232 modems

[Daniele Palmas]

Hi Aleksander (resending with all included),

2017-03-13 20:05 GMT+01:00 Aleksander Morgado :
> On Mon, Mar 13, 2017 at 6:29 PM, Daniele Palmas  wrote:
>>> With this patch on, a Telit RS232 modem still needs the udev tag in
>>> the appropriate port to get it grabbed by the Telit plugin. Without
>>> this patch, the telit plugin would not grab this patch even if the
>>> udev tag is set because the vid/pid filter would filter it out.
>>>
>>
>> It seems good to me, since, as far as I understand it looks like the
>> only way for using use a Telit RS232-based modem: if needed I can do a
>> quick test with one of those modems.
>
> I've tested this already with a Telit LE866, but I wouldn't mind
> additional tests. Remember: you need the ID_MM_TELIT_TAGGED udev tag,
> and if you're using a RS232<->USB adapter, you can request probing of
> the device manually with "mmcli -S".
>

Hi Aleksander,

2017-03-13 20:05 GMT+01:00 Aleksander Morgado :
> On Mon, Mar 13, 2017 at 6:29 PM, Daniele Palmas  wrote:
>>> With this patch on, a Telit RS232 modem still needs the udev tag in
>>> the appropriate port to get it grabbed by the Telit plugin. Without
>>> this patch, the telit plugin would not grab this patch even if the
>>> udev tag is set because the vid/pid filter would filter it out.
>>>
>>
>> It seems good to me, since, as far as I understand it looks like the
>> only way for using use a Telit RS232-based modem: if needed I can do a
>> quick test with one of those modems.
>
> I've tested this already with a Telit LE866, but I wouldn't mind
> additional tests. Remember: you need the ID_MM_TELIT_TAGGED udev tag,
> and if you're using a RS232<->USB adapter, you can request probing of
> the device manually with "mmcli -S".
>

Tested with GL865 and working fine

daniele@L2122:~$ mmcli -m 0

/org/freedesktop/ModemManager1/Modem/0 (device id
'e31ff4d485c411511410e55f1f682373f9f68e2f')
 -
 Hardware |   manufacturer: 'Telit'
  |  model: 'GL865-QUAD'
  |   revision: '10.01.143'
  |  supported: 'gsm-umts'
  |current: 'gsm-umts'
  |   equipment id: '356308040051861'
 -
 System   | device: '/sys/devices/pnp0/00:05'
  |drivers: 'serial'
  | plugin: 'Telit'
  |   primary port: 'ttyS0'
  |  ports: 'ttyS0 (at)'
 -
 Numbers  |   own : '9876543210'
 -
 Status   |   lock: 'none'
  | unlock retries: 'unknown'
  |  state: 'connected'
  |power state: 'on'
  |access tech: 'unknown'
  | signal quality: '61' (recent)
 -
 Modes|  supported: 'allowed: 2g; preferred: none'
  |current: 'allowed: 2g; preferred: none'
 -
 Bands|  supported: 'egsm, dcs, pcs, g850'
  |current: 'egsm, dcs'
 -
 IP   |  supported: 'ipv4, ipv6'
 -
 3GPP |   imei: '356308040051861'
  |  enabled locks: 'none'
  |operator id: '22201'
  |  operator name: 'I TIM'
  |   subscription: 'unknown'
  |   registration: 'home'
 -
 SIM  |   path: '/org/freedesktop/ModemManager1/SIM/0'

 -
 Bearers  |  paths: '/org/freedesktop/ModemManager1/Bearer/0'

> --
> Aleksander
> https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: [PATCH] telit: support RS232 modems

[Dan Williams]

On Sun, 2017-03-12 at 20:47 +0100, Aleksander Morgado wrote:
> Adding the vendor string match allows us to support RS232 devices in
> the Telit plugin: the USB vendor id check may now be ignored and
> instead we probe for the vendor string via AT commands, which works
> even if the device is behind a USB<->RS232 adapter.
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=100171
> ---
> 
> Hey hey,
> 
> This patch enables support for RS232 modems in the Telit plugin; this
> is, modems that are connected to a system via a RS232 port, or via a
> USB<->RS232 adapter.
> 
> Comments?

Should this be paired with a patch adding Gobi capability to the telit
driver, so that we don't capture Gobi-type devices as AT-only?  Or is
that not a problem?

(eg, per our discussion about just using vendor ID instead of udev
tags; this is the same result just different approach, no?)

Dan

> ---
>  plugins/telit/mm-plugin-telit.c | 14 --
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/plugins/telit/mm-plugin-telit.c b/plugins/telit/mm-
> plugin-telit.c
> index caf3ef01..ec3c024f 100644
> --- a/plugins/telit/mm-plugin-telit.c
> +++ b/plugins/telit/mm-plugin-telit.c
> @@ -59,6 +59,7 @@ mm_plugin_create (void)
>  static const gchar *subsystems[] = { "tty", NULL };
>  /* Vendors: Telit */
>  static const guint16 vendor_ids[] = { 0x1bc7, 0 };
> +static const gchar *vendor_strings[] = { "telit", NULL };
>  /* Only handle TELIT tagged devices here. */
>  static const gchar *udev_tags[] = {
>  "ID_MM_TELIT_TAGGED",
> @@ -72,12 +73,13 @@ mm_plugin_create (void)
> 
>  return MM_PLUGIN (
>  g_object_new (MM_TYPE_PLUGIN_TELIT,
> -  MM_PLUGIN_NAME,   "Telit",
> -  MM_PLUGIN_ALLOWED_SUBSYSTEMS, subsystems,
> -  MM_PLUGIN_ALLOWED_VENDOR_IDS, vendor_ids,
> -  MM_PLUGIN_ALLOWED_AT, TRUE,
> -  MM_PLUGIN_ALLOWED_UDEV_TAGS,  udev_tags,
> -  MM_PLUGIN_CUSTOM_INIT,_init,
> +  MM_PLUGIN_NAME,   "Telit",
> +  MM_PLUGIN_ALLOWED_SUBSYSTEMS, subsystems,
> +  MM_PLUGIN_ALLOWED_VENDOR_IDS, vendor_ids,
> +  MM_PLUGIN_ALLOWED_VENDOR_STRINGS,
> vendor_strings,
> +  MM_PLUGIN_ALLOWED_AT, TRUE,
> +  MM_PLUGIN_ALLOWED_UDEV_TAGS,  udev_tags,
> +  MM_PLUGIN_CUSTOM_INIT,_init
> ,
>    NULL));
>  }
> 
> --
> 2.12.0
> ___
> ModemManager-devel mailing list
> ModemManager-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

[PATCH] telit: support RS232 modems

[Aleksander Morgado]

Adding the vendor string match allows us to support RS232 devices in
the Telit plugin: the USB vendor id check may now be ignored and
instead we probe for the vendor string via AT commands, which works
even if the device is behind a USB<->RS232 adapter.

https://bugs.freedesktop.org/show_bug.cgi?id=100171
---

Hey hey,

This patch enables support for RS232 modems in the Telit plugin; this is, 
modems that are connected to a system via a RS232 port, or via a USB<->RS232 
adapter.

Comments?

---
 plugins/telit/mm-plugin-telit.c | 14 --
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/plugins/telit/mm-plugin-telit.c b/plugins/telit/mm-plugin-telit.c
index caf3ef01..ec3c024f 100644
--- a/plugins/telit/mm-plugin-telit.c
+++ b/plugins/telit/mm-plugin-telit.c
@@ -59,6 +59,7 @@ mm_plugin_create (void)
 static const gchar *subsystems[] = { "tty", NULL };
 /* Vendors: Telit */
 static const guint16 vendor_ids[] = { 0x1bc7, 0 };
+static const gchar *vendor_strings[] = { "telit", NULL };
 /* Only handle TELIT tagged devices here. */
 static const gchar *udev_tags[] = {
 "ID_MM_TELIT_TAGGED",
@@ -72,12 +73,13 @@ mm_plugin_create (void)

 return MM_PLUGIN (
 g_object_new (MM_TYPE_PLUGIN_TELIT,
-  MM_PLUGIN_NAME,   "Telit",
-  MM_PLUGIN_ALLOWED_SUBSYSTEMS, subsystems,
-  MM_PLUGIN_ALLOWED_VENDOR_IDS, vendor_ids,
-  MM_PLUGIN_ALLOWED_AT, TRUE,
-  MM_PLUGIN_ALLOWED_UDEV_TAGS,  udev_tags,
-  MM_PLUGIN_CUSTOM_INIT,_init,
+  MM_PLUGIN_NAME,   "Telit",
+  MM_PLUGIN_ALLOWED_SUBSYSTEMS, subsystems,
+  MM_PLUGIN_ALLOWED_VENDOR_IDS, vendor_ids,
+  MM_PLUGIN_ALLOWED_VENDOR_STRINGS, vendor_strings,
+  MM_PLUGIN_ALLOWED_AT, TRUE,
+  MM_PLUGIN_ALLOWED_UDEV_TAGS,  udev_tags,
+  MM_PLUGIN_CUSTOM_INIT,_init,
   NULL));
 }

--
2.12.0
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel