Re: [PATCH v3] brcmfmac: add missing header dependencies

[Arnd Bergmann]

On Monday, August 29, 2016 4:14:45 PM CEST Baoyou Xie wrote:
> We get 1 warning when biuld kernel with W=1:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: 
> no previous prototype for '__brcmf_err' [-Wmissing-prototypes]
> 
> In fact, this function is declared in brcmfmac/debug.h, so this patch
> add missing header dependencies.
> 
> Signed-off-by: Baoyou Xie 

Acked-by: Arnd Bergmann 

Re: [net-next PATCH] e1000: add initial XDP support

[Jesper Dangaard Brouer]

On Sun, 28 Aug 2016 08:23:26 -0400
Jamal Hadi Salim  wrote:

> On 16-08-27 03:11 AM, John Fastabend wrote:
> > From: Alexei Starovoitov 
> >
> > This patch adds initial support for XDP on e1000 driver. Note e1000
> > driver does not support page recycling in general which could be
> > added as a further improvement. However for XDP_DROP and XDP_XMIT
> > the xdp code paths will recycle pages.
> >
> > This patch includes the rcu_read_lock/rcu_read_unlock pair noted by
> > Brenden Blanco in another pending patch.
> >
> >   net/mlx4_en: protect ring->xdp_prog with rcu_read_lock  
> 
> Do you have any perf numbers of drops of this vs tc drop at ingress?

Hi Jamal,

Can you please provide a simple "tc" command that implements "tc drop"?

Then, I'll add this to the series of tests I'm using for (what I call)
"zoom-in" benchmarking.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer

[PATCH v3] brcmfmac: add missing header dependencies

[Baoyou Xie]

We get 1 warning when biuld kernel with W=1:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no 
previous prototype for '__brcmf_err' [-Wmissing-prototypes]

In fact, this function is declared in brcmfmac/debug.h, so this patch
add missing header dependencies.

Signed-off-by: Baoyou Xie 

---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c 
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
index a10f35c..fe67559 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
@@ -19,6 +19,7 @@
 #ifndef __CHECKER__
 #define CREATE_TRACE_POINTS
 #include "tracepoint.h"
+#include "debug.h"
 
 void __brcmf_err(const char *func, const char *fmt, ...)
 {
-- 
2.7.4

Re: [PATCH v2] fix:brcmfmac: add missing header dependencies

[Arend Van Spriel]

On 27-8-2016 8:08, Baoyou Xie wrote:
> We get 1 warning when biuld kernel with W=1:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: 
> no previous prototype for '__brcmf_err' [-Wmissing-
> prototypes]
> 
> In fact, this function is declared in brcmfmac/debug.h, so this patch
> add missing header dependencies

Thanks for this fix, but please remove the 'fix:' prefix in the subject
as it just noise.

Regards,
Arend

> Signed-off-by: Baoyou Xie 
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c 
> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> index a10f35c..fe67559 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> @@ -19,6 +19,7 @@
>  #ifndef __CHECKER__
>  #define CREATE_TRACE_POINTS
>  #include "tracepoint.h"
> +#include "debug.h"
>  
>  void __brcmf_err(const char *func, const char *fmt, ...)
>  {
> 

[ethtool PATCH v1 0/2] ethtool: add support for 1000BaseX and missing 10G link mode

[Vidya Sagar Ravipati]

From: Vidya Sagar Ravipati 

This patchset enhances ethtool link mode bitmap to include
missing interface modes for 1G/10G speeds

Vidya Sagar Ravipati (2):
  ethtool-copy.h:sync with net
  ethtool: add support for 1000BaseX and missing 10G link mode

 ethtool-copy.h | 11 +--
 ethtool.c  | 19 +++
 2 files changed, 28 insertions(+), 2 deletions(-)

-- 
2.1.4

[ethtool PATCH v1 1/2] ethtool-copy.h:sync with net

[Vidya Sagar Ravipati]

From: Vidya Sagar Ravipati 

This covers kernel changes upto:

commit 5711a98221443aec54c4c81ee98c6ae46acccb65
Author: Vidya Sagar Ravipati 
Date:   Fri Aug 26 01:25:50 2016 -0700

net: ethtool: add support for 1000BaseX and missing 10G link modes

This patch enhances ethtool link mode bitmap to include
missing interface modes for 1G/10G speeds

Changes:
1000baseX is the mode introduced to cover all 1G Fiber cases.
All modes under 1000BaseX i.e. 1000BASE-SX, 1000BASE-LX, 1000BASE-LX10
and 1000BASE-BX10 are not explicitly defined at this moment.
10G CR,SR,LR and ER link modes are included for 10G speed..

Issue:
ethtool on  1G/10G SFP port reports Base-T
as this port supports 1000baseX,10G CR, SR and LR modes.

root@tor-02$ ethtool swp1
Settings for swp1:
Supported ports: [ FIBRE ]
Supported link modes:   1000baseT/Full
1baseT/Full
Supported pause frame use: Symmetric Receive-only
Supports auto-negotiation: Yes
Advertised link modes:  1000baseT/Full
Advertised pause frame use: No
Advertised auto-negotiation: No
Speed: 1Mb/s
Duplex: Full
Port: FIBRE
PHYAD: 0
Transceiver: external
Auto-negotiation: off
Current message level: 0x (0)

Link detected: yes

   After fix:
root@tor-02$ ethtool swp1
Settings for swp1:
Supported ports: [ FIBRE ]
Supported link modes:   1000baseX/Full
1baseCR/Full
1baseSR/Full
1baseLR/Full
1baseER/Full
Supported pause frame use: Symmetric Receive-only
Supports auto-negotiation: Yes
Advertised link modes:  1000baseT/Full
Advertised pause frame use: No
Advertised auto-negotiation: No
Speed: 1Mb/s
Duplex: Full
Port: FIBRE
PHYAD: 0
Transceiver: external
Auto-negotiation: off
Current message level: 0x (0)
Link detected: yes

Signed-off-by: Vidya Sagar Ravipati 
Signed-off-by: David S. Miller 

Signed-off-by: Vidya Sagar Ravipati 
---
 ethtool-copy.h | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/ethtool-copy.h b/ethtool-copy.h
index 246f7b0..70748f5 100644
--- a/ethtool-copy.h
+++ b/ethtool-copy.h
@@ -1360,7 +1360,14 @@ enum ethtool_link_mode_bit_indices {
ETHTOOL_LINK_MODE_10baseSR4_Full_BIT= 37,
ETHTOOL_LINK_MODE_10baseCR4_Full_BIT= 38,
ETHTOOL_LINK_MODE_10baseLR4_ER4_Full_BIT= 39,
-   ETHTOOL_LINK_MODE_5baseSR2_Full_BIT = 40,
+   ETHTOOL_LINK_MODE_5baseSR2_Full_BIT = 40,
+   ETHTOOL_LINK_MODE_1000baseX_Full_BIT= 41,
+   ETHTOOL_LINK_MODE_1baseCR_Full_BIT  = 42,
+   ETHTOOL_LINK_MODE_1baseSR_Full_BIT  = 43,
+   ETHTOOL_LINK_MODE_1baseLR_Full_BIT  = 44,
+   ETHTOOL_LINK_MODE_1baseLRM_Full_BIT = 45,
+   ETHTOOL_LINK_MODE_1baseER_Full_BIT  = 46,
+
 
/* Last allowed bit for __ETHTOOL_LINK_MODE_LEGACY_MASK is bit
 * 31. Please do NOT define any SUPPORTED_* or ADVERTISED_*
@@ -1369,7 +1376,7 @@ enum ethtool_link_mode_bit_indices {
 */
 
__ETHTOOL_LINK_MODE_LAST
- = ETHTOOL_LINK_MODE_5baseSR2_Full_BIT,
+ = ETHTOOL_LINK_MODE_1baseER_Full_BIT,
 };
 
 #define __ETHTOOL_LINK_MODE_LEGACY_MASK(base_name) \
-- 
2.1.4

[ethtool PATCH v1 2/2] ethtool: add support for 1000BaseX and missing 10G link mode

[Vidya Sagar Ravipati]

From: Vidya Sagar Ravipati 

This patch enhances ethtool link mode bitmap to include
missing interface modes for 1G/10G speeds

Changes:
a) 1000baseX is the mode introduced to cover all 1G Fiber cases.
All modes under 1000BaseX i.e. 1000BASE-SX, 1000BASE-LX, 1000BASE-LX10
and 1000BASE-BX10 are not explicitly defined at this moment.
10G CR,SR,LR and ER link modes are included for 10G speed..
b) Update description regarding QSFP+/QSFP28 support

Issue:
ethtool on  1G/10G SFP port reports Base-T
as this port supports 1000baseX,10G CR, SR and LR modes.

root@tor-02$ ethtool swp1
Settings for swp1:
Supported ports: [ FIBRE ]
Supported link modes:   1000baseT/Full
1baseT/Full
Supported pause frame use: Symmetric Receive-only
Supports auto-negotiation: Yes
Advertised link modes:  1000baseT/Full
Advertised pause frame use: No
Advertised auto-negotiation: No
Speed: 1Mb/s
Duplex: Full
Port: FIBRE
PHYAD: 0
Transceiver: external
Auto-negotiation: off
Current message level: 0x (0)

Link detected: yes

After fix:
root@tor-02$ ethtool swp1
Settings for swp1:
Supported ports: [ FIBRE ]
Supported link modes:   1000baseX/Full
1baseCR/Full
1baseSR/Full
1baseLR/Full
1baseER/Full
Supported pause frame use: Symmetric Receive-only
Supports auto-negotiation: Yes
Advertised link modes:  1000baseX/Full
Advertised pause frame use: No
Advertised auto-negotiation: No
Speed: 1Mb/s
Duplex: Full
Port: FIBRE
PHYAD: 0
Transceiver: external
Auto-negotiation: off
Current message level: 0x (0)
Link detected: yes

Signed-off-by: Vidya Sagar Ravipati 
---
 ethtool.c | 19 +++
 1 file changed, 19 insertions(+)

diff --git a/ethtool.c b/ethtool.c
index ab58c7f..6287b55 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -23,6 +23,7 @@
  * vmxnet3 support by Shrikrishna Khare 
  * Various features by Ben Hutchings ;
  * Copyright 2008-2010, 2013-2016 Ben Hutchings
+ * QSFP+/QSFP28 DOM support by Vidya Sagar Ravipati 
  *
  * TODO:
  *   * show settings for all devices
@@ -522,6 +523,12 @@ static void init_global_link_mode_masks(void)
ETHTOOL_LINK_MODE_10baseCR4_Full_BIT,
ETHTOOL_LINK_MODE_10baseLR4_ER4_Full_BIT,
ETHTOOL_LINK_MODE_5baseSR2_Full_BIT,
+   ETHTOOL_LINK_MODE_1000baseX_Full_BIT,
+   ETHTOOL_LINK_MODE_1baseCR_Full_BIT,
+   ETHTOOL_LINK_MODE_1baseSR_Full_BIT,
+   ETHTOOL_LINK_MODE_1baseLR_Full_BIT,
+   ETHTOOL_LINK_MODE_1baseLRM_Full_BIT,
+   ETHTOOL_LINK_MODE_1baseER_Full_BIT,
};
static const enum ethtool_link_mode_bit_indices
additional_advertised_flags_bits[] = {
@@ -662,6 +669,18 @@ static void dump_link_caps(const char *prefix, const char 
*an_prefix,
  "10baseLR4_ER4/Full" },
{ 0, ETHTOOL_LINK_MODE_5baseSR2_Full_BIT,
  "5baseSR2/Full" },
+   { 0, ETHTOOL_LINK_MODE_1000baseX_Full_BIT,
+ "1000baseX/Full" },
+   { 0, ETHTOOL_LINK_MODE_1baseCR_Full_BIT,
+ "1baseCR/Full" },
+   { 0, ETHTOOL_LINK_MODE_1baseSR_Full_BIT,
+ "1baseSR/Full" },
+   { 0, ETHTOOL_LINK_MODE_1baseLR_Full_BIT,
+ "1baseLR/Full" },
+   { 0, ETHTOOL_LINK_MODE_1baseLRM_Full_BIT,
+ "1baseLRM/Full" },
+   { 0, ETHTOOL_LINK_MODE_1baseER_Full_BIT,
+ "1baseER/Full" },
};
int indent;
int did1, new_line_pend, i;
-- 
2.1.4

Have the fix for softirq landed???

[Jesper Dangaard Brouer]

Hi Eric and Paolo,

Back in May you discovered (IMHO) a serious bug in softirq.  It even got
covered by LWN.net[1]. I've looked at the most recent git tree (linus
and net-next), and cannot see any changes that fixes this.
What is the progress in this area?

LWN.net: "Threadable NAPI polling, softirqs, and proper fixes"
 [1] http://lwn.net/Articles/687617/

Eric's proposed fix: http://lwn.net/Articles/687631/

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer

Re: [PATCH net iproute2] devlink: Add e-switch support

[Jiri Pirko]

Sun, Aug 28, 2016 at 03:35:21PM CEST, ogerl...@mellanox.com wrote:
>Implement kernel devlink e-switch interface. Currently we allow
>to get and set the device e-switch mode.
>
>Signed-off-by: Or Gerlitz 
>Signed-off-by: Roi Dayan 

Acked-by: Jiri Pirko