Re: [PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID
From: Matthias Schiffer Date: Thu, 23 Feb 2017 17:19:41 +0100 > The incorrect check caused an off-by-one error: the maximum VID 0xff > was unusable. > > Fixes: d342894c5d2f ("vxlan: virtual extensible lan") > Signed-off-by: Matthias Schiffer Applied and queued up for -stable, thanks.
Re: [PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID
On Thu, 23 Feb 2017 17:19:41 +0100, Matthias Schiffer wrote: > The incorrect check caused an off-by-one error: the maximum VID 0xff > was unusable. > > Fixes: d342894c5d2f ("vxlan: virtual extensible lan") > Signed-off-by: Matthias Schiffer > --- > v2: check against VXLAN_N_VID instead of changing operator Acked-by: Jiri Benc Thanks! Jiri
[PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID
The incorrect check caused an off-by-one error: the maximum VID 0xff was unusable. Fixes: d342894c5d2f ("vxlan: virtual extensible lan") Signed-off-by: Matthias Schiffer --- v2: check against VXLAN_N_VID instead of changing operator drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 556953f53437..268c2a12e61d 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -2675,7 +2675,7 @@ static int vxlan_validate(struct nlattr *tb[], struct nlattr *data[]) if (data[IFLA_VXLAN_ID]) { __u32 id = nla_get_u32(data[IFLA_VXLAN_ID]); - if (id >= VXLAN_VID_MASK) + if (id >= VXLAN_N_VID) return -ERANGE; } -- 2.11.1