[iproute RFC PATCH 0/9] Document tc filters

2015-10-23 Thread Phil Sutter 
This series adds documentation in form of a dedicated man page for every
available tc filter with the exception of rsvp which I simply didn't
understand. In addition to that, it adds a list of filters with (very) basic
description to tc.8, listing the specific man pages for detailed information.

I am not too confident of correctness in every aspect, therefore this series is
tagged RFC and the relevant patches are Cc'ed to the filter authors in hope for
review and harsh criticism in form of corrections. :)

Alexey or anyone else with knowledge of rsvp, you could make me very happy by
explaining to me how that filter is supposed to work. In turn I could serve you
with stupid^Wunqualified questions and ultimately tc-rsvp.8 which you would
then have to proof-read as well.

Phil Sutter (9):
  tc: add a man page for basic filter
  tc: add a man page for cgroup filter
  tc: add a man page for flow filter
  tc: add a man page for flower filter
  tc: add a man page for fw filter
  tc: add a man page for route filter
  tc: add a man page for tcindex filter
  tc: add a man page for u32 filter
  tc: ship filter man pages and refer to them in tc.8

 man/man8/Makefile |   4 +-
 man/man8/tc-basic.8   |  34 +++
 man/man8/tc-cgroup.8  |  80 ++
 man/man8/tc-flow.8| 265 
 man/man8/tc-flower.8  | 113 +
 man/man8/tc-fw.8  |  66 +
 man/man8/tc-route.8   |  74 ++
 man/man8/tc-tcindex.8 |  58 +
 man/man8/tc-u32.8 | 663 ++
 man/man8/tc.8 |  52 
 10 files changed, 1408 insertions(+), 1 deletion(-)
 create mode 100644 man/man8/tc-basic.8
 create mode 100644 man/man8/tc-cgroup.8
 create mode 100644 man/man8/tc-flow.8
 create mode 100644 man/man8/tc-flower.8
 create mode 100644 man/man8/tc-fw.8
 create mode 100644 man/man8/tc-route.8
 create mode 100644 man/man8/tc-tcindex.8
 create mode 100644 man/man8/tc-u32.8

-- 
2.1.2

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [iproute RFC PATCH 0/9] Document tc filters

2015-10-23 Thread Thomas Graf 
On 10/23/15 at 07:47pm, Phil Sutter wrote:
>  man/man8/Makefile |   4 +-
>  man/man8/tc-basic.8   |  34 +++
>  man/man8/tc-cgroup.8  |  80 ++
>  man/man8/tc-flow.8| 265 
>  man/man8/tc-flower.8  | 113 +
>  man/man8/tc-fw.8  |  66 +
>  man/man8/tc-route.8   |  74 ++
>  man/man8/tc-tcindex.8 |  58 +
>  man/man8/tc-u32.8 | 663 
> ++

This basically says everything regarding the usability of u32 ;-)

Joke aside, thanks so much for doing this work. This is wonderful.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [iproute RFC PATCH 0/9] Document tc filters

2015-10-23 Thread Stephen Hemminger 
On Fri, 23 Oct 2015 19:47:07 +0200
Phil Sutter  wrote:

> This series adds documentation in form of a dedicated man page for every
> available tc filter with the exception of rsvp which I simply didn't
> understand. In addition to that, it adds a list of filters with (very) basic
> description to tc.8, listing the specific man pages for detailed information.
> 
> I am not too confident of correctness in every aspect, therefore this series 
> is
> tagged RFC and the relevant patches are Cc'ed to the filter authors in hope 
> for
> review and harsh criticism in form of corrections. :)
> 
> Alexey or anyone else with knowledge of rsvp, you could make me very happy by
> explaining to me how that filter is supposed to work. In turn I could serve 
> you
> with stupid^Wunqualified questions and ultimately tc-rsvp.8 which you would
> then have to proof-read as well.
> 
> Phil Sutter (9):
>   tc: add a man page for basic filter
>   tc: add a man page for cgroup filter
>   tc: add a man page for flow filter
>   tc: add a man page for flower filter
>   tc: add a man page for fw filter
>   tc: add a man page for route filter
>   tc: add a man page for tcindex filter
>   tc: add a man page for u32 filter
>   tc: ship filter man pages and refer to them in tc.8
> 
>  man/man8/Makefile |   4 +-
>  man/man8/tc-basic.8   |  34 +++
>  man/man8/tc-cgroup.8  |  80 ++
>  man/man8/tc-flow.8| 265 
>  man/man8/tc-flower.8  | 113 +
>  man/man8/tc-fw.8  |  66 +
>  man/man8/tc-route.8   |  74 ++
>  man/man8/tc-tcindex.8 |  58 +
>  man/man8/tc-u32.8 | 663 
> ++
>  man/man8/tc.8 |  52 
>  10 files changed, 1408 insertions(+), 1 deletion(-)
>  create mode 100644 man/man8/tc-basic.8
>  create mode 100644 man/man8/tc-cgroup.8
>  create mode 100644 man/man8/tc-flow.8
>  create mode 100644 man/man8/tc-flower.8
>  create mode 100644 man/man8/tc-fw.8
>  create mode 100644 man/man8/tc-route.8
>  create mode 100644 man/man8/tc-tcindex.8
>  create mode 100644 man/man8/tc-u32.8
> 

Looks good applied.
Had to one minor whitespace cleanup.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [iproute RFC PATCH 0/9] Document tc filters

2015-10-23 Thread Phil Sutter 
On Fri, Oct 23, 2015 at 10:13:02PM +0200, Thomas Graf wrote:
> On 10/23/15 at 07:47pm, Phil Sutter wrote:
> >  man/man8/Makefile |   4 +-
> >  man/man8/tc-basic.8   |  34 +++
> >  man/man8/tc-cgroup.8  |  80 ++
> >  man/man8/tc-flow.8| 265 
> >  man/man8/tc-flower.8  | 113 +
> >  man/man8/tc-fw.8  |  66 +
> >  man/man8/tc-route.8   |  74 ++
> >  man/man8/tc-tcindex.8 |  58 +
> >  man/man8/tc-u32.8 | 663 
> > ++
> 
> This basically says everything regarding the usability of u32 ;-)

Quoting myself:

> Due to breaking everything down to values, masks and offsets, It is   
>  
> equally powerful and hard to use.

When I wrote that, I still had little idea of nexthdr+ and hash table
giblets. And even after digging through the code for quite some time,
I'm sure I don't.

> Joke aside, thanks so much for doing this work. This is wonderful.

Thanks a lot. I'm not entirely sure though the amount of correct
information prevails the factual errors. :)

Cheers, Phil
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html