Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Murtadha Hubail has submitted this change and it was merged. Change subject: [NO ISSUE][API] Remove Legacy APIs .. [NO ISSUE][API] Remove Legacy APIs - user model changes: no - storage format changes: no - interface changes: no Details: - Incremental progress towards removing all legacy APIs and replacing them by the query service. - Use /query/aql to execute AQL tests. - Adjust AQL test cases results to query/aql output. Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2554 Sonar-Qube: Jenkins Tested-by: Jenkins Contrib: Jenkins Integration-Tests: Jenkins Reviewed-by: Michael Blow --- D asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DdlApiServlet.java D asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/FullApiServlet.java D asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryApiServlet.java D asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/UpdateApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java M asterixdb/asterix-app/src/test/resources/metadata/testsuite.xml R asterixdb/asterix-app/src/test/resources/runtimets/queries/flwor/at00/at00.5.get.uri R asterixdb/asterix-app/src/test/resources/runtimets/queries/flwor/at00/at00.7.pollget.uri D asterixdb/asterix-app/src/test/resources/runtimets/queries/flwor/at00/at00.8.get.http C asterixdb/asterix-app/src/test/resources/runtimets/queries/flwor/at00/at00.8.get.uri M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java M asterixdb/asterix-server/pom.xml M asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/SampleLocalClusterIT.java 15 files changed, 107 insertions(+), 447 deletions(-) Approvals: Anon. E. Moose #1000171: Jenkins: Verified; No violations found; ; Verified Michael Blow: Looks good to me, approved diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DdlApiServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DdlApiServlet.java deleted file mode 100644 index 4c1dbf7..000 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DdlApiServlet.java +++ /dev/null @@ -1,55 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ -package org.apache.asterix.api.http.server; - -import java.util.concurrent.ConcurrentMap; - -import org.apache.asterix.common.context.IStorageComponentProvider; -import org.apache.asterix.common.dataflow.ICcApplicationContext; -import org.apache.asterix.compiler.provider.ILangCompilationProvider; -import org.apache.asterix.lang.common.base.Statement; -import org.apache.asterix.translator.IStatementExecutorFactory; -import org.apache.hyracks.http.api.IServletRequest; - -public class DdlApiServlet extends RestApiServlet { -private static final byte ALLOWED_CATEGORIES = -Statement.Category.QUERY | Statement.Category.UPDATE | Statement.Category.DDL; - -public DdlApiServlet(ConcurrentMap ctx, String[] paths, ICcApplicationContext appCtx, -ILangCompilationProvider compilationProvider, IStatementExecutorFactory statementExecutorFactory, -IStorageComponentProvider componentProvider) { -super(ctx, paths, appCtx, compilationProvider, statementExecutorFactory, componentProvider); -} - -@Override -protected String getQueryParameter(IServletRequest request) { -return request.getParameter("ddl"); -} - -@Override -protected byte getAllowedCategories() { -return ALLOWED_CATEGORIES; -} - -@Override -protected String getErrorMessage() { -return "Invalid statement: Non-DDL statement %s to the DDL API."; -} - -} diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/FullApiServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6135/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3004/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/r6U3Gr : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3004/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Analytics Compatibility Compilation Successful https://goo.gl/Axx5qZ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6135/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3685/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3965/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3707/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3166/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3213/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3254/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3240/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3469/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3785/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8717/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7203/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2554 to look at the new patch set (#4). Change subject: [NO ISSUE][API] Remove Legacy APIs .. [NO ISSUE][API] Remove Legacy APIs - user model changes: no - storage format changes: no - interface changes: no Details: - Incremental progress towards removing all legacy APIs and replacing them by the query service. - Use /query/aql to execute AQL tests. - Adjust AQL test cases results to query/aql output. Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 --- D asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DdlApiServlet.java D asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/FullApiServlet.java D asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryApiServlet.java D asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/UpdateApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java M asterixdb/asterix-app/src/test/resources/metadata/testsuite.xml R asterixdb/asterix-app/src/test/resources/runtimets/queries/flwor/at00/at00.5.get.uri R asterixdb/asterix-app/src/test/resources/runtimets/queries/flwor/at00/at00.7.pollget.uri D asterixdb/asterix-app/src/test/resources/runtimets/queries/flwor/at00/at00.8.get.http C asterixdb/asterix-app/src/test/resources/runtimets/queries/flwor/at00/at00.8.get.uri M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java M asterixdb/asterix-server/pom.xml M asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/SampleLocalClusterIT.java 15 files changed, 107 insertions(+), 447 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/54/2554/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE][API] Remove Legacy APIs
Jenkins has posted comments on this change. Change subject: [NO ISSUE][API] Remove Legacy APIs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1261/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6bfb06236d2bc480adf22bf16d5cca6a8edc726 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No