Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
abdullah alamoudi has posted comments on this change.
Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/2563/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java:
Line 404: } catch (Throwable ignore) {
> we should log a warning in this case, and not swallow interrupt...
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/2563
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: abdullah alamoudi
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2563 to look at the new patch set (#2). Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. [NO ISSUE][RT] Use ThreadLocal date format to format dates - user model changes: no - storage format changes: no - interface changes: no Details: - Instead of creating a new date format object for formatting trace logs, use a thread local instance. Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 --- M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java 1 file changed, 27 insertions(+), 12 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/63/2563/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3743/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3202/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1297/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3721/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7236/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3821/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3290/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3276/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8753/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3505/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4003/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3249/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
abdullah alamoudi has posted comments on this change.
Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/2563/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java:
Line 404: } catch (Throwable ignore) {
> Done
And can't be InterruptedException
--
To view, visit https://asterix-gerrit.ics.uci.edu/2563
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: abdullah alamoudi
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6168/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/reKBTt : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3203/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3291/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3722/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2570
Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery
..
[NOISSUE][ING] Leave permanently failed actives during recovery
Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
1 file changed, 1 insertion(+), 10 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/70/2570/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
index e8bcb10..053e6cd 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
@@ -25,7 +25,6 @@
import org.apache.asterix.active.ActiveEvent;
import org.apache.asterix.active.ActiveEvent.Kind;
-import org.apache.asterix.active.ActivityState;
import org.apache.asterix.active.EntityId;
import org.apache.asterix.active.IActiveEntityEventsListener;
import org.apache.asterix.active.IActiveNotificationHandler;
@@ -33,7 +32,6 @@
import org.apache.asterix.common.api.IMetadataLockManager;
import org.apache.asterix.common.exceptions.ErrorCode;
import org.apache.asterix.common.exceptions.RuntimeDataException;
-import org.apache.asterix.metadata.api.IActiveEntityController;
import org.apache.asterix.metadata.declared.MetadataProvider;
import org.apache.asterix.metadata.entities.Dataset;
import org.apache.asterix.metadata.utils.DatasetUtil;
@@ -214,14 +212,7 @@
for (IActiveEntityEventsListener listener :
entityEventListeners.values()) {
synchronized (listener) {
LOGGER.log(level, "Entity " + listener.getEntityId() + " is "
+ listener.getStats());
-if (listener.getState() == ActivityState.PERMANENTLY_FAILED
-&& listener instanceof IActiveEntityController) {
-LOGGER.log(level, "Recovering");
-((IActiveEntityController) listener).recover();
-} else {
-LOGGER.log(level, "Only notifying");
-listener.notifyAll();
-}
+listener.notifyAll();
}
}
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2570
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1298/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4004/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8754/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3250/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3822/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3277/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3506/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][ING] Leave permanently failed actives during reco...
abdullah alamoudi has abandoned this change. Change subject: [NO ISSUE][ING] Leave permanently failed actives during recovery .. Abandoned moved to https://asterix-gerrit.ics.uci.edu/#/c/2570/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2557 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic77d42dee815ec3d692eae669526be130d2a4ed8 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7237/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/QSw2NL : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3744/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6169/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3029/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/3qoFub : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/ar139c : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3029/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3030/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3030/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6168/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Jenkins has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6169/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
[jira] [Created] (ASTERIXDB-2355) Incorrect error reporting by SQL++ parser
Dmitry Lychagin created ASTERIXDB-2355: -- Summary: Incorrect error reporting by SQL++ parser Key: ASTERIXDB-2355 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2355 Project: Apache AsterixDB Issue Type: Bug Components: SQL - Translator SQL++ Reporter: Dmitry Lychagin Assignee: Dmitry Lychagin Syntax errors are not always correctly reported by the SQL++ parser. For example, invalid query: %%% Reported error message: Flags = '<' In some other cases, the reported message is Conversion = ''' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
Murtadha Hubail has posted comments on this change. Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2570 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NOISSUE][ING] Leave permanently failed actives during recovery
abdullah alamoudi has submitted this change and it was merged.
Change subject: [NOISSUE][ING] Leave permanently failed actives during recovery
..
[NOISSUE][ING] Leave permanently failed actives during recovery
Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2570
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Murtadha Hubail
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
1 file changed, 1 insertion(+), 10 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Jenkins: Verified; No violations found; ; Verified
Murtadha Hubail: Looks good to me, approved
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
index e8bcb10..053e6cd 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
@@ -25,7 +25,6 @@
import org.apache.asterix.active.ActiveEvent;
import org.apache.asterix.active.ActiveEvent.Kind;
-import org.apache.asterix.active.ActivityState;
import org.apache.asterix.active.EntityId;
import org.apache.asterix.active.IActiveEntityEventsListener;
import org.apache.asterix.active.IActiveNotificationHandler;
@@ -33,7 +32,6 @@
import org.apache.asterix.common.api.IMetadataLockManager;
import org.apache.asterix.common.exceptions.ErrorCode;
import org.apache.asterix.common.exceptions.RuntimeDataException;
-import org.apache.asterix.metadata.api.IActiveEntityController;
import org.apache.asterix.metadata.declared.MetadataProvider;
import org.apache.asterix.metadata.entities.Dataset;
import org.apache.asterix.metadata.utils.DatasetUtil;
@@ -214,14 +212,7 @@
for (IActiveEntityEventsListener listener :
entityEventListeners.values()) {
synchronized (listener) {
LOGGER.log(level, "Entity " + listener.getEntityId() + " is "
+ listener.getStats());
-if (listener.getState() == ActivityState.PERMANENTLY_FAILED
-&& listener instanceof IActiveEntityController) {
-LOGGER.log(level, "Recovering");
-((IActiveEntityController) listener).recover();
-} else {
-LOGGER.log(level, "Only notifying");
-listener.notifyAll();
-}
+listener.notifyAll();
}
}
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2570
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cbeae666b1e5d5a9b29a33bac141d60244283ab
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: abdullah alamoudi
[jira] [Created] (ASTERIXDB-2356) Syntax error when parsing CASE expression
Dmitry Lychagin created ASTERIXDB-2356: -- Summary: Syntax error when parsing CASE expression Key: ASTERIXDB-2356 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2356 Project: Apache AsterixDB Issue Type: Bug Components: SQL - Translator SQL++ Reporter: Dmitry Lychagin Assignee: Dmitry Lychagin The following query fails with syntax error SELECT CASE WHEN get_year(current_date()) > 0 THEN "abc" ELSE "def" END LIKE "a%" as v1 The workaround is to put parentheses around CASE expression: (CASE ...) LIKE ... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Dmitry Lychagin has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2571
Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
..
[ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Move CASE expression from Expression production to PrimaryExpr
Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a
---
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/case_08/case_08.1.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/misc/case_08/case_08.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
4 files changed, 31 insertions(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/71/2571/1
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/case_08/case_08.1.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/case_08/case_08.1.query.sqlpp
new file mode 100644
index 000..60229d5
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/case_08/case_08.1.query.sqlpp
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+SELECT
+ CASE WHEN get_year(current_date()) > 0 THEN "abc" ELSE "def" END LIKE "a%"
as v1,
+ ( CASE WHEN get_year(current_date()) > 0 THEN "abc" ELSE "def" END ) LIKE
"a%" as v2,
+ [ CASE WHEN get_year(current_date()) > 0 THEN "abc" ELSE "def" END LIKE "a%"
] as v3
+
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/results/misc/case_08/case_08.1.adm
b/asterixdb/asterix-app/src/test/resources/runtimets/results/misc/case_08/case_08.1.adm
new file mode 100644
index 000..8b095a8
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/results/misc/case_08/case_08.1.adm
@@ -0,0 +1 @@
+{ "v1": true, "v2": true, "v3": [ true ] }
\ No newline at end of file
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index 05382bc..b700df0 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -3599,6 +3599,11 @@
+
+case_08
+
+
+
dataset_nodegroup
diff --git a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
index 9af114b..e1f6f6a 100644
--- a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
+++ b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
@@ -1789,7 +1789,6 @@
(
LOOKAHEAD(2)
expr = OperatorExpr()
-| expr = CaseExpr()
| expr = QuantifiedExpression()
)
{
@@ -2305,6 +2304,7 @@
{
( LOOKAHEAD(4)
expr = FunctionCallExpr()
+ | expr = CaseExpr()
| expr = Literal()
| expr = VariableRef()
| expr = ListConstructor()
--
To view, visit https://asterix-gerrit.ics.uci.edu/2571
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3251/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3278/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3745/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3723/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8755/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1299/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7238/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3823/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3507/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3204/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3292/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4005/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6170/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3205/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3279/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3824/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8756/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3252/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7239/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Dmitry Lychagin has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2572
Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
..
[ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Fixes incorrect error reporting by SQL++ parser.
Error messages like: “Flags=“, “Conversion=“
Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84
---
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-2355/query-ASTERIXDB-2355.1.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
5 files changed, 36 insertions(+), 6 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/72/2572/1
diff --git
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java
index 890667a..a356d23 100644
---
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java
+++
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java
@@ -171,14 +171,14 @@
return IOUtils.toInputStream(resultBuilder.toString(),
StandardCharsets.UTF_8);
}
-private static void checkForErrors(ObjectNode result) throws
AsterixException {
+private static void checkForErrors(ObjectNode result) throws Exception {
final JsonNode errorsField =
result.get(ResultField.ERRORS.getFieldName());
if (errorsField != null) {
final JsonNode errors = errorsField.get(0).get("msg");
if
(!result.get(ResultField.METRICS.getFieldName()).has("errorCount")) {
-throw new AsterixException("Request reported error but not an
errorCount");
+throw new Exception("Request reported error but not an
errorCount");
}
-throw new AsterixException(errors.asText());
+throw new Exception(errors.asText());
}
}
}
\ No newline at end of file
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-2355/query-ASTERIXDB-2355.1.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-2355/query-ASTERIXDB-2355.1.query.sqlpp
new file mode 100644
index 000..68d7f4a
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-2355/query-ASTERIXDB-2355.1.query.sqlpp
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/* Invalid syntax */
+
+ %%%
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index 1b49358..3b1363c 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -1895,7 +1895,7 @@
load-with-autogenerated-no-field
-org.apache.asterix.common.exceptions.AsterixException:
ASX1014: Field "not_id" is not found
+ASX1014: Field "not_id" is not found
@@ -3715,6 +3715,12 @@
+
+none
+
+
+
+
none
Query parameter compiler.joinmem is not
supported
diff --git
a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
index 92aac98..175f144 100644
--- a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
+++ b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
@@ -74,6 +74,7 @@
200 = External UDF cannot produce expected result. Please check the UDF
configuration
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4006/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1300/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3724/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3508/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/YJ3k5m : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/vhrdJQ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3293/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3746/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6171/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3031/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/friQfr : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/b9TfhP : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3031/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2563 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6170/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2571 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6171/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4007/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3825/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3253/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3509/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1301/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3747/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7240/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3725/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3294/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3280/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2572 to look at the new patch set (#2). Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser - user model changes: no - storage format changes: no - interface changes: no Details: - Fixes incorrect error reporting by SQL++ parser. Error messages like: “Flags=“, “Conversion=“ Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 --- M asterixdb/asterix-app/src/test/java/org/apache/asterix/app/result/ResultPrinterTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-2355/query-ASTERIXDB-2355.1.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj 6 files changed, 37 insertions(+), 7 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/72/2572/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8757/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3206/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6172/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/quUotd : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Use ThreadLocal date format to format dates
abdullah alamoudi has submitted this change and it was merged.
Change subject: [NO ISSUE][RT] Use ThreadLocal date format to format dates
..
[NO ISSUE][RT] Use ThreadLocal date format to format dates
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Instead of creating a new date format object for formatting
trace logs, use a thread local instance.
Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2563
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Michael Blow
---
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
1 file changed, 27 insertions(+), 12 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Jenkins: Verified; No violations found; ; Verified
Michael Blow: Looks good to me, approved
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
index c767157..dba6760 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
@@ -21,6 +21,7 @@
import java.io.DataOutput;
import java.io.IOException;
import java.nio.ByteBuffer;
+import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.Date;
@@ -73,9 +74,14 @@
import org.apache.hyracks.util.trace.ITracer;
import org.apache.hyracks.util.trace.ITracer.Scope;
import org.apache.hyracks.util.trace.TraceUtils;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
public class LSMPrimaryUpsertOperatorNodePushable extends
LSMIndexInsertUpdateDeleteOperatorNodePushable {
+private static final Logger LOGGER = LogManager.getLogger();
+private static final ThreadLocal DATE_FORMAT =
+ThreadLocal.withInitial(() -> new
SimpleDateFormat("-MM-dd'T'HH:mm:ss.SSS"));
private final PermutingFrameTupleReference key;
private MultiComparator keySearchCmp;
private ArrayTupleBuilder missingTupleBuilder;
@@ -379,22 +385,31 @@
@Override
public void close() throws HyracksDataException {
+traceLastRecordIn();
+Throwable failure = CleanupUtils.close(frameOpCallback, null);
+failure = CleanupUtils.destroy(failure, cursor);
+failure = CleanupUtils.close(writer, failure);
+failure = CleanupUtils.close(indexHelper, failure);
+if (failure != null) {
+throw HyracksDataException.create(failure);
+}
+}
+
+@SuppressWarnings({ "squid:S1181", "squid:S1166" })
+private void traceLastRecordIn() {
try {
-Throwable failure = CleanupUtils.close(frameOpCallback, null);
-failure = CleanupUtils.destroy(failure, cursor);
-failure = CleanupUtils.close(writer, failure);
-failure = CleanupUtils.close(indexHelper, failure);
-if (failure != null) {
-throw HyracksDataException.create(failure);
-}
-} finally {
-if (tracer.isEnabled(traceCategory) && lastRecordInTimeStamp > 0) {
+if (tracer.isEnabled(traceCategory) && lastRecordInTimeStamp > 0
&& indexHelper != null
+&& indexHelper.getIndexInstance() != null) {
tracer.instant("UpsertClose", traceCategory, Scope.t,
-"{\"last-record-in\":\""
-+ new
SimpleDateFormat("-MM-dd'T'HH:mm:ss.SSS")
-.format(new
Date(lastRecordInTimeStamp))
+"{\"last-record-in\":\"" +
DATE_FORMAT.get().format(new Date(lastRecordInTimeStamp))
+ "\", \"index\":" +
indexHelper.getIndexInstance().toString() + "}");
}
+} catch (Throwable traceFailure) {
+try {
+LOGGER.warn("Tracing last record in failed", traceFailure);
+} catch (Throwable ignore) {
+// Ignore logging failure
+}
}
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2563
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I361542815af7c93291fd6251d9b335c2eb01af56
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: abdullah alamoudi
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3281/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
