[jira] [Created] (NPANDAY-610) ArtifactType as an optional configuration argument
David Akehurst created NPANDAY-610: -- Summary: ArtifactType as an optional configuration argument Key: NPANDAY-610 URL: https://issues.apache.org/jira/browse/NPANDAY-610 Project: NPanday Issue Type: Improvement Components: Maven Plugins Affects Versions: 1.5.0-incubating Reporter: David Akehurst For one of my uses of npanday I need to be able to define the artifactType using a configuration argument. (I.e. it is not defined by the package type of the pom). I have implemented this, and attached an svn diff of the trunk to this ticket. Could we get it into the 1.5.0 release please. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (NPANDAY-610) ArtifactType as an optional configuration argument
[
https://issues.apache.org/jira/browse/NPANDAY-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915578#comment-13915578
]
David Akehurst commented on NPANDAY-610:
===
---
plugins/maven-compile-plugin/src/main/java/npanday/plugin/compile/AbstractCompilerMojo.java
(revision 1572877)
+++
plugins/maven-compile-plugin/src/main/java/npanday/plugin/compile/AbstractCompilerMojo.java
(working copy)
@@ -798,6 +798,14 @@
*/
+/**
+ * artifactType
+ *
+ * @parameter expression = ${artifactType}
+ */
+protected String artifactType;
+
+
public void execute() throws MojoExecutionException
{
SettingsUtil.applyCustomSettings( getLog(), repositoryRegistry,
settingsPath );
Index:
plugins/maven-compile-plugin/src/main/java/npanday/plugin/compile/CompilerMojo.java
===
---
plugins/maven-compile-plugin/src/main/java/npanday/plugin/compile/CompilerMojo.java
(revision 1572877)
+++
plugins/maven-compile-plugin/src/main/java/npanday/plugin/compile/CompilerMojo.java
(working copy)
@@ -104,7 +104,8 @@
compilerConfig.setCommands( getParameters() );
-String artifactTypeName = project.getArtifact().getType();
+
+String artifactTypeName =
(null!=artifactType)?artifactType:project.getArtifact().getType();
ArtifactType artifactType =
ArtifactType.getArtifactTypeForPackagingName( artifactTypeName );
if ( artifactType.equals( ArtifactType.NULL ) )
{
ArtifactType as an optional configuration argument
--
Key: NPANDAY-610
URL: https://issues.apache.org/jira/browse/NPANDAY-610
Project: NPanday
Issue Type: Improvement
Components: Maven Plugins
Affects Versions: 1.5.0-incubating
Reporter: David Akehurst
For one of my uses of npanday I need to be able to define the artifactType
using a configuration argument. (I.e. it is not defined by the package type
of the pom).
I have implemented this, and attached an svn diff of the trunk to this ticket.
Could we get it into the 1.5.0 release please.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Created] (NPANDAY-611) Linux build of plugins broken by \ in tests
David Akehurst created NPANDAY-611: -- Summary: Linux build of plugins broken by \ in tests Key: NPANDAY-611 URL: https://issues.apache.org/jira/browse/NPANDAY-611 Project: NPanday Issue Type: Bug Components: Maven Plugins Affects Versions: 1.5.0-incubating Reporter: David Akehurst Building the maven plugins on linux breaks when compiling the tests because of a few backslashes in the tests. not been able to test this on windows, but the attached comment of svn diff fixes it for linux. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (NPANDAY-611) Linux build of plugins broken by \ in tests
[
https://issues.apache.org/jira/browse/NPANDAY-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915584#comment-13915584
]
David Akehurst commented on NPANDAY-611:
Index:
components/dotnet-executable/src/test/groovy/npanday/executable/execution/CommandExecutorTest.groovy
===
---
components/dotnet-executable/src/test/groovy/npanday/executable/execution/CommandExecutorTest.groovy
(revision 1572887)
+++
components/dotnet-executable/src/test/groovy/npanday/executable/execution/CommandExecutorTest.groovy
(working copy)
@@ -89,14 +89,14 @@
public void testCommandArgWithSpaces()
throws ExecutionException
{
-testArgExpansion([a b], 'a b\');
+testArgExpansion([a b], 'a b');
}
@Test
public void testCommandArgWithEmbeddedSingleQuotes_middle()
throws ExecutionException
{
-testArgExpansion([a ' b], 'a \' b');
+testArgExpansion([a ' b], 'a ' b');
}
@Test
@@ -417,4 +417,4 @@
{
return Os.isFamily(Os.FAMILY_WINDOWS);
}
-}
\ No newline at end of file
+}
Linux build of plugins broken by \ in tests
---
Key: NPANDAY-611
URL: https://issues.apache.org/jira/browse/NPANDAY-611
Project: NPanday
Issue Type: Bug
Components: Maven Plugins
Affects Versions: 1.5.0-incubating
Reporter: David Akehurst
Building the maven plugins on linux breaks when compiling the tests because
of a few backslashes in the tests.
not been able to test this on windows, but the attached comment of svn diff
fixes it for linux.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (NPANDAY-611) Linux build of plugins broken by \ in tests
[ https://issues.apache.org/jira/browse/NPANDAY-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915586#comment-13915586 ] David Akehurst commented on NPANDAY-611: Also, not sure if it is a npanday or a mono bug, but running nunit-console has a different command for windows and linux w.r.t v4. windows nunit-console -v4 linux nunit-console4 Linux build of plugins broken by \ in tests --- Key: NPANDAY-611 URL: https://issues.apache.org/jira/browse/NPANDAY-611 Project: NPanday Issue Type: Bug Components: Maven Plugins Affects Versions: 1.5.0-incubating Reporter: David Akehurst Building the maven plugins on linux breaks when compiling the tests because of a few backslashes in the tests. not been able to test this on windows, but the attached comment of svn diff fixes it for linux. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (NPANDAY-610) ArtifactType as an optional configuration argument
[ https://issues.apache.org/jira/browse/NPANDAY-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Akehurst updated NPANDAY-610: --- Attachment: patch.txt ArtifactType as an optional configuration argument -- Key: NPANDAY-610 URL: https://issues.apache.org/jira/browse/NPANDAY-610 Project: NPanday Issue Type: Improvement Components: Maven Plugins Affects Versions: 1.5.0-incubating Reporter: David Akehurst Attachments: patch.txt For one of my uses of npanday I need to be able to define the artifactType using a configuration argument. (I.e. it is not defined by the package type of the pom). I have implemented this, and attached an svn diff of the trunk to this ticket. Could we get it into the 1.5.0 release please. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (NPANDAY-610) ArtifactType as an optional configuration argument
[ https://issues.apache.org/jira/browse/NPANDAY-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915589#comment-13915589 ] David Akehurst commented on NPANDAY-610: done ArtifactType as an optional configuration argument -- Key: NPANDAY-610 URL: https://issues.apache.org/jira/browse/NPANDAY-610 Project: NPanday Issue Type: Improvement Components: Maven Plugins Affects Versions: 1.5.0-incubating Reporter: David Akehurst Attachments: patch.txt For one of my uses of npanday I need to be able to define the artifactType using a configuration argument. (I.e. it is not defined by the package type of the pom). I have implemented this, and attached an svn diff of the trunk to this ticket. Could we get it into the 1.5.0 release please. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
