Re: [Numpy-discussion] rational custom dtype example

[Charles R Harris]

On Sat, Apr 2, 2016 at 1:59 PM, Steve Mitchell 
wrote:

> I have noticed a few issues with the “rational” custom C dtype example.
>
>
>
> 1.It doesn’t build on Windows.  I managed to tweak it to build.
> Mainly, the MSVC9 compiler is C89.
>
> 2.   A few tests don’t pass on Windows, due to integer sizes.
>
> 3.   The copyswap and copyswapn routines don’t do in-place swapping
> if src == NULL, as specified in the docs.
>
> http://docs.scipy.org/doc/numpy-1.10.0/reference/c-api.types-and-structures.html
>
>
>

Needless to say the example hasn't been tested on windows ;) A PR fixing
the issues that you discovered would be welcome.

Chuck
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
https://mail.scipy.org/mailman/listinfo/numpy-discussion

[Numpy-discussion] rational custom dtype example

[Steve Mitchell]

I have noticed a few issues with the "rational" custom C dtype example.


1.It doesn't build on Windows.  I managed to tweak it to build.  
Mainly, the MSVC9 compiler is C89.

2.   A few tests don't pass on Windows, due to integer sizes.

3.   The copyswap and copyswapn routines don't do in-place swapping if src 
== NULL, as specified in the docs.
http://docs.scipy.org/doc/numpy-1.10.0/reference/c-api.types-and-structures.html

  --Steve

___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
https://mail.scipy.org/mailman/listinfo/numpy-discussion