Re: [OE-core] [PATCH 1/2] quilt: do not test patch-wrapper as it is not enabled

2020-04-15 Thread Alexander Kanavin 
Richard didn't want to merge the patch, as the intermittent nature of the
failure means there may be a deeper issue that will not be solved by
disabling the test that exposes it. Sadly I have not been able to reproduce
this at all, so if you have better ideas or a good understanding of what
the test is doing, you are welcome to help.

Alex

On Wed, 15 Apr 2020 at 20:35, Mingde (Matthew) Zeng <
matthew.z...@windriver.com> wrote:

>
> Can we get an update regarding the status of this patch? It is to fix
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=13841 which the target
> milestone is set to 3.1 M4.
>
> Thanks,
> Matthew
>
> Alexander Kanavin  writes:
>
> > Upstream only enables the test if --with-patch-wrapper
> > was supplied to ./configure, and so should we.
> >
> > Signed-off-by: Alexander Kanavin 
> > ---
> >  meta/recipes-devtools/quilt/quilt.inc | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/meta/recipes-devtools/quilt/quilt.inc
> b/meta/recipes-devtools/quilt/quilt.inc
> > index d6d06c049c..d2db079e0b 100644
> > --- a/meta/recipes-devtools/quilt/quilt.inc
> > +++ b/meta/recipes-devtools/quilt/quilt.inc
> > @@ -71,6 +71,9 @@ do_install_ptest() {
> >   tar -c --exclude=mail.test --exclude=delete.test test/ | ( cd
> ${D}${PTEST_PATH} && tar -xf - && chmod 777 test)
> >   cp ${WORKDIR}/Makefile ${D}${PTEST_PATH}
> >   cp ${WORKDIR}/test.sh ${D}${PTEST_PATH}
> > +
> > + # This is specifically excluded when --with-patch-wrapper is
> absent during ./configure
> > + rm ${D}${PTEST_PATH}/test/patch-wrapper.test
> >  }
> >
> >  PACKAGES += "guards guards-doc"
>
>
> --
> Mingde (Matthew) Zeng
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#137248): 
https://lists.openembedded.org/g/openembedded-core/message/137248
Mute This Topic: https://lists.openembedded.org/mt/72528131/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH 1/2] quilt: do not test patch-wrapper as it is not enabled

2020-04-15 Thread Matthew 

Can we get an update regarding the status of this patch? It is to fix 
https://bugzilla.yoctoproject.org/show_bug.cgi?id=13841 which the target 
milestone is set to 3.1 M4.

Thanks,
Matthew

Alexander Kanavin  writes:

> Upstream only enables the test if --with-patch-wrapper
> was supplied to ./configure, and so should we.
>
> Signed-off-by: Alexander Kanavin 
> ---
>  meta/recipes-devtools/quilt/quilt.inc | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-devtools/quilt/quilt.inc 
> b/meta/recipes-devtools/quilt/quilt.inc
> index d6d06c049c..d2db079e0b 100644
> --- a/meta/recipes-devtools/quilt/quilt.inc
> +++ b/meta/recipes-devtools/quilt/quilt.inc
> @@ -71,6 +71,9 @@ do_install_ptest() {
>   tar -c --exclude=mail.test --exclude=delete.test test/ | ( cd 
> ${D}${PTEST_PATH} && tar -xf - && chmod 777 test)
>   cp ${WORKDIR}/Makefile ${D}${PTEST_PATH}
>   cp ${WORKDIR}/test.sh ${D}${PTEST_PATH}
> +
> + # This is specifically excluded when --with-patch-wrapper is absent 
> during ./configure
> + rm ${D}${PTEST_PATH}/test/patch-wrapper.test
>  }
>
>  PACKAGES += "guards guards-doc"


--
Mingde (Matthew) Zeng
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#137246): 
https://lists.openembedded.org/g/openembedded-core/message/137246
Mute This Topic: https://lists.openembedded.org/mt/72528131/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH 1/2] quilt: do not test patch-wrapper as it is not enabled

2020-03-24 Thread Alexander Kanavin 
Upstream only enables the test if --with-patch-wrapper
was supplied to ./configure, and so should we.

Signed-off-by: Alexander Kanavin 
---
 meta/recipes-devtools/quilt/quilt.inc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-devtools/quilt/quilt.inc 
b/meta/recipes-devtools/quilt/quilt.inc
index d6d06c049c..d2db079e0b 100644
--- a/meta/recipes-devtools/quilt/quilt.inc
+++ b/meta/recipes-devtools/quilt/quilt.inc
@@ -71,6 +71,9 @@ do_install_ptest() {
tar -c --exclude=mail.test --exclude=delete.test test/ | ( cd 
${D}${PTEST_PATH} && tar -xf - && chmod 777 test)
cp ${WORKDIR}/Makefile ${D}${PTEST_PATH}
cp ${WORKDIR}/test.sh ${D}${PTEST_PATH}
+
+   # This is specifically excluded when --with-patch-wrapper is absent 
during ./configure
+   rm ${D}${PTEST_PATH}/test/patch-wrapper.test
 }
 
 PACKAGES += "guards guards-doc"
-- 
2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#136674): 
https://lists.openembedded.org/g/openembedded-core/message/136674
Mute This Topic: https://lists.openembedded.org/mt/72528131/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-