Re: [OE-core] [PATCH v2] device-tree.bbclass: Add support to compile overlays separately
Ping
-Original Message-
From: Jaewon Lee
Sent: Monday, January 28, 2019 3:19 PM
To: Jaewon Lee ; openembedded-core@lists.openembedded.org;
nat...@nathanrossi.com
Cc: Alejandro Enedino Hernandez Samaniego ; Manjukumar
Harthikote Matha
Subject: RE: [OE-core][PATCH v2] device-tree.bbclass: Add support to compile
overlays separately
ping
-Original Message-
From: Jaewon Lee [mailto:jaewon@xilinx.com]
Sent: Friday, December 14, 2018 9:54 AM
To: openembedded-core@lists.openembedded.org; nat...@nathanrossi.com
Cc: Jaewon Lee ; Alejandro Enedino Hernandez Samaniego
; Manjukumar Harthikote Matha
Subject: [OE-core][PATCH v2] device-tree.bbclass: Add support to compile
overlays separately
Currently only dts files are considered when looping through files to compile.
Modifying the loop to compile other files that are overlays.
Also surrounding this check with a try block as the function to find overlays
parses the file for a '/plugin/' tag, and there may be files in the
DT_FILES_PATH directory that are not parseable.
Signed-off-by: Jaewon Lee
Signed-off-by: Alejandro Enedino Hernandez Samaniego
Signed-off-by: Manjukumar Matha
---
meta/classes/devicetree.bbclass | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/meta/classes/devicetree.bbclass b/meta/classes/devicetree.bbclass
index 8fe5a5e..d785285 100644
--- a/meta/classes/devicetree.bbclass
+++ b/meta/classes/devicetree.bbclass
@@ -120,9 +120,12 @@ python devicetree_do_compile() {
includes = expand_includes("DT_INCLUDE", d)
listpath = d.getVar("DT_FILES_PATH")
for dts in os.listdir(listpath):
-if not dts.endswith(".dts"):
-continue # skip non-.dts files
dtspath = os.path.join(listpath, dts)
+try:
+if not(os.path.isfile(dtspath)) or not(dts.endswith(".dts") or
devicetree_source_is_overlay(dtspath)):
+continue # skip non-.dts files and non-overlay files
+except:
+continue # skip if can't determine if overlay
devicetree_compile(dtspath, includes, d) }
--
2.7.5
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH v2] device-tree.bbclass: Add support to compile overlays separately
ping
-Original Message-
From: Jaewon Lee [mailto:jaewon@xilinx.com]
Sent: Friday, December 14, 2018 9:54 AM
To: openembedded-core@lists.openembedded.org; nat...@nathanrossi.com
Cc: Jaewon Lee ; Alejandro Enedino Hernandez Samaniego
; Manjukumar Harthikote Matha
Subject: [OE-core][PATCH v2] device-tree.bbclass: Add support to compile
overlays separately
Currently only dts files are considered when looping through files to compile.
Modifying the loop to compile other files that are overlays.
Also surrounding this check with a try block as the function to find overlays
parses the file for a '/plugin/' tag, and there may be files in the
DT_FILES_PATH directory that are not parseable.
Signed-off-by: Jaewon Lee
Signed-off-by: Alejandro Enedino Hernandez Samaniego
Signed-off-by: Manjukumar Matha
---
meta/classes/devicetree.bbclass | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/meta/classes/devicetree.bbclass b/meta/classes/devicetree.bbclass
index 8fe5a5e..d785285 100644
--- a/meta/classes/devicetree.bbclass
+++ b/meta/classes/devicetree.bbclass
@@ -120,9 +120,12 @@ python devicetree_do_compile() {
includes = expand_includes("DT_INCLUDE", d)
listpath = d.getVar("DT_FILES_PATH")
for dts in os.listdir(listpath):
-if not dts.endswith(".dts"):
-continue # skip non-.dts files
dtspath = os.path.join(listpath, dts)
+try:
+if not(os.path.isfile(dtspath)) or not(dts.endswith(".dts") or
devicetree_source_is_overlay(dtspath)):
+continue # skip non-.dts files and non-overlay files
+except:
+continue # skip if can't determine if overlay
devicetree_compile(dtspath, includes, d) }
--
2.7.5
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH v2] device-tree.bbclass: Add support to compile overlays separately
Currently only dts files are considered when looping through files to
compile. Modifying the loop to compile other files that are overlays.
Also surrounding this check with a try block as the function to find
overlays parses the file for a '/plugin/' tag, and there may be files in
the DT_FILES_PATH directory that are not parseable.
Signed-off-by: Jaewon Lee
Signed-off-by: Alejandro Enedino Hernandez Samaniego
Signed-off-by: Manjukumar Matha
---
meta/classes/devicetree.bbclass | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/meta/classes/devicetree.bbclass b/meta/classes/devicetree.bbclass
index 8fe5a5e..d785285 100644
--- a/meta/classes/devicetree.bbclass
+++ b/meta/classes/devicetree.bbclass
@@ -120,9 +120,12 @@ python devicetree_do_compile() {
includes = expand_includes("DT_INCLUDE", d)
listpath = d.getVar("DT_FILES_PATH")
for dts in os.listdir(listpath):
-if not dts.endswith(".dts"):
-continue # skip non-.dts files
dtspath = os.path.join(listpath, dts)
+try:
+if not(os.path.isfile(dtspath)) or not(dts.endswith(".dts") or
devicetree_source_is_overlay(dtspath)):
+continue # skip non-.dts files and non-overlay files
+except:
+continue # skip if can't determine if overlay
devicetree_compile(dtspath, includes, d)
}
--
2.7.5
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
