[10] request for review 8181779: Memory leak in FX Glass Embedded Window
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8181779/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8181779 -- Thanks, Alexander.
Re: Allow to pass in custom CFLAGS to gcc
Oh sorry, I thought you were talking about the standard openjdk build, --with-extra-cflags is a configure option. Kind Regards, Thomas On Wed, Jul 19, 2017 at 2:38 PM, Jonny Heggheim wrote: > Hi Thomas! > > On 19 July 2017 at 14:18, Thomas Stüfe wrote: > > You can pass extra CFLAGS with option --with-extra-cflags. > > Thanks for your suggestion, do you know where I can find documentation > for this feature? > > I got this error on Gradle 2.13: > $ gradle --with-extra-cflags '-O2 -g -pipe -Wall > -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions > -fstack-protector-strong --param=ssp-buffer-size=4 > -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 > -m64 -mtune=generic' > > Unknown command-line option '--with-extra-cflags'. > > USAGE: gradle [option...] [task...] > > > Jonny >
Re: Allow to pass in custom CFLAGS to gcc
Hi Thomas! On 19 July 2017 at 14:18, Thomas Stüfe wrote: > You can pass extra CFLAGS with option --with-extra-cflags. Thanks for your suggestion, do you know where I can find documentation for this feature? I got this error on Gradle 2.13: $ gradle --with-extra-cflags '-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic' Unknown command-line option '--with-extra-cflags'. USAGE: gradle [option...] [task...] Jonny
Re: Allow to pass in custom CFLAGS to gcc
Hi Jonny! You can pass extra CFLAGS with option --with-extra-cflags. Best Regards, Thomas On Wed, Jul 19, 2017 at 11:31 AM, Jonny Heggheim wrote: > Hi, my name is Jonny Heggheim[1], I am the maintainer of the openjfx > package in Fedora[2]. > > Could you help me with this issue? > https://bugzilla.redhat.com/show_bug.cgi?id=1472613 > > The standard build for Fedora is to build with symbols and then strip > out the debug symbols into a separate -debug package. > > Would it be possible to modify the build so it is possible to pass in > custom CFLAGS? > > The default flags for Fedora 26 builds on x86_64 is: > $ rpm --eval '%{optflags}' > -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 > -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 > -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 > -m64 -mtune=generic > > Sincerely Jonny Heggheim > > [1] https://fedoraproject.org/wiki/User:Jonny > [2] https://apps.fedoraproject.org/packages/openjfx >
Allow to pass in custom CFLAGS to gcc
Hi, my name is Jonny Heggheim[1], I am the maintainer of the openjfx package in Fedora[2]. Could you help me with this issue? https://bugzilla.redhat.com/show_bug.cgi?id=1472613 The standard build for Fedora is to build with symbols and then strip out the debug symbols into a separate -debug package. Would it be possible to modify the build so it is possible to pass in custom CFLAGS? The default flags for Fedora 26 builds on x86_64 is: $ rpm --eval '%{optflags}' -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic Sincerely Jonny Heggheim [1] https://fedoraproject.org/wiki/User:Jonny [2] https://apps.fedoraproject.org/packages/openjfx