RFR: 8249839: Cherry pick GTK WebKit 2.28.3 changes

[Arun Joseph]

Update to GTK WebKit 2.28.3
https://webkitgtk.org/2020/07/09/webkitgtk2.28.3-released.html

-

Commit messages:
 - Cherry pick GTK WebKit 2.28.3 changes

Changes: https://git.openjdk.java.net/jfx/pull/271/files
 Webrev: https://webrevs.openjdk.java.net/jfx/271/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8249839
  Stats: 533 lines in 36 files changed: 381 ins; 66 del; 86 mod
  Patch: https://git.openjdk.java.net/jfx/pull/271.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/271/head:pull/271

PR: https://git.openjdk.java.net/jfx/pull/271

Re: RFR: 8181775: JavaFX WebView does not calculate border-radius properly [v3]

[Bhawesh Choudhary]

> root cause of issue is prism's fillRoundedRect() API doesn't allow rendering 
> of rounded corner rectangle if four
> corners have different radii. but same can be achieved via Path. to fix the 
> issue, in GraphicsContextJava.cpp while
> rendering fillRoundedRect, check if all four corners have same radii. if yes, 
> use FILL_ROUNDED_RECT to draw it
> otherwise construct a path from given rounded rect and draw it.

Bhawesh Choudhary has updated the pull request incrementally with 54 additional 
commits since the last revision:

 - 8181775: JavaFX WebView does not calculate border-radius properly
 - 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% 
or 175%
   
   Reviewed-by: kcr, psadhukhan
 - 8248381: Create a daemon thread for MonocleTimer
   
   Reviewed-by: kcr, jvos
 - 8248490: [macOS] Undecorated stage does not minimize
   
   Reviewed-by: arapte, aghaisas
 - 8248908: Printer.createPageLayout() returns 0.75" margins instead of 
hardware margins
   
   Reviewed-by: kcr
 - 8245284: Update to 610.1 version of WebKit
   
   Co-authored-by: Guru Hb 
   Co-authored-by: Bhawesh Choudhary 
   Reviewed-by: kcr, bchoudhary, sykora
 - 8176270: Adding ChangeListener to TextField.selectedTextProperty causes 
StringOutOfBoundsException
   
   Reviewed-by: aghaisas, kcr
 - 8245422: Better Pisces rasterizing
   
   Reviewed-by: prr, rhalade, arapte, mschoene
 - 8241108: Glib improvements
   
   Reviewed-by: kcr, ahgross, rhalade
 - 8248365: Debug build crashes on Windows when playing media file
   
   Reviewed-by: kcr
 - ... and 44 more: https://git.openjdk.java.net/jfx/compare/e7cb98fe...586af326

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/218/files
  - new: https://git.openjdk.java.net/jfx/pull/218/files/e7cb98fe..586af326

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/218/webrev.02
 - incr: https://webrevs.openjdk.java.net/jfx/218/webrev.01-02

  Stats: 393560 lines in 5665 files changed: 200813 ins; 130033 del; 62714 mod
  Patch: https://git.openjdk.java.net/jfx/pull/218.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/218/head:pull/218

PR: https://git.openjdk.java.net/jfx/pull/218

Re: Hello!

[Nir Lisker]

>
> I'd like to work on implementing this feature: JDK-8238733
> 


I suggest you sent a new email specifically discussing this issue then. You
will need approval from Kevin of Johan to implement it anyway. Someone
might be able to help you technically, but in general you would need to
learn the code yourself.

Similarly, I'm not entirely sure I understand this disconnect between
> "JavaFX's" code and "sun's" code?


Generally, code inside com.sun packages is internal; code inside javafx
packages is for the public API.

On Mon, Jul 20, 2020 at 10:25 PM FireController#1847 <
usfirepilot...@gmail.com> wrote:

> Hey,
>
> Thanks for the response. I've read all of the contributing data and signed
> the OCA (otherwise I wouldn't be here haha).
>
> I've already got a build of JavaFX up and running, but I am completely
> lost on where to get started. I'd like to work on implementing this
> feature: JDK-8238733  
> (sparked
> from JDK-8238729 ), but
> I'm not entirely sure of how complicated it could possibly be. I was
> looking into how insets work on borders, but it appears to be a vastly
> different system that is being used for effects. I also noticed that a lot
> of the border inset logic is on the "Region" class, whereas the effect
> logic is on the "Node" class.
>
> Similarly, I'm not entirely sure I understand this disconnect between
> "JavaFX's" code and "sun's" code? Is there a document explaining what this
> means and/or a document showing a summary of how the code is laid out?
>
> - Fire
>
> On Mon, Jul 20, 2020 at 11:47 AM Nir Lisker  wrote:
>
>> Hi,
>>
>> As the mailing list page [1] says, this list is for technical discussion
>> related to the OpenJFX project.
>>
>> To implement a feature, see [2].
>>
>> - Nir
>>
>> [1] https://mail.openjdk.java.net/mailman/listinfo/openjfx-dev
>> [2] https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md
>>
>> On Sun, Jul 19, 2020 at 10:22 AM FireController#1847 <
>> usfirepilot...@gmail.com> wrote:
>>
>>> Hello,
>>>
>>> I have never used a mailing list before, and I have no clue how this
>>> works
>>> at all. I'm more of a Discord type of person, and am also very young
>>> haha.
>>>
>>> Would anyone be willing to give me a quick summary of what I can expect
>>> now
>>> that I'm subscribed to this, and how I can use it to help me implement a
>>> feature?
>>>
>>> Thanks,
>>> Fire
>>>
>>

RFR: 8249777: build.gradle: project.version should not contain time stamps

[Kevin Rushforth]

The addMavenPublication method sets the `project.version` to `$MAVEN_VERSION`, 
where project is base, graphics,
controls, etc. When doing an ordinary "developer" build, this property contains 
the time stamp . This is causing
problems with the NetBeans gradle plugin not being able to determine the 
dependencies between the projects (modules).

We haven't noticed this bug before now, because we suppress the creation of the 
individual project jar files, but if we
were creating them, we would have the problem that each time we ran gradle, it 
would generate a new
`project-$version.jar` file with a different time stamp each time the build was 
run.

The setting of `project.version=$MAVEN_VERSION` is only used by the maven 
"publish" tasks, which isn't done for
developer builds nor for most productions builds.

The proposed solution is to add a new boolean `MAVEN_PUBLISH` flag, which will 
default to `false`. This flag will
qualify the setting of the `MAVEN_VERSION` property and the configuration of 
the maven publishing tasks. After this
change, it will be necessary to run gradle with `-PMAVEN_PUBLISH=true` in order 
to run the maven publishing tasks.

-

Commit messages:
 - 8249777: build.gradle: project.version should not contain time stamps

Changes: https://git.openjdk.java.net/jfx/pull/270/files
 Webrev: https://webrevs.openjdk.java.net/jfx/270/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8249777
  Stats: 11 lines in 1 file changed: 9 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jfx/pull/270.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/270/head:pull/270

PR: https://git.openjdk.java.net/jfx/pull/270

Re: RFR: 8249777: build.gradle: project.version should not contain time stamps

[Kevin Rushforth]

On Wed, 22 Jul 2020 17:22:25 GMT, Kevin Rushforth  wrote:

> The addMavenPublication method sets the `project.version` to 
> `$MAVEN_VERSION`, where project is base, graphics,
> controls, etc. When doing an ordinary "developer" build, this property 
> contains the time stamp . This is causing
> problems with the NetBeans gradle plugin not being able to determine the 
> dependencies between the projects (modules).
> We haven't noticed this bug before now, because we suppress the creation of 
> the individual project jar files, but if we
> were creating them, we would have the problem that each time we ran gradle, 
> it would generate a new
> `project-$version.jar` file with a different time stamp each time the build 
> was run.  The setting of
> `project.version=$MAVEN_VERSION` is only used by the maven "publish" tasks, 
> which isn't done for developer builds nor
> for most productions builds.  The proposed solution is to add a new boolean 
> `MAVEN_PUBLISH` flag, which will default to
> `false`. This flag will qualify the setting of the `MAVEN_VERSION` property 
> and the configuration of the maven
> publishing tasks. After this change, it will be necessary to run gradle with 
> `-PMAVEN_PUBLISH=true` in order to run the
> maven publishing tasks.

@tiainen can you also review this?

build.gradle line 2063:

> 2062: project.ext.moduleName = "javafx.graphics"
> 2063: project.ext.mavenPublish = IS_MAVEN_PUBLISH
> 2064:

Is this property needed? None of the other projects define it, and I don't see 
any usage of it.

-

PR: https://git.openjdk.java.net/jfx/pull/270

[jfx14] Integrated: 8249799: Create release notes for JavaFX 14.0.2.1

[Johan Vos]

On Wed, 22 Jul 2020 12:07:06 GMT, Johan Vos  wrote:

> Add release notes for 14.0.2.1
> Fix for JDK-8249799

This pull request has now been integrated.

Changeset: c8ee1b7f
Author:Johan Vos 
URL:   https://git.openjdk.java.net/jfx/commit/c8ee1b7f
Stats: 29 lines in 1 file changed: 0 ins; 29 del; 0 mod

8249799: Create release notes for JavaFX 14.0.2.1

Reviewed-by: kcr

-

PR: https://git.openjdk.java.net/jfx/pull/269

Re: [jfx14] RFR: 8249799: Create release notes for JavaFX 14.0.2.1 [v2]

[Johan Vos]

> Add release notes for 14.0.2.1
> Fix for JDK-8249799

Johan Vos has updated the pull request incrementally with two additional 
commits since the last revision:

 - and also change the links, pointing to the original bug
 - Use the bug id of the original issue instead of the backport issue

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/269/files
  - new: https://git.openjdk.java.net/jfx/pull/269/files/f0adf179..fe873a8d

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/269/webrev.01
 - incr: https://webrevs.openjdk.java.net/jfx/269/webrev.00-01

  Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jfx/pull/269.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/269/head:pull/269

PR: https://git.openjdk.java.net/jfx/pull/269

Re: [jfx14] RFR: 8249799: Create release notes for JavaFX 14.0.2.1 [v2]

[Kevin Rushforth]

On Wed, 22 Jul 2020 14:54:38 GMT, Johan Vos  wrote:

>> Add release notes for 14.0.2.1
>> Fix for JDK-8249799
>
> Johan Vos has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - and also change the links, pointing to the original bug
>  - Use the bug id of the original issue instead of the backport issue

Marked as reviewed by kcr (Lead).

-

PR: https://git.openjdk.java.net/jfx/pull/269

Re: Is scene builder abandoned? And what about JavaFX?

[Kevin Rushforth]

JavaFX is quite active, and has not been abandoned. You can find the 
documentation and download the latest releases at openjfx.io [1]. The 
source repository for JavaFX is on GitHub [2].


SceneBuilder is maintained by Gluon. Releases are available for download 
at [3]. The source repository is on GitHub [4].


-- Kevin

[1] https://openjfx.io/
[2] https://github.com/openjdk/jfx
[3] https://gluonhq.com/products/scene-builder/
[4] https://github.com/gluonhq/scenebuilder


On 7/22/2020 5:29 AM, Davide Perini wrote:

Hi all,
love JavaFX and I think that it is very productive, super awesome.
It is pretty sad that scene builder seems so old and unsupported, scene
builder still not support spinner and many "newer" elements. Why?

Is JavaFX dead or is still active?
Since Oracle "abandon" I see no documentation of the new features
implemented.
Is there an official documentation for JavaFX now?
Thanks
Davide

Is scene builder abandoned? And what about JavaFX?

[Davide Perini]

Hi all,
love JavaFX and I think that it is very productive, super awesome. 


It is pretty sad that scene builder seems so old and unsupported, scene
builder still not support spinner and many "newer" elements. Why?

Is JavaFX dead or is still active?
Since Oracle "abandon" I see no documentation of the new features
implemented.
Is there an official documentation for JavaFX now? 


Thanks
Davide

[jfx15] Integrated: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175%

[Oliver Schmidtmer]

On Wed, 3 Jun 2020 15:46:36 GMT, Oliver Schmidtmer 
 wrote:

> In edge cases where monitor scaling of 1.25 or 1.75 is active, Math.ceil and 
> Math.round produce different results and
> EmbeddedScene#getPixels in JFXPanel#paintComponent causes an off-by-one error 
> on the line width and therefore sheared
> rendering.  The changes were already proposed by the submitter in JBS-8220484.
> 
> OCA is signed and send.

This pull request has now been integrated.

Changeset: 3cc29e38
Author:Oliver Schmidtmer 
Committer: Kevin Rushforth 
URL:   https://git.openjdk.java.net/jfx/commit/3cc29e38
Stats: 351 lines in 7 files changed: 0 ins; 341 del; 10 mod

8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 
175%

Reviewed-by: kcr, psadhukhan

-

PR: https://git.openjdk.java.net/jfx/pull/246

Re: [jfx14] RFR: 8249799: Create release notes for JavaFX 14.0.2.1

[Kevin Rushforth]

On Wed, 22 Jul 2020 12:07:06 GMT, Johan Vos  wrote:

> Add release notes for 14.0.2.1
> Fix for JDK-8249799

It looks like you used the JBS bug IDs of the backport records rather than the 
main bug. The rest looks good.

-

PR: https://git.openjdk.java.net/jfx/pull/269

Re: [jfx15] RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175% [v6]

[Prasanta Sadhukhan]

On Mon, 20 Jul 2020 18:11:34 GMT, Oliver Schmidtmer 
 wrote:

>> In edge cases where monitor scaling of 1.25 or 1.75 is active, Math.ceil and 
>> Math.round produce different results and
>> EmbeddedScene#getPixels in JFXPanel#paintComponent causes an off-by-one 
>> error on the line width and therefore sheared
>> rendering.  The changes were already proposed by the submitter in 
>> JBS-8220484.
>> 
>> OCA is signed and send.
>
> Oliver Schmidtmer has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - run test only on windows
>  - Typo

Marked as reviewed by psadhukhan (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/246

[jfx14] RFR: 8249799: Create release notes for JavaFX 14.0.2.1

[Johan Vos]

Add release notes for 14.0.2.1
Fix for JDK-8249799

-

Commit messages:
 - Add release notes for 14.0.2.1

Changes: https://git.openjdk.java.net/jfx/pull/269/files
 Webrev: https://webrevs.openjdk.java.net/jfx/269/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8249799
  Stats: 29 lines in 1 file changed: 29 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/269.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/269/head:pull/269

PR: https://git.openjdk.java.net/jfx/pull/269