Review Request 8088681:Underscore not visible in HTML combo box options inside webview
Hi Kevin, Arun, Please review the fix for : JBS: https://bugs.openjdk.java.net/browse/JDK-8088681 Webrev: http://cr.openjdk.java.net/~asrivastava/dipak/8088681/webrev.00/ I have tested the fix on Win64 and Linux 64. I have run Junit test cases and DRT. Many thanks, Dipak
Review Request [JDK 8] - 8087545:Line separator is broken in the clipboard of WebView
Hi Philip, Kevin, Please review the fix for : JBS: https://bugs.openjdk.java.net/browse/JDK-8087545 Webrev: http://cr.openjdk.java.net/~asrivastava/dipak/8087545/webrev.00/ I have tested the fix on Win64 and Junit test case run was fine. Many thanks, Dipak
[10] Code Review Request For 8133337: [Linux] Pasting HTML from Firefox does not work
Hi Kevin, Please review the proposed fix. JBS: https://bugs.openjdk.java.net/browse/JDK-817 Webrev: http://cr.openjdk.java.net/~asrivastava/dipak/817/webrev.00/ Root cause and solution updated in JBS. Thanks, Dipak
[8] Code Review Request For 8180180: [Mac] WebView renders icons instead of letters on some sites
Hi Philip, Kevin and Arun, Please review the below changes: JBS: https://bugs.openjdk.java.net/browse/JDK-8180180 Webrev: http://cr.openjdk.java.net/~arajkumar/dipak/8180180/webrev/ Please note that this is a backport for JBS - HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8088205"JDK-8088205 . Thanks, Dipak
[10] Review request for 8089283 : Padding property of the select tag is incorrect in WebView
Hi Kevin, Please review the proposed fix: Webrev : http://cr.openjdk.java.net/~asrivastava/dipak/8089283/webrev.00/ JBS : https://bugs.openjdk.java.net/browse/JDK-8089283 DRT and unit test cases are running fine with this change. Many thanks, Dipak
[10] Review request: 8130721: [macos] problem with editing thai in TextArea
Hi Phil/Kevin, Please review the below fix - Webrev : http://cr.openjdk.java.net/~dkumar/8130721/webrev.00/ JBS : https://bugs.openjdk.java.net/browse/JDK-8130721 Details about the fix has been updated in JBS. Thanks, Dipak
[8u-Backport] Review request for 8185634 : Java Fx-Swing dialogs appearing behind main stage
Hi All, Please review the below patch (for 8u-backport) - Webrev : http://cr.openjdk.java.net/~dkumar/8185634/webrev.00/ JBS - https://bugs.openjdk.java.net/browse/JDK-8185634 Thanks, Dipak
RE: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage
Hi Semyon, Could you please review the changes (also have a look at Phil's comment in trailing mail) and let me know your comments. Thanks Kevin and Phil. I have incorporated the changes suggested for unit tests in JavaFx side. Request you to have a look. Please find updated webrev at - http://cr.openjdk.java.net/~dkumar/8185634/webrev.01/ . Thanks, Dipak -Original Message- From: Kevin Rushforth Sent: Thursday, January 18, 2018 3:21 AM To: Phil Race Cc: Dipak Kumar ; openjfx-dev@openjdk.java.net; awt-...@openjdk.java.net Subject: Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage I think you mean https://bugs.openjdk.java.net/browse/JDK-8187803 for the AWT/Swing side... -- Kevin Phil Race wrote: > The AWT/Swing side of this needs to be bug > https://bugs.openjdk.java.net/browse/JDK-8185634 > > One thing I notice is that in XWindowPeer.java the calculation for the > value of transientForWindow is different .. because you don't have the > fix for > https://bugs.openjdk.java.net/browse/JDK-8021961 : > "setAlwaysOnTop doesn't behave correctly in Linux/Solaris under > certain scenarios" > > Do you first need to backport that too ? Maybe Semyon (who authored > that fix) can say whether it matters .. > > -phil. > > On 01/12/2018 02:12 AM, Dipak Kumar wrote: >> Hi All, >> >> >> Please review the below patch (for 8u-backport) - >> >> >> Webrev : http://cr.openjdk.java.net/~dkumar/8185634/webrev.00/ >> >> JBS - https://bugs.openjdk.java.net/browse/JDK-8185634 >> >> >> Thanks, >> >> Dipak >
[11] Review request: 8198354: [macOS] Corrupt Thai characters displayed in word wrapped label
Hi Phil/Kevin, Please review the below fix - Webrev : http://cr.openjdk.java.net/~mbilla/8198354/webrev.00/ JBS : https://bugs.openjdk.java.net/browse/JDK-8198354 Details about the fix has been updated in JBS. Thanks, Dipak