Re: [openstack-dev] [Fuel] Nominating Dmitry Burmistrov to core reviewers of fuel-mirror
Mike, Yes, probably the best place to describe further plans is README file. I'll create a patch. Vladimir Kozhukalov On Tue, Dec 1, 2015 at 8:30 PM, Mike Scherbakov wrote: > Vladimir, > if you've been behind of this, could you please share further plans in > separate email thread or (better) provide plans in README in the repo, so > everyone can be aware of planned changes and can review them too? If you or > someone else propose a change, please post a link here... > > Thanks, > > On Tue, Dec 1, 2015 at 6:27 AM Vladimir Kozhukalov < > vkozhuka...@mirantis.com> wrote: > >> Thomas, >> >> You are right about two independent modules in the repo. That is because >> the former intention was to get rid of fuel-mirror (and fuel-createmirror) >> and perestroika and leave only packetary there. Packetary is to be >> developed so it is able to build not only repositories but packages as >> well. So we'll be able to remove perestroika once it is ready. Two major >> capabilities of fuel-mirror are: >> 1) create mirror (and partial mirror) and packetary can be used for this >> instead >> 2) apply mirror to nailgun (which is rather a matter of python-fuelclient) >> So fuel-mirror also should be removed in the future to avoid >> functionality duplication. >> >> Those were the reasons not to put them separately. (C) "There can be only >> one". >> >> >> >> >> >> Vladimir Kozhukalov >> >> On Tue, Dec 1, 2015 at 1:25 PM, Thomas Goirand wrote: >> >>> On 12/01/2015 09:25 AM, Mike Scherbakov wrote: >>> > 4. I don't quite understand how repo is organized. I see a lot of >>> > Python code regarding to fuel-mirror itself and packetary, which is >>> > used as fuel-mirrors core and being written and maintained mostly >>> by >>> > Bulat [5]. There are seem to be bash scripts now related to >>> > Perestroika, and. I don't quite get how these things relate each to >>> > other, and if we expect core reviewers to be merging code into both >>> > Perestroika and Packetary? Unless mission of repo, code gets clear, >>> > I'd abstain from giving +1... >>> >>> Also, why isn't packetary living in its own repository? It seems wrong >>> to me to have 2 python modules living in the same source repo, unless >>> they share the same egg-info. It feels weird to have to call setup.py >>> install twice in the resulting Debian source package. That's not how >>> things are done elsewhere, and I'd like to avoid special cases, just >>> because it's fuel... >>> >>> Cheers, >>> >>> Thomas Goirand (zigo) >>> >>> >>> >>> __ >>> OpenStack Development Mailing List (not for usage questions) >>> Unsubscribe: >>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >>> >> >> __ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > -- > Mike Scherbakov > #mihgen > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Fuel] Nominating Dmitry Burmistrov to core reviewers of fuel-mirror
Vladimir, if you've been behind of this, could you please share further plans in separate email thread or (better) provide plans in README in the repo, so everyone can be aware of planned changes and can review them too? If you or someone else propose a change, please post a link here... Thanks, On Tue, Dec 1, 2015 at 6:27 AM Vladimir Kozhukalov wrote: > Thomas, > > You are right about two independent modules in the repo. That is because > the former intention was to get rid of fuel-mirror (and fuel-createmirror) > and perestroika and leave only packetary there. Packetary is to be > developed so it is able to build not only repositories but packages as > well. So we'll be able to remove perestroika once it is ready. Two major > capabilities of fuel-mirror are: > 1) create mirror (and partial mirror) and packetary can be used for this > instead > 2) apply mirror to nailgun (which is rather a matter of python-fuelclient) > So fuel-mirror also should be removed in the future to avoid functionality > duplication. > > Those were the reasons not to put them separately. (C) "There can be only > one". > > > > > > Vladimir Kozhukalov > > On Tue, Dec 1, 2015 at 1:25 PM, Thomas Goirand wrote: > >> On 12/01/2015 09:25 AM, Mike Scherbakov wrote: >> > 4. I don't quite understand how repo is organized. I see a lot of >> > Python code regarding to fuel-mirror itself and packetary, which is >> > used as fuel-mirrors core and being written and maintained mostly by >> > Bulat [5]. There are seem to be bash scripts now related to >> > Perestroika, and. I don't quite get how these things relate each to >> > other, and if we expect core reviewers to be merging code into both >> > Perestroika and Packetary? Unless mission of repo, code gets clear, >> > I'd abstain from giving +1... >> >> Also, why isn't packetary living in its own repository? It seems wrong >> to me to have 2 python modules living in the same source repo, unless >> they share the same egg-info. It feels weird to have to call setup.py >> install twice in the resulting Debian source package. That's not how >> things are done elsewhere, and I'd like to avoid special cases, just >> because it's fuel... >> >> Cheers, >> >> Thomas Goirand (zigo) >> >> >> __ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Mike Scherbakov #mihgen __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Fuel] Nominating Dmitry Burmistrov to core reviewers of fuel-mirror
Thomas, You are right about two independent modules in the repo. That is because the former intention was to get rid of fuel-mirror (and fuel-createmirror) and perestroika and leave only packetary there. Packetary is to be developed so it is able to build not only repositories but packages as well. So we'll be able to remove perestroika once it is ready. Two major capabilities of fuel-mirror are: 1) create mirror (and partial mirror) and packetary can be used for this instead 2) apply mirror to nailgun (which is rather a matter of python-fuelclient) So fuel-mirror also should be removed in the future to avoid functionality duplication. Those were the reasons not to put them separately. (C) "There can be only one". Vladimir Kozhukalov On Tue, Dec 1, 2015 at 1:25 PM, Thomas Goirand wrote: > On 12/01/2015 09:25 AM, Mike Scherbakov wrote: > > 4. I don't quite understand how repo is organized. I see a lot of > > Python code regarding to fuel-mirror itself and packetary, which is > > used as fuel-mirrors core and being written and maintained mostly by > > Bulat [5]. There are seem to be bash scripts now related to > > Perestroika, and. I don't quite get how these things relate each to > > other, and if we expect core reviewers to be merging code into both > > Perestroika and Packetary? Unless mission of repo, code gets clear, > > I'd abstain from giving +1... > > Also, why isn't packetary living in its own repository? It seems wrong > to me to have 2 python modules living in the same source repo, unless > they share the same egg-info. It feels weird to have to call setup.py > install twice in the resulting Debian source package. That's not how > things are done elsewhere, and I'd like to avoid special cases, just > because it's fuel... > > Cheers, > > Thomas Goirand (zigo) > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Fuel] Nominating Dmitry Burmistrov to core reviewers of fuel-mirror
On 12/01/2015 09:25 AM, Mike Scherbakov wrote: > 4. I don't quite understand how repo is organized. I see a lot of > Python code regarding to fuel-mirror itself and packetary, which is > used as fuel-mirrors core and being written and maintained mostly by > Bulat [5]. There are seem to be bash scripts now related to > Perestroika, and. I don't quite get how these things relate each to > other, and if we expect core reviewers to be merging code into both > Perestroika and Packetary? Unless mission of repo, code gets clear, > I'd abstain from giving +1... Also, why isn't packetary living in its own repository? It seems wrong to me to have 2 python modules living in the same source repo, unless they share the same egg-info. It feels weird to have to call setup.py install twice in the resulting Debian source package. That's not how things are done elsewhere, and I'd like to avoid special cases, just because it's fuel... Cheers, Thomas Goirand (zigo) __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Fuel] Nominating Dmitry Burmistrov to core reviewers of fuel-mirror
-1 I personally know Dmitry and respect his contributions into our package management and CI systems around it. Thanks to Dmitry, a lot of bad things were prevented and many things developed which work very well. However, I don't particularly understand this proposal, and I'd like to get some clarifications. Even though I'm not a core in the repo, and far from being an expert in this area, I hope other active contributors will find my questions and concerns reasonable. I put -1 for the following reasons: 1. The most important - I'd suggest to wait until SCF [1], when we branch out stable/8.0 and reopen master for new features. Just risk management 2. Roman, are you part of core team for fuel-mirror? Unless I'm missing any Fuel-specific policy, [2] states this clear: "member of the existing core team can nominate" 3. Even though repo is fairly fresh, I'd question if numbers are good enough to become a core (17 reviews [3], 7 commits [4]) 4. I don't quite understand how repo is organized. I see a lot of Python code regarding to fuel-mirror itself and packetary, which is used as fuel-mirrors core and being written and maintained mostly by Bulat [5]. There are seem to be bash scripts now related to Perestroika, and. I don't quite get how these things relate each to other, and if we expect core reviewers to be merging code into both Perestroika and Packetary? Unless mission of repo, code gets clear, I'd abstain from giving +1... [1] https://wiki.openstack.org/wiki/Fuel/8.0_Release_Schedule [2] https://wiki.openstack.org/wiki/Governance/Approved/CoreDevProcess [3] http://stackalytics.com/report/contribution/fuel-mirror/180 [4] git log --oneline --author="Dmitry Burmistrov" | wc -l [5] https://github.com/openstack/fuel-mirror/blob/master/MAINTAINERS#L38 On Fri, Nov 27, 2015 at 6:29 AM Vitaly Parakhin wrote: > +1 > > пятница, 27 ноября 2015 г. пользователь Roman Vyalov написал: > >> Hi all, >> Dmitry is doing great work and I hope our Perestroika build system will >> become even better. >> At the moment Dmitry is core developer in our Perestroika builds system. >> But he not core reviewer in gerrit repository. >> Fuelers, please vote for Dmitry >> > > > -- > Regards, > Vitaly Parakhin. > CI Engineer | Mirantis, Inc. | http://www.mirantis.com > IRC: brain461 @ chat.freenode.net | Slack: vparakhin > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Mike Scherbakov #mihgen __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Fuel] Nominating Dmitry Burmistrov to core reviewers of fuel-mirror
+1 пятница, 27 ноября 2015 г. пользователь Roman Vyalov написал: > Hi all, > Dmitry is doing great work and I hope our Perestroika build system will > become even better. > At the moment Dmitry is core developer in our Perestroika builds system. > But he not core reviewer in gerrit repository. > Fuelers, please vote for Dmitry > -- Regards, Vitaly Parakhin. CI Engineer | Mirantis, Inc. | http://www.mirantis.com IRC: brain461 @ chat.freenode.net | Slack: vparakhin __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Fuel] Nominating Dmitry Burmistrov to core reviewers of fuel-mirror
Hi, My +1 for Dima 2015-11-27 14:19 GMT+02:00 Roman Vyalov : > Hi all, > Dmitry is doing great work and I hope our Perestroika build system will > become even better. > At the moment Dmitry is core developer in our Perestroika builds system. > But he not core reviewer in gerrit repository. > Fuelers, please vote for Dmitry > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- Sergey DevOps Engineer IRC: SergK Skype: Sergey_kul __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev