Re: [osg-users] Segfault in osgPlugins/vrml
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Falko Kellner wrote: > Hi Robert, >> Could you send the whole file you modified to osg-submission, I'll >> review it once it arrives. >> > ok, should be sent. Hi Falko, Robert - see my comments on the patch in the submission list. Regards, Jan -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mandriva - http://enigmail.mozdev.org iD8DBQFKW5FCn11XseNj94gRAv9zAKC1PCYeRl/ngkJiXodLR8rUDFqwoACgnGql xB/7phCLuRgbI+G2dl8cUcM= =ztSe -END PGP SIGNATURE- ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Segfault in osgPlugins/vrml
Hi Falko, Could you send the whole file you modified to osg-submission, I'll review it once it arrives. As for texture orientation, could you provide a model example to illustrate the problem. Robert. On Fri, Jul 10, 2009 at 9:16 AM, Falko Kellner wrote: > Hello, > > in current svn rev 10454 the openvrml plugin loading a vrml file > containing group nodes segfaults, because a node.get() is used instead > of a node.release() in convertvrmlnode(). > > Also, using absolute paths on linux systems is broken: > osgviewer myfile.wrl works > osgviewer /home/fkellner/myfile.wrl file not found. > > I compiled openvrml without javascript/spidermonkey/mozilla etc, maybe > this is the reason why any file path starting with file:// is not > working on my specific system. > > Anyways, following patch solved both > problems for me > > fkell...@bille:/data1/fkellner/osg/OpenSceneGraph/src/osgPlugins/vrml> > svn diff > Index: ReaderWriterVRML2.cpp > === > --- ReaderWriterVRML2.cpp (revision 10454) > +++ ReaderWriterVRML2.cpp (working copy) > @@ -185,7 +185,7 @@ > fileName = "file:///" + unixFileName; > #else > if (unixFileName[0] == '/') // absolute path > - fileName = "file://" + unixFileName; > + fileName = unixFileName; > #endif > else > // relative path > @@ -259,7 +259,7 @@ > // no children > } > > - return osg_group.get(); > + return osg_group.release(); > > } > > > Another question: When loading a vrml Model with ppm textures that loads > correctly in blender and for example OpenSG, the textures are flipped in > osgviewer. Can you check if this is a general problem with the ppm > importer? Other texture from e.g. jpeg or gif work fine. > > ___ > osg-users mailing list > osg-users@lists.openscenegraph.org > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
[osg-users] Segfault in osgPlugins/vrml
Hello, in current svn rev 10454 the openvrml plugin loading a vrml file containing group nodes segfaults, because a node.get() is used instead of a node.release() in convertvrmlnode(). Also, using absolute paths on linux systems is broken: osgviewer myfile.wrl works osgviewer /home/fkellner/myfile.wrl file not found. I compiled openvrml without javascript/spidermonkey/mozilla etc, maybe this is the reason why any file path starting with file:// is not working on my specific system. Anyways, following patch solved both problems for me fkell...@bille:/data1/fkellner/osg/OpenSceneGraph/src/osgPlugins/vrml> svn diff Index: ReaderWriterVRML2.cpp === --- ReaderWriterVRML2.cpp (revision 10454) +++ ReaderWriterVRML2.cpp (working copy) @@ -185,7 +185,7 @@ fileName = "file:///" + unixFileName; #else if (unixFileName[0] == '/') // absolute path -fileName = "file://" + unixFileName; +fileName = unixFileName; #endif else // relative path @@ -259,7 +259,7 @@ // no children } -return osg_group.get(); +return osg_group.release(); } Another question: When loading a vrml Model with ppm textures that loads correctly in blender and for example OpenSG, the textures are flipped in osgviewer. Can you check if this is a general problem with the ppm importer? Other texture from e.g. jpeg or gif work fine. begin:vcard fn:Falko Kellner n:Kellner;Falko org;quoted-printable;quoted-printable:Christian-Albrechts-Universit=C3=A4t zu Kiel;Institut f=C3=BCr Informatik email;internet:fkell...@mip.informatik.uni-kiel.de x-mozilla-html:FALSE url:http://www.mip.informatik.uni-kiel.de/tiki-index.php?page=Falko+Kellner version:2.1 end:vcard ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org