[GitHub] [hadoop-ozone] elek commented on a change in pull request #543: HDDS-2997. Support github comment based commands
elek commented on a change in pull request #543: HDDS-2997. Support github comment based commands URL: https://github.com/apache/hadoop-ozone/pull/543#discussion_r378842830 ## File path: .github/comment-commands/retest.sh ## @@ -1,4 +1,4 @@ -#!/usr/bin/env bash +!/usr/bin/env bash Review comment: Not intentional. Just disappeared in the fog. Thanks to catch it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #543: HDDS-2997. Support github comment based commands
elek commented on a change in pull request #543: HDDS-2997. Support github comment based commands URL: https://github.com/apache/hadoop-ozone/pull/543#discussion_r378729723 ## File path: .github/comment-commands/retest.sh ## @@ -0,0 +1,30 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +#doc: add new empty commit to trigger new CI build + +PR_URL=$(jq -r '.issue.pull_request.url' "$GITHUB_EVENT_PATH") +read -r REPO_URL BRANCH <<<"$(curl "$PR_URL" | jq -r '.head.repo.ssh_url + " " + .head.ref')" Review comment: OK, it's fixed now. Tested on the same PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #543: HDDS-2997. Support github comment based commands
elek commented on a change in pull request #543: HDDS-2997. Support github comment based commands URL: https://github.com/apache/hadoop-ozone/pull/543#discussion_r378729998 ## File path: .github/comment-commands/pending.sh ## @@ -0,0 +1,31 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +#doc: Add a REQUESTED_CHANGE type review to mark issue non-mergeable: `/pending ` +# shellcheck disable=SC2124 +MESSAGE="Marking this issue as un-mergeable as requested. + +Please use \`/ready\` comment when it's resolved. + +> $@" + +URL="$(jq -r '.issue.pull_request.url' "$GITHUB_EVENT_PATH")/reviews" +set +x #GITHUB_TOKEN Review comment: Ok. I added `set +x` to everywhere where GITHUB_TOKEN is used. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #543: HDDS-2997. Support github comment based commands
elek commented on a change in pull request #543: HDDS-2997. Support github comment based commands URL: https://github.com/apache/hadoop-ozone/pull/543#discussion_r378281735 ## File path: .github/comment-commands/retest.sh ## @@ -0,0 +1,30 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +#doc: add new empty commit to trigger new CI build + +PR_URL=$(jq -r '.issue.pull_request.url' "$GITHUB_EVENT_PATH") +read -r REPO_URL BRANCH <<<"$(curl "$PR_URL" | jq -r '.head.repo.ssh_url + " " + .head.ref')" Review comment: Seems to be a permission problem. For some reason github couldn't push. I can try to use https remote and the token as the password... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #543: HDDS-2997. Support github comment based commands
elek commented on a change in pull request #543: HDDS-2997. Support github comment based commands URL: https://github.com/apache/hadoop-ozone/pull/543#discussion_r378119516 ## File path: .github/comment-commands/pending.sh ## @@ -0,0 +1,31 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +#doc: Add a REQUESTED_CHANGE type review to mark issue non-mergeable: `/pending ` +# shellcheck disable=SC2124 +MESSAGE="Marking this issue as un-mergeable as requested. + +Please use \`/ready\` comment when it's resolved. + +> $@" + +URL="$(jq -r '.issue.pull_request.url' "$GITHUB_EVENT_PATH")/reviews" +set +x #GITHUB_TOKEN Review comment: I am not sure if github expose the token to the console or it's masked. If not masked we should either use `set +x` or never use `set -x`. Both works. Do you prefer to put it to everywhere or remove it from everwhere? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org