[Bug 1483262] Review Request: phpdoc - Documentation generator for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1483262 --- Comment #6 from Shawn Iwinski--- (In reply to Remi Collet from comment #5) > Some other issues I'll fix this and provide the updated files when I can -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505079] Review Request: php-goaop-parser-reflection - Provides reflection information, based on raw source
https://bugzilla.redhat.com/show_bug.cgi?id=1505079 --- Comment #3 from Shawn Iwinski--- (In reply to Remi Collet from comment #2) > - What do you think of raising minimal build dependency on phpparser ? > > - What do you think of raising minimal runtime dependency on phpparser ? > Is this a problem in the drupal stack (ie, is there other package which > require another version of phpparser) ? I should be able to do this. I'll verify and update this pkg. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506741] Review Request: php-stecman-symfony-console-completion - Automatic BASH completion for Symfony Console based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1506741 --- Comment #5 from Shawn Iwinski--- (In reply to Remi Collet from comment #3) > > : Fix license file name > > mv LICENCE LICENSE > > I don't think this is needed, LICENCE is valid (en_GB vs en_US) I'll fix/remove this after initial import -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505076] Review Request: php-vlucas-phpdotenv - Loads environment variables from .env
https://bugzilla.redhat.com/show_bug.cgi?id=1505076 --- Comment #4 from Shawn Iwinski--- THANKS for the review! https://pagure.io/releng/fedora-scm-requests/issue/2588 https://pagure.io/releng/fedora-scm-requests/issue/2589 https://pagure.io/releng/fedora-scm-requests/issue/2590 https://pagure.io/releng/fedora-scm-requests/issue/2591 https://pagure.io/releng/fedora-scm-requests/issue/2592 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505084] Review Request: php-pda-pheanstalk - PHP client for beanstalkd queue
https://bugzilla.redhat.com/show_bug.cgi?id=1505084 --- Comment #4 from Shawn Iwinski--- THANKS for the review! https://pagure.io/releng/fedora-scm-requests/issue/2582 https://pagure.io/releng/fedora-scm-requests/issue/2583 https://pagure.io/releng/fedora-scm-requests/issue/2584 https://pagure.io/releng/fedora-scm-requests/issue/2585 https://pagure.io/releng/fedora-scm-requests/issue/2586 https://pagure.io/releng/fedora-scm-requests/issue/2587 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506734] Review Request: php-amqplib - Pure PHP implementation of the AMQP protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1506734 --- Comment #6 from Shawn Iwinski--- THANKS for the review! https://pagure.io/releng/fedora-scm-requests/issue/2576 https://pagure.io/releng/fedora-scm-requests/issue/2577 https://pagure.io/releng/fedora-scm-requests/issue/2578 https://pagure.io/releng/fedora-scm-requests/issue/2579 https://pagure.io/releng/fedora-scm-requests/issue/2580 https://pagure.io/releng/fedora-scm-requests/issue/2581 (In reply to Remi Collet from comment #1) > Mirnor issue with local build > > 1) PhpAmqpLib\Tests\Unit\AMQPCollectionTest::testEncode080 > Failed asserting that two arrays are equal. > > Trivial fix, in tests bootstrap > date_default_timezone_set('UTC'); > > BTW, test suite passes, so not a blocker (mock), but "nice to have". I'll add this after initial import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1470842] Review Request: bazel - A fast, scalable, multi-language and extensible build system
https://bugzilla.redhat.com/show_bug.cgi?id=1470842 Zamir SUNchanged: What|Removed |Added CC||sjenn...@redhat.com Flags||needinfo?(sjenning@redhat.c ||om) --- Comment #4 from Zamir SUN --- Hi Seth, Recently packaging guidelines changed a bit. Please see if you can request for an opt-out. https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505073] Review Request: php-symfony4 - Symfony PHP framework ( version 4)
https://bugzilla.redhat.com/show_bug.cgi?id=1505073 --- Comment #3 from Shawn Iwinski--- THANKS for the review! https://pagure.io/releng/fedora-scm-requests/issue/2573 https://pagure.io/releng/fedora-scm-requests/issue/2574 https://pagure.io/releng/fedora-scm-requests/issue/2575 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506741] Review Request: php-stecman-symfony-console-completion - Automatic BASH completion for Symfony Console based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1506741 --- Comment #4 from Shawn Iwinski--- THANKS for the review! https://pagure.io/releng/fedora-scm-requests/issue/2567 https://pagure.io/releng/fedora-scm-requests/issue/2568 https://pagure.io/releng/fedora-scm-requests/issue/2569 https://pagure.io/releng/fedora-scm-requests/issue/2570 https://pagure.io/releng/fedora-scm-requests/issue/2571 https://pagure.io/releng/fedora-scm-requests/issue/2572 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 925993] Review Request: ghc-yesod-core - Yesod core library
https://bugzilla.redhat.com/show_bug.cgi?id=925993 --- Comment #14 from Jens Petersen--- Thank you, Elliot! Sorry for the delay. Hmm, fedrepo-req gives me: Error: A failure occurred while creating a new issue at https://pagure.io/api/0/releng/fedora-scm-requests/new_issue. The status code was "401". The error was "Invalid or expired token. Please visit https://pagure.io/ to get or renew your API token.". -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1502200] Review Request: ghc-hxt - A collection of tools for processing XML with Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=1502200 --- Comment #8 from Jens Petersen--- (In reply to Robert-André Mauchin from comment #7) > I don't understand why you are complicating this matter, why do you want to > apply it to *all* ghc packages? It just applies to ones with large doc, no > need to add a BR either, the user will choose to install the doc subpackage > or not. Because it affects cross-referencing in haddock documentation. If the docs for deps are missing then it affects the haddock generation. AFAIK anyway. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1502091] Review Request: python-enlighten - Enlighten Progress Bar
https://bugzilla.redhat.com/show_bug.cgi?id=1502091 Fedora Update Systemchanged: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1502091] Review Request: python-enlighten - Enlighten Progress Bar
https://bugzilla.redhat.com/show_bug.cgi?id=1502091 --- Comment #7 from Fedora Update System--- python-enlighten-1.0.6-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7157f5f23a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507775] Review Request: R-xml2 - Parse XML
https://bugzilla.redhat.com/show_bug.cgi?id=1507775 --- Comment #5 from Gwyn Ciesla--- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-xml2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506011] Review Request: nm-tray - NetworkManager tray icon
https://bugzilla.redhat.com/show_bug.cgi?id=1506011 --- Comment #8 from Gwyn Ciesla--- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nm-tray -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506961] Review Request: adobe-source-han-code-jp-fonts - Adobe OpenType UI font for mixed Latin and Japanese text
https://bugzilla.redhat.com/show_bug.cgi?id=1506961 --- Comment #4 from Gwyn Ciesla--- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/adobe-source-han-code-jp-fonts -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508002] Review Request: uTox - The lightweight Tox client
https://bugzilla.redhat.com/show_bug.cgi?id=1508002 --- Comment #1 from Sandro Mani--- I'm not sure whether address sanitizer ought to be enabled in a release build, since it is basically a memory error debugging aid. I'd go with ENABLE_ASAN=OFF and remove libasan from the BRs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 879928] Review Request: rigsofrods - Vehicle simulator based on soft-body physics
https://bugzilla.redhat.com/show_bug.cgi?id=879928 --- Comment #21 from Pavel Alexeev--- I think it just useless now. See https://github.com/RigsOfRods/rigs-of-rods/commit/17ab75843545407433dc319e1aaa6831eb854b87 Dropped. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22849976 Changes: https://github.com/Hubbitus/rpm-rigsofrods/commit/c1504cccefb9f0d1e65a2725db9427091370996d Spec: https://raw.githubusercontent.com/Hubbitus/rpm-rigsofrods/c1504cccefb9f0d1e65a2725db9427091370996d/rigsofrods.spec Srpm: http://rpm.hubbitus.info/Fedora26/rigsofrods/rigsofrods-0.4.7.0-4.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507286] Review Request: R-evaluate - Parsing and Evaluation Tools that Provide More Details than the Default
https://bugzilla.redhat.com/show_bug.cgi?id=1507286 --- Comment #5 from Fedora Update System--- R-evaluate-0.10.1-4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4b5c2b003 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted
https://bugzilla.redhat.com/show_bug.cgi?id=1438842 Jeremy Clinechanged: What|Removed |Added Status|ASSIGNED|CLOSED CC||jcl...@redhat.com Resolution|--- |RAWHIDE Last Closed||2017-11-01 18:22:37 --- Comment #16 from Jeremy Cline --- Nope, I'm just sloppy. Sorry! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507286] Review Request: R-evaluate - Parsing and Evaluation Tools that Provide More Details than the Default
https://bugzilla.redhat.com/show_bug.cgi?id=1507286 --- Comment #4 from Fedora Update System--- R-evaluate-0.10.1-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8efacd5959 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507286] Review Request: R-evaluate - Parsing and Evaluation Tools that Provide More Details than the Default
https://bugzilla.redhat.com/show_bug.cgi?id=1507286 Fedora Update Systemchanged: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506413] Review Request: R-stringr - Simple, Consistent Wrappers for Common String Operations
https://bugzilla.redhat.com/show_bug.cgi?id=1506413 Fedora Update Systemchanged: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506413] Review Request: R-stringr - Simple, Consistent Wrappers for Common String Operations
https://bugzilla.redhat.com/show_bug.cgi?id=1506413 --- Comment #6 from Fedora Update System--- R-stringr-1.2.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-970f9ecd9e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted
https://bugzilla.redhat.com/show_bug.cgi?id=1438842 Adam Williamsonchanged: What|Removed |Added CC||awill...@redhat.com --- Comment #15 from Adam Williamson --- Is there a reason this review request ticket is still open, if the review is complete and the package is imported? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1485185] Review Request: R-IRdisplay - Jupyter Display Machinery
https://bugzilla.redhat.com/show_bug.cgi?id=1485185 --- Comment #6 from Fedora Update System--- R-IRdisplay-0.4.4-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c0808690f0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493003] Review Request: R-htmlwidgets - HTML Widgets for R
https://bugzilla.redhat.com/show_bug.cgi?id=1493003 --- Comment #8 from Fedora Update System--- R-htmlwidgets-0.9-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-431120137a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger
https://bugzilla.redhat.com/show_bug.cgi?id=1507986 Sandro Manichanged: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Sandro Mani --- [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/tox [!]: Package must own all directories that it creates. => Please fix this on import by using %{_includedir}/tox/ instead of %{_includedir}/tox/* Rest is good, approved. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSD (unspecified)", "ISC", "BSD (2 clause)", "FSF All Permissive". 142 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/tox [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/tox [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #9 from Robert-André Mauchin--- Will do, thanks again for the reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 Sandro Manichanged: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #8 from Sandro Mani --- The following should be fixed rssguard.x86_64: E: non-standard-executable-perm /usr/bin/rssguard 775 Otherwise all good, approved (but please fix the permission when importing). Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated", "AGPL (v3 or later)", "BSD (3 clause) GPL (v3 or later)", "CC0", "*No copyright* BSD (3 clause)", "BSD (3 clause)". [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
[Bug 1485585] Review Request: R-htmltools - Tools for HTML
https://bugzilla.redhat.com/show_bug.cgi?id=1485585 --- Comment #6 from Fedora Update System--- R-htmltools-0.3.6-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9adfb8b53f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506428] Review Request: gnome-shell-extension-historymanager-prefix-search - Use PageUp and PageDown to search for previous GNOME Shell commands
https://bugzilla.redhat.com/show_bug.cgi?id=1506428 --- Comment #6 from Andrew Toskin--- > Please use a more meaningful name for your archive Done. Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-historymanager-prefix-search/raw/master/gnome-shell-extension-historymanager-prefix-search.spec SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-historymanager-prefix-search-10-2.fc28.src.rpm I'm not positive about this part of the process, but I've also opened an issue on RelEng's Pagure about splitting the packages. https://pagure.io/releng/issue/7124 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506429] Review Request: gnome-shell-extension-windowoverlay-icons - Show app icons on top of the windows thumbnails in Activities Overview
https://bugzilla.redhat.com/show_bug.cgi?id=1506429 --- Comment #4 from Andrew Toskin--- > Please use a more meaningful name for your archive... Done. Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-windowoverlay-icons/raw/master/gnome-shell-extension-windowoverlay-icons.spec SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-windowoverlay-icons-27-2.fc28.src.rpm I'm not positive about this part of the process, but I've also opened an issue on RelEng's Pagure about splitting the packages. https://pagure.io/releng/issue/7124 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger
https://bugzilla.redhat.com/show_bug.cgi?id=1507986 --- Comment #4 from Robert-André Mauchin--- Fixed Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/3cd73a7/toxcore.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/tox/fedora-rawhide-x86_64/00656774-toxcore/toxcore-0.1.10-2.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1477154 Fedora Update Systemchanged: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-10-17 15:20:02 |2017-11-01 14:32:31 --- Comment #25 from Fedora Update System --- meta-test-family-0.7.4-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505052] Review Request: qmdnsengine - Library for multicast DNS as per RFC 676
https://bugzilla.redhat.com/show_bug.cgi?id=1505052 --- Comment #8 from Fedora Update System--- nitroshare-0.3.4-1.fc25 qhttpengine-1.0.0-1.fc25 qmdnsengine-0.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-332b64508f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505052] Review Request: qmdnsengine - Library for multicast DNS as per RFC 676
https://bugzilla.redhat.com/show_bug.cgi?id=1505052 --- Comment #7 from Fedora Update System--- nitroshare-0.3.4-1.fc26 qhttpengine-1.0.0-1.fc26 qmdnsengine-0.1.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-eb7f0fae1e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505052] Review Request: qmdnsengine - Library for multicast DNS as per RFC 676
https://bugzilla.redhat.com/show_bug.cgi?id=1505052 Fedora Update Systemchanged: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505052] Review Request: qmdnsengine - Library for multicast DNS as per RFC 676
https://bugzilla.redhat.com/show_bug.cgi?id=1505052 --- Comment #6 from Fedora Update System--- nitroshare-0.3.4-1.fc27 qhttpengine-1.0.0-1.fc27 qmdnsengine-0.1.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-63b23de415 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506011] Review Request: nm-tray - NetworkManager tray icon
https://bugzilla.redhat.com/show_bug.cgi?id=1506011 --- Comment #7 from Raphael Groner--- https://pagure.io/releng/fedora-scm-requests/issue/2559 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506011] Review Request: nm-tray - NetworkManager tray icon
https://bugzilla.redhat.com/show_bug.cgi?id=1506011 --- Comment #6 from Raphael Groner--- Thanks for the review! https://pagure.io/releng/fedora-scm-requests/issue/2560 https://pagure.io/releng/fedora-scm-requests/issue/2561 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507704] Review Request: python-ndjson-testrunner - A test runner that outputs newline delimited JSON results
https://bugzilla.redhat.com/show_bug.cgi?id=1507704 --- Comment #7 from Fedora Update System--- python-ndjson-testrunner-1.0.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a3e216b6ac -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507235] Review Request: python-mpd2 - Python library providing a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1507235 Fedora Update Systemchanged: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System --- python-mpd2-0.5.5-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b7e3b64193 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507774] Review Request: R-commonmark - High Performance CommonMark and Github Markdown Rendering in R
https://bugzilla.redhat.com/show_bug.cgi?id=1507774 --- Comment #7 from Fedora Update System--- R-commonmark-1.4-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d1984a070a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507371] Review Request: R-brew - Templating Framework for Report Generation
https://bugzilla.redhat.com/show_bug.cgi?id=1507371 --- Comment #7 from Fedora Update System--- R-brew-1.0.6-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-61a7e84ca5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness
https://bugzilla.redhat.com/show_bug.cgi?id=1505026 Fedora Update Systemchanged: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- brightlight-5-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b221e2951 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507347] Review Request: python-jupyter-kernel-test - Machinery for testing Jupyter kernels via the messaging protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1507347 --- Comment #9 from Fedora Update System--- python-jupyter-kernel-test-0.3-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-68f1425608 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508080] Review Request: golang-github-yuin-gopher-lua - GopherLua: VM and compiler for Lua in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1508080 Robert-André Mauchinchanged: What|Removed |Added Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com QA Contact|jsmith.fed...@gmail.com | --- Comment #2 from Robert-André Mauchin --- Thanks, I'll look into rpmlint errors. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #7 from Robert-André Mauchin--- Done. Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/4c01019/rssguard.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rssguard/fedora-rawhide-x86_64/00656759-rssguard/rssguard-3.5.4-3.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507235] Review Request: python-mpd2 - Python library providing a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1507235 --- Comment #16 from Fedora Update System--- mpdris2-0.7-5.20171028git3c3fe12.fc26 python-mpd2-0.5.5-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-865887c093 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507235] Review Request: python-mpd2 - Python library providing a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1507235 Fedora Update Systemchanged: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507235] Review Request: python-mpd2 - Python library providing a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1507235 --- Comment #15 from Fedora Update System--- mpdris2-0.7-5.20171028git3c3fe12.fc27 python-mpd2-0.5.5-4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7cbd10475c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505209] Review Request: isoimagewriter - KDE ISO Image Writer
https://bugzilla.redhat.com/show_bug.cgi?id=1505209 --- Comment #11 from Fedora Update System--- isoimagewriter-0.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1503175] Review Request: thonny - Python IDE for beginners
https://bugzilla.redhat.com/show_bug.cgi?id=1503175 Ben Rosserchanged: What|Removed |Added CC||rosser@gmail.com --- Comment #2 from Ben Rosser --- Hi Aivar, Welcome to Fedora! As Sergey says, the copy of the spec here and the one in the SRPM differ. In general this is a bad idea, even though here the differences are minor/cosmetic: $ diff thonny.spec thonny/thonny.spec 11d10 < 15d13 < 31d28 < # In order to get rid of rpmlint warning I took a quick look at the spec; it generally looks pretty reasonable. I have a few initial comments: Source0: https://pypi.python.org/packages/01/ad/b9ce07063b9d6b9c5f3835b0256775feacd75de44d86f813924ee96d3f16/thonny-2.1.12.tar.gz You can replace the "2.1.12" here by the "%{version}" macro; this way whenever you bump the version of the package the Source URL will automatically be updated, too. (It's easy to forget otherwise to change the version in the URL). Also, if possible, it's better to use the "files.pythonhosted.org" URLs for PyPI, as they lack the magic hashes and are generally simpler. e.g. something like the following, where %pypi_name is "thonny": Source0: https://files.pythonhosted.org/packages/source/t/%{pypi_name}/%{pypi_name}-%{version}.tar.gz (See https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file for another example of this). While it's certainly fine to have the man page and desktop file in the spec like this, if you are the upstream maintainer, is it possible to include them in the upstream releases in the future? Distributions other than Fedora would likely benefit from them. You should also look into creating and shipping an AppData file for the package as described here: https://fedoraproject.org/wiki/Packaging:AppData. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1503461] Review Request: xxhash - Extremely fast hash algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1503461 --- Comment #14 from Fedora Update System--- root-6.10.08-1.fc25, xxhash-0.6.3-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1120788] Review Request: Rex - Tool for Automation, Remote Execution and Configuration Deployment
https://bugzilla.redhat.com/show_bug.cgi?id=1120788 --- Comment #24 from Fedora Update System--- Rex-1.5.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness
https://bugzilla.redhat.com/show_bug.cgi?id=1505026 Fedora Update Systemchanged: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness
https://bugzilla.redhat.com/show_bug.cgi?id=1505026 --- Comment #10 from Fedora Update System--- brightlight-5-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8071ee299f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507235] Review Request: python-mpd2 - Python library providing a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1507235 Fedora Update Systemchanged: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- mpdris2-0.7-5.20171028git3c3fe12.fc27, python-mpd2-0.5.5-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7cbd10475c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507704] Review Request: python-ndjson-testrunner - A test runner that outputs newline delimited JSON results
https://bugzilla.redhat.com/show_bug.cgi?id=1507704 Fedora Update Systemchanged: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- python-ndjson-testrunner-1.0.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce848c555e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507774] Review Request: R-commonmark - High Performance CommonMark and Github Markdown Rendering in R
https://bugzilla.redhat.com/show_bug.cgi?id=1507774 Fedora Update Systemchanged: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- R-commonmark-1.4-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-37612d34a8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1321081] Review Request: flwkey - Modem program for the K1EL Winkeyer series
https://bugzilla.redhat.com/show_bug.cgi?id=1321081 --- Comment #2 from Richard Shaw--- Spec URL: https://hobbes1069.fedorapeople.org/flwkey.spec SRPM URL: https://hobbes1069.fedorapeople.org/flwkey-1.2.3-2.fc26.src.rpm * Wed Nov 01 2017 Richard Shaw - 1.2.3-2 - Add appdata file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508080] Review Request: golang-github-yuin-gopher-lua - GopherLua: VM and compiler for Lua in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1508080 Jared Smithchanged: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508080] Review Request: golang-github-yuin-gopher-lua - GopherLua: VM and compiler for Lua in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1508080 Jared Smithchanged: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jared Smith --- There are a few errors and warnings from rpmlint that should probably be fixed, but the package is otherwise approved. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 83 files have unknown license. Detailed output of licensecheck in /home/jsmith/Documents/Personal/Reviews/1508080-golang-github-yuin- gopher-lua/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode, /usr/share/gocode/src/github.com [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-yuin-gopher-lua-devel , golang-github-yuin-gopher-lua-unit- test-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported
[Bug 1508510] Review Request: qtools - Simple command-line tools for sending and receiving AMQP messages
https://bugzilla.redhat.com/show_bug.cgi?id=1508510 Irina Bovermanchanged: What|Removed |Added Assignee|nob...@fedoraproject.org|acon...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508510] New: Review Request: qtools - Simple command-line tools for sending and receiving AMQP messages
https://bugzilla.redhat.com/show_bug.cgi?id=1508510 Bug ID: 1508510 Summary: Review Request: qtools - Simple command-line tools for sending and receiving AMQP messages Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ibove...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://irina.fedorapeople.org/qtools.spec SRPM URL: https://irina.fedorapeople.org/ Description: Simple command-line tools for sending and receiving AMQP messages Fedora Account System Username: irina -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 794793] Review Request: openssl-ibmpkcs11 - An openssl PKCS#11 engine
https://bugzilla.redhat.com/show_bug.cgi?id=794793 Joshua Millerchanged: What|Removed |Added Blocks|1498619 | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1404305] Review Request: bcc - BPF Compiler Collection
https://bugzilla.redhat.com/show_bug.cgi?id=1404305 Joshua Millerchanged: What|Removed |Added Blocks|1498794 | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger
https://bugzilla.redhat.com/show_bug.cgi?id=1507986 --- Comment #3 from Sandro Mani--- This also needs to be included in the license breakdown ISC --- c-toxcore-0.1.10/toxcore/crypto_core_mem.c These don't seem to actually be used so I guess it's okay to leave them out. MIT/X11 (BSD like) -- c-toxcore-0.1.10/other/bootstrap_daemon/docker/get-nodes.py c-toxcore-0.1.10/other/fun/bootstrap_node_info.py -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507985] Review Request: libfilteraudio - Lightweight audio filtering library made from webrtc code
https://bugzilla.redhat.com/show_bug.cgi?id=1507985 Sandro Manichanged: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Sandro Mani --- You should ask upstream to include a separate license file, but this is non-blocking. Package approved. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === = MUST items = C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 88 files have unknown license. [-]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present
[Bug 1508492] Review Request: flcluster - A management tool for accessing dxcluster nodes
https://bugzilla.redhat.com/show_bug.cgi?id=1508492 --- Comment #1 from Richard Shaw--- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=22843805 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508492] New: Review Request: flcluster - A management tool for accessing dxcluster nodes
https://bugzilla.redhat.com/show_bug.cgi?id=1508492 Bug ID: 1508492 Summary: Review Request: flcluster - A management tool for accessing dxcluster nodes Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: hobbes1...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://hobbes1069.fedorapeople.org//flcluster.spec SRPM URL: http://hobbes1069.fedorapeople.org//flcluster-1.0.3-1.fc26.src.rpm Description: flcluster can connect to and display data from DX cluster servers. The three most common server types are A←-R-Cluster, CC-Cluster, and DX Spider. The program is designed to work stand alone or as a helper application to fldigi. It can move call, mode, and frequency data from a spotted QSO to the appropriate fldigi controls. It can query fldigi for the same items when generating a spot report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger
https://bugzilla.redhat.com/show_bug.cgi?id=1507986 --- Comment #2 from Robert-André Mauchin--- Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/68026b4/toxcore.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/tox/fedora-rawhide-x86_64/00656750-toxcore/toxcore-0.1.10-2.fc28.src.rpm - Fixed licenses - Removed INSTALL_ROOT=%{buildroot} Thank you for all the reviews! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507235] Review Request: python-mpd2 - Python library providing a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1507235 Fedora Update Systemchanged: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507235] Review Request: python-mpd2 - Python library providing a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1507235 --- Comment #13 from Fedora Update System--- mpdris2-0.7-5.20171028git3c3fe12.fc27 python-mpd2-0.5.5-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7cbd10475c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508478] Review Request: linsim - Tool for Amateur Radio Digital Mode evaluation
https://bugzilla.redhat.com/show_bug.cgi?id=1508478 --- Comment #1 from Richard Shaw--- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=22843567 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508478] New: Review Request: linsim - Tool for Amateur Radio Digital Mode evaluation
https://bugzilla.redhat.com/show_bug.cgi?id=1508478 Bug ID: 1508478 Summary: Review Request: linsim - Tool for Amateur Radio Digital Mode evaluation Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: hobbes1...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://hobbes1069.fedorapeople.org//linsim.spec SRPM URL: http://hobbes1069.fedorapeople.org//linsim-2.0.3-1.fc26.src.rpm Description: Linsim is designed to read and then add path simulation to any monophonic wav file recorded at any sampling rate. It works particularly well with files that were created using fldigi’s audio capture and audio generate functions. The entire wav file will be saved to computer memory and then duplicated during the signal processing. The user should try to keep the length of the wav file at 20 Mg or less, but the author has tested some 200 Mg files on both Linux and Windows-8 without causing a program fault. These files were original VOAR broadcasts of about 30 minutes duration. The objective of this type of simulation is to finally measure the character error rate (CER) and bit error rate (BER) of a specific modem type and decoder design. For most modems a sequence of 1000 characters provides a sufficient level of confidence in the CER measurment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #6 from Sandro Mani--- You can also rm -rf src/qtsingleapplication in %prep to be sure, and then you don't need to include it in the license breakdown. For the rest, looks good! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507985] Review Request: libfilteraudio - Lightweight audio filtering library made from webrtc code
https://bugzilla.redhat.com/show_bug.cgi?id=1507985 --- Comment #3 from Robert-André Mauchin--- Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/8392830/libfilteraudio.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/tox/fedora-rawhide-x86_64/00656736-libfilteraudio/libfilteraudio-0.0.1-2.fc28.src.rpm - Added export LDFLAGS=%{__global_ldflags} - Added space to %changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #5 from Robert-André Mauchin--- Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/8392830/rssguard.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rssguard/fedora-rawhide-x86_64/00656729-rssguard/rssguard-3.5.4-3.fc28.src.rpm - I've fixed the license. - I've elected to remove the call to finish as it was not essential to the correct functioning of the restart function. - I've removed CONFIG+=debug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508080] Review Request: golang-github-yuin-gopher-lua - GopherLua: VM and compiler for Lua in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1508080 Jared Smithchanged: What|Removed |Added Status|NEW |ASSIGNED CC||jsmith.fed...@gmail.com QA Contact|extras...@fedoraproject.org |jsmith.fed...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060852] Review Request: flnet - Amateur Radio Net Control Station
https://bugzilla.redhat.com/show_bug.cgi?id=1060852 --- Comment #18 from Richard Shaw--- SPEC: https://hobbes1069.fedorapeople.org/flnet.spec SRPM: https://hobbes1069.fedorapeople.org/flnet-7.3.2-1.fc26.src.rpm * Wed Nov 01 2017 Richard Shaw - 7.3.2-1 - Update to latest upstream release. - Add appdata file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060852] Review Request: flnet - Amateur Radio Net Control Station
https://bugzilla.redhat.com/show_bug.cgi?id=1060852 Richard Shawchanged: What|Removed |Added Status|ASSIGNED|NEW Assignee|leamas.a...@gmail.com |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1432538] Review Request: libnsl2 - Public client interface library for NIS(YP) and NIS+
https://bugzilla.redhat.com/show_bug.cgi?id=1432538 Petr Kubatchanged: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2017-11-01 08:22:51 --- Comment #6 from Petr Kubat --- I guess this can be closed now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #4 from Sandro Mani--- > It's normal, it searches for compiled qm files, doesn't find them, so it > compiles them with lrelease-qt5. The translations work fine. Ok > He added a function called finish: Ok, yes this is pretty un-unbundlable. In this case just add the bundled virtual provides, and perhaps add a comment about why it can't be unbundled. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #3 from Robert-André Mauchin--- > in the build log, I suppose it might be related to the out-of-tree build and > that localization is potentially broken? It's normal, it searches for compiled qm files, doesn't find them, so it compiles them with lrelease-qt5. The translations work fine. > There appears to be a bundled qtsingleapplication, ideally it should be > unbundled I tried to do that, but it turns out the author "customized" the local copy of qtsingleapplication by adding functions to it. Specifically this commit: https://github.com/martinrotter/rssguard/commit/5a6870e184c92f4131c52e2b7d35e57c81ba4607#diff-b665d878174c480761afcde9c0eaa1f0 He added a function called finish: >void QtSingleApplication::finish() >{ > delete peer; peer = 0; >} If I try to build with the system qtsingleapplication, it fails because it desn't find thi finish function. I'm not sure how to proceed then. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1491216] Review Request: 5minute - Give me an instance of mine image on OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1491216 --- Comment #12 from Neal Gompa--- > %autosetup -n %{name}-%{version} This needs to be the following: > %autosetup -n %{name}-%{name}-%{version} GitHub prefixes the project name to the folder inside the tarball already. It does -. Since the tag already has the project name, it has to be repeated twice. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508384] Review Request: git-publish - Prepare and store patch revisions as git tags
https://bugzilla.redhat.com/show_bug.cgi?id=1508384 Stefan Hajnoczichanged: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) --- Comment #2 from Stefan Hajnoczi --- (In reply to Igor Gnatenko from comment #1) > * Give links to RAW text, not to html ones.. > https://raw.githubusercontent.com/stefanha/git-publish/master/git-publish. > spec > > > %build > is not needed > > > Requires: python2 >= 2.7 > is not needed > > * YOu should patch shebang to be /usr/bin/python3 > * Because /usr/bin/env is wrong > * And because python3 is the right interpreter unless there is good reason > to keep it py2 > > > Source0: > > https://github.com/stefanha/git-publish/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz > Source0:%{url}/archive/v%{version}/%{name}-%{version}.tar.gz > > --- > > Apart from this, package looks good. Did you send introduction to > de...@lists.fedoraproject.org ? Thanks for your feedback, Igor. I will address them and post an update. Will send an introduction to de...@lists.fedoraproject.org too. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508384] Review Request: git-publish - Prepare and store patch revisions as git tags
https://bugzilla.redhat.com/show_bug.cgi?id=1508384 Igor Gnatenkochanged: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508384] Review Request: git-publish - Prepare and store patch revisions as git tags
https://bugzilla.redhat.com/show_bug.cgi?id=1508384 --- Comment #1 from Igor Gnatenko--- * Give links to RAW text, not to html ones.. https://raw.githubusercontent.com/stefanha/git-publish/master/git-publish.spec > %build is not needed > Requires: python2 >= 2.7 is not needed * YOu should patch shebang to be /usr/bin/python3 * Because /usr/bin/env is wrong * And because python3 is the right interpreter unless there is good reason to keep it py2 > Source0: > https://github.com/stefanha/git-publish/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz Source0:%{url}/archive/v%{version}/%{name}-%{version}.tar.gz --- Apart from this, package looks good. Did you send introduction to de...@lists.fedoraproject.org ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508384] Review Request: git-publish - Prepare and store patch revisions as git tags
https://bugzilla.redhat.com/show_bug.cgi?id=1508384 Igor Gnatenkochanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|ignate...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508384] New: Review Request: git-publish - Prepare and store patch revisions as git tags
https://bugzilla.redhat.com/show_bug.cgi?id=1508384 Bug ID: 1508384 Summary: Review Request: git-publish - Prepare and store patch revisions as git tags Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: stefa...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://github.com/stefanha/git-publish/blob/master/git-publish.spec SRPM URL: https://kojipkgs.fedoraproject.org/work/tasks/345/22840345/git-publish-1.3-1.fc26.src.rpm Description: git-publish handles repetitive and time-consuming details of managing patch email submission. It works with individual patches as well as patch series and has support for pull request emails. Each revision is stored as a git tag including the cover letter (if any). This makes it easy to refer back to previous revisions of a patch. Numbering is handled automatically and the To:/Cc: email addresses are remembered across revisions to save you retyping them. Many projects have conventions for submitting patches. It is possible to encode them as a .gitpublish file and hooks/ scripts. This automatically uses the right settings and can run a coding style checker or linting tools before emails are sent. Fedora Account System Username: stefanha This is my first Fedora package and I have asked rjones to be my sponsor. I am the upstream maintainer for git-publish and also maintain a git-publish Copr repo here: https://copr.fedorainfracloud.org/coprs/stefanha/git-publish/. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507985] Review Request: libfilteraudio - Lightweight audio filtering library made from webrtc code
https://bugzilla.redhat.com/show_bug.cgi?id=1507985 --- Comment #2 from Sandro Mani--- As a general remark, I'm not sure whether the changelog format requires an empty line between each entry, but I'd personally recommend it because it greatly increases readability. I'll leave up to you though. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507985] Review Request: libfilteraudio - Lightweight audio filtering library made from webrtc code
https://bugzilla.redhat.com/show_bug.cgi?id=1507985 --- Comment #1 from Sandro Mani--- You should also export LDFLAGS=%{__global_ldflags} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger
https://bugzilla.redhat.com/show_bug.cgi?id=1507986 --- Comment #1 from Sandro Mani--- Created attachment 1346390 --> https://bugzilla.redhat.com/attachment.cgi?id=1346390=edit licensecheck.txt INSTALL_ROOT=%{buildroot} is usually only needed for qmake generated Makefiles and shouldn't be necessary here. Some files are BSD licensed, see licensecheck.txt attached. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #2 from Sandro Mani--- Created attachment 1346389 --> https://bugzilla.redhat.com/attachment.cgi?id=1346389=edit licensecheck.txt Actually there are a variety of licenses involved, see licensecheck.txt attached. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #1 from Sandro Mani--- There are a couple of errors like: RCC: Error in '../resources/rssguard.qrc': Cannot find file 'localizations/rssguard_cs.qm' messages in the build log, I suppose it might be related to the out-of-tree build and that localization is potentially broken? Does CONFIG+=debug actually have any effect? There appears to be a bundled qtsingleapplication, ideally it should be unbundled, otherwise you'll need to add the bundled(qtsingleapplication) provides, see [1]. Also note that qtsingleapplication is BSD licensed, hence you'd need to update the License field accordingly if you bundle. [1] https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1491216] Review Request: 5minute - Give me an instance of mine image on OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1491216 --- Comment #11 from Pavlina Moravcova Varekova--- Thanks for your advice. Files are changed Spec URL: https://people.redhat.com/pmoravec/5minute/5minute.spec SRPM URL: https://people.redhat.com/pmoravec/5minute/5minute-0.2.18-1.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php
https://bugzilla.redhat.com/show_bug.cgi?id=1508332 Remi Colletchanged: What|Removed |Added Blocks||1433919 Alias||php-icewind-smb2 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1433919 [Bug 1433919] Version 11.0.2 is avaliable -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508332] New: Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php
https://bugzilla.redhat.com/show_bug.cgi?id=1508332 Bug ID: 1508332 Summary: Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://git.remirepo.net/cgit/rpms/php/icewind/php-icewind-smb2.git/plain/php-icewind-smb2.spec?id=20b8a6f1c9312c97759b25d50ceb04eb03021c65 SRPM URL: http://rpms.remirepo.net/SRPMS/php-icewind-smb2-2.0.2-1.remi.src.rpm Description: PHP wrapper for smbclient and libsmbclient-php * Reuses a single smbclient instance for multiple requests * Doesn't leak the password to the process list * Simple 1-on-1 mapping of SMB commands * A stream-based api to remove the need for temporary files * Support for using libsmbclient directly trough libsmbclient-php Autoloader: /usr/share/php/Icewind/SMB2/autoload.php Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org