[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 Qiyu Yan changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-08-23 23:47:41 --- Comment #7 from Qiyu Yan --- Built in rawhide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 --- Comment #6 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fcitx5-lua -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 Qiyu Yan changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 Andy Mender changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Andy Mender --- Verified freshly in Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=49962023 Package approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 --- Comment #4 from Qiyu Yan --- (In reply to Andy Mender from comment #3) > Mid-submission EDIT: > Thanks for the Koji build! I was about to post my COPR build. I'll start > using Koji for this as well, since it doesn't seem to have the same issues > as COPR. > > > BuildRequires: cmake, extra-cmake-modules > > BuildRequires: gcc-c++, lua-devel > > BuildRequires: ninja-build, fcitx5-devel > > BuildRequires: gettext-devel > > Requires: fcitx5-data > > Could you split these into individual lines for better readability? > > Also, it's probably a good idea to use the "pkgconfig(foo)" format for the > dependencies inside fcitx5-devel if possible. In the fcitx5-qt package you > used something like this: > > BuildRequires: pkgconfig(Fcitx5Utils) > > And in fcitx5-rime something like this: > > BuildRequires: pkgconfig(Fcitx5Core) > > BuildRequires: pkgconfig(Fcitx5Module) > > > %files -f %{name}.lang > > %license LICENSES/LGPL-2.1-or-later.txt > > %doc README.md > > %{_libdir}/fcitx5/luaaddonloader.so > > %{_datadir}/fcitx5/* > > > > %files devel > > %{_includedir}/Fcitx5/* > > %{_libdir}/cmake/* > > Mid-submission EDIT: > I saw you fixed the wildcards in the -devel subpackage, but I think the one > used in the main package could also be improved: > %{_datadir}/fcitx5/* changed to: > %{_datadir}/fcitx5/addon/imeapi.conf # the %{_datadir}/fcitx5/addon dir > is owned by another fcitx5 package > %{_datadir}/fcitx5/addon/luaaddonloader.conf > %{_datadir}/fcitx5/lua > > Above are fixed > Package Review > == > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > === > - Package installs properly. > Note: Installation errors (see attachment) > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ > > > = MUST items = > > C/C++: > [x]: Package does not contain kernel modules. > [x]: Package contains no static executables. > [x]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. > Review: The unversioned SO file luaaddonloader.so is for internal use > only. > Ignore error. > [x]: If your application is a C or C++ application you must list a > BuildRequires against gcc, gcc-c++ or clang. > [x]: Header files in -devel subpackage, if present. > [x]: Package does not contain any libtool archives (.la) > [x]: Rpath absent or only used for internal libs. > > Generic: > [x]: Package successfully compiles and builds into binary rpms on at least > one supported primary architecture. > Note: Using prebuilt packages > Review: Tested in COPR. > [x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated". 49 files have unknown license. Detailed > output of licensecheck in > /home/amender/rpmbuild/SPECS/fcitx5-lua/fcitx5-lua/licensecheck.txt > [x]: License file installed when any subpackage combination is installed. > [x]: Package requires other packages for directories it uses. > Note: No known owner of /usr/include/Fcitx5, /usr/share/fcitx5, > /usr/lib64/fcitx5 > Review: Bogus, fcitx5-data and fcitx5-devel are listed as requirements. > /usr/lib64/fcitx5 is owned by fcitx5-libs and picked up automatically > via autodep. > [x]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/fcitx5, > /usr/lib64/fcitx5, /usr/include/Fcitx5 > Review: same as above. > [x]: %build honors applicable compiler flags or justifies otherwise. > [x]: Package contains no bundled libraries without FPC exception. > [x]: Changelog in prescribed format. > Review: Yes, even though rpmlint complains. > [x]: Sources contain only permissible code or content. > [-]: Package contains desktop file if it is a GUI application. > [x]: Development files must be in a -devel package > [?]: Package uses nothing in %doc for runtime. > [x]: The spec file handles locales properly. > [x]: Package consistently uses macros (instead of hard-coded directory > names). > [x]: Package is named according to the Package Naming Guidelines. > [x]: Package does not generate any conflict. > [x]: Package obeys FHS, except libexecdir and /usr/target. > [x]: If the package is a rename of another package, proper Obsoletes and > Provides are present. > [x]: Requires correct, justified where necessary. > Review: Yes, but see the earlier pkgconfig(foo) comments. > [x]: Spec file is legible and written in American English. > [-]: Pack
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 Qiyu Yan changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-33-x86_64/01626593-fcitx5-lua/fcitx5-lua.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-33-x86_64/01626593-fcitx5-lua/fcitx5-lua-0-0.2.20200812gitd705404.fc33.src.rpm Description: Lua support for fcitx. Fedora Account System Username: yanqiyu -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 --- Comment #3 from Andy Mender --- Mid-submission EDIT: Thanks for the Koji build! I was about to post my COPR build. I'll start using Koji for this as well, since it doesn't seem to have the same issues as COPR. > BuildRequires: cmake, extra-cmake-modules > BuildRequires: gcc-c++, lua-devel > BuildRequires: ninja-build, fcitx5-devel > BuildRequires: gettext-devel > Requires: fcitx5-data Could you split these into individual lines for better readability? Also, it's probably a good idea to use the "pkgconfig(foo)" format for the dependencies inside fcitx5-devel if possible. In the fcitx5-qt package you used something like this: > BuildRequires: pkgconfig(Fcitx5Utils) And in fcitx5-rime something like this: > BuildRequires: pkgconfig(Fcitx5Core) > BuildRequires: pkgconfig(Fcitx5Module) > %files -f %{name}.lang > %license LICENSES/LGPL-2.1-or-later.txt > %doc README.md > %{_libdir}/fcitx5/luaaddonloader.so > %{_datadir}/fcitx5/* > > %files devel > %{_includedir}/Fcitx5/* > %{_libdir}/cmake/* Mid-submission EDIT: I saw you fixed the wildcards in the -devel subpackage, but I think the one used in the main package could also be improved: %{_datadir}/fcitx5/* changed to: %{_datadir}/fcitx5/addon/imeapi.conf # the %{_datadir}/fcitx5/addon dir is owned by another fcitx5 package %{_datadir}/fcitx5/addon/luaaddonloader.conf %{_datadir}/fcitx5/lua Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Review: The unversioned SO file luaaddonloader.so is for internal use only. Ignore error. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages Review: Tested in COPR. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 49 files have unknown license. Detailed output of licensecheck in /home/amender/rpmbuild/SPECS/fcitx5-lua/fcitx5-lua/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/Fcitx5, /usr/share/fcitx5, /usr/lib64/fcitx5 Review: Bogus, fcitx5-data and fcitx5-devel are listed as requirements. /usr/lib64/fcitx5 is owned by fcitx5-libs and picked up automatically via autodep. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/fcitx5, /usr/lib64/fcitx5, /usr/include/Fcitx5 Review: same as above. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. Review: Yes, even though rpmlint complains. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [?]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. Review: Yes, but see the earlier pkgconfig(foo) comments. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation siz
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 --- Comment #2 from Qiyu Yan --- A koji buid: https://koji.fedoraproject.org/koji/taskinfo?taskID=49952759 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 --- Comment #1 from Qiyu Yan --- Hi, I just updated %files devel part, if you are running build, you can kill that and restart with the new version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 Qiyu Yan changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-33-x86_64/01626583-fcitx5-lua/fcitx5-lua.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-33-x86_64/01626583-fcitx5-lua/fcitx5-lua-0-0.2.20200812gitd705404.fc33.src.rpm Description: Lua support for fcitx. Fedora Account System Username: yanqiyu -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 Qiyu Yan changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-rawhide-x86_64/01614375-fcitx5-lua/fcitx5-lua.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-rawhide-x86_64/01614375-fcitx5-lua/fcitx5-lua-0-0.2.gitd705404.fc34.src.rpm Description: Lua support for fcitx. Fedora Account System Username: yanqiyu -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 Bug 1868854 depends on bug 1868846, which changed state. Bug 1868846 Summary: Review Request: fcitx5 - Next generation of fcitx https://bugzilla.redhat.com/show_bug.cgi?id=1868846 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 Qiyu Yan changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-rawhide-x86_64/01612180-fcitx5-lua/fcitx5-lua.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-rawhide-x86_64/01612180-fcitx5-lua/fcitx5-lua-0-0.2.gitd705404.fc34.src.rpm Description: Lua support for fcitx. Fedora Account System Username: yanqiyu -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 Qiyu Yan changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-rawhide-x86_64/01607821-fcitx5-lua/fcitx5-lua.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-rawhide-x86_64/01607821-fcitx5-lua/fcitx5-lua-0-0.1.20200812gitd705404.fc33.src.rpm Description: Lua support for fcitx. Fedora Account System Username: yanqiyu -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 Qiyu Yan changed: What|Removed |Added Blocks||1868850 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1868850 [Bug 1868850] Review Request: fcitx5-chinese-addons - Chinese related addon for fcitx5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854 Qiyu Yan changed: What|Removed |Added Depends On||1868846 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1868846 [Bug 1868846] Review Request: fcitx5 - Next generation of fcitx -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org