[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560

Zamir SUN  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-07-22 09:29:48



--- Comment #13 from Zamir SUN  ---
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging
effort.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/P2W7OPGOX4MXLLMHJDXMMAX4KYJBQ5MU/

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-desktop-schemas



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
deepin-desktop-schemas-3.1.16-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-198295a453

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560



--- Comment #11 from Fedora Update System  ---
deepin-desktop-schemas-3.1.16-1.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-198295a453

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560



--- Comment #10 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-desktop-schemas

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Robert-André Mauchin  ---
Perfect, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560



--- Comment #8 from sensor@gmail.com ---
https://github.com/FZUG/repo/commit/1c772c17c2d750f2d4faad05abeeb4532b19b2d1

Release 3.1.16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #7 from Robert-André Mauchin  ---
@mosquito: There's a new release, 3.1.16 See
https://github.com/linuxdeepin/deepin-desktop-schemas/releases

Once you bump the version, I'll accept the package.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 105 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/deepin-desktop-schemas/review-deepin-
 desktop-schemas/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section 

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1476590




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1476590
[Bug 1476590] Review Request: deepin-daemon - Daemon handling the DDE
session settings
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #6 from Robert-André Mauchin  ---
Have you proposed deepin-artwork-themes and deepin-gtk-theme yet?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560



--- Comment #5 from sensor@gmail.com ---
Diff: 
https://github.com/FZUG/repo/commit/260e289c3ff55635f076bcf3992895a0d338a1c6

Ok, thanks :)  It deleted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
Oops, sorry. My comment about glib-compile-schemas was wrong. I trusted
fedora-review without checking the guidelines, but
/usr/bin/glib-compile-schemas should not be called since F24 (#1409315). So
please remove those calls again.

Looks good otherwise, I'll re-review when deepin-artwork-themes review is done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560



--- Comment #3 from sensor@gmail.com ---
SPEC: 
https://raw.githubusercontent.com/FZUG/repo/5e57f37830e634919c2c440cf8a5fb2311ca2e7e/rpms/deepin_project/deepin-desktop-schemas.spec

Fixed :)
I will be submit deepin-artwork-themes package for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

Ahh, deepin-artwork-themes. I don't think you submitted that for review yet.

- glib-compile-schemas is run in %postun and %posttrans if package has
  *.gschema.xml files.
  Note: gschema file(s) in deepin-desktop-schemas
  See:
  http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks||1421058




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1421058
[Bug 1421058] Review Request: deepin-metacity - 2D window manager for
Deepin
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560



--- Comment #1 from sensor@gmail.com ---
SPEC:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00585733-deepin-desktop-schemas/deepin-desktop-schemas.spec
SRPM:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00585733-deepin-desktop-schemas/deepin-desktop-schemas-3.1.15-1.fc25.src.rpm

Release 3.1.15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560

Zamir SUN  changed:

   What|Removed |Added

 Blocks||1465889
   ||(DeepinDEPackageReview)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org