[Bug 1531380] Review Request: perl-Path-Iter - Simple Efficient Path Iteration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531380



--- Comment #19 from Fedora Update System  ---
perl-Path-Iter-0.2-1.fc27 has been pushed to the Fedora 27 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529593] Review Request: adapta-gtk-theme - An adaptive Gtk+ theme based on Material Design Guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529593

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #22 from Fedora Update System  ---
adapta-gtk-theme-3.93.0.66-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-9789110634

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535549] Review Request: mupen64plus - Nintendo 64 Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535549

Antonio Trande  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|anto.tra...@gmail.com   |nob...@fedoraproject.org
  Flags|fedora-review?  |



--- Comment #9 from Antonio Trande  ---
I'm leaving this package to Robert-André, who cannot do without comment this
ticket.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
ejabberd-18.01-1.fc27, erlang-base64url-1.0-1.fc27,
erlang-cache_tab-1.0.12-1.fc27, erlang-esip-1.0.21-1.fc27,
erlang-ezlib-1.0.3-1.fc27, erlang-fast_tls-1.0.20-1.fc27,
erlang-fast_xml-1.1.28-1.fc27, erlang-fast_yaml-1.0.12-1.fc27,
erlang-fs-4.1-2.fc27, erlang-jose-1.8.4-1.fc27, erlang-stun-1.0.20-1.fc27,
erlang-xmpp-1.1.19-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d1658ffde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534261] Review Request: erlang-base64url - URL safe base64-compatible codec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534261

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
ejabberd-18.01-1.fc27, erlang-base64url-1.0-1.fc27,
erlang-cache_tab-1.0.12-1.fc27, erlang-esip-1.0.21-1.fc27,
erlang-ezlib-1.0.3-1.fc27, erlang-fast_tls-1.0.20-1.fc27,
erlang-fast_xml-1.1.28-1.fc27, erlang-fast_yaml-1.0.12-1.fc27,
erlang-fs-4.1-2.fc27, erlang-jose-1.8.4-1.fc27, erlang-stun-1.0.20-1.fc27,
erlang-xmpp-1.1.19-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d1658ffde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534268] Review Request: erlang-jose - JSON Object Signing and Encryption (JOSE) for Erlang and Elixir

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534268

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
ejabberd-18.01-1.fc27, erlang-base64url-1.0-1.fc27,
erlang-cache_tab-1.0.12-1.fc27, erlang-esip-1.0.21-1.fc27,
erlang-ezlib-1.0.3-1.fc27, erlang-fast_tls-1.0.20-1.fc27,
erlang-fast_xml-1.1.28-1.fc27, erlang-fast_yaml-1.0.12-1.fc27,
erlang-fs-4.1-2.fc27, erlang-jose-1.8.4-1.fc27, erlang-stun-1.0.20-1.fc27,
erlang-xmpp-1.1.19-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d1658ffde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532696] Review Request: gcin - An input method focused on Chinese users

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532696

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
gcin-2.8.5-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-16c106298c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531380] Review Request: perl-Path-Iter - Simple Efficient Path Iteration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531380

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-21 07:33:48



--- Comment #18 from Fedora Update System  ---
perl-Path-Iter-0.2-1.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536827] New: Review Request: rust-pest_derive - Pest's derive macro

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536827

Bug ID: 1536827
   Summary: Review Request: rust-pest_derive - Pest's derive macro
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-pest_derive.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-pest_derive-1.0.1-1.fc28.src.rpm
Description:
Pest's derive macro.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 972346] Review Request: ros-common_msgs - Common ROS Messages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=972346

Tim Niemueller  changed:

   What|Removed |Added

 CC||thofm...@fedoraproject.org,
   ||t...@niemueller.de



--- Comment #9 from Tim Niemueller  ---
You might want to look into what Till (CC) has done.

https://copr.fedorainfracloud.org/coprs/thofmann/ros/
https://pagure.io/ros

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536780] Review Request: swift-lang - Apple' s Swift Programming Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536780



--- Comment #4 from Ron Olson  ---
Yep, I realized I needed to explicitly limit the architectures. I have limited
it to only x86_64, added the pod2man dependency, reorganized the %prep section,
and it builds on my machine and I uploaded the new files
(https://tachoknight.fedorapeople.org/swift-lang/), but when I uploaded that
srpm to Koji it dies in a new place:
http://koji.fedoraproject.org/koji/taskinfo?taskID=24356831.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536878] New: Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536878

Bug ID: 1536878
   Summary: Review Request: elementary-wallpapers - Collection of
wallpapers from the elementary project
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://decathorpe.fedorapeople.org/packages/elementary-wallpapers.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/elementary-wallpapers-0-0.1.20171230.git4f5b8e4.fc27.src.rpm

Description:
This is the official collection of wallpapers from the elementary
project.

Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24355209


This is a **RENAME** of my "pandora-wallpapers" package, and this one will
obsolete it - please check that the Obsoletes: and Provides: tags I have added
are correct (I have checked the upgrade path locally).

Additionally, I have added a settings file so the wallpapers will show up in
GNOME Control Center, when the appropriate "-gnome" subpackage is installed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536870] Review Request: agenda - Simple, fast, no-nonsense to-do ( task) list

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536870

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - Headers for the source files seems to indicate it is licensed under LGPLv3:

LGPL (v3)
-
agenda-1.0.9/src/Agenda.vala
agenda-1.0.9/src/AgendaWindow.vala

Copyright (C) 2014-2017 Agenda Developers

This program is free software: you can redistribute it and/or modify it
under the terms of the GNU Lesser General Public License version 3, as
published by the Free Software Foundation.

Ask for clarification upstream, specifically to fix the headers if they have
indeed switched to GPLv3.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "LGPL (v3)", "GPL (v3 or later)", "Unknown or
 generated". 64 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/agenda/review-
 agenda/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and 

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #1 from Antonio Trande  ---
- Are you sure that 'qca' (or qca-qt5?) is required for building?

- Make arch-specific the 'openbabel' explicit request:
Requires:  openbabel%{?_isa}

- devel subpackage requires the main package (that contains libmolsketch.so):
Requires: %{name}%{?_isa} = %{version}-%{release}

- Remove that macros in comments or use %% for disabling them.

- Use %make_install in the %install section

- Remove INSTALL as documentation

- %{_libdir}/lib*.so* installs unversioned libraries too. Change it with
  %{_libdir}/lib*.so.*

- Regarding your question on devel mailing list, there could be a problem with
some architectures (like s390x) about how to set correctly the libraries
directory.
In particular, 

obabeliface/obabeliface.pro
libmolsketch/libmolsketch.pro

contain a "DESTDIR = ../lib" line. To fix try to add the option
""MSK_INSTALL_LIBS=%{_libdir}" to qmake's line.

- Set MSK_INSTALL_INCLUDES to %{_includedir}/lib%{name}

- /usr/share/icons/hicolor/scalable/mimetypes must not be owned by this
package.

- doc is a stand-alone package, it must provide an own license file.

- Most files are licensed under GPLv2+ license; you can use it as License file
i guess.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Header files in -devel subpackage, if present.
  Note: molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/TextInputItem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/abstractxmlobject.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/abstractitemaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/abstractrecursiveitemaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/alignmentaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/arrowtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/arrowtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/bondtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/bondtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/coloraction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/connectaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/deleteaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/drawaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/flipbondaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/flipstereobondsaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/frameaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/frametypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/frametypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/genericaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/incdecaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/itemgrouptypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/itemtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/itemtypeselectionaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/itemtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/linewidthaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/mechanismarrowaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/multiaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/periodictablewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/reactionarrowaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/ringaction.h
  

[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536878

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536873] New: Review Request: dippi - Calculate display info like DPI and aspect ratio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536873

Bug ID: 1536873
   Summary: Review Request: dippi - Calculate display info like
DPI and aspect ratio
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://decathorpe.fedorapeople.org/packages/dippi.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/dippi-2.5.1-1.fc27.src.rpm

Description:
Analyze any display. Input a few simple details and figure out the
aspect ratio, DPI, and other details of a particular display. Great for
deciding which laptop or external monitor to purchase, and if it would
be considered HiDPI.

Handy features:
- Find out if a display is a good choice based on its size and resolution
- Get advice about different densities
- Differentiates between laptops and desktop displays
- Stupid simple: all in a cute li'l window


Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24354200


Packager's comments:
The "invalid-lc-messages-dir" rpmlint errors for the "bh" and "mo" locales
seems to be outdated, there's already a lot of packages that supply
translations for those languages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534050] Review Request: python-nixio - Python bindings for NIX

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534050



--- Comment #6 from Raphael Groner  ---
Please show the adjusted spec file.

There are several skipped tests in build.log, can you explain why? Maybe caused
from missing dependencies.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534050] Review Request: python-nixio - Python bindings for NIX

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534050



--- Comment #7 from Ankur Sinha (FranciscoD)  ---
https://github.com/sanjayankur31/rpm-specs/blob/python-nixio/python-nixio.spec

Those tests are skipped because nix cpp is not available (nixio.core is not
built). As noted in the spec, upstream intends to remove this requirement
completely and suggested that it be built without the nix cpp bits.

https://github.com/G-Node/nixpy/pull/276

Cheers!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536882] New: Review Request: harvey - Color contrast checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536882

Bug ID: 1536882
   Summary: Review Request: harvey - Color contrast checker
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://decathorpe.fedorapeople.org/packages/harvey.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/harvey-0.1.8-1.fc27.src.rpm

Description:
Harvey is a color contrast checker. It checks a given set of colors for
WCAG contrast compliance.

Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24356624

Packager's comments:
The "invalid-lc-messages-dir" rpmlint errors for the "bh" and "mo" locales seem
to be outdated, there's already a lot of packages that supply translations for
those languages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536870] New: Review Request: agenda - Simple, fast, no-nonsense to-do (task) list

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536870

Bug ID: 1536870
   Summary: Review Request: agenda - Simple, fast, no-nonsense
to-do (task) list
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://decathorpe.fedorapeople.org/packages/agenda.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/agenda-1.0.9-1.fc27.src.rpm

Description: A simple, fast, no-nonsense to-do (task) list.
Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24353592

Packager's comments:
Upstream has added a LICENSE file since the packaged release, so I'll include
that as %license with the update to the next release - when it will be tagged
eventually.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534787] Review Request: python-fastavro - Fast Avro for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534787

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
All good, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536780] Review Request: swift-lang - Apple' s Swift Programming Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536780



--- Comment #3 from Robert-André Mauchin  ---
 - Please split your BR on multiple lines.


 - It seems you're missing a /usr/bin/pod2man dependency, provided by
perl-podlators.

CMake Error at cmake/modules/SwiftManpage.cmake:23 (message):
  Need pod2man installed to generate man page
Call Stack (most recent call first):
  docs/tools/CMakeLists.txt:3 (manpage)
-- Configuring incomplete, errors occurred!

 - Sphinx would be useful to build the docs:

CMake Warning at docs/CMakeLists.txt:24 (message):
  Unable to find sphinx-build program.  Not building docs

 - Tried to build in Koji: i686 is no go:

NotImplementedError: System "Linux" with architecture "i686" is not supported
/var/tmp/apple-swift/swift/utils/build-script: fatal error: command terminated
with a non-zero exit status 1, aborting

https://swift.org/blog/swift-linux-port/

"Currently x86_64 is the only supported architecture on Linux."

   I guess you should define an ExclusiveArches specifically for swift-lang.
You should also consider making a srpm package:

swift-srpm-macros.noarch : RPM macros for building Swift source packages

  It would contain a file:

/usr/lib/rpm/macros.d/macros.swift-srpm

   which defines macros specific to your language. For example:

%swift_arches x86_64

 - I haven't been able to build it on my sytems, it segfaults after 45 mn.
Fails on Koji too: https://koji.fedoraproject.org/koji/taskinfo?taskID=24356781


>I am currently trying to remove the dependency on building everything and 
>using the Fedora-supplied packages for Clang, LLVM, etc., is it okay that I 
>keep updating the spec file and comment on this ticket?

Yes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534787] Review Request: python-fastavro - Fast Avro for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534787



--- Comment #4 from Ankur Sinha (FranciscoD)  ---
Thanks for the review. Here's the updated spec/srpm:

https://ankursinha.fedorapeople.org/python-fastavro/python-fastavro.spec
https://ankursinha.fedorapeople.org/python-fastavro/python-fastavro-0.17.3-1.fc27.src.rpm

Changelog:

* Sun Jan 21 2018 Ankur Sinha  - 0.17.3-1
- Update for review (rhbz#1534787)
- Update to latest upstream release
- Generate separate doc subpackage for docs
- Install man page
- Rectify license
- Fix tests

Cheers!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 972346] Review Request: ros-common_msgs - Common ROS Messages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=972346



--- Comment #8 from Ankur Sinha (FranciscoD)  ---
Rich, are we still interested in packaging up ROS at the moment? (I've moved on
from Robotics myself, so I'm not into ROS anymore). 

Cheers :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536780] Review Request: swift-lang - Apple' s Swift Programming Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536780

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Hardware|x86_64  |All
 Whiteboard||NotReady



--- Comment #2 from Neal Gompa  ---
Yes, that's fine. Please keep providing updated progress in the form of spec +
srpm links and details as you go along.

When it is ready, please remove the "NotReady" marker from the whiteboard field
in this ticket.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534050] Review Request: python-nixio - Python bindings for NIX

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534050



--- Comment #5 from Ankur Sinha (FranciscoD)  ---
I've updated the package as you'd suggested. Scratch build here: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=24347793

* Sun Jan 21 2018 Ankur Sinha  - 1.4.3-1
- Use newer release and GitHub sources
- Run tests
- Define summary macro
- Add doc sub package

Requesting SCM now.

Cheers!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] New: Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852

Bug ID: 1536852
   Summary: Review Request: molsketch - Molecular Structures
Editor
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: alex.ploumis...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL:
https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-2.fc28.src.rpm

Description: Molsketch is a 2D molecular editing tool. Its goal is to help you
draw molecules quickly and easily. Of course your creation can be exported
afterwards in high quality, in a number of vector and bitmap formats.

Fedora Account System Username: alexpl

COPR repo: https://copr.fedorainfracloud.org/coprs/alexpl/molsketch/

koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24348629


A good 2D molecular drawing program is among the most rudimentary tools for a
chemist and one that's been sorely missing from Fedora. The ones that we have
kept around are either dead upstream, missing basic features, bug-ridden or all
of the above.
Molsketch was in limbo for quite sometime, but there is a new lead developer
willing to modernize the program, who's been cleaning up the code and adding
missing features. I have been working closely with him for the past year and
I've also had friends and colleagues use the package from COPR and give
feedback.

The package fails to build on s390x at the moment and I will get in touch with
the SIG for that arch, but since it is not a primary architecture, there
shouldn't be any problem with accepting the package in its current state.

The first spec file I had used was adapted from OpenSUSE and I still have some
doubts about the qt requirements, since we have different packages in Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536827] Review Request: rust-pest_derive - Pest's derive macro

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536827

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536827] Review Request: rust-pest_derive - Pest's derive macro

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536827

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||anto.tra...@gmail.com
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536782] Review Request: golang-github-cryptix-wav - golang wav reader and writer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536782



--- Comment #1 from Robert-André Mauchin  ---

 - add examples/ to %doc

 - when you package a development snapshot, you must add the commit date in
Release:

%global   commit  7b3d650b50a50a0137376e392770f372edc3d968
%global   shortcommit %(c=%{commit}; echo ${c:0:7})
%global   commitdate  20171018

Name:   golang-%{provider}-%{project}-%{repo}
Version:0
Release:0.1.%{commitdate}git%{shortcommit}%{?dist}


   And in %changelog:

* Thu Dec 21 2017 mosquito  - 0-0.1.20171018git7b3d650

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org