Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
Kai-Uwe, Do you want to forward-port this patch to plasma-framework, or should I do it? (I sense that this might be the reason for CCMAILing me. :-)) -- sebas On Thursday, June 20, 2013 08:57:17 Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- Review request for Plasma. Description --- This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive. Diffs - plasma/declarativeimports/core/datamodel.h 0943b68 plasma/declarativeimports/core/datamodel.cpp f81e579 Diff: http://git.reviewboard.kde.org/r/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 22, 2013, 2:42 p.m.) Review request for Plasma. Changes --- Emit a signal when sort order changes. I have no idea whether this is the right apporach or if that works. All I can say is that it compiles but I tried my best :-) Description --- This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive. Diffs (updated) - plasma/declarativeimports/core/datamodel.h 0943b68 plasma/declarativeimports/core/datamodel.cpp f81e579 Diff: http://git.reviewboard.kde.org/r/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34881 --- Ship it! For absolute completeness, the sortCaseSensitivity property should also have a NOTIFY signal .. but i don't see why anyone would ever bind to that signal and it would require a reimplementation of the set method, so i'm fine with it going in without .. so a +1 from me; if Marco can confirm then this is good to go in. - Aaron J. Seigo On June 22, 2013, 2:42 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 22, 2013, 2:42 p.m.) Review request for Plasma. Description --- This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive. Diffs - plasma/declarativeimports/core/datamodel.h 0943b68 plasma/declarativeimports/core/datamodel.cpp f81e579 Diff: http://git.reviewboard.kde.org/r/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
On June 22, 2013, 3:24 p.m., Aaron J. Seigo wrote: For absolute completeness, the sortCaseSensitivity property should also have a NOTIFY signal .. but i don't see why anyone would ever bind to that signal and it would require a reimplementation of the set method, so i'm fine with it going in without .. so a +1 from me; if Marco can confirm then this is good to go in. my blessings :p - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34881 --- On June 22, 2013, 2:42 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 22, 2013, 2:42 p.m.) Review request for Plasma. Description --- This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive. Diffs - plasma/declarativeimports/core/datamodel.h 0943b68 plasma/declarativeimports/core/datamodel.cpp f81e579 Diff: http://git.reviewboard.kde.org/r/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34884 --- This review has been submitted with commit 49fcb63e705420da8dcdda71e49d5e6a15d1c704 by Kai Uwe Broulik to branch master. - Commit Hook On June 22, 2013, 2:42 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 22, 2013, 2:42 p.m.) Review request for Plasma. Description --- This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive. Diffs - plasma/declarativeimports/core/datamodel.h 0943b68 plasma/declarativeimports/core/datamodel.cpp f81e579 Diff: http://git.reviewboard.kde.org/r/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 22, 2013, 3:30 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Description --- This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive. Diffs - plasma/declarativeimports/core/datamodel.h 0943b68 plasma/declarativeimports/core/datamodel.cpp f81e579 Diff: http://git.reviewboard.kde.org/r/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34813 --- the patch is almost ok, tough can you still find a way to make it emit a sortOrderChanged signal? - Marco Martin On June 20, 2013, 9:41 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 20, 2013, 9:41 a.m.) Review request for Plasma. Description --- This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive. Diffs - plasma/declarativeimports/core/datamodel.h 0943b68 Diff: http://git.reviewboard.kde.org/r/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- Review request for Plasma. Description --- This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive. Diffs - plasma/declarativeimports/core/datamodel.h 0943b68 plasma/declarativeimports/core/datamodel.cpp f81e579 Diff: http://git.reviewboard.kde.org/r/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34738 --- plasma/declarativeimports/core/datamodel.h http://git.reviewboard.kde.org/r/48/#comment25468 is this necessary, given that there is a setSortCaseSensitivity in the parent class? - Aaron J. Seigo On June 20, 2013, 8:57 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 20, 2013, 8:57 a.m.) Review request for Plasma. Description --- This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive. Diffs - plasma/declarativeimports/core/datamodel.h 0943b68 plasma/declarativeimports/core/datamodel.cpp f81e579 Diff: http://git.reviewboard.kde.org/r/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 20, 2013, 9:41 a.m.) Review request for Plasma. Changes --- Nope, it's not needed. Reduces this patch to simply adding a Q_PROPERTY Description --- This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive. Diffs (updated) - plasma/declarativeimports/core/datamodel.h 0943b68 Diff: http://git.reviewboard.kde.org/r/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
On June 20, 2013, 9:20 a.m., Aaron J. Seigo wrote: plasma/declarativeimports/core/datamodel.h, line 94 http://git.reviewboard.kde.org/r/48/diff/1/?file=164874#file164874line94 is this necessary, given that there is a setSortCaseSensitivity in the parent class? you can bind qproperty read and write on superclass methods as well. one reason it might be necessary is because you want also a notify signal when it changes (so property bindings can work) so you can emit the signal when you set the property another way could be rechecking the sort property when the model gets reset, so the signal can be emitted there... - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34738 --- On June 20, 2013, 9:41 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 20, 2013, 9:41 a.m.) Review request for Plasma. Description --- This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive. Diffs - plasma/declarativeimports/core/datamodel.h 0943b68 Diff: http://git.reviewboard.kde.org/r/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
On June 20, 2013, 9:20 a.m., Aaron J. Seigo wrote: plasma/declarativeimports/core/datamodel.h, line 94 http://git.reviewboard.kde.org/r/48/diff/1/?file=164874#file164874line94 is this necessary, given that there is a setSortCaseSensitivity in the parent class? Marco Martin wrote: you can bind qproperty read and write on superclass methods as well. one reason it might be necessary is because you want also a notify signal when it changes (so property bindings can work) so you can emit the signal when you set the property another way could be rechecking the sort property when the model gets reset, so the signal can be emitted there... aand, i see the old property setSortorder is lacking a notify signal as well :/ it should have it too - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34738 --- On June 20, 2013, 9:41 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 20, 2013, 9:41 a.m.) Review request for Plasma. Description --- This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive. Diffs - plasma/declarativeimports/core/datamodel.h 0943b68 Diff: http://git.reviewboard.kde.org/r/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
