Re: 5.12 release: congratulations and post-mortem

[Luigi Toscano]

On Tuesday, 6 February 2018 18:34:34 CET Paul Brown wrote:
> - Establish strict deadlines for suggested changes to media (texts and
> videos) and strictly stick to said deadlines.
> 
> [EDIT: Ivana has also suggested this, but here are my thoughts too.]
> 
> So when the next-to-last draft of the announcement text or the video is
> done, it is submitted to the peers. Peers then have say, 48 hours or
> whatever to suggest/request changes.
> 
> Once the window for requests is closed only proofreading and minor
> corrections should be allowed. 24 hours before the release, no changes
> should be allowed at all.

Even 48 hours, in order to help translators.

-- 
Luigi

D10170: Added optional transparency/blur to menu frames

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D10170#202023, @anemeth wrote:
  
  > KDE4 Breeze has no trasnparency and blur anymore
  >  @hpereiradacosta can you point me to some KDE4 apps that are still in use? 
I'm just curious what hasn't been ported yet.
  
  
  Amarok at least, clementine (?), 
  vlc  (?)
  many qt4 based applications not ported to qt5, such as backintime
  
  Anyway, thanks for the updated patch !
  Lets wait for a couple more days for someone from VDG to show up (@colomar ? 
@alake ?), and if none shows up lets land it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10337: First approach to a plasmoid that can display the state of caps lock

[Aleix Pol Gonzalez]

apol updated this revision to Diff 26665.
apol added a comment.


  Also expose numlock, somewhat

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10337?vs=26638=26665

BRANCH
  arcpatch-D10337

REVISION DETAIL
  https://phabricator.kde.org/D10337

AFFECTED FILES
  applets/CMakeLists.txt
  applets/keyboardindicator/contents/ui/main.qml
  applets/keyboardindicator/metadata.desktop

To: apol, #plasma, jriddell
Cc: graesslin, abetts, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

Re: 5.12 release: congratulations and post-mortem

[Paul Brown]

On Tuesday, 6 February 2018 16:54:19 CET Nate Graham wrote:
> Congrats on a fantastic release of Plasma 5.12 everybody! People are
> really gonna love it.
> 
> The release process was a bit rockier than expected, and I thought I
> might do a post-mortem to see how we can make the next one smoother:
> 
>.
>.
>.
>
> Thoughts?

- Create teams with a clearly designated team leader for tasks that are 
currently done by one person to avoid bottlenecks and delays.

I'm thinking of video-creation, social-media post creation, announcement 
composition, etc. Like that, you alleviate the workload of the team leader 
with researchers and "elves" than can create assets needed for the completion 
of the task.

Also, if the team leader, God forbid, should become unavailable for any 
reason, the rest of the team can pick up form where the team leader left off 
and deliver.

- Establish strict deadlines for suggested changes to media (texts and videos) 
and strictly stick to said deadlines.

[EDIT: Ivana has also suggested this, but here are my thoughts too.]

So when the next-to-last draft of the announcement text or the video is done, 
it is submitted to the peers. Peers then have say, 48 hours or whatever to 
suggest/request changes.

Once the window for requests is closed only proofreading and minor corrections 
should be allowed. 24 hours before the release, no changes should be allowed 
at all.

This would avoid the last minute hacks that are so error prone, as well as the 
"too many chefs" syndrome, that leads to everybody trying to push their own 
preference on the media.

This requires that all media is available quite in advance of the launch. But 
this should be the norm anyway.

Paul
-- 
Promotion & Communication

www: http://kde.org
Mastodon: https://mastodon.technology/@kde
Facebook: https://www.facebook.com/kde/
Twitter: https://twitter.com/kdecommunity



signature.asc
Description: This is a digitally signed message part.

D10272: Fix crash when searching

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R124 System Settings

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10272

To: aacid, mart
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Plasma 5.8.9

[Marco Martin]

On martedì 6 febbraio 2018 14:41:15 CET David Edmundson wrote:
> We decided last meeting that from now onwards Plasma 5.8 releases should be
> on-demand when we fix major issues.
> (though 5.8.9 is in the calendar to be released in April)
> 
> We have three changes in p-w that are worth releasing, two security related
> from this week.
> 
> I propose we make a release later this week when we're done with 5.12.0.
> 
> Opinions?

+1, the security issue i'm thinking about is worth a release veery quickly

-- 
Marco Martin

D10184: Port mediawiki runner to Plasma5/Qt5

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 26662.
kossebau added a comment.


  keep also ampersand with varname, not type, in method signature

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10184?vs=26661=26662

BRANCH
  portmediawiki

REVISION DETAIL
  https://phabricator.kde.org/D10184

AFFECTED FILES
  runners/CMakeLists.txt
  runners/mediawiki/CMakeLists.txt
  runners/mediawiki/mediawiki.cpp
  runners/mediawiki/mediawiki.h
  runners/mediawiki/mediawikirunner.cpp
  runners/mediawiki/mediawikirunner.h
  runners/mediawiki/plasma-runner-techbase.desktop
  runners/mediawiki/plasma-runner-userbase.desktop
  runners/mediawiki/plasma-runner-wikipedia.desktop
  runners/mediawiki/plasma-runner-wikitravel.desktop

To: kossebau, broulik, jriddell, davidedmundson, sebas
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10346: check for EGL_KHR_platform_gbm extension as well

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> egl_gbm_backend.cpp:107
>  
>  display = eglGetPlatformDisplayEXT(EGL_PLATFORM_GBM_MESA, device, 
> nullptr);
>  }

this is going to crash and burn when you have KHR but not Mesa.

You'll need to keep track of which extension you have, and alter any extension 
specific code accordingly.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10346

To: mart, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10346: check for EGL_KHR_platform_gbm extension as well

[Marco Martin]

mart updated this revision to Diff 26664.
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  - wock which extension we're usingrks both as qwidget and with the 
qstyle-based qqc2-desktop-style

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10346?vs=26663=26664

BRANCH
  phab/khrgbm

REVISION DETAIL
  https://phabricator.kde.org/D10346

AFFECTED FILES
  plugins/platforms/drm/egl_gbm_backend.cpp
  plugins/platforms/virtual/egl_gbm_backend.cpp

To: mart, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10337: First approach to a plasmoid that can display the state of caps lock

[Martin Flöser]

graesslin added a comment.


  Please be aware that this will not work on Wayland. The modifier state is 
only available to the window which currently has keyboard focus. We either need 
a dedicated Wayland protocol to send all modifier changes to Plasma or some 
other way to have KWin feed in the state.
  
  Anyway: I would recommend to make it only available for platform xcb right 
now.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10337

To: apol, #plasma, jriddell
Cc: graesslin, abetts, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth updated this revision to Diff 26658.
anemeth added a comment.


  Implemented the changes suggested by @hpereiradacosta
  Only KDE5 Breeze has transparency and blur now

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10170?vs=26407=26658

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10170

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezeblurhelper.cpp
  kstyle/breezeblurhelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10337: First approach to a plasmoid that can display the state of caps lock

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D10337#202007, @apol wrote:
  
  > In https://phabricator.kde.org/D10337#201998, @graesslin wrote:
  >
  > > Please be aware that this will not work on Wayland. The modifier state is 
only available to the window which currently has keyboard focus. We either need 
a dedicated Wayland protocol to send all modifier changes to Plasma or some 
other way to have KWin feed in the state.
  > >
  > > Anyway: I would recommend to make it only available for platform xcb 
right now.
  >
  >
  > Note this is using a Plasma Data Engine that is used by several plasmoids 
and components throughout plasma. In turn, we should make sure that if the data 
engine doesn't have any data, it doesn't work.
  >  Or have the data engine work on Wayland.
  
  
  The data engine can partially work. If you are interested only in the data 
engine while you have keyboard focus, it actually does work [1]. An example 
would be the lockscreen which uses the data engine and has keyboard focus.
  
  The concept of this data engine just doesn't match the Wayland world: there 
are no global keyloggers. KWayland::Server could send the modifier changes to 
all applications, but this would on the one side trigger wakeups whenever a 
modifier changes for all applications (bad) or in the worst case even trigger 
crashes in applications as they don't expect modifier changes when not having 
keyboard focus.
  
  So in summary: it depends a lot on what the use case for the engine is. This 
plasmoid unfortunately is an example for a usage pattern which does not work in 
a Wayland world. The only possibility I see is exposing a DBus service in KWin 
and have the data engine talk to it, but this would mean it's kwin dependent 
and still doesn't work on Wayland in general.
  
  [1] KModifierKeyInfo doesn't support Wayland yet, so in practice it doesn't 
work

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10337

To: apol, #plasma, jriddell
Cc: graesslin, abetts, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

Re: 5.12 release: congratulations and post-mortem

[Paul Brown]

On Tuesday, 6 February 2018 18:49:41 CET Luigi Toscano wrote:
> On Tuesday, 6 February 2018 18:34:34 CET Paul Brown wrote:
> > - Establish strict deadlines for suggested changes to media (texts and
> > videos) and strictly stick to said deadlines.
> > 
> > [EDIT: Ivana has also suggested this, but here are my thoughts too.]
> > 
> > So when the next-to-last draft of the announcement text or the video is
> > done, it is submitted to the peers. Peers then have say, 48 hours or
> > whatever to suggest/request changes.
> > 
> > Once the window for requests is closed only proofreading and minor
> > corrections should be allowed. 24 hours before the release, no changes
> > should be allowed at all.
> 
> Even 48 hours, in order to help translators.

Thanks, Luigi, yes. I made up the times. We would have to calculate them 
carefully.

Paul
-- 
Promotion & Communication

www: http://kde.org
Mastodon: https://mastodon.technology/@kde
Facebook: https://www.facebook.com/kde/
Twitter: https://twitter.com/kdecommunity



signature.asc
Description: This is a digitally signed message part.

D10272: Fix crash when searching

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D10272

To: aacid, mart
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10337: First approach to a plasmoid that can display the state of caps lock

[Aleix Pol Gonzalez]

apol added a comment.


  F5695536: VID_20180206_195933.mp4  this 
is a very clunky video of what it looks like. Hope this helps.
  Design input very welcome.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10337

To: apol, #plasma, jriddell
Cc: graesslin, abetts, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10346: check for EGL_KHR_platform_gbm extension as well

[Marco Martin]

mart created this revision.
mart added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
mart requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  some drivers, like Mali have EGL_KHR_platform_gbm
  but not EGL_MESA_platform_gbm

TEST PLAN
  pending a test on rock64 board

REPOSITORY
  R108 KWin

BRANCH
  phab/khrgbm

REVISION DETAIL
  https://phabricator.kde.org/D10346

AFFECTED FILES
  plugins/platforms/drm/egl_gbm_backend.cpp
  plugins/platforms/virtual/egl_gbm_backend.cpp

To: mart, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10197: Fix krunner's alt+f2 on wayland

[Martin Flöser]

graesslin added a comment.


  To ensure we don't forget about it I created: 
https://bugs.kde.org/show_bug.cgi?id=389964

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10197

To: apol, #plasma, davidedmundson
Cc: graesslin, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Compiling and deploying plasma-desktop

[Harald Sitter]

sudo apt-get build-dep plasma-desktop
git clone kde:plasma-desktop
mkdir plasma-desktop-build
cd plasma-desktop-build
cmake ../plasma-desktop -DKDE_INSTALL_USE_QT_SYS_PATHS=ON
-DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Debian
make
sudo make install

As the others indicated, this isn't usually how you want to go about
it since that basically smashes your system level installation in
/usr. What people usually do is install to a completely separate path
in their home and then use extra envrionment rigging to start programs
from that path instead of /usr.
Point being that you don't need to mess with a VM.

On Mon, Feb 5, 2018 at 10:30 PM, pointedstick  wrote:
> Howdy folks,
>
> What's the best way to go about compiling plasma-desktop from source and 
> deploying to /usr/ (in a KDE Neon dev unstable VM; I wouldn't do this on a 
> real machine), and are there any necessary dependencies that also always need 
> to be compiled from source?
>
> Thanks!
>
> Nate
>

D10024: Add supportedSchemes feature

[Milian Wolff]

mwolff added a comment.


  I've committed this now. If someone tells me how to add KIOSK support, I can 
add that later on as needed

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10024

To: mwolff, #plasma, dfaure, mart
Cc: ngraham, mart, apol, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D10025: Use KFileWidget::setSupportedSchemes when available

[Milian Wolff]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:a7d62a329994: Use KFileWidget::setSupportedSchemes when 
available (authored by mwolff).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10025?vs=25765=26631

REVISION DETAIL
  https://phabricator.kde.org/D10025

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: mwolff, dfaure, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma plasma-integration kf5-qt5 SUSEQt5.9 - Build # 38 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-integration%20kf5-qt5%20SUSEQt5.9/38/
 Project:
Plasma plasma-integration kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 06 Feb 2018 09:49:23 +
 Build duration:
4 min 22 sec and counting
   CONSOLE OUTPUT
  [...truncated 189.33 KB...]Generating MOC predefs moc_predefs.hGenerating MOC source include/ksni_unittest.mocGenerating MOC compilation mocs_compilation.cpp[  8%] Built target ksni_unittest_autogenScanning dependencies of target kfontsettingsdata_unittest_autogen[  9%] Automatic MOC for target kfontsettingsdata_unittestGenerating MOC source XPQ4DETOJG/moc_kdeplatformfiledialoghelper.cppGenerating MOC source XPQ4DETOJG/moc_kdeplatformsystemtrayicon.cppGenerating MOC source XPQ4DETOJG/moc_kfontsettingsdata.cppGenerating MOC source XPQ4DETOJG/moc_khintssettings.cppGenerating MOC source XPQ4DETOJG/moc_kwaylandintegration.cppGenerating MOC source XPQ4DETOJG/moc_qdbusmenubar_p.cppGenerating MOC source XPQ4DETOJG/moc_x11integration.cppGenerating MOC compilation mocs_compilation.cpp[  9%] Built target kdeplatformtheme_unittest_autogenScanning dependencies of target khintssettings_unittest_autogen[ 11%] Automatic MOC for target khintssettings_unittestGenerating MOC predefs moc_predefs.hGenerating MOC source include/kfontsettingsdata_unittest.mocGenerating MOC source XPQ4DETOJG/moc_kfontsettingsdata.cppGenerating MOC compilation mocs_compilation.cpp[ 11%] Built target kfontsettingsdata_unittest_autogenScanning dependencies of target windowdecotest_autogen[ 12%] Automatic MOC for target windowdecotestGenerating MOC predefs moc_predefs.hGenerating MOC source include/khintssettings_unittest.mocGenerating MOC source XPQ4DETOJG/moc_khintssettings.cppGenerating MOC compilation mocs_compilation.cpp[ 12%] Built target khintssettings_unittest_autogenScanning dependencies of target qfiledialogtest_autogen[ 14%] Automatic MOC for target qfiledialogtestGenerating MOC predefs moc_predefs.hGenerating MOC source include/windowdecotest.mocGenerating MOC compilation mocs_compilation.cppGenerating MOC predefs moc_predefs.hGenerating MOC compilation mocs_compilation.cpp[ 14%] Built target windowdecotest_autogen[ 14%] Built target qfiledialogtest_autogenScanning dependencies of target systraymenuexclusiveactionstest_autogen[ 15%] Automatic MOC for target systraymenuexclusiveactionstestGenerating MOC predefs moc_predefs.hGenerating MOC compilation mocs_compilation.cpp[ 15%] Built target systraymenuexclusiveactionstest_autogenScanning dependencies of target kfiledialogqml_unittest[ 16%] Building CXX object autotests/CMakeFiles/kfiledialogqml_unittest.dir/kfiledialogqml_unittest.cpp.oScanning dependencies of target KDEPlasmaPlatformTheme[ 18%] Building CXX object src/platformtheme/CMakeFiles/KDEPlasmaPlatformTheme.dir/qdbusmenubar.cpp.o[ 19%] Building CXX object autotests/CMakeFiles/kfiledialogqml_unittest.dir/kfiledialogqml_unittest_autogen/mocs_compilation.cpp.o[ 21%] Linking CXX executable kfiledialogqml_unittest[ 22%] Building CXX object src/platformtheme/CMakeFiles/KDEPlasmaPlatformTheme.dir/kdeplatformtheme.cpp.o[ 22%] Built target kfiledialogqml_unittestScanning dependencies of target kdirselectdialog_unittest[ 23%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/kdirselectdialog_unittest.cpp.o[ 25%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/__/src/platformtheme/kdeplatformfiledialogbase.cpp.o[ 26%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/__/src/platformtheme/kdirselectdialog.cpp.o/home/jenkins/workspace/Plasma plasma-integration kf5-qt5 SUSEQt5.9/src/platformtheme/kdirselectdialog.cpp: In constructor 'KDirSelectDialog::KDirSelectDialog(const QUrl&, bool, QWidget*)':/home/jenkins/workspace/Plasma plasma-integration kf5-qt5 SUSEQt5.9/src/platformtheme/kdirselectdialog.cpp:277:83: warning: unused parameter 'parent' [-Wunused-parameter] KDirSelectDialog::KDirSelectDialog(const QUrl , bool localOnly, QWidget *parent)   ^~[ 28%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/__/src/platformtheme/kfiletreeview.cpp.o[ 29%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/kdirselectdialog_unittest_autogen/mocs_compilation.cpp.o[ 30%] Linking CXX executable kdirselectdialog_unittest[ 30%] Built target kdirselectdialog_unittestScanning dependencies of target kdeplatformtheme_unittest[ 32%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/kdeplatformtheme_unittest.cpp.o[ 33%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/qdbusmenubar.cpp.o[ 35%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kdeplatformtheme.cpp.o[ 36%] Building CXX object 

D10263: Fix being unable to close the toolbox menu by clicking outside

[Marco Martin]

mart added a comment.


  opening the toolbox  enables an "edit mode" which opens all applet handles, 
they should continue to be interactible, so hideOnWindowDeactivate is probably 
not going to be enough, but would need more complex interaction (ie the desktop 
containment itself closing it when clicking on an epmpty area and probably when 
the desktop window loses focus

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10263

To: hein, #plasma, mart
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  for after 5.12.0 but good for backport

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10253

To: hein, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  I think it's about time to merge this in master

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixthediff

REVISION DETAIL
  https://phabricator.kde.org/D8911

To: hein, #plasma, mart, abetts
Cc: anthonyfieroni, mmustac, ngraham, davidedmundson, broulik, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10263: Fix being unable to close the toolbox menu by clicking outside

[Marco Martin]

mart added a comment.


  update: for me on master the toolbox menu is already closed both when 
clicking on an empty desktop area or another window, but not the applet handles 
or borders, as it should

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10263

To: hein, #plasma, mart
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10024: Add supportedSchemes feature

[Milian Wolff]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6ab218dba91f: Add supportedSchemes feature (authored by 
mwolff).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10024?vs=25891=26632#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10024?vs=25891=26632

REVISION DETAIL
  https://phabricator.kde.org/D10024

AFFECTED FILES
  autotests/kdiroperatortest.cpp
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: mwolff, #plasma, dfaure, mart
Cc: ngraham, mart, apol, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

KDE CI: Plasma plasma-integration kf5-qt5 FreeBSDQt5.9 - Build # 13 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-integration%20kf5-qt5%20FreeBSDQt5.9/13/
 Project:
Plasma plasma-integration kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 06 Feb 2018 09:49:23 +
 Build duration:
14 min and counting
   CONSOLE OUTPUT
  [...truncated 157.23 KB...][ 19%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/kdirselectdialog_unittest.cpp.o[ 21%] Building CXX object autotests/CMakeFiles/ksni_unittest.dir/ksni_unittest.cpp.o[ 22%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/__/src/platformtheme/kdeplatformfiledialogbase.cpp.o[ 23%] Building CXX object autotests/CMakeFiles/kfiledialogqml_unittest.dir/kfiledialogqml_unittest_autogen/mocs_compilation.cpp.o[ 25%] Building CXX object autotests/CMakeFiles/ksni_unittest.dir/ksni_unittest_autogen/mocs_compilation.cpp.o[ 26%] Building CXX object autotests/CMakeFiles/khintssettings_unittest.dir/__/src/platformtheme/khintssettings.cpp.o[ 28%] Linking CXX executable kfiledialogqml_unittest[ 29%] Linking CXX executable ksni_unittest[ 29%] Built target KDEPlasmaPlatformTheme_autogenScanning dependencies of target kfontsettingsdata_unittest[ 30%] Building CXX object autotests/CMakeFiles/kfontsettingsdata_unittest.dir/kfontsettingsdata_unittest.cpp.o[ 30%] Built target kdeplatformtheme_unittest_autogen[ 32%] Building CXX object autotests/CMakeFiles/kfontsettingsdata_unittest.dir/__/src/platformtheme/kfontsettingsdata.cpp.o[ 32%] Built target ksni_unittest[ 33%] Building CXX object autotests/CMakeFiles/khintssettings_unittest.dir/khintssettings_unittest_autogen/mocs_compilation.cpp.o[ 33%] Built target kfiledialogqml_unittest[ 35%] Building CXX object autotests/CMakeFiles/kfontsettingsdata_unittest.dir/kfontsettingsdata_unittest_autogen/mocs_compilation.cpp.o[ 36%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/__/src/platformtheme/kdirselectdialog.cpp.o[ 38%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/__/src/platformtheme/kfiletreeview.cpp.oScanning dependencies of target kfiledialog_unittest[ 39%] Linking CXX executable kfontsettingsdata_unittest[ 40%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/kdirselectdialog_unittest_autogen/mocs_compilation.cpp.o[ 42%] Building CXX object autotests/CMakeFiles/kfiledialog_unittest.dir/kfiledialog_unittest.cpp.o[ 43%] Building CXX object autotests/CMakeFiles/kfiledialog_unittest.dir/kfiledialog_unittest_autogen/mocs_compilation.cpp.o[ 45%] Linking CXX executable khintssettings_unittestScanning dependencies of target kdeplatformtheme_unittest[ 46%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/kdeplatformtheme_unittest.cpp.o[ 46%] Built target kfontsettingsdata_unittestScanning dependencies of target systraymenuexclusiveactionstest[ 47%] Building CXX object tests/CMakeFiles/systraymenuexclusiveactionstest.dir/systraymenuexclusiveactionstest.cpp.o[ 47%] Built target khintssettings_unittestScanning dependencies of target windowdecotest[ 49%] Building CXX object tests/CMakeFiles/windowdecotest.dir/windowdecotest.cpp.o/usr/home/jenkins/workspace/Plasma plasma-integration kf5-qt5 FreeBSDQt5.9/src/platformtheme/kdirselectdialog.cpp:277:83: warning: unused parameter 'parent' [-Wunused-parameter]KDirSelectDialog::KDirSelectDialog(const QUrl , bool localOnly, QWidget *parent)  ^1 warning generated.[ 50%] Building CXX object tests/CMakeFiles/systraymenuexclusiveactionstest.dir/systraymenuexclusiveactionstest_autogen/mocs_compilation.cpp.o[ 52%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/qdbusmenubar.cpp.o[ 53%] Linking CXX executable kdirselectdialog_unittest[ 54%] Linking CXX executable kfiledialog_unittest[ 56%] Linking CXX executable systraymenuexclusiveactionstest[ 57%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kdeplatformtheme.cpp.o[ 57%] Built target kdirselectdialog_unittest[ 59%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kfontsettingsdata.cpp.o[ 60%] Building CXX object tests/CMakeFiles/windowdecotest.dir/windowdecotest_autogen/mocs_compilation.cpp.o[ 61%] Linking CXX executable windowdecotest[ 63%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/khintssettings.cpp.o[ 64%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kdeplatformfiledialoghelper.cpp.o[ 66%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kdeplatformfiledialogbase.cpp.o[ 67%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kdeplatformsystemtrayicon.cpp.o/usr/home/jenkins/workspace/Plasma plasma-integration kf5-qt5 

D9207: Don't load KDE platform module in kglobalaccel5

[Marco Martin]

mart added a comment.


  can this be resurrected?

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D9207

To: hein, #plasma, davidedmundson, mart, graesslin
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10325: RFC: [KFileWidget] Hide places frame and header

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10321: [Notifications] Let clear entry also clear history

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a3664acb6054: [Notifications] Let clear entry also clear 
history (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10321?vs=26576=26634

REVISION DETAIL
  https://phabricator.kde.org/D10321

AFFECTED FILES
  applets/notifications/package/contents/ui/main.qml

To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9207: Don't load KDE platform module in kglobalaccel5

[Eike Hein]

hein added a comment.


  Well, the maintainer spoke out against it, so not much I can do.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D9207

To: hein, #plasma, davidedmundson, mart, graesslin
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10263: Fix being unable to close the toolbox menu by clicking outside

[Eike Hein]

hein added a comment.


  Empty desktop doesn't close it for me without this patch.
  
  This was based on a user bug report. It was almost the first thing they saw / 
struggled with when using Plasma for the first time.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10263

To: hein, #plasma, mart
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7abd8d0da447: Fix dupe handling in 
requestAddLauncherToActivities; improve unit test (authored by hein).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10253?vs=26388=26635

REVISION DETAIL
  https://phabricator.kde.org/D10253

AFFECTED FILES
  libtaskmanager/autotests/launchertasksmodeltest.cpp
  libtaskmanager/launchertasksmodel.cpp

To: hein, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10170: Added optional transparency/blur to menu frames

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hello,
  
  Thanks for the updated patch and for the work on BlurHelper. 
  Couple more comments below.
  
  Hugo

INLINE COMMENTS

> breezeblurhelper.cpp:144
> +if (!blurRegion.isEmpty()) {
> +#if !BREEZE_USE_KDE4
> +KWindowEffects::enableBlurBehind(widget->winId(), true, 
> blurRegion);

ok. So this is awkward. The whole code (the whole class in fact), does nothing 
for KDE4 (because of KWindowEffects not being available).
We should then not have the event filters installed, nor even the blur helper 
created, etc.
Alternatively, one would need to duplicate the code from KWIndowEffect. as done 
in the original oxygen code.

For KF5, it is definitly better to use KWindowsEffect. so fine.
For kDE4 applications, not having the blur behind the translucent window is an 
issue (and there still are some kde4 applications around).
So there, one should either

- duplicate the code (for this #ifdef branch only
- disable the blur (as now), and possibly also the transparency (in order not 
to endup with transparent menus and no blur).

> breezestyle.cpp:3632
> +// force registration of widget
> +_blurHelper->registerWidget( widget->window() );
> +}

This should go to Breeze::Style::polish.
There is already a "if( qobject_cast( widget )" there. Just move this 
to the corresponding code block.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10321: [Notifications] Let clear entry also clear history

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10321

To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:25c30932961e: Port launch feedback KCM to Qt Quick and 
implement VDG redesign (authored by hein).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8911?vs=23327=26636#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8911?vs=23327=26636

REVISION DETAIL
  https://phabricator.kde.org/D8911

AFFECTED FILES
  kcms/launch/CMakeLists.txt
  kcms/launch/Messages.sh
  kcms/launch/kcm_launchfeedback.desktop
  kcms/launch/kcmlaunch.cpp
  kcms/launch/kcmlaunch.desktop
  kcms/launch/kcmlaunch.h
  kcms/launch/launchfeedback.cpp
  kcms/launch/launchfeedback.h
  kcms/launch/package/contents/ui/main.qml
  kcms/launch/package/metadata.desktop

To: hein, #plasma, mart, abetts
Cc: anthonyfieroni, mmustac, ngraham, davidedmundson, broulik, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10337: First approach to a plasmoid that can display the state of caps lock

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, jriddell.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10337

AFFECTED FILES
  applets/CMakeLists.txt
  applets/keyboardindicator/contents/ui/main.qml
  applets/keyboardindicator/metadata.desktop

To: apol, #plasma, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10334: RFC: Make KRunner a Dock window

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  In https://phabricator.kde.org/D10334#201753, @graesslin wrote:
  
  > There is the panel behavior thing missing which used to be in the old code. 
A panel does not get keyboard focus. With the panel behavior that can be 
changed.
  
  
  The old code was un-usably broken, please provide a patch yourself then.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10334

To: apol, #plasma, graesslin
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10232: Include a pixel more in the dirty area

[Marco Martin]

mart updated this revision to Diff 26640.
mart added a comment.


  - fix cursor painting

REPOSITORY
  R319 Konsole

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10232?vs=26606=26640

BRANCH
  phab/dirty

REVISION DETAIL
  https://phabricator.kde.org/D10232

AFFECTED FILES
  src/TerminalDisplay.cpp

To: mart, #plasma, #konsole, markg
Cc: markg, hindenburg, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10325: RFC: [KFileWidget] Hide places frame and header

[Kai Uwe Broulik]

broulik added a comment.


  > Would it be possible to show it as if it were locked? That would solve all 
the issues with it, right?
  
  I don't get it. That "lock" feature is entirely a Dolphin invention. It does 
exactly what I do here:
  
void DolphinDockWidget::setLocked(bool lock)
{
...
if (lock) {
...
setTitleBarWidget(m_dockTitleBar);
setFeatures(QDockWidget::NoDockWidgetFeatures);
  
  with `m_dockTitleBar` being a custom widget for some added padding

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10197: Fix krunner's alt+f2 on wayland

[Aleix Pol Gonzalez]

apol added a comment.


  Feel free to revert and reopen the bug:
  https://bugs.kde.org/show_bug.cgi?id=385693

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10197

To: apol, #plasma, davidedmundson
Cc: graesslin, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

[Jaime Torres Amate]

jtamate created this revision.
jtamate added a reviewer: Plasma: Workspaces.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  store the const iterator returned, not the address.
  
  F5695179: plasma_before.png 
  
  F5695178: plasma_after.png 

TEST PLAN
  Moving 50.000 small files in dolphin with drag between two disks.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10342

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: jtamate, #plasma_workspaces
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10344: Create panel on current screen

[Robert Hoffmann]

hoffmannrobert created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
hoffmannrobert requested review of this revision.

REVISION SUMMARY
  In multi-monitor environments panels are always created on screen number 0.
  There is no easy way to have panels on the other screens besides editing
  plasma-org.kde.plasma.desktop-appletsrc and modifying lastScreen.
  
  This patch identifies the screen where the right-click 'Add Panel' happened
  and adds a panel to this particular screen.
  
  Depends on the changes in plasma-framework ( see 
https://phabricator.kde.org/D10343 ) providing
  Containment *createContainmentForScreen(int screenNum, const QString , 
const QVariantList  = QVariantList());
  Containment *addContainmentForScreen(int screenNum, const QString , 
const QVariantList , uint id, bool delayedInit = false);
  void Containment::setLastScreen(int screen);

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10344

AFFECTED FILES
  shell/scripting/scriptengine.cpp
  shell/shellcorona.cpp

To: hoffmannrobert
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

[Jaime Torres Amate]

jtamate edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10342

To: jtamate, #plasma_workspaces
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10184: Port mediawiki runner to Plasma5/Qt5

[Friedrich W . H . Kossebau]

kossebau marked 2 inline comments as done.
kossebau added a comment.


  Thanks for first round of review :)

INLINE COMMENTS

> broulik wrote in mediawiki.cpp:134
> Categorized logging, perhaps?

Yes, though I plan to do this later in one concentrated go for all of 
kdeplasma-addons, so things will be consistent and complete.

> broulik wrote in mediawiki.h:74
> Asterisk goes to variable name, `QObject *parent` (pedantic)

Ah, too much kdevelop code done (where asterisk goes to type) :)

> broulik wrote in plasma-runner-wikipedia.desktop:118
> Is there a chance we can make this user-configurable or perhaps have it use 
> the current language automatically? (Just asking, it's fine if you just did a 
> straight port)

No idea yet, but i had seen the related bug report 
https://bugs.kde.org/show_bug.cgi?id=256019 and agree that it will be good to 
have.

I hope that can be covered in the planned follow-up work to improve the 
configuration UI to allow the user adding more mediawiki servers without having 
to create and install new desktop files like now.
No brain cycles yet spent on that.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10184

To: kossebau, broulik, jriddell, davidedmundson, sebas
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Plasma 5.13 Kickoff Meeting

[Jonathan Riddell]

5.12 LTS is nearly out the door so here's a poll for a kickoff meeting
for 5.13, let us know when you can make it

https://doodle.com/poll/8wwrt59dt8prz6pf

Jonathan

D10197: Fix krunner's alt+f2 on wayland

[David Edmundson]

davidedmundson added a comment.


  The old code is clearly wrong.
  
  It calls Dialog::event(event);
  
  that will set up a shellsurface in the expose event
  Then we process further and set up a shell surface in the expose event
  
  PlasmaShellSurfaces are shared, but you still have two objects handling the 
move event simultaneously, and worst still
  
} else if (event->type() == QEvent::Hide) {
  
  delete m_plasmaShellSurface;
  
  is just screaming out for a crash as dialog is sharing that same object. 
We're just being very lucky at the moment.
  
  I wouldn't want to see this reverted as-is.
  
  But clearly we need the setRole and the setPanelTakesFocus.  I missed that in 
my review.
  That could mean just adding an if(Dock) in Dialog.cpp  , only setting those 
parts in ExposeEvent here, or adding an extra virtual to configure dialog 
somehow.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10197

To: apol, #plasma, davidedmundson
Cc: graesslin, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10344: Create panel on current screen

[Robert Hoffmann]

hoffmannrobert edited the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10344

To: hoffmannrobert
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Plasma 5.12.0 is released

[Bhushan Shah]

Plasma 5.12.0 is now released
https://www.kde.org/announcements/plasma-5.12.0.php


Please made bugfixes to Plasma/5.12 branch and new features to master
branches


-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

[Jaime Torres Amate]

jtamate added a comment.


  In https://phabricator.kde.org/D10342#201979, @broulik wrote:
  
  > Interesting. I'm curious as to why it calls those functions that often in 
the first place while copying files.
  
  
  My guess is that it is used to fill the task completion in the task bar, but 
is only a wild guess.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10342

To: jtamate, #plasma_workspaces
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10325: [KFileWidget] Hide places frame and header

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kfilewidget.cpp:1351
>  placesDock = new QDockWidget(i18nc("@title:window", "Places"), q);
> -placesDock->setFeatures(QDockWidget::DockWidgetClosable);
> +placesDock->setFeatures(QDockWidget::NoDockWidgetFeatures);
> +placesDock->setTitleBarWidget(new 
> KDEPrivate::KFileWidgetDockTitleBar(placesDock));

Does it really make sense that it's a dock if it can't be interacted with?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: apol, markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

5.12 release: congratulations and post-mortem

[Nate Graham]

Congrats on a fantastic release of Plasma 5.12 everybody! People are 
really gonna love it.


The release process was a bit rockier than expected, and I thought I 
might do a post-mortem to see how we can make the next one smoother:




Problem: Initial request for release notes was not seen by many
===
Solutions:
- Send email to kde-pr...@kde.org and kde-de...@kde.org as well
- Use a Phabricator task instead of email to track overall work
- Make a subtask to track gathering release notes from developers
- Delegate a specific person (Ivanna?) to be responsible for turning the 
release notes into final marketing copy




Problem: Unclear roles; nobody knew who owned the beta announcement
===
Solutions:
- Make roles and responsibilities clear to all; assign specific people 
to specific tasks

- Make the KDE Promo crew the guardians of everything public-facing



Problem: Unclear access to the kde.org website
==
(At once point, changes were requested and planned, but the one person 
that everybody knew had access was on vacation)


Solutions:
- Define who should have access ahead of time
- Get those people access to the website ahead of time



Problem: Promo video produced at the last minute, gating final release
==
Solutions:
- Supply whomever is making the video with a pre-release copy of Plasma 
5.12 at least a few days in advance so that the video can be completed 
sooner




Thoughts?

Nate

D10337: First approach to a plasmoid that can display the state of caps lock

[Aleix Pol Gonzalez]

apol added a comment.


  In https://phabricator.kde.org/D10337#201998, @graesslin wrote:
  
  > Please be aware that this will not work on Wayland. The modifier state is 
only available to the window which currently has keyboard focus. We either need 
a dedicated Wayland protocol to send all modifier changes to Plasma or some 
other way to have KWin feed in the state.
  >
  > Anyway: I would recommend to make it only available for platform xcb right 
now.
  
  
  Note this is using a Plasma Data Engine that is used by several plasmoids and 
components throughout plasma. In turn, we should make sure that if the data 
engine doesn't have any data, it doesn't work.
  Or have the data engine work on Wayland.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10337

To: apol, #plasma, jriddell
Cc: graesslin, abetts, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth marked 2 inline comments as done.
anemeth added a comment.


  KDE4 Breeze has no trasnparency and blur anymore

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10197: Fix krunner's alt+f2 on wayland

[Martin Flöser]

graesslin added a comment.


  As the commit went into the 5.12 branch we cannot build up on any 
functionality not yet available in Dialog.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10197

To: apol, #plasma, davidedmundson
Cc: graesslin, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9207: Don't load KDE platform module in kglobalaccel5

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D9207#201848, @hein wrote:
  
  > Well, the maintainer spoke out against it, so not much I can do.
  
  
  Please be aware that I am no longer the maintainer of kglobalaccel. 
Nevertheless I recommend against it as the risk of breakage is high especially 
as nobody notices breakage during the frameworks dev cycle.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D9207

To: hein, #plasma, davidedmundson, mart, graesslin
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10337: First approach to a plasmoid that can display the state of caps lock

[Andres Betts]

abetts added a comment.


  Does this have a look yet?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10337

To: apol, #plasma, jriddell
Cc: abetts, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D10334: RFC: Make KRunner a Dock window

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D10334#201879, @apol wrote:
  
  > In https://phabricator.kde.org/D10334#201753, @graesslin wrote:
  >
  > > There is the panel behavior thing missing which used to be in the old 
code. A panel does not get keyboard focus. With the panel behavior that can be 
changed.
  >
  >
  > The old code was un-usably broken, please provide a patch yourself then.
  
  
  *sigh* the code used to work when I wrote it. I don't know why it broke and 
honestly I don't care. I fixed Krunner several times and I'm certainly not 
going to fix it, now that it got broken again by removing needed code without 
asking the one who wrote it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10334

To: apol, #plasma, graesslin
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10184: Port mediawiki runner to Plasma5/Qt5

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 26661.
kossebau marked an inline comment as done.
kossebau added a comment.


  update to kai's feedback

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10184?vs=26208=26661

BRANCH
  portmediawiki

REVISION DETAIL
  https://phabricator.kde.org/D10184

AFFECTED FILES
  runners/CMakeLists.txt
  runners/mediawiki/CMakeLists.txt
  runners/mediawiki/mediawiki.cpp
  runners/mediawiki/mediawiki.h
  runners/mediawiki/mediawikirunner.cpp
  runners/mediawiki/mediawikirunner.h
  runners/mediawiki/plasma-runner-techbase.desktop
  runners/mediawiki/plasma-runner-userbase.desktop
  runners/mediawiki/plasma-runner-wikipedia.desktop
  runners/mediawiki/plasma-runner-wikitravel.desktop

To: kossebau, broulik, jriddell, davidedmundson, sebas
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

[Kai Uwe Broulik]

broulik added a comment.


  Interesting. I'm curious as to why it calls those functions that often in the 
first place while copying files.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10342

To: jtamate, #plasma_workspaces
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10197: Fix krunner's alt+f2 on wayland

[Martin Flöser]

graesslin added a comment.


  I really think this needs to be reverted. Krunner must be a dock, it must be 
set to windows go below and it must take focus. This is all functionality not 
provided by Plasma::Dialog. Just removing the code doesn't work unfortunately.
  
  I have a hard time understanding what the actual problem was. For me KRunner 
was always working. The change says it's about workarounds for X11, but that 
doesn't match the change as everything what's red is Wayland only. Can someone 
elaborate on what the actual problem was which this change was trying to 
address.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10197

To: apol, #plasma, davidedmundson
Cc: graesslin, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

[andreas]

https://bugs.kde.org/show_bug.cgi?id=346972
Bug 346972 depends on bug 339863, which changed state.

Bug 339863 Summary: Full and empty stars are indistinguishable when using an 
icon theme (including Oxygen) that lacks the "rating-unrated" icon
https://bugs.kde.org/show_bug.cgi?id=339863

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10357: Show high-resolution and vector logos properly in HighDPI mode

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 388633
  
  Take the device pixel ratio into consideration when rendering the logo, so it 
looks nice in HighDPI mode.

TEST PLAN
  Tested in NDE Neon with the standard Plasma logo, which is an SVG.
  
  Before:
  
  After:

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10357

AFFECTED FILES
  Modules/about-distro/src/Module.cpp
  main.cpp

To: ngraham, #plasma
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10357: Show high-resolution and vector logos properly in HighDPI mode

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D10357

To: ngraham, #plasma
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9207: Don't load KDE platform module in kglobalaccel5

[Eike Hein]

hein abandoned this revision.
hein added a comment.


  As mentioned, I'm OK with abandoning it. I think the change is hygienic, but 
it's also a micro-optimization.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D9207

To: hein, #plasma, davidedmundson, mart, graesslin
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10327: [LauncherTasksModel] Support applications: URLs in requestOpenUrls

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:eff4bc7c3cf3: [LauncherTasksModel] Support applications: 
URLs in requestOpenUrls (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10327?vs=26593=26627

REVISION DETAIL
  https://phabricator.kde.org/D10327

AFFECTED FILES
  libtaskmanager/launchertasksmodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: Compiling and deploying plasma-desktop

[Roman Gilg]

kdesrc-build: 
https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source#kdesrc-build

And you can do this on a real machine with Neon dev unstable. Or at
least I do it...

On Mon, Feb 5, 2018 at 10:30 PM, pointedstick  wrote:
> Howdy folks,
>
> What's the best way to go about compiling plasma-desktop from source and 
> deploying to /usr/ (in a KDE Neon dev unstable VM; I wouldn't do this on a 
> real machine), and are there any necessary dependencies that also always need 
> to be compiled from source?
>
> Thanks!
>
> Nate
>

D10328: [Task Manager] Use KFilePlacesModel::isHidden

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:51a927375c90: [Task Manager] Use 
KFilePlacesModel::isHidden (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10328?vs=26594=26626

REVISION DETAIL
  https://phabricator.kde.org/D10328

AFFECTED FILES
  applets/taskmanager/plugin/backend.cpp

To: broulik, #plasma, hein, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 34 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/34/
 Project:
Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 06 Feb 2018 08:09:27 +
 Build duration:
7 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kcm-keyboard-iso_codesFailed: TestSuite.lookandfeel-kcmTest

D10325: [KFileWidget] Hide places frame and header

[Kai Uwe Broulik]

broulik updated this revision to Diff 26642.
broulik retitled this revision from "RFC: [KFileWidget] Hide places frame and 
header" to "[KFileWidget] Hide places frame and header".
broulik edited the test plan for this revision.
broulik added a comment.


  - Add custom widget for added spacing, fixes the items glued to the top when 
borders are enabled, see updated Test Plan for new screenshots

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10325?vs=26590=26642

REVISION DETAIL
  https://phabricator.kde.org/D10325

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidgetdocktitlebar.cpp
  src/filewidgets/kfilewidgetdocktitlebar_p.h

To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10325: [KFileWidget] Hide places frame and header

[Mark Gaiser]

markg added a comment.


  In https://phabricator.kde.org/D10325#201884, @broulik wrote:
  
  > > Would it be possible to show it as if it were locked? That would solve 
all the issues with it, right?
  >
  > I don't get it. That "lock" feature is entirely a Dolphin invention. It 
does exactly what I do here:
  >
  >   void DolphinDockWidget::setLocked(bool lock)
  >   {
  >   ...
  >   if (lock) {
  >   ...
  >   setTitleBarWidget(m_dockTitleBar);
  >   setFeatures(QDockWidget::NoDockWidgetFeatures);
  >
  >
  > with `m_dockTitleBar` being a custom widget for some added padding
  
  
  Looks like i was looking at the wrong picture. I was looking as your 
**after** image and comparing that to the "locked" state in dolphin.
  The image i was expecting is the one you call "crammed at the top" :)
  
  Imho, the "crammed at the top" version looks best as the "after" one just has 
some weird empty room above the panel now. But feel free to use the one you 
think fits best.
  
  A suggestion though if you do choose for the "after" version. Would it be 
possible to rearrange the layout then?
  So:
  
  - move the actions to the top, right above the panel.
  - move the location bar next to the actions
  
  I think that would look nice :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10337: First approach to a plasmoid that can display the state of caps lock

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:29
> +
> +Plasmoid.onActivated: toggle()
> +

I don't see a `toggle()` function

> main.qml:34
> +engine: "keystate"
> +connectedSources: "Caps Lock"
> +}

I know QML does this magically but I'd prefer explicit array

  connectedSources: ["Caps Lock"]

> main.qml:61
> +source: plasmoid.icon
> +active: parent.containsMouse || root.capsLock
> +}

You change the icon *and* let it glow when caps lock is enabled?

> metadata.desktop:3
> +Name=Keyboard Indicator
> +Comment=Shows the state of the keyboard
> +Type=Service

Is this supposed to be augmented to show Num Lock etc otherwise this is oddly 
unspecific

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10337

To: apol, #plasma, jriddell
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Plasma 5.8.9

[David Edmundson]

We decided last meeting that from now onwards Plasma 5.8 releases should be
on-demand when we fix major issues.
(though 5.8.9 is in the calendar to be released in April)

We have three changes in p-w that are worth releasing, two security related
from this week.

I propose we make a release later this week when we're done with 5.12.0.

Opinions?

David

D10338: Don't show tooltips for inactive windows

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, graesslin, McPain.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  You don't get any tooltips for controls within inactive windows either. It's 
distracting.

TEST PLAN
  No longer get tooltips on inactive windows. Still get them on active windows

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D10338

AFFECTED FILES
  src/decorationbutton.cpp

To: broulik, #plasma, graesslin, McPain
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10232: Include a pixel more in the dirty area

[Kurt Hindenburg]

hindenburg added a comment.


  I now get all kinds of extra vertical lines on right side of screen and some 
horizontal ones near cursor using 1.3 scaling - I didn't see these before the 
latest patch
  
  My zsh prompt is: kurthindenburg:~/ $ 
  [9:17:48]
  
  vertical lines on right side of the last ]
  vertical lines below current cursor lines

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D10232

To: mart, #plasma, #konsole, markg
Cc: markg, hindenburg, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart